Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Rémy Maucherat]

2015-10-31 9:10 GMT+01:00 Mark Thomas :

> > Essentially,
> >
> > [junit] Caused by: java.lang.NoSuchMethodError: sniCallBack
> > [junit] at org.apache.tomcat.jni.SSLContext.make(Native Method)
>
> Ah, yes, ok, native 1.2 assumes SNI, and the old Java classes
[org.apache.tomcat.jni] don't have it. What's the strategy here ? Should
the Java APIs be updated, or is the native code supposed to behave better ?

Rémy

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Mark Thomas]

On 31 October 2015 09:33:36 GMT+00:00, "Rémy Maucherat"  wrote:
>2015-10-31 9:10 GMT+01:00 Mark Thomas :
>
>> > Essentially,
>> >
>> > [junit] Caused by: java.lang.NoSuchMethodError: sniCallBack
>> > [junit] at org.apache.tomcat.jni.SSLContext.make(Native
>Method)
>>
> Ah, yes, ok, native 1.2 assumes SNI, and the old Java classes
>[org.apache.tomcat.jni] don't have it. What's the strategy here ?
>Should
>the Java APIs be updated, or is the native code supposed to behave
>better ?

My preference would be for the native code to behave better but I don't know 
how easy that is to implement. That way native 1.2.x can be used with current 
and previous 6.0.x, 7.0.x and 8.0.x releases.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Mark Thomas]

On 31/10/2015 02:15, Konstantin Kolinko wrote:
> 2015-10-22 13:47 GMT+03:00 Mark Thomas :
>> Version 1.2.0 includes the following changes:
>> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
>> - ALPN support
>>
>> The proposed release artefacts can be found at [1],
>> and the build was done using tag [2].
>>
>> The Apache Tomcat Native 1.2.0 is
>>  [ ] Stable, go ahead and release
>>  [ ] Broken because of ...
> 
> 
> Is there an expectation that this library works with Tomcat 7, Tomcat 8?
> (E.g. download links for 1.1.33 were removed from download page).

Yes.

> It does not!

Then that needs to be fixed.

> Running Tomcat 7 tests all HTTP tests pass, but an HTTPS test crashes
> (org.apache.tomcat.util.net.TestSsl)
> 
> Essentially,
> 
> [junit] Caused by: java.lang.NoSuchMethodError: sniCallBack
> [junit] at org.apache.tomcat.jni.SSLContext.make(Native Method)
> [junit] at
> org.apache.tomcat.util.net.AprEndpoint.bind(AprEndpoint.java:573)
> [junit] at
> org.apache.tomcat.util.net.AbstractEndpoint.init(AbstractEndpoint.java:651)
> [junit] at
> org.apache.coyote.AbstractProtocol.init(AbstractProtocol.java:434)
> [junit] at
> org.apache.catalina.connector.Connector.initInternal(Connector.java:978)
> [junit] at
> org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:102)
> [junit] ... 33 more
> 
> The above is followed by a JVM crash on a subsequent test.
> I filed it into Bugzilla,
> https://bz.apache.org/bugzilla/show_bug.cgi?id=58566
> 
> On a good side, non-SSL tests do pass. (Tomcat 7, skipping websocket tests)
> 
> I think immediate action is to restore download links for 1.1.33.

Thanks for taking care of that.

> Maybe clarify the release announcement at http://tomcat.apache.org/.
> (Add a note that this library targets not-yet-released versions of
> Tomcat).

It doesn't. It should work with all Tomcat versions.

There appear to be multiple issues with 1.2.0 of varying severity. My
plan is to get them fixed and then roll 1.2.1. Given the regressions, I
don't intend to e-mail out the announcement for 1.2.0.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Konstantin Kolinko]

2015-10-22 13:47 GMT+03:00 Mark Thomas :
> Version 1.2.0 includes the following changes:
> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
> - ALPN support
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.0 is
>  [ ] Stable, go ahead and release
>  [ ] Broken because of ...


Is there an expectation that this library works with Tomcat 7, Tomcat 8?
(E.g. download links for 1.1.33 were removed from download page).

It does not!

Running Tomcat 7 tests all HTTP tests pass, but an HTTPS test crashes
(org.apache.tomcat.util.net.TestSsl)

Essentially,

[junit] Caused by: java.lang.NoSuchMethodError: sniCallBack
[junit] at org.apache.tomcat.jni.SSLContext.make(Native Method)
[junit] at
org.apache.tomcat.util.net.AprEndpoint.bind(AprEndpoint.java:573)
[junit] at
org.apache.tomcat.util.net.AbstractEndpoint.init(AbstractEndpoint.java:651)
[junit] at
org.apache.coyote.AbstractProtocol.init(AbstractProtocol.java:434)
[junit] at
org.apache.catalina.connector.Connector.initInternal(Connector.java:978)
[junit] at
org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:102)
[junit] ... 33 more

The above is followed by a JVM crash on a subsequent test.
I filed it into Bugzilla,
https://bz.apache.org/bugzilla/show_bug.cgi?id=58566

On a good side, non-SSL tests do pass. (Tomcat 7, skipping websocket tests)

I think immediate action is to restore download links for 1.1.33.

Maybe clarify the release announcement at http://tomcat.apache.org/.
(Add a note that this library targets not-yet-released versions of
Tomcat).


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Violeta Georgieva]

2015-10-22 13:47 GMT+03:00 Mark Thomas :
>
> Version 1.2.0 includes the following changes:
> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
> - ALPN support
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.0 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

+1

Regards,
Violeta

>  [1]
>
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.0/
>  [2]
> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_0
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[jean-frederic clere]

On 10/22/2015 12:47 PM, Mark Thomas wrote:
> Version 1.2.0 includes the following changes:
> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
> - ALPN support
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.0 is
>  [X] Stable, go ahead and release

We need to get more people using it ;-)

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Christopher Schultz]

Mark,

On 10/26/15 3:48 PM, Mark Thomas wrote:
> Ping.
> 
> Currently this release only has two votes. 9.0.x requires a 1.2.x
> tcnative so this is currently blocking any work on a 9.0.0.RC1 release.
> 
> Additional testing and votes would be very welcome.

I'll give it a try.

It would be great if some Windows users could weigh-in.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Mark Thomas]

Ping.

Currently this release only has two votes. 9.0.x requires a 1.2.x
tcnative so this is currently blocking any work on a 9.0.0.RC1 release.

Additional testing and votes would be very welcome.

Thanks in advance,

Mark


On 22/10/2015 07:22, Rémy Maucherat wrote:
> 2015-10-22 12:47 GMT+02:00 Mark Thomas :
> 
>> Version 1.2.0 includes the following changes:
>> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
>> - ALPN support
>>
> (most importantly IMO) - Add API methods to access OpenSSL BIO
> 
>>
>> The proposed release artefacts can be found at [1],
>> and the build was done using tag [2].
>>
>> The Apache Tomcat Native 1.2.0 is
>>  [X] Stable, go ahead and release
>>  [ ] Broken because of ...
>>
>>
>>  [1]
>>
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.0/
>>  [2]
>> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_0
>>
>> So I guess I've been testing the OpenSSL engine for a while, and I didn't
> run into issues. ALPN works as well [APR and NIOx] with HTTP/2. So IMO this
> is quite ambitious, but maybe "stable" can be tried since most of the "new"
> code is actually only a merge from code released elsewhere.
> 
> Rémy
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Rémy Maucherat]

2015-10-22 12:47 GMT+02:00 Mark Thomas :

> Version 1.2.0 includes the following changes:
> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
> - ALPN support
>
(most importantly IMO) - Add API methods to access OpenSSL BIO

>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.0 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...
>
>
>  [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.0/
>  [2]
> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_0
>
> So I guess I've been testing the OpenSSL engine for a while, and I didn't
run into issues. ALPN works as well [APR and NIOx] with HTTP/2. So IMO this
is quite ambitious, but maybe "stable" can be tried since most of the "new"
code is actually only a merge from code released elsewhere.

Rémy

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Mark Thomas]

On 22/10/2015 11:47, Mark Thomas wrote:
> Version 1.2.0 includes the following changes:
> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
> - ALPN support
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.0 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

I'm happily running HTTP/2 on Windows with the x64 binaries.

I've found a couple of bugs but they have all been in the 9.0.x Java code.

Mark

>  [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.0/
>  [2]
> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_0
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org