Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-20 Thread Mark Thomas
Mark Thomas wrote:
 Looks like we need to run native2ascii over a quite a few French and
 German files.

Done for trunk and fixes proposed for 6.0.x.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-20 Thread sebb
On 20/04/2009, Mark Thomas ma...@apache.org wrote:
 Mark Thomas wrote:
   Looks like we need to run native2ascii over a quite a few French and
   German files.

Surely the ISO-8859-1 (Latin-1) character set supports most accents in
Latin languages, so there should be no need to use Unicode escapes for
these?

Looks to me like the problem with the Spanish version is due to a
packaging error in the tomcat-I18n-es.jar file, which contains
corrupted copies of the original files.

Using Unicode escapes should prevent this packing error from
recurring, but seems rather a drastic measure, as it makes the
properties files rather harder to read.


 Done for trunk and fixes proposed for 6.0.x.


  Mark



  -
  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
  For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-20 Thread Mark Thomas
sebb wrote:
 On 20/04/2009, Mark Thomas ma...@apache.org wrote:
 Mark Thomas wrote:
   Looks like we need to run native2ascii over a quite a few French and
   German files.
 
 Surely the ISO-8859-1 (Latin-1) character set supports most accents in
 Latin languages, so there should be no need to use Unicode escapes for
 these?

I would have expected it to work but it appears that it doesn't. It is
probably related to the users default platform encoding. I suspect the
issues are when a user is using something other than ISO-8859-1 or UTF-8
but I haven't done any testing to prove this.

 Looks to me like the problem with the Spanish version is due to a
 packaging error in the tomcat-I18n-es.jar file, which contains
 corrupted copies of the original files.

The issue appears to be wider than that.

 Using Unicode escapes should prevent this packing error from
 recurring, but seems rather a drastic measure, as it makes the
 properties files rather harder to read.

Preventing the packaging error is not my primary motivation with these
patches. My primary motivation is making sure these files work as
intended for all users.

In the rare cases where someone needs to work on these files and wants
to do it in native form it is trivial to use native2ascii to convert the
files to native form, edit them and then convert them back.

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-20 Thread sebb
On 20/04/2009, Mark Thomas ma...@apache.org wrote:
 sebb wrote:
   On 20/04/2009, Mark Thomas ma...@apache.org wrote:
   Mark Thomas wrote:
 Looks like we need to run native2ascii over a quite a few French and
 German files.
  
   Surely the ISO-8859-1 (Latin-1) character set supports most accents in
   Latin languages, so there should be no need to use Unicode escapes for
   these?


 I would have expected it to work but it appears that it doesn't. It is

I would have too - which is why I wrote this reply - but that
obviously changes things.

  probably related to the users default platform encoding. I suspect the
  issues are when a user is using something other than ISO-8859-1 or UTF-8
  but I haven't done any testing to prove this.

   Looks to me like the problem with the Spanish version is due to a
   packaging error in the tomcat-I18n-es.jar file, which contains
   corrupted copies of the original files.


 The issue appears to be wider than that.


   Using Unicode escapes should prevent this packing error from
   recurring, but seems rather a drastic measure, as it makes the
   properties files rather harder to read.


 Preventing the packaging error is not my primary motivation with these
  patches. My primary motivation is making sure these files work as
  intended for all users.

OK, point taken.

  In the rare cases where someone needs to work on these files and wants
  to do it in native form it is trivial to use native2ascii to convert the
  files to native form, edit them and then convert them back.


  Mark



  -
  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
  For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-19 Thread Mark Thomas
Ian Darwin wrote:
 Is there a policy on how we store localized files?

Based on the javadoc for the properties class [1] it should be
ISO-8859-1 with any characters that cannot be expressed in that encoded
escaped using Unicode escapes.

 The file java/org/apache/catalina/manager/LocalStrings_es.properties
 appears mostly to be ASCII characters but it has a few 16-bit unicode
 chars stuck
 in it, which then get interpreted as 2 8-bit chars because there is no
 Unicode
 mark at the top of the file.
 
 For example the file contains, on line 33, the Spanish word for
 configuration as
 
 Configuraci\u00F3n - 14 characters including a null byte

I think this was the case for 6.0.18 but trunk has been fixed, at least
for the Spanish messages, by [2].

 I believe that Eclipse wrecks properties files in just this way if you
 make the mistake
 of editing them in Eclipse, but I don't know if that's what happened here.

I think this is just how the files were originally contributed.

Looks like we need to run native2ascii over a quite a few French and
German files.

Mark

[1] http://java.sun.com/j2se/1.5.0/docs/api/java/util/Properties.html
[2] https://issues.apache.org/bugzilla/show_bug.cgi?id=45447


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-18 Thread Ian Darwin

Is there a policy on how we store localized files?

The file java/org/apache/catalina/manager/LocalStrings_es.properties
appears mostly to be ASCII characters but it has a few 16-bit unicode 
chars stuck
in it, which then get interpreted as 2 8-bit chars because there is no 
Unicode

mark at the top of the file.

For example the file contains, on line 33, the Spanish word for 
configuration as


Configuraci\u00F3n - 14 characters including a null byte

It should be

ConfiguraciĆ³n -- 13 chars, hopefully you have the fonts to see this and 
no mailer wrecks it


that is, the f3 character is in as a single byte.

I believe that Eclipse wrecks properties files in just this way if you 
make the mistake

of editing them in Eclipse, but I don't know if that's what happened here.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org