Re: Time for Tomcat 7.0.66

2015-11-25 Thread Violeta Georgieva
2015-11-25 15:51 GMT+02:00 Konstantin Kolinko :
>
> 2015-11-25 10:32 GMT+03:00 Konstantin Kolinko :
> > 2015-11-24 22:38 GMT+03:00 Violeta Georgieva :
> >> Hi,
> >>
> >> Tomorrow morning I plan to prepare Tomcat 7.0.66 for voting.
> >> If you want to add something to this release, please reply here.
> >
> > 1. The fix implementing configuration option for EL quoting (BZ 57136,
> > r1712859) has not been ported to Tomcat 7 yet.
> >
> > I also plan to restore the old behaviour by default, for the reasons I
> > explained in thread "On escaping of EL in attributes (BZ 57136)" on
> > dev@.
> >
> > I am working on it. Estimation is ~2 hours.
> >
>
> Done.
>
> I think we are OK to go.
>
> I did run the test with Nio +  Java 7 + explicitly set
> compile.source=1.7 and compile.target=1.7.  All tests passed.
>
>

Ok thanks

> (I have to run now. I'll be offline for next ~5 hours).
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>


Re: Time for Tomcat 7.0.66

2015-11-25 Thread Keiichi Fujino
2015-11-25 16:51 GMT+09:00 Violeta Georgieva :

> 2015-11-25 9:32 GMT+02:00 Konstantin Kolinko :
> >
> > 2015-11-24 22:38 GMT+03:00 Violeta Georgieva :
> > > Hi,
> > >
> > > Tomorrow morning I plan to prepare Tomcat 7.0.66 for voting.
> > > If you want to add something to this release, please reply here.
> >
> > 1. The fix implementing configuration option for EL quoting (BZ 57136,
> > r1712859) has not been ported to Tomcat 7 yet.
> >
> > I also plan to restore the old behaviour by default, for the reasons I
> > explained in thread "On escaping of EL in attributes (BZ 57136)" on
> > dev@.
> >
> > I am working on it. Estimation is ~2 hours.
> >
>
> Ok
>
> >
> > 2. I have a question on recent tribes commit that has been committed
> > to Tomcat 7 as well (see Re: r1716305).
> >
> > I guess a fix there is to simply add the following lines, falling back
> > to old behaviour.
> >
> > if (mapMember == null) {
> > mapMember = member;
> > }
>
> I saw this.
>
> I'll wait for these changes.
>
>
Hi.

I've done this.



> Regards,
> Violeta
>
> > Best regards,
> > Konstantin Kolinko
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
> --
> Keiichi.Fujino
>


Re: Time for Tomcat 7.0.66

2015-11-25 Thread Konstantin Kolinko
2015-11-25 10:32 GMT+03:00 Konstantin Kolinko :
> 2015-11-24 22:38 GMT+03:00 Violeta Georgieva :
>> Hi,
>>
>> Tomorrow morning I plan to prepare Tomcat 7.0.66 for voting.
>> If you want to add something to this release, please reply here.
>
> 1. The fix implementing configuration option for EL quoting (BZ 57136,
> r1712859) has not been ported to Tomcat 7 yet.
>
> I also plan to restore the old behaviour by default, for the reasons I
> explained in thread "On escaping of EL in attributes (BZ 57136)" on
> dev@.
>
> I am working on it. Estimation is ~2 hours.
>

Done.

I think we are OK to go.

I did run the test with Nio +  Java 7 + explicitly set
compile.source=1.7 and compile.target=1.7.  All tests passed.


(I have to run now. I'll be offline for next ~5 hours).

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Time for Tomcat 7.0.66

2015-11-24 Thread Violeta Georgieva
2015-11-25 9:32 GMT+02:00 Konstantin Kolinko :
>
> 2015-11-24 22:38 GMT+03:00 Violeta Georgieva :
> > Hi,
> >
> > Tomorrow morning I plan to prepare Tomcat 7.0.66 for voting.
> > If you want to add something to this release, please reply here.
>
> 1. The fix implementing configuration option for EL quoting (BZ 57136,
> r1712859) has not been ported to Tomcat 7 yet.
>
> I also plan to restore the old behaviour by default, for the reasons I
> explained in thread "On escaping of EL in attributes (BZ 57136)" on
> dev@.
>
> I am working on it. Estimation is ~2 hours.
>

Ok

>
> 2. I have a question on recent tribes commit that has been committed
> to Tomcat 7 as well (see Re: r1716305).
>
> I guess a fix there is to simply add the following lines, falling back
> to old behaviour.
>
> if (mapMember == null) {
> mapMember = member;
> }

I saw this.

I'll wait for these changes.

Regards,
Violeta

> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>