Re: STATUS.txt reviews
2011/3/3 Mark Thomas ma...@apache.org: On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our branches and we can give it a test run and see if we like it. Any takers? If you go down that route, use the reviewboard instance provided by ASF infra. I am currently neutral on this. I can see the benefits of reviewboard but I like that by keeping things simple I can easily work off-line. There is a problem with out trunk/tc7 that there are patches that are work-in-progress or are hard to apply and would benefit from review. The current approach is using Bugzilla, but 1) there is no such list of ready-for-review items, like the STATUS file, and they may fell off the radar 2) it is hard to review them there, because you will need separate step to download the patch, and then comment in the text field or whatever If reviewboard can solve the above, it would be fine. From descriptions it looks that it is suited for pre-commit reviews. I have no experience with it, though. Thus I suggest to try it for our trunk. For the RTC branches though I think it is not a replacement for the STATUS. Maybe with more experience I will change my mind, but as of now the STATUS is more traceable and formal. I do not mind about links to reviewboard being mentioned in STATUS, like we mention the patches on people or message threads. The links to ASF reviewboard: https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the https://reviews.apache.org/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: STATUS.txt reviews
https://issues.apache.org/jira/browse/INFRA-3507 Filip On 3/10/2011 5:12 AM, Konstantin Kolinko wrote: 2011/3/3 Mark Thomasma...@apache.org: On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our branches and we can give it a test run and see if we like it. Any takers? If you go down that route, use the reviewboard instance provided by ASF infra. I am currently neutral on this. I can see the benefits of reviewboard but I like that by keeping things simple I can easily work off-line. There is a problem with out trunk/tc7 that there are patches that are work-in-progress or are hard to apply and would benefit from review. The current approach is using Bugzilla, but 1) there is no such list of ready-for-review items, like the STATUS file, and they may fell off the radar 2) it is hard to review them there, because you will need separate step to download the patch, and then comment in the text field or whatever If reviewboard can solve the above, it would be fine. From descriptions it looks that it is suited for pre-commit reviews. I have no experience with it, though. Thus I suggest to try it for our trunk. For the RTC branches though I think it is not a replacement for the STATUS. Maybe with more experience I will change my mind, but as of now the STATUS is more traceable and formal. I do not mind about links to reviewboard being mentioned in STATUS, like we mention the patches on people or message threads. The links to ASF reviewboard: https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the https://reviews.apache.org/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1497/3496 - Release Date: 03/10/11 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
STATUS.txt reviews
I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our branches and we can give it a test run and see if we like it. Any takers? Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: STATUS.txt reviews
On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our branches and we can give it a test run and see if we like it. Any takers? If you go down that route, use the reviewboard instance provided by ASF infra. I am currently neutral on this. I can see the benefits of reviewboard but I like that by keeping things simple I can easily work off-line. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: STATUS.txt reviews
On 3/2/2011 2:05 PM, Mark Thomas wrote: On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote: I wanted to throw out an idea of an alternative or complementary way to handle our STATUS.txt files, and this solution can apply to our CTR branches as well. The solution would be http://www.reviewboard.org/ If there is an interest, I can spend some time configuring an instance for one of our branches and we can give it a test run and see if we like it. Any takers? If you go down that route, use the reviewboard instance provided by ASF infra. didn't know we had one, excellent! I am currently neutral on this. I can see the benefits of reviewboard but I like that by keeping things simple I can easily work off-line. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1204 / Virus Database: 1435/3477 - Release Date: 03/02/11 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
