Re: Servlet 3.1 tests

2013-04-11 Thread Remy Maucherat
On Wed, 2013-04-10 at 21:41 -0400, Mark Thomas wrote:
> On 10/04/2013 09:43, Remy Maucherat wrote:
> > Hi,
> >
> > Are there any good Servlet 3.1 tests around ? (besides the websockets
> > impl)
> 
> Not yet. We have Filip's initial implementation and a few associated 
> tests but that is it. The Servlet 3.1 NIO stuff is next on my TODO list 
> after the WebSocket work. That should generate a few tests. I suspect 
> that as folks start to use the new API there will be various bug reports 
> around the edge cases and they will generate a fair few tests.
> 
> The biggest problem with using WebSocket to test servlet 3.1 is that the 
> Servlet[Input|Output]Stream implementations are separate for HTTP 
> upgrade and async.

Ok, thanks. I indeed found one test which actually looks good
(TestNonBlockingAPI). Yes, I see why an upgrade test like websockets
does not fully apply to the usage inside a Servlet since the code is
indeed separate.

> > I doubt the Servlet TCK will have that sort of stuff, Servlet 3.0 wasn't
> > very good for that beyond testing of a few specific aspects.
> 
> I have access to the Servlet 3.1 draft TCK but haven't looked at it yet.

I haven't looked either, but I hope you're not expecting much.

Rémy



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Servlet 3.1 tests

2013-04-10 Thread Mark Thomas

On 10/04/2013 09:43, Remy Maucherat wrote:

Hi,

Are there any good Servlet 3.1 tests around ? (besides the websockets
impl)


Not yet. We have Filip's initial implementation and a few associated 
tests but that is it. The Servlet 3.1 NIO stuff is next on my TODO list 
after the WebSocket work. That should generate a few tests. I suspect 
that as folks start to use the new API there will be various bug reports 
around the edge cases and they will generate a fair few tests.


The biggest problem with using WebSocket to test servlet 3.1 is that the 
Servlet[Input|Output]Stream implementations are separate for HTTP 
upgrade and async.



I doubt the Servlet TCK will have that sort of stuff, Servlet 3.0 wasn't
very good for that beyond testing of a few specific aspects.


I have access to the Servlet 3.1 draft TCK but haven't looked at it yet.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Servlet 3.1 tests

2013-04-10 Thread Remy Maucherat
Hi,

Are there any good Servlet 3.1 tests around ? (besides the websockets
impl)

I doubt the Servlet TCK will have that sort of stuff, Servlet 3.0 wasn't
very good for that beyond testing of a few specific aspects.

Rémy



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org