Re: jdbc-pool build in 7.0.28

2012-06-30 Thread Mark Thomas
On 30/06/2012 02:19, Filip Hanik (mailing lists) wrote:
> Haven't had time to confirm this yet myself.
> 
> I helped a user troubleshoot an issue, something that looked like a bug that
> was already fixed
> https://issues.apache.org/bugzilla/show_bug.cgi?id=53367
> 
> The conversation is at
> http://tomcat.markmail.org/thread/betq2iim6todqlde
> 
> and when I gave the user a JAR from trunk, the symptoms went away.
> 
> So either
> 1. I forgot to update SVN external property
> 2. The user wasn't running 7.0.28
> 3. Our build didn't pick up the changes made
> 
> I'll take a look at 3. on Monday

The bug was fixed in r1346691 [1], [2]. The external on the modules
directory in the svn tag [3] points to r1350020. I think that safely
rules out option 1.

Option 3 is unlikely since I always build a release from a clean export
from the tag. Just to be sure, I checked the 7.0.28 src from the archive
[4] and it does contain the changes from [1]. Therefore, that rules out 3.

That leaves option 2 or

Option 4: The OP ran into a different issue that was fixed since the
7.0.28 tag. Looking at the svn log, I don't see any candidates so option
2 looks most likely at the moment.

Mark


[1] http://svn.apache.org/viewvc?view=revision&revision=1346691
[2] https://issues.apache.org/bugzilla/show_bug.cgi?id=53367#c1
[3] http://svn.apache.org/viewvc/tomcat/tc7.0.x/tags/TOMCAT_7_0_28/modules/
[4]
http://archive.apache.org/dist/tomcat/tomcat-7/v7.0.28/src/apache-tomcat-7.0.28-src.zip

> 
> Best
> Filip
> 
>  
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



jdbc-pool build in 7.0.28

2012-06-29 Thread Filip Hanik (mailing lists)
Haven't had time to confirm this yet myself.

I helped a user troubleshoot an issue, something that looked like a bug that
was already fixed
https://issues.apache.org/bugzilla/show_bug.cgi?id=53367

The conversation is at
http://tomcat.markmail.org/thread/betq2iim6todqlde

and when I gave the user a JAR from trunk, the symptoms went away.

So either
1. I forgot to update SVN external property
2. The user wasn't running 7.0.28
3. Our build didn't pick up the changes made

I'll take a look at 3. on Monday

Best
Filip

 




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org