Author: markt
Date: Wed Jun 24 19:45:46 2015
New Revision: 1687352
URL: http://svn.apache.org/r1687352
Log:
Add some more false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1687352&r1=1687351&r2=1687352&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Wed Jun 24 19:45:46
2015
@@ -201,6 +201,13 @@
<Bug code="SQL" />
</Match>
<Match>
+ <!-- Correct behaviour does not assume sequential operations on concurrent
+ hash map are atomic. -->
+ <Class name="org.apache.coyote.AbstractProtocol$AbstractConnectionHandler"
/>
+ <Method name="process" />
+ <Bug pattern="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION" />
+ </Match>
+ <Match>
<!-- Locks are always released. Non-standard pattern is required because
-->
<!-- of lock upgrade that is used. -->
<Class name="org.apache.coyote.http11.upgrade.AprServletInputStream" />
@@ -229,6 +236,24 @@
<Bug code="UL" />
</Match>
<Match>
+ <!-- Number being tested is unsigned. -->
+ <Class name="org.apache.coyote.http2.Http2UpgradeHandler" />
+ <Method name="createRemoteStream" />
+ <Bug pattern="IM_BAD_CHECK_FOR_ODD" />
+ </Match>
+ <Match>
+ <!-- Notify is correct. Condition changed outside of this method. -->
+ <Class name="org.apache.coyote.http2.Http2UpgradeHandler" />
+ <Mehtod name="releaseBackLog" />
+ <Bug pattern="NN_NAKED_NOTIFY" />
+ </Match>
+ <Match>
+ <!-- Notify is correct. Condition changed outside of this method. -->
+ <Class name="org.apache.coyote.http2.Stream" />
+ <Mehtod name="incrementWindowSize" />
+ <Bug pattern="NN_NAKED_NOTIFY" />
+ </Match>
+ <Match>
<!-- Returning null is required by the EL specification -->
<Class name="org.apache.el.lang.ELSupport" />
<Method name="coerceToBoolean"/>
@@ -454,7 +479,10 @@
</Match>
<Match>
<!-- Object is only ever set to null, sync therefore is still valid -->
- <Class name="org.apache.tomcat.util.net.NioEndpoint$SocketProcessor"/>
+ <Or>
+ <Class name="org.apache.tomcat.util.net.NioEndpoint$SocketProcessor"/>
+ <Class name="org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor"/>
+ </Or>
<Method name="run"/>
<Bug code="ML"/>
</Match>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
