Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Remy Maucherat

Costin Manolache wrote:

You could easily remove them from your tree.
Do you have any valid reason to no longer have the files ? I remember
for 4.x people felt they were usefull. I'm not sure 'I can't ignore
them easily' or 'I don't need them' is a real -1 reason. ( and by
'I'll remove them from the tree' I assume you meant either your own
tree or a -1 ).

I don't care that much about them - I have to ignore them as well if I
make any change, like adding the sandbox. So if anybody else feels
they should be removed, I'll do so.


I am not happy:
- it's an ad for a specific IDE (that I happen to use, but do not 
particularly like unless someone explains to me why a workspace with TC 
5.5, jbossweb (more or less similar to TC 6), and TC 6 causes Eclipse to 
take 3 minutes to display the main window, and then think it must 
recompile everything and takes 8 more minutes doing that - thankfully, 
the coding capabilities are still unparalleled in the free IDEs, so I 
didn't dump it yet)
- I do not see much benefit, given the only meaningful dependency is on 
commons-logging
- you did not commit files with proper line endings, so I get annoying 
Unix line endings on Windows, please be more careful about that
- your configuration leads to polluting the classes folder with 
Eclipse's class output (I will allow your file to remain if your accept 
that I change this)


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Costin Manolache
On 3/30/06, Remy Maucherat [EMAIL PROTECTED] wrote:

 Costin Manolache wrote:
  You could easily remove them from your tree.
  Do you have any valid reason to no longer have the files ? I remember
  for 4.x people felt they were usefull. I'm not sure 'I can't ignore
  them easily' or 'I don't need them' is a real -1 reason. ( and by
  'I'll remove them from the tree' I assume you meant either your own
  tree or a -1 ).
 
  I don't care that much about them - I have to ignore them as well if I
  make any change, like adding the sandbox. So if anybody else feels
  they should be removed, I'll do so.

 I am not happy:
 - it's an ad for a specific IDE (that I happen to use, but do not
 particularly like unless someone explains to me why a workspace with TC
 5.5, jbossweb (more or less similar to TC 6), and TC 6 causes Eclipse to
 take 3 minutes to display the main window, and then think it must
 recompile everything and takes 8 more minutes doing that - thankfully,
 the coding capabilities are still unparalleled in the free IDEs, so I
 didn't dump it yet)


I would be happy to commit the idea config as well ( I use it from time to
time, it's
a bit faster actually ). And I'm sure we can find someone to add netbeans
conf as well.



- I do not see much benefit, given the only meaningful dependency is on
 commons-logging


That's a good point - it's probably less usefull than in tc5. But still,
doesn't hurt.


- you did not commit files with proper line endings, so I get annoying
 Unix line endings on Windows, please be more careful about that


I was going to ask - when did our policy changed to use windows line endings
???
I was a bit annoyed to see windows ending as well, it looks bad on unix and
mac.


- your configuration leads to polluting the classes folder with
 Eclipse's class output (I will allow your file to remain if your accept
 that I change this)


Of course you can change this, it's an excelent idea. Not sure about the
windows
line endings, I'm tempted to say -1, but since it's only used by eclipse,
I'll live with it :-)

Could we at least use unix lines in build.xml ?

Costin


Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Remy Maucherat

Costin Manolache wrote:

I was going to ask - when did our policy changed to use windows line endings
???
I was a bit annoyed to see windows ending as well, it looks bad on unix and
mac.


There's a config in svn for that, I think, and for some reason it's not 
the default.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Costin Manolache
I don't know about svn - but the repository itself should be in unix format,
or at least that used to be
the convention. I'm not the tab and line ending police - but it would be
good to be consistent, it's really
ugly to have files with both windows and unix line ending.

Costin

On 3/30/06, Remy Maucherat [EMAIL PROTECTED] wrote:

 Costin Manolache wrote:
  I was going to ask - when did our policy changed to use windows line
 endings
  ???
  I was a bit annoyed to see windows ending as well, it looks bad on unix
 and
  mac.

 There's a config in svn for that, I think, and for some reason it's not
 the default.

 Rémy

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Rahul Akolkar
On 3/30/06, Remy Maucherat [EMAIL PROTECTED] wrote:
 Costin Manolache wrote:
  I was going to ask - when did our policy changed to use windows line endings
  ???
  I was a bit annoyed to see windows ending as well, it looks bad on unix and
  mac.

 There's a config in svn for that, I think, and for some reason it's not
 the default.

snip/

svn:eol-style can be set to native (usually the case for most files in
the ASF repo -then svn will do the line-ending conversions as needed).

You can also set autoprops in your svn config so when you add new
files svn properties get tacked on (based on file extension).

-Rahul


 Rémy

snap/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-30 Thread Rahul Akolkar
On 3/30/06, Rahul Akolkar [EMAIL PROTECTED] wrote:
 On 3/30/06, Remy Maucherat [EMAIL PROTECTED] wrote:
  Costin Manolache wrote:
   I was going to ask - when did our policy changed to use windows line 
   endings
   ???
   I was a bit annoyed to see windows ending as well, it looks bad on unix 
   and
   mac.
 
  There's a config in svn for that, I think, and for some reason it's not
  the default.
 
 snip/

 svn:eol-style can be set to native (usually the case for most files in
 the ASF repo -then svn will do the line-ending conversions as needed).

 You can also set autoprops in your svn config so when you add new
 files svn properties get tacked on (based on file extension).

snip/

Related details are here (See paragraph starting Committers will need to ...):

http://www.apache.org/dev/version-control.html#https-svn

Here are the eol-style settings that we recommend folks use for their
svn client configs:

http://www.apache.org/dev/svn-eol-style.txt

-Rahul


 -Rahul


  Rémy
 
 snap/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-29 Thread Remy Maucherat

Ian Darwin wrote:

(and as costin just pointed out, we have them for 5.x).


They weren't in the root folder, so I could ignore them more easily.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-29 Thread Costin Manolache
You could easily remove them from your tree.
Do you have any valid reason to no longer have the files ? I remember
for 4.x people felt they were usefull. I'm not sure 'I can't ignore
them easily' or 'I don't need them' is a real -1 reason. ( and by
'I'll remove them from the tree' I assume you meant either your own
tree or a -1 ).

I don't care that much about them - I have to ignore them as well if I
make any change, like adding the sandbox. So if anybody else feels
they should be removed, I'll do so.

Costin

On 3/29/06, Remy Maucherat [EMAIL PROTECTED] wrote:
 Ian Darwin wrote:
  (and as costin just pointed out, we have them for 5.x).

 They weren't in the root folder, so I could ignore them more easily.

 Rémy

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-28 Thread Remy Maucherat

[EMAIL PROTECTED] wrote:

Author: costin
Date: Mon Mar 27 22:45:43 2006
New Revision: 389421

URL: http://svn.apache.org/viewcvs?rev=389421view=rev
Log:
Add eclipse files


This sort of thing is an unwanted convenience (for example, it trashes 
my own files, and I would like to keep them, thank you very much). I'll 
remove them.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-28 Thread Costin Manolache
But it can be usefull for people who just checkout, we had them in the old
repos AFAIK.

You should be able to  just save yours, then replace the svn files and add
to .svnignore.

( I don't mind if you remove them - it's just a nice convenience for the
people who don't
have them yet )

Costin

On 3/28/06, Remy Maucherat [EMAIL PROTECTED] wrote:

 [EMAIL PROTECTED] wrote:
  Author: costin
  Date: Mon Mar 27 22:45:43 2006
  New Revision: 389421
 
  URL: http://svn.apache.org/viewcvs?rev=389421view=rev
  Log:
  Add eclipse files

 This sort of thing is an unwanted convenience (for example, it trashes
 my own files, and I would like to keep them, thank you very much). I'll
 remove them.

 Rémy

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]




Re: svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-28 Thread Ian Darwin

Remy Maucherat wrote:

[EMAIL PROTECTED] wrote:

Author: costin
Date: Mon Mar 27 22:45:43 2006
New Revision: 389421

URL: http://svn.apache.org/viewcvs?rev=389421view=rev
Log:
Add eclipse files


This sort of thing is an unwanted convenience (for example, it trashes 
my own files, and I would like to keep them, thank you very much). 
I'll remove them.
I'm curious, what difference do you need from what is there now? If you 
set your Eclipse classpath variable TOMCAT_LIBS_BASE then the files 
should work for you. I believe we should have files like these committed 
(and as costin just pointed out, we have them for 5.x).


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r389421 - in /tomcat/tc6.0.x/trunk: .classpath .project

2006-03-27 Thread costin
Author: costin
Date: Mon Mar 27 22:45:43 2006
New Revision: 389421

URL: http://svn.apache.org/viewcvs?rev=389421view=rev
Log:
Add eclipse files

Added:
tomcat/tc6.0.x/trunk/.classpath
tomcat/tc6.0.x/trunk/.project

Added: tomcat/tc6.0.x/trunk/.classpath
URL: 
http://svn.apache.org/viewcvs/tomcat/tc6.0.x/trunk/.classpath?rev=389421view=auto
==
--- tomcat/tc6.0.x/trunk/.classpath (added)
+++ tomcat/tc6.0.x/trunk/.classpath Mon Mar 27 22:45:43 2006
@@ -0,0 +1,10 @@
+?xml version=1.0 encoding=UTF-8?
+classpath
+   classpathentry 
excluding=org/apache/tomcat/util/net/puretls/|org/apache/naming/factory/MailSessionFactory.java|org/apache/naming/factory/SendMailFactory.java
 kind=src path=java/
+   classpathentry kind=con 
path=org.eclipse.jdt.launching.JRE_CONTAINER/
+   classpathentry kind=var 
path=TOMCAT_LIBS_BASE/commons-logging-1.0.4/commons-logging.jar/
+   classpathentry kind=var 
path=TOMCAT_LIBS_BASE/commons-modeler-1.1/commons-modeler.jar/
+   classpathentry kind=var 
path=TOMCAT_LIBS_BASE/apache-ant-1.6.5/lib/ant.jar/
+   classpathentry kind=var 
path=TOMCAT_LIBS_BASE/eclipse/plugins/org.eclipse.jdt.core_3.1.1.jar/
+   classpathentry kind=output path=classes/
+/classpath

Added: tomcat/tc6.0.x/trunk/.project
URL: 
http://svn.apache.org/viewcvs/tomcat/tc6.0.x/trunk/.project?rev=389421view=auto
==
--- tomcat/tc6.0.x/trunk/.project (added)
+++ tomcat/tc6.0.x/trunk/.project Mon Mar 27 22:45:43 2006
@@ -0,0 +1,17 @@
+?xml version=1.0 encoding=UTF-8?
+projectDescription
+   nametomcat6/name
+   comment/comment
+   projects
+   /projects
+   buildSpec
+   buildCommand
+   nameorg.eclipse.jdt.core.javabuilder/name
+   arguments
+   /arguments
+   /buildCommand
+   /buildSpec
+   natures
+   natureorg.eclipse.jdt.core.javanature/nature
+   /natures
+/projectDescription



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]