Re: warning message - small issue

2017-01-30 Thread Mark Thomas
On 30/01/2017 19:24, George Stanchev wrote:
> Hello,
> 
> Let me know if you want an official bug report or this not will suffice. The 
> message "jsseUtil.noVerificationDepth" which is defined in
> 
> https://svn.apache.org/repos/asf/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties
> 
> as a one arg string:
> 
> jsseUtil.noVerificationDepth=The truststoreProvider [{0}] does not support 
> the certificateVerificationDepth configuration option
> 
> But the argument is never used when emitting the message. Its only usage is in
> 
> java\org\apache\tomcat\util\net\jsse\JSSEUtil.java
> 
> as follows: log.warn(sm.getString("jsseUtil.noVerificationDepth"));
> 
> I can submit a bug report or any of the devs can just fix the string (or, 
> preferably the warning)

Generally, bug reports are preferred since that ensures the issue
doesn't get forgotten about. For simple stuff like this, an e-mail is
fine but if it does look like it has been forgotten, then a bug report
will ensure it isn't.

Bug reports also give you the opportunity to provide patches and get you
name in the changelog ;)

Thanks for the report. Should be fixed now.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



warning message - small issue

2017-01-30 Thread George Stanchev
Hello,

Let me know if you want an official bug report or this not will suffice. The 
message "jsseUtil.noVerificationDepth" which is defined in

https://svn.apache.org/repos/asf/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/LocalStrings.properties

as a one arg string:

jsseUtil.noVerificationDepth=The truststoreProvider [{0}] does not support the 
certificateVerificationDepth configuration option

But the argument is never used when emitting the message. Its only usage is in

java\org\apache\tomcat\util\net\jsse\JSSEUtil.java

as follows: log.warn(sm.getString("jsseUtil.noVerificationDepth"));

I can submit a bug report or any of the devs can just fix the string (or, 
preferably the warning)

George