mod_jk doesn't make the setting of "reply_timeout" effective.

2006-02-13 Thread Hidenori Yukawa

I am using mod_jk 1.2.15.
It set if to workers.properties.
---
worker.ap1.type=ajp13
worker.ap1.host=192.168.0.3
worker.ap1.port=8009
worker.ap1.recovery_options=0 or 3
worker.ap1.retries=1
worker.ap1.reply_timeout=3
---

I set "reply_timeout=3"(30sec) by mod_jk1.2.15.
And, The JSP page that return the result after the sleep had been done
for 3 minutes was displayed. 

At recovery_options=0 or 2, "503 Service Temporarily Unavailable" will be 
displayed in about 30 seconds. This is a result the same as the expectation. 

At recovery_options=1 or 3, "502 Bad Gateway" will be displayed in about 3 minutes. 
This is not a result the same as the expectation. 
At this time, I want you to be going to be displayed in about 30 seconds as "502 Bad Gateway".



mod_jk 1.2.13 was a result the same as the expectation regardless of 
recovery_options value.
Thanks in advance.

Regards.
Hidenori Yukawa

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38629] New: - Classloader not quickly enough available for JSPs

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38629

   Summary: Classloader not quickly enough available for JSPs
   Product: Tomcat 5
   Version: 5.0.30
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


On a loaded server, I can experience, that when tomcat is restarted, JSPs are
enabled for http access, before the classloader is fully available. At least
needed classes are not immediately available for use as expected.

Symptoms are various class unavailable errors on the first invocations of JSPs.
Not only the very first invocation, but until the class gets available.

Here are examples for two different class usages that are affected.
Please note that all affected classes are stored in 
WEB-INF/classes/com/folgmann.

Java classes used in  inside JSPs:

java.lang.NoClassDefFoundError: com/folgmann/RefererBeanat
org.apache.jsp.paid.sec.postings.list_jsp._jspService(list_jsp.java:220)
at
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)  at
javax.servlet.http.HttpServlet.service(HttpServlet.java:802)at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324) 
at
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
at
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)   at
javax.servlet.http.HttpServlet.service(HttpServlet.java:802)at 
[...]

I've got dozens more of these messages, for different classes and different 
JSPs.

Java classes implementing tag handlers for custom tags:

java.lang.NoClassDefFoundError: com.folgmann.tags.BodyStartTag  at
org.apache.jsp.paid.sec.messages.read_jsp.class$(read_jsp.java:151) at
org.apache.jsp.paid.sec.messages.read_jsp._jspService(read_jsp.java:161)
at
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)  at
javax.servlet.http.HttpServlet.service(HttpServlet.java:802)at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324) 
at
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
at
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)   at
javax.servlet.http.HttpServlet.service(HttpServlet.java:802)at 
[...]

I've got dozens more of these messages, for different classes and different 
JSPs.

Having a close look at all of these error messages shows, that it seems totally
random which class has problems beeing available when JSPs using it are enabled
for http access. After some accesses the error messages vanish, because the
class seems now to be available.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38630] New: - Environment (java:comp/env/) sometimes not available

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38630

   Summary: Environment (java:comp/env/) sometimes not available
   Product: Tomcat 5
   Version: 5.0.30
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: major
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Very often, let's say in 30%-50% of each invocations java:comp is not available
inside a static initializer when my webapp is started or restarted.

Example:

12.02.2006 13:21:44 org.apache.catalina.session.StandardManager start
SCHWERWIEGEND: Exception loading sessions from persistent storage
java.lang.ExceptionInInitializerError
[...]
Caused by: javax.naming.NameNotFoundException: Name java:comp is not bound in
this Context
[...]

which is thrown by line two of this code snippet:

Context initContext = new InitialContext();
envContext = (Context)initContext.lookup("java:comp/env/");

As this error occurs only sometimes, it seems to be a race condition between the
setting up of the environmental context and the starting of the application.
It might be a problem with persistent sessions as the StandardManager error line
suggests.

Please fix it, as my application needs to read an  out of it's deployment descriptor to start-up
successfully. Everytime this error occurs one has to start the application
manually again in the tomcat manager webapp. This is bad for automated restarts.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Tomcat errors.

2006-02-13 Thread Ángel Prieto

Hello, I'm having some problems with apache+tomcat with this configuration:
Apache 2.0.51 (on Fedora Core 2)
Tomcat 5.0.28
JDK 1.4.0_04
Mod_jk connector for FC2.


Sometimes system goes down and we don't have any idea what the reason 
is. We get this error sometimes:


10-feb-2006 10:05:02 org.apache.commons.modeler.Registry registerComponent
GRAVE: Error registering 
server:type=RequestProcessor,worker=jk-9109,name=JkRequest413
javax.management.InstanceAlreadyExistsException: 
server:type=RequestProcessor,worker=jk-9109,name=JkRequest413

at mx4j.server.MBeanServerImpl.register(MBeanServerImpl.java:1123)
at mx4j.server.MBeanServerImpl.registerImpl(MBeanServerImpl.java:1054)
at 
mx4j.server.MBeanServerImpl.registerMBeanImpl(MBeanServerImpl.java:1002)

at mx4j.server.MBeanServerImpl.registerMBean(MBeanServerImpl.java:978)
at 
org.apache.commons.modeler.Registry.registerComponent(Registry.java:871)
at 
org.apache.jk.common.ChannelSocket.registerRequest(ChannelSocket.java:436)
at 
org.apache.jk.common.HandlerRequest.decodeRequest(HandlerRequest.java:443)

at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:352)
at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:743)
at 
org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:675) 


at org.apache.jk.common.SocketConnection.runIt(ChannelSocket.java:866)
at 
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:683) 


at java.lang.Thread.run(Thread.java:536)

Could anyone tell me something about it?

thank you in advance.

--
Angel Prieto
[EMAIL PROTECTED] 
SINERGIA TECNOLÓGICA

C/ Almirante Churruca

30007 Murcia
TEL.  968 270 624Fax. 968 231 501
www.sinergiatec.com
__

La información incluida en el presente correo electrónico es CONFIDENCIAL, 
siendo para el uso exclusivo del destinatario arriba mencionado. Si usted lee 
este mensaje y no es el destinatario señalado, el empleado o el agente 
responsable de entregar el mensaje al destinatario, o ha recibido esta 
comunicación por error, le informamos que está totalmente prohibida cualquier 
divulgación, distribución o reproducción de esta comunicación, y le rogamos que 
nos lo notifique, nos devuelva el mensaje original a la dirección arriba 
mencionada y borre el mensaje. Gracias.
__



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Request parameters straight after authentication

2006-02-13 Thread Kevin McCormack
Hi all,

I believe that I've found a bug in Tomcat but wanted to run it by
people on this list first to make sure. Note that I've checked
Bugzilla and searched the mailing list and not found anything that
looks like this. I hope that I'm not wasting peoples time. Here
goes...

Spec

I'm running Tomcat 5.5.12. I have tested on both Red Hat Enterprise
Linux 3 and Windows 2000. I've tested on Java 1.5.0_05.

Behaviour
===
-- User has not logged on to the app and this is their first access
1) User issues POST request to the app
2) User receives HTTP 302 redirect to login page. User issues GET for
this page.
3) User issues POST request with j_username and j_password to
authentication page
4) Authentication is successful. Server issues another HTTP 302 to
send user to original requested destination.
5) User issues GET request to the redirect URL.
6) None of the original request parameters are available on the final
destination.

To further clarify, if I'd submitted a request parameter called test
on the original request (step 1), it would not be available once I
process the request in step 5. This is not an issue when the user is
authenticated already.

Possible Fix?
==
I looked through the Tomcat 5.5.12 source code and ended up in the
org.apache.catalina.authentication.FormAuthenticator class and noticed
that there is no code there to save the request parameters from the
original request into the saved request in the saveRequest() mehtod
and to copy them into the final 'new' request in the restoreRequest()
method. Am I missing something here? Is this done somewhere else? I
added this code in myself and copied it to the
$TOMCAT_HOME/server/classes directory and all seems to now work fine.
I can post the code if desired (don't want to send a huge long mail
unless necessary).

Conclusion

I believe that this is a bug and that I have found a fix for it but
I'm not a Tomcat expert and would like someone who knows the code to
verify that a) this is a bug and b) that it has not been fixed
somewhere else that I am unaware of. I'm willing to raise a bug and
post the fixed code if desired.

Thanks very much for your time.

Kevin.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Building Tomcat 5.0

2006-02-13 Thread Bob Herrmann

I'm trying to update the build script for 5.0

Has anyone seen this, it seems the 'get' in ant downloads a corrupt file,
while the browser or command line tools get it right.

ie.


   
   
   


$  ant  -f b.xml
-Dsrc=http://easynews.dl.sourceforge.net/sourceforge/mx4j/mx4j-2.1.1.tar.gz
b

$ cksum  mx4j-2.1.1.tar.gz
768509745 4585483 mx4j-2.1.1.tar.gz

$ cksum cksum mx4j-2.1.1.tar.gz-firefox
552602649 4587837 mx4j-2.1.1.tar.gz-mozilla

Why do I always get the edge cases?

-bob


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r376730 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/buf/CharChunk.java

2006-02-13 Thread Remy Maucherat

Costin Manolache wrote:

Well, long time ago CharChunk and ByteChunk were supposed to be just an
implementation
detail of MessageBytes - which was supposed to hide the detail of chars and
bytes and avoid the strings.
But they were supposed to work together, and stay kind of consistent.


I am not against it, as other parts of the code assume the default HTTP 
encoding when dealing with bytes. User code can use toChars or toString 
to force character conversion whenever needed, so it looks reasonably safe.



Sorry :-)

I guess it had something to do with  jdk compat ? Well, too lazy to search -
but
I doubt any reason would be valid today, most VMs have this.


No idea, you said no because it would break API compatibility, or 
something like it. So I thought this was a misunderstanding about what 
the change was about.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



problem building 5.5.15

2006-02-13 Thread Eric Lenio
All -

Apologies in advance if this should go to tomcat-users but I'm
suspecting a problem with the way the source code is being distributed
so I'm starting here.

I downloaded the source file for 5.5.15 and built it.  After installing
it I ran bin/version.sh which said I had version 5.5.0.0.  Not what I
was expecting.

So I followed instructions, exactly, from
http://tomcat.apache.org/tomcat-5.5-doc/building.html to build directly
from subversion.  The build went
fine.  But version.sh still says 5.5.0.0.  I was expecting to have
5.5.15.

So, did I really just build 5.5.0.0?  There was a bug that was
supposedly fixed in 5.5.15 that I was experiencing, and I still see this
bug when I use this 5.5.0.0 which leads me to conclude I did not
really build 5.5.15.

Note: I can't use the binary 5.5.15 package because I have a requirement
to patch JNDIRealm.java, that's why I am starting from the source code.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377402 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 08:00:24 2006
New Revision: 377402

URL: http://svn.apache.org/viewcvs?rev=377402&view=rev
Log:
Corrected logging of IOException, keep alive close will cause an IOException on 
the other end.


Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java?rev=377402&r1=377401&r2=377402&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/TcpReplicationThread.java
 Mon Feb 13 08:00:24 2006
@@ -70,7 +70,14 @@
 } catch (Exception e) {
 //this is common, since the sockets on the other
 //end expire after a certain time.
-log.warn ("TCP Worker thread in cluster caught '" + e + "' 
closing channel", e);
+if ( e instanceof IOException ) {
+//dont spew out stack traces for IO exceptions unless 
debug is enabled.
+if (log.isDebugEnabled()) log.debug ("IOException in 
replication worker, unable to drain channel. Probable cause: Keep alive socket 
closed.", e);
+else log.warn ("IOException in replication worker, unable 
to drain channel. Probable cause: Keep alive socket closed.");
+} else if ( log.isErrorEnabled() ) {
+//this is a real error, log it.
+log.error("Exception caught in 
TcpReplicationThread.drainChannel.",e);
+} 
 
 // close channel and nudge selector
 try {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377432 - in /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster: ClusterChannel.java group/ group/GroupChannel.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 09:33:22 2006
New Revision: 377432

URL: http://svn.apache.org/viewcvs?rev=377432&view=rev
Log:
Infrastructure for a group layer, this is the way to abstract away membership 
and replication logic from the cluster object, as the cluster object, the 
replication valve and the manager are responsible for session replication 
logic, the channel is responsible for replication and membership.


Added:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java

Added: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java?rev=377432&view=auto
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
 (added)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
 Mon Feb 13 09:33:22 2006
@@ -0,0 +1,27 @@
+/*
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.cluster;
+
+/**
+ * Channel interface
+ * A channel is an object that manages a group of members.
+ * It manages a complete cluster group, both membership and replication.
+ * @author Filip Hanik
+ * @version $Revision: 304032 $, $Date: 2005-07-27 10:11:55 -0500 (Wed, 27 Jul 
2005) $
+ */
+public interface ClusterChannel {
+
+}

Added: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java?rev=377432&view=auto
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java
 (added)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java
 Mon Feb 13 09:33:22 2006
@@ -0,0 +1,32 @@
+/*
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.cluster.group;
+
+
+import org.apache.catalina.cluster.ClusterChannel;
+
+/**
+ * Channel interface
+ * A channel is an object that manages a group of members.
+ * It manages a complete cluster group, both membership and replication.
+ * @author Filip Hanik
+ * @version $Revision: 304032 $, $Date: 2005-07-27 10:11:55 -0500 (Wed, 27 Jul 
2005) $
+ */
+public class GroupChannel implements ClusterChannel {
+public GroupChannel() {
+}
+
+}



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat errors.

2006-02-13 Thread Mark Thomas
Ángel Prieto wrote:
> Hello, I'm having some problems with apache+tomcat with this configuration:
> Could anyone tell me something about it?

The question belongs on the users list as per
http://tomcat.apache.org/lists.html

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Mark Thomas
Eric Lenio wrote:
> All -
> 
> Apologies in advance if this should go to tomcat-users but I'm
> suspecting a problem with the way the source code is being distributed
> so I'm starting here.
> 
> I downloaded the source file for 5.5.15 and built it.  After installing
> it I ran bin/version.sh which said I had version 5.5.0.0.  Not what I
> was expecting.
This is the default version number set in build.properties.default

The behaviour you see is expected and can be changed by setting the
appropriate ant properties.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Eric Lenio
OK thanks for the tip.  Is there a document that goes into detail
on this?

On Mon, Feb 13, 2006 at 07:35:42PM +, Mark Thomas wrote:
> Eric Lenio wrote:
> > All -
> > 
> > Apologies in advance if this should go to tomcat-users but I'm
> > suspecting a problem with the way the source code is being distributed
> > so I'm starting here.
> > 
> > I downloaded the source file for 5.5.15 and built it.  After installing
> > it I ran bin/version.sh which said I had version 5.5.0.0.  Not what I
> > was expecting.
> This is the default version number set in build.properties.default
> 
> The behaviour you see is expected and can be changed by setting the
> appropriate ant properties.
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Request parameters straight after authentication

2006-02-13 Thread Mark Thomas
Kevin McCormack wrote:
> Possible Fix?
> ==
> I looked through the Tomcat 5.5.12 source code and ended up in the
> org.apache.catalina.authentication.FormAuthenticator class and noticed
> that there is no code there to save the request parameters from the
> original request into the saved request in the saveRequest() mehtod
> and to copy them into the final 'new' request in the restoreRequest()
> method. Am I missing something here?
Yep, lines 478 to 490 of the current version of FormAuthenticator

> Conclusion
> 
> I believe that this is a bug and that I have found a fix for it but
> I'm not a Tomcat expert and would like someone who knows the code to
> verify that a) this is a bug and b) that it has not been fixed
> somewhere else that I am unaware of. I'm willing to raise a bug and
> post the fixed code if desired.
This might be a bug but your fix is the wrong way to do it. You have
to assume a request parameter encoding and that causes i18n problems.

Is your setting of maxSavePostSize appropriate?

If you are convinced you have a bug, a test case (as simple as
possible ready to run war with all source code) will greatly increase
the chances that someone looks at it.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Mark Thomas
Eric Lenio wrote:
> OK thanks for the tip.  Is there a document that goes into detail
> on this?
BUILDING.TXT and http://tomcat.apache.org/tomcat-5.5-doc/building.html
are the main documents. Documentation patches are always welcome.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tomcat errors.

2006-02-13 Thread Angel Prieto
Hello, what do you want to mean when you say this question belongs as 
per? I can't find it. Could you please me tell me the full url?


Thanks in advance.

Mark Thomas escribió:

Ángel Prieto wrote:
  

Hello, I'm having some problems with apache+tomcat with this configuration:
Could anyone tell me something about it?



The question belongs on the users list as per
http://tomcat.apache.org/lists.html

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Eric Lenio
Hi Mark, I would be happy to send in patches to the docs on how to build
Tomcat but I still need more info.  Let me rephrase my initial question.

Does there exist a module in the current subversion 
repository that has predefined all the properties to
generate a file that is the same as a release?

For example, I am attempting to generate apache-tomcat-5.5.15.tar.gz.
The current docs basically say "run ant".  Based on your earlier email I
know now that I'm supposed to first set the tomcat version properties.
OK so after ant finishes up, then what?  I think the next step is to
go into the build subdir and do 'ant release' but that's guesswork on my
part.  I'm looking to replicate the way you guys produce official 
releases.


On Mon, Feb 13, 2006 at 07:59:58PM +, Mark Thomas wrote:
> Eric Lenio wrote:
> > OK thanks for the tip.  Is there a document that goes into detail
> > on this?
> BUILDING.TXT and http://tomcat.apache.org/tomcat-5.5-doc/building.html
> are the main documents. Documentation patches are always welcome.
> 
> Mark
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377484 - in /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster: ./ group/ io/ session/ tcp/

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 13:00:05 2006
New Revision: 377484

URL: http://svn.apache.org/viewcvs?rev=377484&view=rev
Log:
Started working on the cluster group, before I can fully do that, I need to 
clean up the dependencies between session replication logic and cluster core 
code.


Added:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ChannelException.java
Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterMessage.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/MembershipService.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/group/GroupChannel.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/io/ObjectReader.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/io/XByteBuffer.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/ReplicationStream.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ClusterData.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ClusterReceiverBase.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/DataSender.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java

Added: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ChannelException.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ChannelException.java?rev=377484&view=auto
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ChannelException.java
 (added)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ChannelException.java
 Mon Feb 13 13:00:05 2006
@@ -0,0 +1,42 @@
+/*
+ * Copyright 1999,2004-2005 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.cluster;
+
+/**
+ * Channel Exception 
+ * @author Filip Hanik
+ * @version $Revision: 304032 $, $Date: 2005-07-27 10:11:55 -0500 (Wed, 27 Jul 
2005) $
+ */
+
+public class ChannelException
+extends Exception {
+public ChannelException() {
+super();
+}
+
+public ChannelException(String message) {
+super(message);
+}
+
+public ChannelException(String message, Throwable cause) {
+super(message, cause);
+}
+
+public ChannelException(Throwable cause) {
+super(cause);
+}
+
+}

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java?rev=377484&r1=377483&r2=377484&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/ClusterChannel.java
 Mon Feb 13 13:00:05 2006
@@ -24,4 +24,53 @@
  */
 public interface ClusterChannel {
 
+/**
+ * Start and stop sequences can be controlled by these constants
+ */
+public static final int DEFAULT = 15;
+public static final int MBR_RX_SEQ = 1;
+public static final int SND_TX_SEQ = 2;
+public static final int SND_RX_SEQ = 4;
+public static final int MBR_TX_SEQ = 8;
+
+/**
+ * Starts up the channel. This can be called multiple times for individual 
services to start
+ * The svc parameter can be the logical or value of any constants
+ * @param svc int value of 
+ * DEFAULT - will start all services 
+ * MBR_RX_SEQ - starts the membership receiver 
+ * MBR_TX_SEQ - starts the membership broadcaster 
+ * SND_TX_SEQ - starts the replication transmitter
+ * SND_RX_SEQ - starts the replication receiver
+ * @throws ChannelException if a startup error occurs or the service is 
already started.
+ */
+

Re: problem building 5.5.15

2006-02-13 Thread Mark Thomas
Eric Lenio wrote:
> Hi Mark, I would be happy to send in patches to the docs on how to build
> Tomcat but I still need more info.  Let me rephrase my initial question.
> 
> Does there exist a module in the current subversion 
> repository that has predefined all the properties to
> generate a file that is the same as a release?

Not that I am aware of. There will always be some properties that
depend on the environment. However, it looks like some of the defaults
could be better set (eg the version number).

Yoav, who is away at the moment, is the release manager for 5.5 and
should be able to shed more light.

Mark



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377486 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 13:04:20 2006
New Revision: 377486

URL: http://svn.apache.org/viewcvs?rev=377486&view=rev
Log:
Use constants instead of hard coding values

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java?rev=377486&r1=377485&r2=377486&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
 Mon Feb 13 13:04:20 2006
@@ -257,8 +257,8 @@
  * @throws java.lang.Exception if a IO error occurs
  */
 public void start() throws java.lang.Exception {
-start(1);
-start(2);
+start(MembershipService.MBR_RX);
+start(MembershipService.MBR_RX);
 registerMBean();
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377488 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 13:10:41 2006
New Revision: 377488

URL: http://svn.apache.org/viewcvs?rev=377488&view=rev
Log:
oops, use the correct values

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java?rev=377488&r1=377487&r2=377488&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java
 Mon Feb 13 13:10:41 2006
@@ -258,7 +258,7 @@
  */
 public void start() throws java.lang.Exception {
 start(MembershipService.MBR_RX);
-start(MembershipService.MBR_RX);
+start(MembershipService.MBR_TX);
 registerMBean();
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r377499 - in /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp: ReplicationTransmitter.java SimpleTcpCluster.java

2006-02-13 Thread fhanik
Author: fhanik
Date: Mon Feb 13 13:39:52 2006
New Revision: 377499

URL: http://svn.apache.org/viewcvs?rev=377499&view=rev
Log:
more code cleanup

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java?rev=377499&r1=377498&r2=377499&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java
 Mon Feb 13 13:39:52 2006
@@ -415,11 +415,9 @@
 
 /**
  * Send data to one member
- * FIXME set filtering messages
  * @see 
org.apache.catalina.cluster.ClusterSender#sendMessage(org.apache.catalina.cluster.ClusterMessage,
 org.apache.catalina.cluster.Member)
  */
-public void sendMessage(ClusterMessage message, Member member)
-throws java.io.IOException {   
+public void sendMessage(ClusterMessage message, Member member) throws 
IOException {   
 long time = 0 ;
 if(doTransmitterProcessingStats) {
 time = System.currentTimeMillis();
@@ -440,47 +438,21 @@
  * Send to all senders at same cluster domain as message from address
  * @param message Cluster message to send
  * @since 5.5.10
- * FIXME Refactor with sendMessage get a sender list from
  */
-public void sendMessageClusterDomain(ClusterMessage message) 
- throws java.io.IOException {
-long time = 0;
-if (doTransmitterProcessingStats) {
-time = System.currentTimeMillis();
-}
-try {
-String domain = message.getAddress().getDomain();
-if(domain == null)
-throw new RuntimeException("Domain at member not set");
-ClusterData data = serialize(message);
-IDataSender[] senders = getSenders();
-for (int i = 0; i < senders.length; i++) {
-
-IDataSender sender = senders[i];
-if(domain.equals(sender.getDomain())) {
-try {
-boolean success = sendMessageData(data, sender);
-} catch (Exception x) {
-//THIS WILL NEVER HAPPEN, as sendMessageData swallows 
the error
-}
-}
-}
-} finally {
-// FIXME better exception handling
-if (doTransmitterProcessingStats) {
-addProcessingStats(time);
-}
-}
+public void sendMessageClusterDomain(ClusterMessage message) throws 
IOException {
+sendMessage(message,true);
 
 }
 
+public void sendMessage(ClusterMessage message) throws IOException {
+sendMessage(message,false);
+}
+
 /**
  * send message to all senders (broadcast)
  * @see 
org.apache.catalina.cluster.ClusterSender#sendMessage(org.apache.catalina.cluster.ClusterMessage)
- * FIXME Refactor with sendMessageClusterDomain!
  */
-public void sendMessage(ClusterMessage message)
-throws java.io.IOException {
+public void sendMessage(ClusterMessage message, boolean domainOnly) throws 
IOException {
 long time = 0;
 if (doTransmitterProcessingStats) {
 time = System.currentTimeMillis();
@@ -491,19 +463,19 @@
 for (int i = 0; i < senders.length; i++) {
 
 IDataSender sender = senders[i];
-try {
-sendMessageData(data, sender);
-} catch (Exception x) {
-// FIXME remember exception and send it at finally
-}
+//domain filter
+String domain = message.getAddress().getDomain();
+if ( domainOnly && !(domain.equals(sender.getDomain())) ) 
continue;
+sendMessageData(data, sender);
 }
 } finally {
-// FIXME better exception handling
 if (doTransmitterProcessingStats) {
 addProcessingStats(time);
 }
 }
 }
+
+
 
 /**
  * start the sender and register transmitter mbean
@@ -828,9 +800,9 @@
  * @throws java.io.IOException If an error occurs
  */
 protected boolean sendMessageData(ClusterData data,
-   IDataSender sender) throws 
java.io.IOException {
+  IDataSender sender) {
 i

DO NOT REPLY [Bug 38637] New: - IP address of the HttpSession owner

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38637

   Summary: IP address of the HttpSession owner
   Product: Tomcat 5
   Version: 5.5.9
  Platform: All
OS/Version: other
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


hi,

This is not a bug, just a suggestion.

Sometimes it is necessary to back trace session data to the originating client.
It would be really useful if StandardSession has IP address of the client as a
property. 

Thanks in advance,
Vlad

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38637] - IP address of the HttpSession owner

2006-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38637


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|P2  |P5




--- Additional Comments From [EMAIL PROTECTED]  2006-02-14 04:52 ---
But an ISP could use a cluster of transparent proxies that mask the real source
IP and distribute traffic from one user across many IPs. eg:
http://webmaster.info.aol.com/proxyinfo.html

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Proposal: void AuthenticatorBase.doLogin(request, response, principal)

2006-02-13 Thread Ken Johanson
These 3 new (proposed) methods allow webapps (with classloader access to 
the server APIs) to implicitly register a Principal with a HttpSession 
(e.g to implement or use-existing 3rd party Authenticator/Realm systems):


Add to org.apache.catalina.connector.ResponseFacade:
public Response getResponse() {
  return resp;
}

Add to org.apache.catalina.connector.RequestFacade:
public Request getRequest() {
  return (Request)request;
}

Add to org.apache.catalina.authenticator.AuthenticatorBase:
public void doLogin(HttpServletRequest request,
  HttpServletResponse response, Principal principal)
{
  register(
(HttpRequest)((RequestFacade)request).getRequest(),
(HttpResponse)((ResponseFacade)response).getResponse(),
principal, "FORM", null, null);
}

I have tested these but in a limited way, and am not certain of the 
absence of potential ClassCastExceptions.


Example usage, querying an existing config'd Authenticator:

/** query an existing plain-password (custom form-based login) 
authenticator/realm, if success login: **/
public static boolean tryLogin(HttpServletRequest request, 
HttpServletRequest response, String user, String pass)

  throws Exception
{
  Server server = ServerFactory.getServer();
  Service service = server.findService("Catalina");
  if (service==null)
throw new NullPointerException("login: Cannot load Service 
'Catalina'");

  Engine engine = (Engine) service.getContainer();
  if (engine==null)
throw new NullPointerException("login: Cannot load Container for 
Service 'Catalina'");


  Host host = null;
  String hostname = Strings.norm(request.getHeader("Host"));
  Object[] o = engine.findChildren();
  for (int i=0; ithrow new NullPointerException("login: Cannot load Host 
'"+hostname+"'");

  String reqbase  = Strings.norm(req.getContextPath())+"/";
  Context context = (Context) host.findChild(reqbase);
  if (context==null)
  {
context = (Context) host.findChild(Strings.clip(reqbase,-1));
  }
  if (context==null)
throw new NullPointerException("login: Cannot load Context 
'"+reqbase+"'");

  Manager manager = context.getManager();
  HttpSession hses = request.getSession(true);
  Session session = null;
  try {
session = manager.findSession(hses.getId());
  } catch (IOException e) {}
  if (session==null)
throw new NullPointerException("login: Cannot load Session 
'"+reqbase+"'");

  Realm realm = context.getRealm();
  LoginConfig config = context.getLoginConfig();
  FormAuthenticator auth = null;
  Pipeline pipe = context.getPipeline();
  Valve[] v = pipe.getValves();
  for (int i=0; ithrow new NullPointerException("login: Cannot load Authenticator 
'"+reqbase+"'");

  Principal principal = realm.authenticate(user, pass);
  if (principal==null)
return false;
  session.setNote(Constants.FORM_PRINCIPAL_NOTE, principal);
  session.setNote(Constants.SESS_USERNAME_NOTE, user);
  session.setNote(Constants.SESS_PASSWORD_NOTE, pass);
  auth.doLogin(request, response, principal);
  return true;
}



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r377486 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

2006-02-13 Thread Peter Rossbach

Is that correct that you use now at McastService the same constant?

Before it was start(1) and start(2)

Peter
[EMAIL PROTECTED]



Am 13.02.2006 um 22:04 schrieb [EMAIL PROTECTED]:


Author: fhanik
Date: Mon Feb 13 13:04:20 2006
New Revision: 377486

URL: http://svn.apache.org/viewcvs?rev=377486&view=rev
Log:
Use constants instead of hard coding values

Modified:
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java


Modified: tomcat/container/tc5.5.x/modules/cluster/src/share/org/ 
apache/catalina/cluster/mcast/McastService.java
URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/ 
cluster/src/share/org/apache/catalina/cluster/mcast/ 
McastService.java?rev=377486&r1=377485&r2=377486&view=diff
== 

--- tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java (original)
+++ tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java Mon Feb 13 13:04:20 2006

@@ -257,8 +257,8 @@
  * @throws java.lang.Exception if a IO error occurs
  */
 public void start() throws java.lang.Exception {
-start(1);
-start(2);
+start(MembershipService.MBR_RX);
+start(MembershipService.MBR_RX);
 registerMBean();
 }




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r377486 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/mcast/McastService.java

2006-02-13 Thread Peter Rossbach

Ohh,

I see you have later correct this past bug. Thanks!

Are your current big changes not a very high risk to break the  
cluster functionaliy again?
Why we not going inside a branch or a cluster2 module? Currently a  
lot of user work very successfully with the tomcat 5.5.15 cluster. It  
was my fault last year to changes to quick a lot.


Regards
Peter
[EMAIL PROTECTED]



Am 14.02.2006 um 07:37 schrieb Peter Rossbach:


Is that correct that you use now at McastService the same constant?

Before it was start(1) and start(2)

Peter
[EMAIL PROTECTED]



Am 13.02.2006 um 22:04 schrieb [EMAIL PROTECTED]:


Author: fhanik
Date: Mon Feb 13 13:04:20 2006
New Revision: 377486

URL: http://svn.apache.org/viewcvs?rev=377486&view=rev
Log:
Use constants instead of hard coding values

Modified:
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java


Modified: tomcat/container/tc5.5.x/modules/cluster/src/share/org/ 
apache/catalina/cluster/mcast/McastService.java
URL: http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/ 
modules/cluster/src/share/org/apache/catalina/cluster/mcast/ 
McastService.java?rev=377486&r1=377485&r2=377486&view=diff
= 
=
--- tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java (original)
+++ tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/ 
catalina/cluster/mcast/McastService.java Mon Feb 13 13:04:20 2006

@@ -257,8 +257,8 @@
  * @throws java.lang.Exception if a IO error occurs
  */
 public void start() throws java.lang.Exception {
-start(1);
-start(2);
+start(MembershipService.MBR_RX);
+start(MembershipService.MBR_RX);
 registerMBean();
 }




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: problem building 5.5.15

2006-02-13 Thread Mladen Turk

Eric Lenio wrote:

All -

Apologies in advance if this should go to tomcat-users but I'm
suspecting a problem with the way the source code is being distributed
so I'm starting here.

I downloaded the source file for 5.5.15 and built it.  After installing
it I ran bin/version.sh which said I had version 5.5.0.0.  Not what I
was expecting.



You will need to edit the build/build.properties.default
and adjust the version numbers to preferred version.

It's up to RM to adjust them before releasing or building.
We don't have actual version number inside the SVN, although
we might add some sort of


in the build.xml that would contain only version flags:

# - Vesion Control Flags -
version.major=5
version.minor=5
version.build=1
version.patch=16
#Set the pretty version name
version=5.5.16-dev


Since that still implies that RM will still have to
edit that file before releasing, you might as well create
a build.properties file with the upper content.

The easiest thing would be to have a separate version
property file updated regularly upon releases.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]