svn commit: r1832587 - in /tomcat/tc8.0.x/trunk: java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java webapps/docs/changelog.xml

2018-05-31 Thread kfujino 
Author: kfujino
Date: Thu May 31 08:29:07 2018
New Revision: 1832587

URL: http://svn.apache.org/viewvc?rev=1832587=rev
Log:
When decoding of path parameter failed, make sure to throw DecodeException 
instead of throwing ArrayIndexOutOfBoundsException.

Modified:

tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java?rev=1832587=1832586=1832587=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
 Thu May 31 08:29:07 2018
@@ -645,6 +645,7 @@ public class PojoMethodMapping {
 "pojoMethodMapping.decodePathParamFail",
 valueString, pathParam.getType()), e);
 params = new Object[] { de };
+break;
 }
 params[entry.getKey().intValue()] = value;
 }

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1832587=1832586=1832587=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Thu May 31 08:29:07 2018
@@ -159,6 +159,15 @@
   
 
   
+  
+
+  
+When decoding of path parameter failed, make sure to throw
+DecodeException instead of throwing
+ArrayIndexOutOfBoundsException. (kfujino)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62419] Avoid CORS Origin echoing by default

2018-05-31 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62419

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Mark Thomas  ---
https://markmail.org/message/sv2kr463zhummdkd
http://tomcat.apache.org/security-8.html#Fixed_in_Apache_Tomcat_8.5.32

Reviewing r1831728, the docs needs to be updated to reflect those changes. I'll
get that done today.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832585 - in /tomcat/trunk: java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java webapps/docs/changelog.xml

2018-05-31 Thread kfujino 
Author: kfujino
Date: Thu May 31 08:24:15 2018
New Revision: 1832585

URL: http://svn.apache.org/viewvc?rev=1832585=rev
Log:
When decoding of path parameter failed, make sure to throw DecodeException 
instead of throwing ArrayIndexOutOfBoundsException.

Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java?rev=1832585=1832584=1832585=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java 
Thu May 31 08:24:15 2018
@@ -645,6 +645,7 @@ public class PojoMethodMapping {
 "pojoMethodMapping.decodePathParamFail",
 valueString, pathParam.getType()), e);
 params = new Object[] { de };
+break;
 }
 params[entry.getKey().intValue()] = value;
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1832585=1832584=1832585=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu May 31 08:24:15 2018
@@ -217,6 +217,11 @@
   
 Use NIO2 API for websockets writes. (remm)
   
+  
+When decoding of path parameter failed, make sure to throw
+DecodeException instead of throwing
+ArrayIndexOutOfBoundsException. (kfujino)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832586 - in /tomcat/tc8.5.x/trunk: java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java webapps/docs/changelog.xml

2018-05-31 Thread kfujino 
Author: kfujino
Date: Thu May 31 08:26:43 2018
New Revision: 1832586

URL: http://svn.apache.org/viewvc?rev=1832586=rev
Log:
When decoding of path parameter failed, make sure to throw DecodeException 
instead of throwing ArrayIndexOutOfBoundsException.

Modified:

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java?rev=1832586=1832585=1832586=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
 Thu May 31 08:26:43 2018
@@ -645,6 +645,7 @@ public class PojoMethodMapping {
 "pojoMethodMapping.decodePathParamFail",
 valueString, pathParam.getType()), e);
 params = new Object[] { de };
+break;
 }
 params[entry.getKey().intValue()] = value;
 }

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1832586=1832585=1832586=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Thu May 31 08:26:43 2018
@@ -175,6 +175,15 @@
   
 
   
+  
+
+  
+When decoding of path parameter failed, make sure to throw
+DecodeException instead of throwing
+ArrayIndexOutOfBoundsException. (kfujino)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832589 - in /tomcat/tc7.0.x/trunk: java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java webapps/docs/changelog.xml

2018-05-31 Thread kfujino 
Author: kfujino
Date: Thu May 31 08:30:47 2018
New Revision: 1832589

URL: http://svn.apache.org/viewvc?rev=1832589=rev
Log:
When decoding of path parameter failed, make sure to throw DecodeException 
instead of throwing ArrayIndexOutOfBoundsException.

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java?rev=1832589=1832588=1832589=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java
 Thu May 31 08:30:47 2018
@@ -645,6 +645,7 @@ public class PojoMethodMapping {
 "pojoMethodMapping.decodePathParamFail",
 valueString, pathParam.getType()), e);
 params = new Object[] { de };
+break;
 }
 params[entry.getKey().intValue()] = value;
 }

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1832589=1832588=1832589=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu May 31 08:30:47 2018
@@ -119,6 +119,15 @@
   
 
   
+  
+
+  
+When decoding of path parameter failed, make sure to throw
+DecodeException instead of throwing
+ArrayIndexOutOfBoundsException. (kfujino)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Created] (MTOMCAT-314) Maven Package creating a issue on spark submit

2018-05-31 Thread GOPAL (JIRA) 
GOPAL created MTOMCAT-314:
-

 Summary: Maven Package creating a issue on spark submit
 Key: MTOMCAT-314
 URL: https://issues.apache.org/jira/browse/MTOMCAT-314
 Project: Apache Tomcat Maven Plugin
  Issue Type: Question
Reporter: GOPAL
 Attachments: exceptionscala.PNG

I am using IntelliJ and build a spark and scala application, From IntelliJ am 
able to build and execute the application without issue,

I did Maven compile and then package to get single Shaded Jar File. 

Using  spark-submit am executing this shaded-jar file ,. But am getting "Unable 
to resolve class Dependency Exception,

Can someone please look into this , This is am facing from last one month



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62420] New: Documents

2018-05-31 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62420

Bug ID: 62420
   Summary: Documents
   Product: Tomcat Native
   Version: unspecified
  Hardware: Other
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Documentation
  Assignee: dev@tomcat.apache.org
  Reporter: melixan...@gmail.com
  Target Milestone: ---

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62419] Avoid CORS Origin echoing by default

2018-05-31 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62419

--- Comment #2 from Ralf Hauser  ---
To easily test whether you are affected

  curl -vsLH "Origin: http://evil.com; https://yourdomain.tld/ 2>&1  | grep -i
access-control

If you see "evil", then you are, if you see "*" you are not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832602 - /tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties

2018-05-31 Thread remm 
Author: remm
Date: Thu May 31 12:48:48 2018
New Revision: 1832602

URL: http://svn.apache.org/viewvc?rev=1832602=rev
Log:
Fix error message typo.

Modified:
tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties

Modified: tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties?rev=1832602=1832601=1832602=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties Thu May 
31 12:48:48 2018
@@ -81,7 +81,7 @@ stream.header.connection=Connection [{0}
 stream.header.contentLength=Connection [{0}], Stream [{1}], The content length 
header value [{2}] does not agree with the size of the data received [{3}]
 stream.header.debug=Connection [{0}], Stream [{1}], HTTP header [{2}], Value 
[{3}]
 stream.header.duplicate=Connection [{0}], Stream [{1}], received multiple 
[{3}] headers
-stream.header.invalid=Connection [{0}], Stream [{1}], The header [{2}] 
contained invalid date [{3}]
+stream.header.invalid=Connection [{0}], Stream [{1}], The header [{2}] 
contained invalid value [{3}]
 stream.header.noPath=Connection [{0}], Stream [{1}], The [:path] pseudo header 
was empty
 stream.header.required=Connection [{0}], Stream [{1}], One or more required 
headers was missing
 stream.header.te=Connection [{0}], Stream [{1}], HTTP header [te] is not 
permitted to have the value [{2}] in an HTTP/2 request



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832595 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/CorsFilter.java webapps/docs/config/filter.xml

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 09:45:40 2018
New Revision: 1832595

URL: http://svn.apache.org/viewvc?rev=1832595=rev
Log:
Update docs after changes for CVE-2018-8014

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/CorsFilter.java
tomcat/tc7.0.x/trunk/webapps/docs/config/filter.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May 31 09:45:40 2018
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281

svn commit: r1832594 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/CorsFilter.java webapps/docs/config/filter.xml

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 09:45:13 2018
New Revision: 1832594

URL: http://svn.apache.org/viewvc?rev=1832594=rev
Log:
Update docs after changes for CVE-2018-8014

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/filters/CorsFilter.java
tomcat/tc8.0.x/trunk/webapps/docs/config/filter.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May 31 09:45:13 2018
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1779898,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207,1822186,1823164,1823497,1824960,1826872-1826873,1827862,1829310,1829777,1829796,1829935,1830215,1830991,1831042,1831557,1831569,1832269,1832271
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1

svn commit: r1832593 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/filters/CorsFilter.java webapps/docs/config/filter.xml

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 09:44:54 2018
New Revision: 1832593

URL: http://svn.apache.org/viewvc?rev=1832593=rev
Log:
Update docs after changes for CVE-2018-8014

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/filters/CorsFilter.java
tomcat/tc8.5.x/trunk/webapps/docs/config/filter.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May 31 09:44:54 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205

[Git migration] Developer process

2018-05-31 Thread Mark Thomas 
Hi,

The next issue to resolve for the Git migration is developer process.

Note that this does not cover branch names, merge strategy etc. This is
issue is about the options available for developers to organise their
local development environment. The key question is how to efficiently
switch between trunk, 8.5.x and 7.0.x.

To some extent this will be personal preference. However, it would be
useful to have some recommendations to give folks a starting point.

Options discussed previously include:
- multiple clones
- git worktree

We may want to consider documenting something and/or linking to some
existing guides.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed

2018-05-31 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk has an issue affecting its community integration.
This issue affects 4 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk :  Tomcat 9.x, a web server implementing the Java Servlet 
4.0,
...
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on junit exists, no need to add for property junit.jar.
 -INFO- Made directory [/srv/gump/public/workspace/tomcat-trunk/tomcat-deps]
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html
Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build)
Work ended in a state of : Failed
Elapsed: 20 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar:/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar:/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
-
build-manifests:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/manifests
 [copy] Copying 19 files to 
/srv/gump/public/workspace/tomcat-trunk/output/manifests

setup-bnd:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar

setproxy:

downloadfile:
  [get] Getting: 
https://repo.maven.apache.org/maven2/biz/aQute/bnd/biz.aQute.bnd/4.0.0/biz.aQute.bnd-4.0.0.jar
  [get] To: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/download-798041586.tmp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bnd-4.0.0
 [move] Moving 1 file to 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bnd-4.0.0

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar

setproxy:

downloadfile:
  [get] Getting: 
https://repo.maven.apache.org/maven2/biz/aQute/bnd/biz.aQute.bndlib/4.0.0/biz.aQute.bndlib-4.0.0.jar
  [get] To: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/download-1351560366.tmp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bndlib-4.0.0
 [move] Moving 1 file to 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bndlib-4.0.0
  [taskdef] Could not load definitions from resource 
aQute/bnd/ant/taskdef.properties. It could not be found.

build-bnd:
[mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/bnd
 [copy] Copying 24 files to 
/srv/gump/public/workspace/tomcat-trunk/output/bnd

package:
  [jar] Building jar: 
/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar

add-osgi:
 [echo] add-osgi 
/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar 
true

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:748: The following

svn commit: r1832592 - in /tomcat/trunk: java/org/apache/catalina/filters/CorsFilter.java webapps/docs/config/filter.xml

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 09:44:21 2018
New Revision: 1832592

URL: http://svn.apache.org/viewvc?rev=1832592=rev
Log:
Update docs after changes for CVE-2018-8014

Modified:
tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java
tomcat/trunk/webapps/docs/config/filter.xml

Modified: tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java?rev=1832592=1832591=1832592=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java Thu May 31 
09:44:21 2018
@@ -1060,7 +1060,7 @@ public class CorsFilter extends GenericF
 
 //  Configuration Defaults
 /**
- * By default, all origins are allowed to make requests.
+ * By default, no origins are allowed to make requests.
  */
 public static final String DEFAULT_ALLOWED_ORIGINS = "";
 
@@ -1076,7 +1076,7 @@ public class CorsFilter extends GenericF
 public static final String DEFAULT_PREFLIGHT_MAXAGE = "1800";
 
 /**
- * By default, support credentials is turned on.
+ * By default, support credentials is disabled.
  */
 public static final String DEFAULT_SUPPORTS_CREDENTIALS = "false";
 

Modified: tomcat/trunk/webapps/docs/config/filter.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/filter.xml?rev=1832592=1832591=1832592=diff
==
--- tomcat/trunk/webapps/docs/config/filter.xml (original)
+++ tomcat/trunk/webapps/docs/config/filter.xml Thu May 31 09:44:21 2018
@@ -130,7 +130,7 @@
 specified to enable access to resource from any origin. Otherwise, a
 whitelist of comma separated origins can be provided. Eg: 
 http://www.w3.org, https://www.apache.org.
-Defaults: * (Any origin is allowed to
+Defaults: The empty String. (No origin is allowed to
 access the resource).
   
   
@@ -171,7 +171,7 @@
 Access-Control-Allow-Credentials header in a pre-flight
 response. It helps browser determine whether or not an actual request
 can be made using credentials. Defaults:
-true
+false
   
   
 A flag to control if CORS specific attributes should be added to



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832596 - in /tomcat/trunk/webapps/docs: changelog.xml config/http.xml

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 10:09:10 2018
New Revision: 1832596

URL: http://svn.apache.org/viewvc?rev=1832596=rev
Log:
Correct the documentation for the allowHostHeaderMismatch attribute of the 
standard HTTP Connector implementations.

Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/http.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1832596=1832595=1832596=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu May 31 10:09:10 2018
@@ -231,6 +231,10 @@
 minSpareThreads in the documentation web application.
 (markt)
   
+  
+Correct the documentation for the allowHostHeaderMismatch
+attribute of the standard HTTP Connector implementations. (markt)
+  
 
   
   

Modified: tomcat/trunk/webapps/docs/config/http.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http.xml?rev=1832596=1832595=1832596=diff
==
--- tomcat/trunk/webapps/docs/config/http.xml (original)
+++ tomcat/trunk/webapps/docs/config/http.xml Thu May 31 10:09:10 2018
@@ -326,8 +326,8 @@
 
   By default Tomcat will reject requests that specify a host in the
   request line but specify a different host in the host header. This
-  chekc can be disabled by setting this attribute to false. If
-  not specified, the default is true.
+  check can be disabled by setting this attribute to true. If
+  not specified, the default is false.
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832597 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/http.xml

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 10:12:22 2018
New Revision: 1832597

URL: http://svn.apache.org/viewvc?rev=1832597=rev
Log:
Correct the documentation for the allowHostHeaderMismatch attribute of the 
standard HTTP Connector implementations.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/http.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May 31 10:12:22 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205

Thoughts on suggestions for new contributors

2018-05-31 Thread Mark Thomas 
Hi,

It can often be difficult to identify suitable tasks for new
contributors who want to make a contribution but have no particular itch
to scratch of their own. In the past, my thoughts have turned to the
code coverage and a response along the lines of "Pick a class / package
with low coverage and write some tests to increase it.".

I have generally held back from those sorts of suggestions because they
struck me as more of a 'make work' task.

As you may have noticed I have been working on the HttpParser unit tests
over the last few days. This was prompted, as a result of the recent
fqdn parsing issues, to ensure that the unit tests were covering all of
the edge cases. While the fqdn parsing was fine, working on the unit
tests to expand code coverage uncovered three related bugs in the
handling of some error cases in the HTTP header parsing.

In light of the above experience, I now think suggesting improving the
unit test coverage is a great place to suggest for a contributor to get
started when they don;t have their own itch to scratch.

Thoughts?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed

2018-05-31 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk has an issue affecting its community integration.
This issue affects 4 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk :  Tomcat 9.x, a web server implementing the Java Servlet 
4.0,
...
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on junit exists, no need to add for property junit.jar.
 -INFO- Made directory [/srv/gump/public/workspace/tomcat-trunk/tomcat-deps]
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html
Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build)
Work ended in a state of : Failed
Elapsed: 18 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar:/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar:/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
-
build-manifests:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/manifests
 [copy] Copying 19 files to 
/srv/gump/public/workspace/tomcat-trunk/output/manifests

setup-bnd:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar

setproxy:

downloadfile:
  [get] Getting: 
https://repo.maven.apache.org/maven2/biz/aQute/bnd/biz.aQute.bnd/4.0.0/biz.aQute.bnd-4.0.0.jar
  [get] To: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/download-1637164288.tmp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bnd-4.0.0
 [move] Moving 1 file to 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bnd-4.0.0

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar

setproxy:

downloadfile:
  [get] Getting: 
https://repo.maven.apache.org/maven2/biz/aQute/bnd/biz.aQute.bndlib/4.0.0/biz.aQute.bndlib-4.0.0.jar
  [get] To: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/download-197173004.tmp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bndlib-4.0.0
 [move] Moving 1 file to 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bndlib-4.0.0
  [taskdef] Could not load definitions from resource 
aQute/bnd/ant/taskdef.properties. It could not be found.

build-bnd:
[mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/bnd
 [copy] Copying 24 files to 
/srv/gump/public/workspace/tomcat-trunk/output/bnd

package:
  [jar] Building jar: 
/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar

add-osgi:
 [echo] add-osgi 
/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar 
true

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:748: The following

[Bug 62273] Add support for alternate URL specification

2018-05-31 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62273

--- Comment #18 from Trevor Robinson  ---
(In reply to Christopher Schultz from comment #15)
> Um... this should UN-BREAK things, not break things. I don't think you want
> to wait until Tomcat 10 for your brackets to start working again, do you?

Hmm, I think I misinterpreted your comment #13. So if I have this right, this
patch implements an option called 'USE_URL_LIVING_STANDARD' that allows the
previous parsing behavior to continue, right? Does it default to true? From my
perspective, we didn't change anything about our Tomcat setup, it just suddenly
started rejecting our URLs that included square brackets when we upgraded from
8.5.29 to 8.5.31.

If it wasn't your intention to change the behavior, then I'm sorry for my
initial comment's strong reaction.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Thoughts on suggestions for new contributors

2018-05-31 Thread Igal Sapir 

On 5/31/2018 3:28 AM, Mark Thomas wrote:



As you may have noticed I have been working on the HttpParser unit tests
over the last few days. This was prompted, as a result of the recent
fqdn parsing issues, to ensure that the unit tests were covering all of
the edge cases. While the fqdn parsing was fine, working on the unit
tests to expand code coverage uncovered three related bugs in the
handling of some error cases in the HTTP header parsing.

In light of the above experience, I now think suggesting improving the
unit test coverage is a great place to suggest for a contributor to get
started when they don;t have their own itch to scratch.

Thoughts?
I, for one, would be very happy to work on things like that as it will 
allow me to get familiarized with the code better.


I will look at your recent unit tests for HttpParser and other classes, 
but are there any written guidelines regarding test cases?



Igal




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Git migration] Developer process

2018-05-31 Thread Igal Sapir 

On 5/31/2018 3:00 AM, Mark Thomas wrote:

Hi,

The next issue to resolve for the Git migration is developer process.

Note that this does not cover branch names, merge strategy etc. This is
issue is about the options available for developers to organise their
local development environment. The key question is how to efficiently
switch between trunk, 8.5.x and 7.0.x.

To some extent this will be personal preference. However, it would be
useful to have some recommendations to give folks a starting point.

Options discussed previously include:
- multiple clones
- git worktree
According to this blog post [1] Git Worktrees are a better solution.  It 
looks like Worktrees were added in order to address the shortfalls of 
maintaining multiple clones.


There is a warning, however, about using Worktrees on repos that contain 
submodules [2], and I don't know if that applies to the Tomcat repos or 
not, so that's something to look out for.


Igal

[1] 
https://spin.atomicobject.com/2016/06/26/parallelize-development-git-worktrees/
[2] 
https://blog.github.com/2015-07-29-git-2-5-including-multiple-worktrees-and-triangular-workflows/




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62423] New: Wrong Attribute Name for Certificate Revocation Lists

2018-05-31 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62423

Bug ID: 62423
   Summary: Wrong Attribute Name for Certificate Revocation Lists
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Documentation
  Assignee: dev@tomcat.apache.org
  Reporter: lin.m...@live.com
  Target Milestone: 

The attribute name for "Certificate Revocation Lists" should be
"certificateRevocationListFile", not "certificateRevocationFile".

Log:
[SetPropertiesRule]{Server/Service/Connector/SSLHostConfig} Setting property
'certificateRevocationFile' to 'path\ca.crl' did not find a matching property.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62423] Wrong Attribute Name for Certificate Revocation Lists

2018-05-31 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=62423

Lin Xiaonan  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Lin Xiaonan  ---
https://tomcat.apache.org/tomcat-8.5-doc/config/http.html#SSL_Support_-_SSLHostConfig

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed

2018-05-31 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk has an issue affecting its community integration.
This issue affects 4 projects,
 and has been outstanding for 3 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk :  Tomcat 9.x, a web server implementing the Java Servlet 
4.0,
...
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -ERROR- No such project [bnd] for property.
 -ERROR- No such project [bnd] for property.
 -ERROR- Cannot resolve output/outputpath of *unknown* [bnd]
 -ERROR- Unhandled Property: bndlib.jar on: Ant on Project:tomcat-trunk
 -ERROR- Cannot resolve output/outputpath of *unknown* [bnd]
 -ERROR- Unhandled Property: bnd.jar on: Ant on Project:tomcat-trunk
 -DEBUG- Dependency on junit exists, no need to add for property junit.jar.
 -INFO- Made directory [/srv/gump/public/workspace/tomcat-trunk/tomcat-deps]
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html
Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build)
Work ended in a state of : Failed
Elapsed: 20 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=*Unset* 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 -Dbnd.jar=*Unset* 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar:/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar:/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
-
[javac] Creating empty 
/srv/gump/public/workspace/tomcat-trunk/output/classes/org/apache/tomcat/websocket/server/package-info.class
[javac] Creating empty 
/srv/gump/public/workspace/tomcat-trunk/output/classes/org/apache/tomcat/util/descriptor/tld/package-info.class
 [copy] Copying 224 files to 
/srv/gump/public/workspace/tomcat-trunk/output/classes

build-manifests:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/manifests
 [copy] Copying 19 files to 
/srv/gump/public/workspace/tomcat-trunk/output/manifests

setup-bnd:

testexist:
 [echo] Testing  for *Unset*

setproxy:

downloadfile:
  [get] Getting: 
https://repo.maven.apache.org/maven2/biz/aQute/bnd/biz.aQute.bnd/4.0.0/biz.aQute.bnd-4.0.0.jar
  [get] To: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/download-1593587456.tmp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs/bnd-4.0.0
 [move] Moving 1 file to /srv/gump/public/workspace/tomcat-trunk

testexist:
 [echo] Testing  for *Unset*

setproxy:

downloadfile:
  [taskdef] Could not load definitions from resource 
aQute/bnd/ant/taskdef.properties. It could not be found.

build-bnd:
[mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/bnd
 [copy] Copying 24 files to 
/srv/gump/public/workspace/tomcat-trunk/output/bnd

package:
  [jar] Building jar: 
/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar

add-osgi:
 [echo]

REMINDER: Apache EU Roadshow 2018 in Berlin is less than 2 weeks away!

2018-05-31 Thread sharan 

Hello Apache Supporters and Enthusiasts

This is a reminder that our Apache EU Roadshow in Berlin is less than 
two weeks away and we need your help to spread the word. Please let your 
work colleagues, friends and anyone interested in any attending know 
about our Apache EU Roadshow event.


We have a great schedule including tracks on Apache Tomcat, Apache Http 
Server, Microservices, Internet of Things (IoT) and Cloud Technologies. 
You can find more details at the link below:


https://s.apache.org/0hnG

Ticket prices will be going up on 8^th June 2018, so please make sure 
that you register soon if you want to beat the price increase. 
https://foss-backstage.de/tickets


Remember that registering for the Apache EU Roadshow also gives you 
access to FOSS Backstage so you can attend any talks and workshops from 
both conferences. And don’t forget that our Apache Lounge will be open 
throughout the whole conference as a place to meet up, hack and relax.


We look forward to seeing you in Berlin!

Thanks
Sharan Foga,  VP Apache Community Development

http://apachecon.com/
@apachecon

PLEASE NOTE: You are receiving this message because you are subscribed 
to a user@ or dev@ list of one or more Apache Software Foundation projects.

svn commit: r1832619 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 14:11:27 2018
New Revision: 1832619

URL: http://svn.apache.org/viewvc?rev=1832619=rev
Log:
Better name for test servlet

Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml

tomcat/trunk/test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1832619=1832618=1832619=diff
==
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Thu May 31 14:11:27 
2018
@@ -1677,7 +1677,7 @@
   
   
 
-
+
 
 
   

Modified: 
tomcat/trunk/test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java?rev=1832619=1832618=1832619=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java 
(original)
+++ 
tomcat/trunk/test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java 
Thu May 31 14:11:27 2018
@@ -51,9 +51,9 @@ public class TestStuckThreadDetectionVal
 @Test
 public void testDetection() throws Exception {
 // second, we test the actual effect of the flag on the startup
-StuckingServlet stuckingServlet = new StuckingServlet(8000L);
+StickingServlet stickingServlet = new StickingServlet(8000L);
 Wrapper servlet = Tomcat.addServlet(context, "myservlet",
-stuckingServlet);
+stickingServlet);
 servlet.addMapping("/myservlet");
 
 StuckThreadDetectionValve valve = new StuckThreadDetectionValve();
@@ -89,17 +89,17 @@ public class TestStuckThreadDetectionVal
 // check that we did not reach the join timeout
 Assert.assertFalse(asyncThread.isAlive());
 }
-Assert.assertFalse(stuckingServlet.wasInterrupted);
+Assert.assertFalse(stickingServlet.wasInterrupted);
 Assert.assertTrue(result.toString().startsWith("OK"));
 }
 
 @Test
 public void testInterruption() throws Exception {
 // second, we test the actual effect of the flag on the startup
-StuckingServlet stuckingServlet = new StuckingServlet(
+StickingServlet stickingServlet = new StickingServlet(
 TimeUnit.SECONDS.toMillis(20L));
 Wrapper servlet = Tomcat.addServlet(context, "myservlet",
-stuckingServlet);
+stickingServlet);
 servlet.addMapping("/myservlet");
 
 StuckThreadDetectionValve valve = new StuckThreadDetectionValve();
@@ -134,18 +134,18 @@ public class TestStuckThreadDetectionVal
 // check that we did not reach the join timeout
 Assert.assertFalse(asyncThread.isAlive());
 }
-Assert.assertTrue(stuckingServlet.wasInterrupted);
+Assert.assertTrue(stickingServlet.wasInterrupted);
 Assert.assertEquals(0, valve.getStuckThreadIds().length);
 Assert.assertTrue(result.toString().startsWith("OK"));
 }
 
-private static class StuckingServlet extends HttpServlet {
+private static class StickingServlet extends HttpServlet {
 
 private static final long serialVersionUID = 1L;
 private final long delay;
 boolean wasInterrupted = false;
 
-StuckingServlet(long delay) {
+StickingServlet(long delay) {
 this.delay = delay;
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1832620 - in /tomcat/tc8.5.x/trunk: ./ res/findbugs/filter-false-positives.xml test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 14:13:43 2018
New Revision: 1832620

URL: http://svn.apache.org/viewvc?rev=1832620=rev
Log:
Better name for test servlet

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml

tomcat/tc8.5.x/trunk/test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May 31 14:13:43 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205

Re: Tagging 9.0.x and 8.5.x

2018-05-31 Thread Rémy Maucherat 
On Thu, May 31, 2018 at 3:20 PM Mark Thomas  wrote:

> Hi all,
>
> June is almost upon us so I'm thinking about the next release round.
>
> I've got a couple of small tasks on my personal TODO list and there are
> one or two BZ issues that could be resolved. I plan to complete these
> tasks and then tag. Depending how things go, I currently anticipate
> tagging late this week or early next.
>

+1

Rémy

svn commit: r1832621 - in /tomcat/tc7.0.x/trunk: ./ res/findbugs/filter-false-positives.xml test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java

2018-05-31 Thread markt 
Author: markt
Date: Thu May 31 14:16:28 2018
New Revision: 1832621

URL: http://svn.apache.org/viewvc?rev=1832621=rev
Log:
Better name for test servlet

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml

tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May 31 14:16:28 2018
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281

svn commit: r1832603 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/LocalStrings.properties

2018-05-31 Thread remm 
Author: remm
Date: Thu May 31 12:50:33 2018
New Revision: 1832603

URL: http://svn.apache.org/viewvc?rev=1832603=rev
Log:
Fix error message typo

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/LocalStrings.properties

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May 31 12:50:33 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed

2018-05-31 Thread Mark Thomas 
On 31/05/18 10:07, Bill Barker wrote:



> /srv/gump/public/workspace/tomcat-trunk/build.xml:3037: Problem: failed to 
> create task or type bndwrap

I have made an attempt to fix this. I based my fix on how the Eclipse
JDT jar is referenced. I think I did it correctly but we'll need to wait
until the next Gump run to find out.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tagging 9.0.x and 8.5.x

2018-05-31 Thread Mark Thomas 
Hi all,

June is almost upon us so I'm thinking about the next release round.

I've got a couple of small tasks on my personal TODO list and there are
one or two BZ issues that could be resolved. I plan to complete these
tasks and then tag. Depending how things go, I currently anticipate
tagging late this week or early next.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org