Bug report for Tomcat 9 [2019/09/08]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |57505|New|Enh|2015-01-27|Add integration tests for JspC| |57661|New|Enh|2015-03-04|Delay sending of 100 continue response until appli| |58242|New|Enh|2015-08-13|Scanning jars in classpath to get annotations in p| |58530|New|Enh|2015-10-23|Proposal for new Manager HTML GUI | |58548|New|Enh|2015-10-26|support certifcate transparency | |58859|New|Enh|2016-01-14|Allow to limit charsets / encodings supported by T| |59203|New|Enh|2016-03-21|Try to call Thread.interrupt before calling Thread| |59344|Ver|Enh|2016-04-18|PEM file support for JSSE | |59750|New|Enh|2016-06-24|Amend "authenticate" method with context by means | |60997|New|Enh|2017-04-17|Enhance SemaphoreValve to support denied status an| |61971|New|Enh|2018-01-06|documentation for using tomcat with systemd | |62048|New|Enh|2018-01-25|Missing logout function in Manager and Host-Manage| |62072|New|Enh|2018-02-01|Add support for request compression | |62140|New|Enh|2018-02-27|catalina.sh should document the verbs it accepts a| |62312|New|Enh|2018-04-18|Add Proxy Authentication support to websocket clie| |62405|New|Enh|2018-05-23|Add Rereadable Request Filter | |62488|New|Enh|2018-06-25|Obtain dependencies from Maven Central where possi| |62611|New|Enh|2018-08-09|Compress log files after rotation | |62695|Inf|Nor|2018-09-07|Provide sha512 checksums for Tomcat releases publi| |62723|New|Enh|2018-09-14|Clarify "channelSendOptions" value in cluster docu| |62773|New|Enh|2018-09-28|Change DeltaManager to handle session deserializat| |62814|New|Enh|2018-10-10|Use readable names for cluster channel/map options| |62843|New|Enh|2018-10-22|Tomcat Russian localization | |62920|New|Enh|2018-11-17|Maven Plugin For Tomcat 9.0.x | |62964|New|Enh|2018-11-29|Add RFC7807 conformant Problem Details for HTTP st| |63023|New|Enh|2018-12-20|Provide a way to load SecurityProviders into the s| |63049|New|Enh|2018-12-31|Add support in system properties override from com| |63191|Inf|Nor|2019-02-20|RemoteEndpoint.Async#sendText(String, SendHandler)| |63237|New|Enh|2019-03-06|Consider processing mbeans-descriptors.xml at comp| |63362|New|Enh|2019-04-18|GlobalRequestProcessor statistics in MBean does no| |63389|New|Enh|2019-04-27|Enable Servlet Warmup for Containerization| |63493|New|Enh|2019-06-10|enhancement - add JMX counters to monitor authenti| |63505|New|Enh|2019-06-14|enhancement - support of stored procedures for Dat| |63545|New|Enh|2019-07-06|enhancement - add a new pattern attribute for logg| |63682|New|Nor|2019-08-22|Async servlet over HTTP/2 non-blocking write hangi| |63691|New|Nor|2019-08-24|Add a no-op JarScanner| +-+---+---+--+--+ | Total 36 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2019/09/08]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration| |62626|New|Nor|2018-08-15|Tomcat 9.0.10 APR/Native crashes | |62911|New|Enh|2018-11-15|Add support for proxying ocsp requests via ProxyH| |63199|Inf|Nor|2019-02-22|sslsocket handshake JVM crash | |63405|New|Nor|2019-05-06|Tomcat 7.0.91.0 EXCEPTION_ACCESS_VIOLATION - Probl| |63671|New|Nor|2019-08-19|libtcnative does not compile with OpenSSL < 1.1.0 | |63701|Inf|Maj|2019-08-27|SSL initialize hangs with OpenSSL 1.1.1 | +-+---+---+--+--+ | Total7 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2019/09/08]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|Return tomcat authenticated user back to mod_jk (A| |47750|New|Maj|2009-08-27|ISAPI: Loss of worker settings when changing via j| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |53883|Inf|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe on the p| |54621|New|Enh|2013-02-28|[PATCH] custom mod_jk availability checks | |56489|New|Enh|2014-05-05|Include a directory for configuration files | |56576|New|Enh|2014-05-29|Websocket support | |57402|New|Enh|2014-12-30|Provide correlation ID between mod_jk log and acce| |57403|New|Enh|2014-12-30|Persist configuration changes made via status work| |57407|New|Enh|2014-12-31|Make session_cookie, session_path and session_cook| |57790|New|Enh|2015-04-03|Check worker names for typos | |61476|New|Enh|2017-09-01|Allow reset of an individual worker stat value| |61621|New|Enh|2017-10-15|Content-Type is forced to lowercase when it goes t| |62093|New|Enh|2018-02-09|Allow use_server_errors to apply to specific statu| |63214|New|Nor|2019-02-27|Using JkAutoAlias, Filenames with Spaces Cannot be| +-+---+---+--+--+ | Total 20 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Modules [2019/09/08]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int| |54929|Inf|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang| |55078|New|Nor|2013-06-07|Configuring a DataSource Resource with dataSourceJ| |55662|New|Enh|2013-10-17|Add a way to set an instance of java.sql.Driver di| |56046|New|Enh|2014-01-21|org.apache.tomcat.jdbc.pool.XADataSource InitSQL p| |56088|New|Maj|2014-01-29|AbstractQueryReport$StatementProxy throws exceptio| |56310|Inf|Maj|2014-03-25|PooledConnection and XAConnection not handled corr| |56586|New|Nor|2014-06-02|initSQL should be committed if defaultAutoCommit =| |56775|New|Nor|2014-07-28|PoolCleanerTime schedule issue| |56779|New|Nor|2014-07-28|Allow multiple connection initialization statement| |56790|New|Nor|2014-07-29|Resizing pool.maxActive to a higher value at runti| |56798|New|Nor|2014-07-31|Idle eviction strategy could perform better (and i| |56804|New|Nor|2014-08-02|Use a default validationQueryTimeout other than "f| |56805|New|Nor|2014-08-02|datasource.getConnection() may be unnecessarily bl| |56837|New|Nor|2014-08-11|if validationQuery have error with timeBetweenEvic| |56970|New|Nor|2014-09-11|MaxActive vs. MaxTotal for commons-dbcp and tomcat| |56974|New|Nor|2014-09-12|jdbc-pool validation query defaultAutoCommit statu| |57460|New|Nor|2015-01-19|[DB2]Connection broken after few hours but not rem| |57729|New|Enh|2015-03-20|Add QueryExecutionReportInterceptor to log query e| |58489|Opn|Maj|2015-10-08|QueryStatsComparator throws IllegalArgumentExcepti| |59077|New|Nor|2016-02-26|DataSourceFactory creates a neutered data source | |59569|New|Nor|2016-05-18|isWrapperFor/unwrap implementations incorrect | |59879|New|Nor|2016-07-18|StatementCache interceptor returns ResultSet objec| |60195|New|Nor|2016-10-02|No javadoc in Maven Central | |60522|New|Nor|2016-12-27|An option for setting if the transaction should be| |60524|Inf|Nor|2016-12-28|NPE in SlowQueryReport in tomcat-jdbc-7.0.68 | |60645|New|Nor|2017-01-25|StatementFinalizer is not thread-safe | |61032|New|Nor|2017-04-24|min pool size is not being respected | |61103|New|Nor|2017-05-18|StatementCache potentially caching non-functional | |61302|New|Enh|2017-07-15|Refactoring of DataSourceProxy| |61303|New|Enh|2017-07-15|Refactoring of ConnectionPool | |62432|New|Nor|2018-06-06|Memory Leak in Statement Finalizer? | |62598|New|Enh|2018-08-04|support pool with multiple JDBC data sources | |62910|Inf|Nor|2018-11-15|tomcat-jdbc global pool transaction problem | |63612|Inf|Cri|2019-07-26|PooledConnection#connectUsingDriver, Thread.curren| |63705|New|Nor|2019-08-29|The tomcat pool doesn't register all connection th| +-+---+---+--+--+ | Total 41 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 8 [2019/09/08]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |55243|New|Enh|2013-07-11|Add special search string for nested roles| |55252|New|Enh|2013-07-12|Separate Ant and command-line wrappers for JspC | |55383|New|Enh|2013-08-07|Improve markup and design of Tomcat's HTML pages | |9|New|Enh|2013-09-14|UserDatabaseRealm enhacement: may use local JNDI | |55675|New|Enh|2013-10-18|Checking and handling invalid configuration option| |55788|New|Enh|2013-11-16|TagPlugins should key on tag QName rather than imp| |56166|New|Enh|2014-02-20|Suggestions for exception handling (avoid potentia| |56398|New|Enh|2014-04-11|Support Arquillian-based unit testing | |56399|New|Enh|2014-04-11|Re-factor request/response recycling so Coyote and| |56402|New|Enh|2014-04-11|Add support for HTTP Upgrade to AJP components| |56448|New|Enh|2014-04-23|Implement a robust solution for client initiated S| |56522|Opn|Enh|2014-05-14|jasper-el 8 does not comply to EL Spec 3.0 regardi| |56546|New|Enh|2014-05-19|Improve thread trace logging in WebappClassLoader.| |56713|New|Enh|2014-07-12|Limit time that incoming request waits while webap| |56890|Inf|Maj|2014-08-26|getRealPath returns null | |56966|New|Enh|2014-09-11|AccessLogValve's elapsed time has 15ms precision o| |57130|New|Enh|2014-10-22|Allow digest.sh to accept password from a file or | |57421|New|Enh|2015-01-07|Farming default directories | |57486|New|Enh|2015-01-23|Improve reuse of ProtectedFunctionMapper instances| |57701|New|Enh|2015-03-13|Implement "[Redeploy]" button for a web applicatio| |57830|New|Enh|2015-04-18|Add support for ProxyProtocol | |58052|Opn|Enh|2015-06-19|RewriteValve: Implement additional RewriteRule dir| |58072|New|Enh|2015-06-23|ECDH curve selection | |58577|New|Enh|2015-11-03|JMX Proxy Servlet can't handle overloaded methods | |58837|New|Enh|2016-01-12|support "X-Content-Security-Policy" a.k.a as "CSP"| |58935|Opn|Enh|2016-01-29|Re-deploy from war without deleting context | |59232|New|Enh|2016-03-24|Make the context name of an app available via JNDI| |59423|New|Enh|2016-05-03|amend "No LoginModules configured for ..." with hi| |59758|New|Enh|2016-06-27|Add http proxy username-password credentials suppo| |60281|Ver|Nor|2016-10-20|Pathname of uploaded WAR file should not be contai| |60721|Ver|Nor|2017-02-10|Unable to find key spec if more applications use b| |60781|New|Nor|2017-02-27|Access Log Valve does not escape the same as mod_l| |60849|New|Enh|2017-03-13|Tomcat NIO Connector not able to handle SSL renego| |61668|Ver|Min|2017-10-26|Possible NullPointerException in org.apache.coyote| |61877|New|Enh|2017-12-08|use web.xml from CATALINA_HOME by default | |61917|New|Enh|2017-12-19|AddDefaultCharsetFilter only supports text/* respo| |62150|New|Enh|2018-03-01|Behavior of relative paths with RequestDispatcher | |62214|New|Enh|2018-03-22|The "userSubtree=true" and "roleSubtree=true" in J| |62245|New|Enh|2018-04-02|[Documentation] Mention contextXsltFile in Default| |62912|New|Enh|2018-11-15|Tomcat adds a space character in the Content-Type | |63080|New|Enh|2019-01-16|Support rfc7239 Forwarded header | |63195|Inf|Enh|2019-02-21|Add easy way to test RemoteIpValve works properly | |63286|New|Enh|2019-03-25|Inconsistencies between AccessLogValve and mod_log| |63681|New|Enh|2019-08-21|Introduce RealmBase#authenticate(GSSName, GSSCrede| |63685|Inf|Maj|2019-08-22|WebappClassLoaderBase and StandardRoot reload clas| +-+---+---+--+--+ | Total 45 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 7 [2019/09/08]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |50944|Ver|Blk|2011-03-18|JSF: java.lang.NullPointerException at com.sun.fac| |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |55104|New|Enh|2013-06-16|Allow passing arguments with spaces to Commons Dae| |55470|New|Enh|2013-08-23|Help users for ClassNotFoundExceptions during star| |55477|New|Enh|2013-08-23|Add a solution to map an realm name to a security | |56148|New|Enh|2014-02-17|support (multiple) ocsp stapling | |56181|New|Enh|2014-02-23|RemoteIpValve & RemoteIpFilter: HttpServletRequest| |56300|New|Enh|2014-03-22|[Tribes] No useful examples, lack of documentation| |56438|New|Enh|2014-04-21|If jar scan does not find context config or TLD co| |56614|New|Enh|2014-06-12|Add a switch to ignore annotations detection on ta| |56787|New|Enh|2014-07-29|Simplified jndi name parsing | |57367|New|Enh|2014-12-18|If JAR scan experiences a stack overflow, give the| |57827|New|Enh|2015-04-17|Enable adding/removing of members via jmx in a sta| |57872|New|Enh|2015-04-29|Do not auto-switch session cookie to version=1 due| |57892|New|Enh|2015-05-05|Log once a warning if a symbolic link is ignored (| |60597|New|Enh|2017-01-17|Add ability to set cipher suites for websocket cli| |63167|New|Enh|2019-02-12|Network Requirements To Resolve No Members Active | |63625|New|Cri|2019-08-02|Unable to start Tomcat 7.0.96 (stop by 0xc005)| +-+---+---+--+--+ | Total 18 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Taglibs [2019/09/08]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | |57548|New|Min|2015-02-08|Auto-generate the value for org.apache.taglibs.sta| |57684|New|Min|2015-03-10|Version info should be taken from project version | |59359|New|Enh|2016-04-20|(Task) Extend validity period for signing KEY - be| |59668|New|Nor|2016-06-06|x:forEach retains the incorrect scope when used in| |61875|New|Nor|2017-12-08|Investigate whether Xalan can be removed | +-+---+---+--+--+ | Total 10 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63737] New: Compression may not work when there are multiple Accept-Encoding headers in the request
https://bz.apache.org/bugzilla/show_bug.cgi?id=63737 Bug ID: 63737 Summary: Compression may not work when there are multiple Accept-Encoding headers in the request Product: Tomcat 9 Version: 9.0.x Hardware: PC OS: Mac OS X 10.1 Status: NEW Severity: normal Priority: P2 Component: Connectors Assignee: dev@tomcat.apache.org Reporter: awilkin...@pivotal.io Target Milestone: - This was originally reported as a Spring Boot issue [1]. CompressionConfig only considers a single Accept-Encoding request header. When the request contains more than one such header, compression may not be used depending on which of the headers in considered. The problem also occurs with 8.5.x. [1] https://github.com/spring-projects/spring-boot/issues/18176 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63737] Compression may not work when there are multiple Accept-Encoding headers in the request
https://bz.apache.org/bugzilla/show_bug.cgi?id=63737 Andy Wilkinson changed: What|Removed |Added OS|Mac OS X 10.1 |All -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Fix various Javadoc warnings/errors with Java 9
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 09af10c Fix various Javadoc warnings/errors with Java 9
09af10c is described below
commit 09af10cc02fb10fc359fe20df58381bd4b79fde2
Author: Mark Thomas
AuthorDate: Sun Sep 8 12:24:15 2019 +0100
Fix various Javadoc warnings/errors with Java 9
Aligning with 8.5.x where posisble
---
java/org/apache/el/ValueExpressionImpl.java| 6 +-
java/org/apache/juli/logging/Log.java | 26 ++-
java/org/apache/naming/JndiPermission.java | 4 +-
.../naming/resources/DirContextURLConnection.java | 2 +-
.../apache/naming/resources/VirtualDirContext.java | 2 +-
.../tomcat/dbcp/jocl/JOCLContentHandler.java | 90 +++---
.../apache/tomcat/dbcp/pool/KeyedObjectPool.java | 1 -
java/org/apache/tomcat/dbcp/pool/ObjectPool.java | 1 -
.../tomcat/dbcp/pool/PoolableObjectFactory.java| 1 -
.../dbcp/pool/impl/GenericKeyedObjectPool.java | 12 +--
.../tomcat/dbcp/pool/impl/GenericObjectPool.java | 83 ++--
.../tomcat/dbcp/pool/impl/StackObjectPool.java | 8 +-
12 files changed, 124 insertions(+), 112 deletions(-)
diff --git a/java/org/apache/el/ValueExpressionImpl.java
b/java/org/apache/el/ValueExpressionImpl.java
index a676943..80614e3 100644
--- a/java/org/apache/el/ValueExpressionImpl.java
+++ b/java/org/apache/el/ValueExpressionImpl.java
@@ -55,7 +55,7 @@ import org.apache.el.util.ReflectionUtil;
*
*
*
- * The {@link javax.el.ExpressionFactory#createValueExpression} method
+ * The {@link javax.el.ExpressionFactory#createValueExpression} method
* can be used to parse an expression string and return a concrete instance
* of ValueExpression that encapsulates the parsed expression.
* The {@link FunctionMapper} is used at parse time, not evaluation time,
@@ -103,9 +103,6 @@ public final class ValueExpressionImpl extends
ValueExpression implements
super();
}
-/**
- *
- */
public ValueExpressionImpl(String expr, Node node, FunctionMapper fnMapper,
VariableMapper varMapper, Class expectedType) {
this.expr = expr;
@@ -281,5 +278,4 @@ public final class ValueExpressionImpl extends
ValueExpression implements
this.varMapper);
return this.getNode().getValueReference(ctx);
}
-
}
diff --git a/java/org/apache/juli/logging/Log.java
b/java/org/apache/juli/logging/Log.java
index ec977b0..e016676 100644
--- a/java/org/apache/juli/logging/Log.java
+++ b/java/org/apache/juli/logging/Log.java
@@ -24,7 +24,7 @@ package org.apache.juli.logging;
* this interface must have a constructor that takes a single String
* parameter representing the "name" of this Log.
*
- * The six logging levels used by Log are (in order):
+ * The six logging levels used by Log are (in order):
*
* trace (the least serious)
* debug
@@ -33,7 +33,7 @@ package org.apache.juli.logging;
* error
* fatal (the most serious)
*
- * The mapping of these log levels to the concepts used by the underlying
+ * The mapping of these log levels to the concepts used by the underlying
* logging system is implementation dependent.
* The implementation should ensure, though, that this ordering behaves
* as expected.
@@ -44,12 +44,12 @@ package org.apache.juli.logging;
* to be logged).
*
* For example,
- *
+ *
*if (log.isDebugEnabled()) {
*... do something expensive ...
*log.debug(theResult);
*}
- *
+ *
*
*
* Configuration of the underlying logging system will generally be done
@@ -71,6 +71,9 @@ public interface Log {
* Call this method to prevent having to perform expensive operations
* (for example, String concatenation)
* when the log level is more than debug.
+ *
+ * @return true if debug level logging is enabled, otherwise
+ * false
*/
public boolean isDebugEnabled();
@@ -81,6 +84,9 @@ public interface Log {
* Call this method to prevent having to perform expensive operations
* (for example, String concatenation)
* when the log level is more than error.
+ *
+ * @return true if error level logging is enabled, otherwise
+ * false
*/
public boolean isErrorEnabled();
@@ -91,6 +97,9 @@ public interface Log {
* Call this method to prevent having to perform expensive operations
* (for example, String concatenation)
* when the log level is more than fatal.
+ *
+ * @return true if fatal level logging is enabled, otherwise
+ * false
*/
public boolean isFatalEnabled();
@@ -101,6 +110,9 @@ public interface Log {
* Call this method to prevent having to perform expensive operations
* (for example, String conc
[GitHub] [tomcat] alitokmen opened a new pull request #201: Avoid NPE in NamingContextListener.getGlobalNamingContext with Embedded containers
alitokmen opened a new pull request #201: Avoid NPE in NamingContextListener.getGlobalNamingContext with Embedded containers URL: https://github.com/apache/tomcat/pull/201 When the Service is an Embedded service, it doesn't have a Server object when stopping - Which in turn implies that when one uses a Tomcat Embedded server the getGlobalNamingContext also cannot rely on the Server object being present when shutting down. Add a !null check in order to avoid NPEs and hence a clean shutdown. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] KangZhiDong commented on issue #194: fix typo
KangZhiDong commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-529220827 @markt-asf please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Fix various Javadoc warnings/errors with Java 9
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 0359131 Fix various Javadoc warnings/errors with Java 9
0359131 is described below
commit 0359131707e6cb86ee9b7abac8db78eb71a194cb
Author: Mark Thomas
AuthorDate: Sun Sep 8 23:34:18 2019 +0100
Fix various Javadoc warnings/errors with Java 9
Aligning with 8.5.x where posisble
---
java/javax/servlet/jsp/JspWriter.java | 4 +-
.../javax/servlet/jsp/tagext/SimpleTagSupport.java | 4 +-
java/javax/servlet/jsp/tagext/TagExtraInfo.java| 2 +-
java/org/apache/catalina/Executor.java | 9 +-
java/org/apache/catalina/startup/TldConfig.java| 4 +-
java/org/apache/jasper/compiler/JspUtil.java | 62
java/org/apache/jasper/compiler/PageDataImpl.java | 7 +-
java/org/apache/jasper/compiler/SmapGenerator.java | 11 ++-
java/org/apache/jasper/compiler/SmapStratum.java | 38
.../org/apache/jasper/runtime/BodyContentImpl.java | 74 +-
java/org/apache/jasper/runtime/JspWriterImpl.java | 13 ++-
java/org/apache/jasper/tagplugins/jstl/Util.java | 42 +---
java/org/apache/jasper/xmlparser/ASCIIReader.java | 2 +-
java/org/apache/jasper/xmlparser/UCSReader.java| 2 +-
java/org/apache/jasper/xmlparser/UTF8Reader.java | 2 +-
java/org/apache/juli/FileHandler.java | 16 ++-
.../tomcat/dbcp/dbcp/DelegatingConnection.java | 8 +-
.../dbcp/dbcp/DelegatingDatabaseMetaData.java | 8 +-
.../tomcat/dbcp/dbcp/DelegatingResultSet.java | 8 +-
.../tomcat/dbcp/dbcp/DelegatingStatement.java | 8 +-
.../dbcp/dbcp/PoolableConnectionFactory.java | 108 ++---
.../apache/tomcat/dbcp/dbcp/PoolingConnection.java | 2 +-
.../dbcp/dbcp/cpdsadapter/DriverAdapterCPDS.java | 2 +-
.../dbcp/cpdsadapter/PooledConnectionImpl.java | 2 +-
.../dbcp/datasources/CPDSConnectionFactory.java| 8 +-
.../dbcp/datasources/InstanceKeyDataSource.java| 14 +--
.../datasources/KeyedCPDSConnectionFactory.java| 8 +-
.../apache/tomcat/dbcp/jocl/ConstructorUtil.java | 20 ++--
.../dbcp/pool/BaseKeyedPoolableObjectFactory.java | 2 +-
.../dbcp/pool/BasePoolableObjectFactory.java | 4 +-
.../dbcp/pool/impl/CursorableLinkedList.java | 74 +++---
.../apache/tomcat/util/codec/binary/Base64.java| 8 +-
.../apache/tomcat/util/digester/CallParamRule.java | 17 +---
.../tomcat/util/digester/ObjectParamRule.java | 8 +-
.../util/digester/WithDefaultsRulesWrapper.java| 3 +-
java/org/apache/tomcat/util/http/ServerCookie.java | 2 +-
java/org/apache/tomcat/util/net/NioChannel.java| 4 +-
.../apache/tomcat/util/net/SecureNioChannel.java | 2 +-
java/org/apache/tomcat/util/net/URL.java | 7 +-
.../tomcat/util/net/jsse/JSSESocketFactory.java| 2 +-
.../tomcat/util/threads/ThreadPoolExecutor.java| 2 +-
41 files changed, 333 insertions(+), 290 deletions(-)
diff --git a/java/javax/servlet/jsp/JspWriter.java
b/java/javax/servlet/jsp/JspWriter.java
index 691f354..9d0be8b 100644
--- a/java/javax/servlet/jsp/JspWriter.java
+++ b/java/javax/servlet/jsp/JspWriter.java
@@ -111,8 +111,8 @@ public abstract class JspWriter extends java.io.Writer {
/**
* Write a line separator. The line separator string is defined by the
- * system property line.separator, and is not necessarily a single
- * newline ('\n') character.
+ * system property line.separator, and is not necessarily a
+ * single newline ('\n') character.
*
* @exception IOException
*If an I/O error occurs
diff --git a/java/javax/servlet/jsp/tagext/SimpleTagSupport.java
b/java/javax/servlet/jsp/tagext/SimpleTagSupport.java
index 496ba95..9d9c88f 100644
--- a/java/javax/servlet/jsp/tagext/SimpleTagSupport.java
+++ b/java/javax/servlet/jsp/tagext/SimpleTagSupport.java
@@ -149,8 +149,8 @@ public class SimpleTagSupport implements SimpleTag {
*
* For every instance of TagAdapter
* encountered while traversing the ancestors, the tag handler returned by
- * TagAdapter.getAdaptee() - instead of the TagAdapter itself -
- * is compared to klass. If the tag handler matches, it - and
+ * TagAdapter.getAdaptee() - instead of the TagAdapter itself
-
+ * is compared to klass. If the tag handler matches, it - and
* not its TagAdapter - is returned.
*
*
diff --git a/java/javax/servlet/jsp/tagext/TagExtraInfo.java
b/java/javax/servlet/jsp/tagext/TagExtraInfo.java
index 027e7c2..1fff9f2 100644
--- a/java/javax/servlet/jsp/tagext/TagExtraInfo.java
+++ b/java/javax/servlet/jsp/tagext/TagExtraInfo.java
@@ -46,7 +46,7 @@ package javax.servlet.jsp.tagext;
* getVariableInfo().
*
*
- * NOTE: It is a
