Re: [VOTE] Release Apache Tomcat 8.0.53

[Coty Sutherland]

On Fri, Jun 29, 2018 at 12:42 PM Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 8.0.53 release is now available for voting.
>
> NOTE: This is the last release!
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.53/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1189/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_53/
>
> The proposed 8.0.53 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.53
>

+1, LGTM


>
> Regards,
> Violeta
>

Re: Feature Request: Add a YUM Package for Tomcat

[Coty Sutherland]

Hi,

On Tue, Jul 10, 2018 at 7:52 PM Michel Feinstein 
wrote:

>  Hi developers, I just want  to post here a feature request.
>
> There are several tutorials online on how to get Tomcat (any version)
> running on a server. They will be mostly about using "wget" to download the
> binaries and adding SystemV or systemd init files.
>
> Those are fine, they work, but it makes harder to update Tomcat and a YUM
> package is just a lot easier to manage, install, update, etc.
>
> I am using AWS EC2 with an Amazon Linux AMI 2, so a systemd Linux
> distribution that supports YUM and there isn't a YUM package for Tomcat 9
> (at least not one that I can find anywhere).
>

This isn't something that the ASF Tomcat community would provide because
those things are distribution specific. I'm not sure if everyone's thoughts
on that has changed, but in the past we haven't done that. Given that
you're using AMI, there should already be a tomcat package available there.
Do you not see any, or is the one available not Tomcat 9? If you can find
the AMI provided one and it isn't the Tomcat version that you want I'd
suggest opening a bug with them to have it updated.


>
> I am not an experienced Linux user, so I don't know much about the
> difficulties of YUM packaging or setting up an external YUM repository
> (outside from the AWS managed one I mean), but I think the effort of adding
> such a product into the Tomcat development process will be very much
> welcome.
>

It's actually quite easy to do because Tomcat only has a few dependencies.
I maintain Tomcat for Fedora/RHEL so I'd be happy to talk more about it :)


>
> Thank you!
>

Re: [VOTE] Release Apache Tomcat 8.5.34

[Coty Sutherland]

On Tue, Sep 4, 2018 at 6:52 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.34 release is now available for voting.
>
> The major changes compared to the 8.5.33 release are:
>
> - Fix multiple issues associated with using the asynchronous Servlet
>   API in combination with HTTP/2
>
> - Add recursion to rewrite substitution parsing
>
> - Expand the information in the documentation web application
>   regarding the use of CATALINA_HOME and CATALINA_BASE.
>   Patch provided by Marek Czernek.
>
>
> Along with lots of other bug fixes and improvements.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.34/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1194/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_34/
>
> The proposed 8.5.34 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.34
>

+1


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: svn commit: r1731734 - in /tomcat/trunk: java/org/apache/catalina/manager/host/ webapps/docs/

[Coty Sutherland]

In addition to the object array size restoration made in 1731735, I think
that another erroneous change that I submitted slipped in to your patch. I
noticed it while poking around at tomcat-8.5.0.Beta. Now when you add a
host you get a button that just contains {5} where the persist button that
I proposed would have been. You can revert the change with the following
patch to make it work the way it did before:

+++
Index: java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java
===
--- java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java (revision
1737136)
+++ java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java (working
copy)
@@ -511,9 +511,6 @@
 "  " +
 "   " +
 "  \n" +
-"  " +
-"   " +
-"  \n" +
 " \n" +
 "\n";

+++

Cheers

On Mon, Feb 22, 2016 at 3:19 PM,  wrote:

> Author: markt
> Date: Mon Feb 22 20:19:15 2016
> New Revision: 1731734
>
> URL: http://svn.apache.org/viewvc?rev=1731734&view=rev
> Log:
> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=48674
> Implement an option within the Host Manager web pplication to persist the
> current configuration.
> Based on a patch by Coty Sutherland.
>
> Modified:
>
> tomcat/trunk/java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java
>
> tomcat/trunk/java/org/apache/catalina/manager/host/HostManagerServlet.java
>
> tomcat/trunk/java/org/apache/catalina/manager/host/LocalStrings.properties
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java?rev=1731734&r1=1731733&r2=1731734&view=diff
>
> ==
> ---
> tomcat/trunk/java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java
> (original)
> +++
> tomcat/trunk/java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java
> Mon Feb 22 20:19:15 2016
> @@ -94,7 +94,8 @@ public final class HTMLHostManagerServle
>  } else if (command.equals("/list")) {
>  // Nothing to do - always generate list
>  } else if (command.equals("/add") || command.equals("/remove") ||
> -command.equals("/start") || command.equals("/stop")) {
> +command.equals("/start") || command.equals("/stop") ||
> +command.equals("/persist")) {
>  message = smClient.getString(
>  "hostManagerServlet.postCommand", command);
>  } else {
> @@ -143,6 +144,8 @@ public final class HTMLHostManagerServle
>  message = start(name, smClient);
>  } else if (command.equals("/stop")) {
>  message = stop(name, smClient);
> +} else if (command.equals("/persist")) {
> +message = persist(smClient);
>  } else {
>  //Try GET
>  doGet(request, response);
> @@ -227,6 +230,22 @@ public final class HTMLHostManagerServle
>
>
>  /**
> + * Persist the current configuration to server.xml.
> + *
> + * @param smClient i18n resources localized for the client
> + */
> +protected String persist(StringManager smClient) {
> +
> +StringWriter stringWriter = new StringWriter();
> +PrintWriter printWriter = new PrintWriter(stringWriter);
> +
> +super.persist(printWriter, smClient);
> +
> +return stringWriter.toString();
> +}
> +
> +
> +/**
>   * Render a HTML list of the currently active Contexts in our virtual
> host,
>   * and memory and server status information.
>   *
> @@ -341,7 +360,7 @@ public final class HTMLHostManagerServle
>  writer.print
>  (MessageFormat.format(HOSTS_ROW_DETAILS_SECTION,
> args));
>
> -args = new Object[4];
> +args = new Object[6];
>  if (host.getState().isAvailable()) {
>  args[0] = response.encodeURL
>  (request.getContextPath() +
> @@ -362,10 +381,10 @@ public final class HTMLHostManagerServle
>  args[3] = hostsRemove;
>  if (host == this.installedHost) {
>  writer.print(MessageFormat.format(
> -MANAGER_HOST_ROW_BUTTON_SECTION, args));
> + 

Re: Time for Tomcat 7.0.69

[Coty Sutherland]

> BTW, there is no report that the issue affects Tomcat 7 at all (the
> user reported the issue for Tomcat 8 and 9).

They are affected; I added a comment in the bug summarizing my findings
regarding all four tomcat versions. Sorry I didn't do that initially.

On Wed, Apr 6, 2016 at 7:21 AM, Rémy Maucherat  wrote:

> 2016-04-06 5:48 GMT-05:00 Konstantin Kolinko :
>
> > 2. The catalina.policy change for BZ 59247 has to be reverted and
> > alternative fix to be applied.
> >
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=59247#c8
> >
> > Your -1 hasn't been seconded and doesn't seem to have sufficient
> technical
> justification. The change is only a harmless workaround in the default
> configuration and not even a code change. As a result, it is not a valid
> veto.
>
> Rémy
>



-- 
Coty Sutherland, RHCSA, RHCE, JBCAA
Senior Software Engineer @ Red Hat, Inc.
100 East Davie Street
Raleigh, NC 27606

Email: c...@redhat.com
IRC Nickname: coty
Office: 919-890-8303

Questions about BeanELResolver behavior

[Coty Sutherland]

Hi all,

I have a question regarding the way that the ResourceBundleELResolver (and
the BeanELResolver) function as part of investigations into the changes
made for https://bz.apache.org/bugzilla/show_bug.cgi?id=46915 and then
reverted in https://bz.apache.org/bugzilla/show_bug.cgi?id=53001  (very old
stuff, I know). What I've come to find is that whenever you provide a
non-existent basename the var.resourceBundle.keys call returns an empty
string. This behavior is consistent between all tomcat versions. For my
testing I'm using the reproducer from bz-46915, but here is a snippet of
the JSP:

<%@ taglib uri="http://java.sun.com/jsp/jstl/fmt"; prefix="fmt"%>

Re: Questions about BeanELResolver behavior

[Coty Sutherland]

Understood. Thanks for the walk through; I think I understand what's going
on. I am going to read through the spec a bit more and verify though since
I don't know much of anything about EL :(

Thanks again!

On Mon, May 9, 2016 at 5:14 PM, Mark Thomas  wrote:

> On 09/05/2016 20:45, Coty Sutherland wrote:
>
> 
>
> > <%@ taglib uri="http://java.sun.com/jsp/jstl/fmt"; prefix="fmt"%>
> >  > var="messageString" />
> > 

Re: 8.0.35 Javadoc problems

[Coty Sutherland]

Did this issue hold up the release announcement for 8.0.35? There was
a user in #tomcat asking why it wasn't announced and was concerned
that the release had issues.

-Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 8.0.35 Javadoc problems

[Coty Sutherland]

> No. I just forgot to send out the announcement. I'll get that done shortly.

Cool, thanks!

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL.

[Coty Sutherland]

> It may have been branched in March, but wouldn't it have been branched from 
> the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still 
> occurs.

No, 8.5 was branched from trunk and therefore included the revision
that you pointed out. Please see the dev list thread titled "Tomcat
8.next" for more information on the 8.5 origin. Additionally, looking
at the mergeinfo in svn (svn mergeinfo ^/tomcat/trunk@1726515) shows
that it was forked from trunk. If you looked at the 8.5 AprEndpoint
class and don't see the change, it's because it was changed by
r1727667 on 1/29 (r1726515 was included on 1/24).

On Fri, May 27, 2016 at 12:24 PM, Matt Cosentino  wrote:
> It may have been branched in March, but wouldn't it have been branched from 
> the 8.0 base? This change from 9.0 is not in the 8.5 code and the NPE still 
> occurs.
>
> Bringing an issue to your attention is spamming?
>
> - Matt
>
>
> -Original Message-
> From: Rémy Maucherat [mailto:r...@apache.org]
> Sent: Friday, May 27, 2016 11:06 AM
> To: Tomcat Developers List 
> Subject: Re: Tomcat 8.5: Avoid NPE on bind for APR when using SSL.
>
> 2016-05-27 17:45 GMT+02:00 Matt Cosentino :
>
>> No? 8.5 suffers from the same NPE.
>>
>> First, 8.5 was branched in March, then I am not happy about being spammed.
>
> Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.37

[Coty Sutherland]

2016-09-01 12:56 GMT+02:00 Mark Thomas :
> The proposed 8.0.37 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.37

+1
Unit tests pass on linux with tcnative 1.2.8 and my test suite looks good.

On Fri, Sep 2, 2016 at 4:31 AM, Mark Thomas  wrote:
> On 01/09/2016 11:56, Mark Thomas wrote:
>> The proposed Apache Tomcat 8.0.37 release is now available for voting.
>>
>> The main changes since 8.0.36 are:
>>
>> - treat paths used to obtain a request dispatcher as encoded
>>   (configurable)
>>
>> - update the packaged version of the Tomcat Native Library to 1.2.8
>>
>> - various jdbc-pool fixes
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.37/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1093/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_37/
>>
>> The proposed 8.0.37 release is:
>> [ ] Broken - do not release
>> [X] Stable - go ahead and release as 8.0.37
>
> Unit tests pass for BIO, NIO, NIO2 and APR/native(1.2.8) on Linux OSX
> and Windows.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M10

[Coty Sutherland]

2016-08-31 19:21 GMT+03:00 Mark Thomas :

> The proposed 9.0.0.M10 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M10

+1

On Fri, Sep 2, 2016 at 5:15 AM, Huxing Zhang  wrote:
> The proposed 9.0.0.M10 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M10
>
> No test case failure except the following:
>
>[concat] Testsuites with failed tests:
>[concat] 
> TEST-org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt
>[concat] 
> TEST-org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
>[concat] 
> TEST-org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt
>
> Example failure are:
> test-apr:
> [junit] Running 
> org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser
> [junit] Error in cipher list
> [junit] 139694456104704:error:1410D0B9:SSL 
> routines:SSL_CTX_set_cipher_list:no cipher match:ssl/ssl_lib.c:2018:
> [junit]
> [junit] Error in cipher list
> [junit] 140604037801728:error:1410D0B9:SSL 
> routines:SSL_CTX_set_cipher_list:no cipher match:ssl/ssl_lib.c:2018:
>
> I'v tested with openssl 1.0.2h and 1.1.0, and 1.1.1-dev, all failed, I saw 
> the similar failure in gump:
> http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.txt
>
> Examples ok.
> Our test app works fine.
>
> --
> From:Mark Thomas 
> Time:2016 Sep 1 (Thu) 00:22
> To:dev@tomcat.apache.org 
> Subject:[VOTE] Release Apache Tomcat 9.0.0.M10
>
>
> The proposed Apache Tomcat 9.0.0.M10 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M9 release are:
>
> - limited support for wildcard Host names and aliases
>
> - fix regressions in JSSE TLS handshake
>
> - treat paths used to obtain a request dispatcher as encoded
>   (configurable)
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M10/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1091/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M10/
>
> The proposed 9.0.0.M10 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M10
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.5

[Coty Sutherland]

On 31/08/2016 21:48, Mark Thomas wrote:

> The proposed 8.5.5 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.5
> [ ] Beta   - go ahead and release as 8.5.5
> [X] Stable - go ahead and release as 8.5.5

+1

On Fri, Sep 2, 2016 at 5:17 AM, Huxing Zhang  wrote:
> The proposed 8.5.5 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.5
> [ ] Beta   - go ahead and release as 8.5.5
> [ X ] Stable - go ahead and release as 8.5.5
>
> No test failure.
> Examples ok.
> Our test app works fine.
>
> --
> From:Mark Thomas 
> Time:2016 Sep 1 (Thu) 04:48
> To:dev@tomcat.apache.org 
> Subject:[VOTE] Release Apache Tomcat 8.5.5
>
>
> The proposed Apache Tomcat 8.5.5 release is now available for voting.
>
> The major changes compared to the 8.5.4 release are:
>
>
> - limited support for wildcard Host names and aliases
>
> - fix regressions in JSSE TLS handshake
>
> - treat paths used to obtain a request dispatcher as encoded
>   (configurable)
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.5/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1092/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_5/
>
> The proposed 8.5.5 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.5
> [ ] Beta   - go ahead and release as 8.5.5
> [ ] Stable - go ahead and release as 8.5.5
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Deploying Tomcat on Snappy Ubuntu Core

[Coty Sutherland]

Hi Micheal,

I hadn't heard of snaps (or used Ubuntu much) but the concept seems
interesting to me. Would you be able to send me links to what you have so
far so I can check it out? I have a few questions, but I'll reserve those
until I get a chance to review what you have.

Thanks!

On Sep 14, 2016 3:51 PM, "Michael Hall"  wrote:

> Hi everyone,
>
> Ubuntu has developed a new platform for deploying applications using
> bundled packages called "snaps". These make it easier to deploy and
> update on Ubuntu independently of it's release cycle (and on non-Ubuntu
> distros too for that matter). I would like to make Tomcat available in
> this format so it can be more easily used on lightweight cloud instances
> or devices like the Raspberry Pi.
>
> I have a working example of Tomcat as a snap, and it works really well
> with a separate read-only CATALINE_HOME and a writable, versioned
> CATALINA_BASE that will allow for atomic updates and rollbacks without
> breaking application data, and it's very easy to use.
>
> The next step is to contribute this to upstream, where it can be
> improved (I've only scratched the surface of what can be done with it)
> and integrated with the CI system so that snap package can be
> automatically created and uploaded for testers and users. This is where
> I need help from somebody on this list, so please let me know if you are
> interested and I will provide you the packaging files (there are only 2)
> and a working binary package if you want to give it a try.
>
> Thanks.
>
> --
> Michael Hall
> mhall...@ubuntu.com
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Should we update version scheme information for tomcat 9?

[Coty Sutherland]

Hi all,

I'm getting quite a few questions on freenode in #tomcat about the
versioning scheme for tomcat 9. I looked at the
http://tomcat.apache.org/whichversion.html page and it has some good
information there, but it doesn't mention what the milestone releases
are or how they fit into the alpha/beta/stable releases. Can we add
some information there to help users better understand the milestone
releases (if that is going to continue to be a thing) and how they fit
into the lifecycle?

I can open a bug for it, but wanted to get an opinion on whether or
not this is something that we want to do.



Thanks,
Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.72

[Coty Sutherland]

On Wed, Sep 14, 2016 at 3:01 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.72 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.72/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1095/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_72/
>
> The proposed 7.0.72 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.72 Stable

+1

On Fri, Sep 16, 2016 at 7:28 AM, Felix Schumacher
 wrote:
>
>
> Am 14. September 2016 15:01:59 MESZ, schrieb Violeta Georgieva 
> :
>>The proposed Apache Tomcat 7.0.72 release is now available for voting.
>>
>>It can be obtained from:
>>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.72/
>>The Maven staging repo is:
>>https://repository.apache.org/content/repositories/orgapachetomcat-1095/
>>The svn tag is:
>>http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_72/
>>
>>The proposed 7.0.72 release is:
>>[ ] Broken - do not release
>>[x] Stable - go ahead and release as 7.0.72 Stable
>
> Regards,
> Felix
>
>>
>>Regards,
>>Violeta
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Should we update version scheme information for tomcat 9?

[Coty Sutherland]

I'm not sure where to file a bug for this, but I produced a first pass
at a patch to update the page. I'm not sure I have a solid grasp on
why we're doing milestones in tc9 (other than to prevent a bunch of
revisions from being releases pre-beta) so this might need some
changes to convey the intent a bit better.

On Thu, Sep 15, 2016 at 12:26 PM, Mark Thomas  wrote:
> On 15 September 2016 16:32:36 BST, Coty Sutherland  
> wrote:
>>Hi all,
>>
>>I'm getting quite a few questions on freenode in #tomcat about the
>>versioning scheme for tomcat 9. I looked at the
>>http://tomcat.apache.org/whichversion.html page and it has some good
>>information there, but it doesn't mention what the milestone releases
>>are or how they fit into the alpha/beta/stable releases. Can we add
>>some information there to help users better understand the milestone
>>releases (if that is going to continue to be a thing) and how they fit
>>into the lifecycle?
>>
>>I can open a bug for it, but wanted to get an opinion on whether or
>>not this is something that we want to do.
>>
>>
>>
>>Thanks,
>>Coty
>>
>>-
>>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> +1
>
> Current plan is milestones until the specs are final. Depending on what 
> happens with JavaEE 7 we might need to rethink that. We should know more 
> after Java One.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
Index: docs/whichversion.html
===
--- docs/whichversion.html	(revision 1761025)
+++ docs/whichversion.html	(working copy)
@@ -397,22 +397,23 @@
 
 
 
-Alpha / Beta / Stable
+Milestone / Alpha / Beta / Stable
 
 
 
 When voting for a release, reviewers specify the stability level that they
 consider the release has reached. Initial releases of a new major version
-typically process from Alpha, through Beta to Stable over a period of several
-months. However, the Stable level is only available once the Java specifications
-the release implements have been finalised. This means a release that in all
-other respects is considered stable, may still be labelled as Beta if the
-specifications are not final.
+may have Milestone releases (depending on the state of the specification) before 
+moving into Alpha state and then typically process from Alpha, through Beta to 
+Stable over a period of several months. However, the Stable level is only 
+available once the Java specifications the release implements have been finalised. 
+This means a release that in all other respects is considered stable, may still 
+be labelled as Beta if the specifications are not final.
 
 
 The download pages will always show the latest stable release and any newer
-Alpha or Beta release if one exists. Alpha and beta releases are always clearly
-marked on the download pages.
+Milestone, Alpha, or Beta release if one exists. Milestone, Alpha, and Beta 
+releases are always clearly marked on the download pages.
 
 
 Stability is a subjective judgement and you should always read carefully the
@@ -423,6 +424,11 @@
 
 
 
+Milestone releases may contain large amounts of untested/missing
+functionality that is being implemented based on an unfinished specification and
+therefore could change significantly as the specification changes.
+
+
 Alpha releases may contain large amounts of untested/missing
 functionality required by the specification and/or significant bugs and are not
 expected to run stably for any length of time.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Should we update version scheme information for tomcat 9?

[Coty Sutherland]

Ahh. That makes a lot more sense; thanks. I'll amend my patch and
attach it again in a bit.

On Fri, Sep 16, 2016 at 9:52 AM, Mark Thomas  wrote:
> On 16/09/2016 13:59, Coty Sutherland wrote:
>> I'm not sure where to file a bug for this, but I produced a first pass
>> at a patch to update the page. I'm not sure I have a solid grasp on
>> why we're doing milestones in tc9 (other than to prevent a bunch of
>> revisions from being releases pre-beta) so this might need some
>> changes to convey the intent a bit better.
>
> Version numbers aren't the concern.
>
> Think of it as:
> - Milestone - Specification JARs not complete
> - Alpha - Specification JARs complete, other stuff (including the
>   implementation of the specification) not complete
> - Beta  - Feature complete, not production ready
> - Stable- Production ready
>
> Once the spec is final getting to Alpha is pretty easy. Historically, we
> haven't been this far ahead of the curve before. We've usually been
> playing catch up so we've started with Alpha.
>
> Does that help?
>
> Mark
>
>
>>
>> On Thu, Sep 15, 2016 at 12:26 PM, Mark Thomas  wrote:
>>> On 15 September 2016 16:32:36 BST, Coty Sutherland  
>>> wrote:
>>>> Hi all,
>>>>
>>>> I'm getting quite a few questions on freenode in #tomcat about the
>>>> versioning scheme for tomcat 9. I looked at the
>>>> http://tomcat.apache.org/whichversion.html page and it has some good
>>>> information there, but it doesn't mention what the milestone releases
>>>> are or how they fit into the alpha/beta/stable releases. Can we add
>>>> some information there to help users better understand the milestone
>>>> releases (if that is going to continue to be a thing) and how they fit
>>>> into the lifecycle?
>>>>
>>>> I can open a bug for it, but wanted to get an opinion on whether or
>>>> not this is something that we want to do.
>>>>
>>>>
>>>>
>>>> Thanks,
>>>> Coty
>>>>
>>>> -
>>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>> +1
>>>
>>> Current plan is milestones until the specs are final. Depending on what 
>>> happens with JavaEE 7 we might need to rethink that. We should know more 
>>> after Java One.
>>>
>>> Mark
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>>
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Should we update version scheme information for tomcat 9?

[Coty Sutherland]

OK, I've read over what I proposed again and it looks correct to me. I
only made one change after you provided further explanation and that
change was to add 'finalized' in the Alpha release description:

+functionality required by the finalised specification and/or significant bugs

I did this to further demarcate Milestone releases from Alpha
releases. If this sounds good to everyone, I'll push it up.

Thanks!

On Sat, Sep 17, 2016 at 12:35 PM, Jarosław Górny
 wrote:
> 2016-09-16 15:52 GMT+02:00 Mark Thomas :
>> On 16/09/2016 13:59, Coty Sutherland wrote:
>>> I'm not sure where to file a bug for this, but I produced a first pass
>>> at a patch to update the page. I'm not sure I have a solid grasp on
>>> why we're doing milestones in tc9 (other than to prevent a bunch of
>>> revisions from being releases pre-beta) so this might need some
>>> changes to convey the intent a bit better.
>>
>> Version numbers aren't the concern.
>>
>> Think of it as:
>> - Milestone - Specification JARs not complete
>> - Alpha - Specification JARs complete, other stuff (including the
>>   implementation of the specification) not complete
>> - Beta  - Feature complete, not production ready
>> - Stable- Production ready
>>
>> Once the spec is final getting to Alpha is pretty easy. Historically, we
>> haven't been this far ahead of the curve before. We've usually been
>> playing catch up so we've started with Alpha.
>>
>> Does that help?
>>
>
>
> Thanks! This is very interesting and important to what I'm doing!
>
>
> --
> Jarosław Górny
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.10

[Coty Sutherland]

My vote is non-binding, but...

2016-09-26 19:17 GMT+03:00 Mark Thomas :
>
> Version 1.2.10 includes the following change:
>
> - Update minimum recommended OpenSSL version to 1.0.2j
> - Windows binaries built with OpenSSL 1.0.2j
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.10 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

+1 :)

On Mon, Oct 3, 2016 at 9:02 AM, Henri Gomez  wrote:
>  [X] Stable, go ahead and release
> [ ] Broken because of ...
>
> Built and tested on Ubuntu 16.04 64bits against Tomcat 8.5.5
>
> 2016-10-03 14:17 GMT+02:00 Mark Thomas :
>
>> Ping.
>>
>> There are only two binding votes so far.
>>
>> If you are able to review this release and vote on it, it would be much
>> appreciated.
>>
>> Thanks,
>>
>> Mark
>>
>>
>> On 26/09/2016 17:17, Mark Thomas wrote:
>> > Version 1.2.10 includes the following change:
>> >
>> > - Update minimum recommended OpenSSL version to 1.0.2j
>> > - Windows binaries built with OpenSSL 1.0.2j
>> >
>> > The proposed release artefacts can be found at [1],
>> > and the build was done using tag [2].
>> >
>> > The Apache Tomcat Native 1.2.10 is
>> >  [ ] Stable, go ahead and release
>> >  [ ] Broken because of ...
>> >
>> > Thanks,
>> >
>> > Mark
>> >
>> >
>> > [1]
>> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-
>> connectors/native/1.2.10/
>> > [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_
>> NATIVE_1_2_10
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> > For additional commands, e-mail: dev-h...@tomcat.apache.org
>> >
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.12

[Coty Sutherland]

On Thu, Feb 9, 2017 at 7:38 AM, Mark Thomas  wrote:
> Version 1.2.12 includes the following changes compared to 1.2.10:
>
> - Update minimum recommended OpenSSL version to 1.0.2k
> - Windows binaries built with OpenSSL 1.0.2k
> - Better documentation for building on Windows
>   (including with FIPS enabled OpenSSL)
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.12 is
>  [x] Stable, go ahead and release
>  [ ] Broken because of ...

Though my vote is non-binding...it looks good to me :)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1784959 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

[Coty Sutherland]

On Wed, Mar 1, 2017 at 9:55 AM, Mark Thomas  wrote:
> On 01/03/17 14:54, csuth...@apache.org wrote:
>> Author: csutherl
>> Date: Wed Mar  1 14:54:38 2017
>> New Revision: 1784959
>>
>> URL: http://svn.apache.org/viewvc?rev=1784959&view=rev
>> Log:
>> Follow up to r1784807.
>> Removing PushToken class reference as it was deleted by r1784807.
>
> Nice catch.
>
> Thanks.

No problem :)

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.12

[Coty Sutherland]

On Wed, Mar 8, 2017 at 1:56 PM, Mark Thomas  wrote:
> The proposed Apache Tomcat 8.5.12 release is now available for voting.
>
> The major changes compared to the 8.5.11 release are:
>
> - Updates to the early access version of the Serlet 4.0 API to align it
>   with the most recent discussions in the Servlet EG
>
> - Support for Java 9 during annotation scanning
>
> - Update Tomcat Native to 1.2.12 to pick up the latest Windows binaries
>   built with OpenSSL 1.0.2k
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.12/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1121/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_12/
>
> The proposed 8.5.12 release is:
> [x] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.12

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.38

[Coty Sutherland]

On Wed, Mar 8, 2017 at 3:26 PM, Mark Thomas  wrote:
> The proposed Apache Tomcat 8.0.42 release is now available for voting.
>
> The main changes since 8.0.41 are:
>
> - Limited relaxation of the HTTP request line validation
>
> - Support for Java 9 during annotation scanning
>
> - Update Tomcat Native to 1.2.12 to pick up the latest Windows binaries
>   built with OpenSSL 1.0.2k
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.42/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1122/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_42/
>
> The proposed 8.0.42 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.42

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.12

[Coty Sutherland]

On Mon, Mar 13, 2017 at 4:00 PM, Mark Thomas  wrote:
> On 13/03/17 19:57, Coty Sutherland wrote:
>> On Wed, Mar 8, 2017 at 1:56 PM, Mark Thomas  wrote:
>>> The proposed Apache Tomcat 8.5.12 release is now available for voting.
>>>
>>> The major changes compared to the 8.5.11 release are:
>>>
>>> - Updates to the early access version of the Serlet 4.0 API to align it
>>>   with the most recent discussions in the Servlet EG
>>>
>>> - Support for Java 9 during annotation scanning
>>>
>>> - Update Tomcat Native to 1.2.12 to pick up the latest Windows binaries
>>>   built with OpenSSL 1.0.2k
>>>
>>> It can be obtained from:
>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.12/
>>> The Maven staging repo is:
>>> https://repository.apache.org/content/repositories/orgapachetomcat-1121/
>>> The svn tag is:
>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_12/
>>>
>>> The proposed 8.5.12 release is:
>>> [x] Broken - do not release
>>> [ ] Stable - go ahead and release as 8.5.12
>>
>> +1
>
> Broken how? Or did you X the wrong box?

Crap, sorry. I X'd the wrong box...it's Stable for me. Sorry again.

> Mark
>
>
>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.76

[Coty Sutherland]

On Thu, Mar 9, 2017 at 9:12 AM, Mark Thomas  wrote:
> On 09/03/17 14:11, Mark Thomas wrote:
>> The proposed Apache Tomcat 7.0.76 release is now available for voting.
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.76/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1123/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_76/
>>
>> The proposed 7.0.76 release is:
>> [ ] Broken - do not release
>> [x] Stable - go ahead and release as 7.0.76 Stable

+1

>> Regards,
>
> Whoops. I hit sent before editing the signature.
>
> Mark
>
>
>> Violeta
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.13

[Coty Sutherland]

On Mon, Mar 27, 2017 at 11:13 AM, Mark Thomas  wrote:
> The proposed Apache Tomcat 8.5.13 release is now available for voting.
>
> The major changes compared to the 8.5.12 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1126/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/
>
> The proposed 8.5.13 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.13

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat 8.5 Java 9 compatibilty

[Coty Sutherland]

Hi all,

I see a good bit of discussion regarding testing trunk with java 9,
are we planning to test 8.5 with java 9 also? I've executed the unit
tests for both and see that there are quite a few more failures on 8.5
than there are for trunk, so it seems that we've been fixing trunk but
not 8.5.



Thanks,
Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat 8.5 Java 9 compatibilty

[Coty Sutherland]

On Wed, Mar 29, 2017 at 12:10 PM, Mark Thomas  wrote:
> On 29/03/17 16:56, Coty Sutherland wrote:
>> Hi all,
>>
>> I see a good bit of discussion regarding testing trunk with java 9,
>> are we planning to test 8.5 with java 9 also? I've executed the unit
>> tests for both and see that there are quite a few more failures on 8.5
>> than there are for trunk, so it seems that we've been fixing trunk but
>> not 8.5.
>
> Correct.
>
> My thinking was that, while Java 9 was still only 'early access' and
> somewhat of a moving target, make the fixes in Tomcat 9 and back-port
> them to 8.5.x and 7.0.x (assuming 8.0.x is EOL by then) once Java 9 is
> released. My primary concern is I don't want to have to make breaking
> changes in 8.5.x and friends as Java 9 evolves. That is unlikely but not
> impossible.

That's what I was hoping for, thanks for confirming.

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Building tomcat with maven

[Coty Sutherland]

Hi,

In order to improve my build process I'm looking at utilizing maven to
build tomcat rather than ant (maven works with an existing toolset,
whereas ant doesn't). Does anyone know of any groups that have tried
to do or are doing this, or any projects that I could look into? If
not, would anyone be interested in my progress on creating a
(hopefully simple) maven wrapper that uses AntRun plugin to build
with?



Thanks,
Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Building tomcat with maven

[Coty Sutherland]

On Wed, Mar 29, 2017 at 1:31 PM, Mark Thomas  wrote:
> On 29/03/17 18:09, Coty Sutherland wrote:
>> Hi,
>>
>> In order to improve my build process I'm looking at utilizing maven to
>> build tomcat rather than ant (maven works with an existing toolset,
>> whereas ant doesn't). Does anyone know of any groups that have tried
>> to do or are doing this, or any projects that I could look into? If
>> not, would anyone be interested in my progress on creating a
>> (hopefully simple) maven wrapper that uses AntRun plugin to build
>> with?
>
> If you have some free time, this might be some useful background reading:
> http://tomcat.markmail.org/thread/rk3iaqjx7coo4bsb

Thanks, I'll check it out.

> although it sounds as if you just want to put a Maven wrapper around the
> existing build script which is very different to what that thread proposed.

I'm open to whatever; using the AntRun plugin was just what seemed
easiest if the tomcat community didn't want to move to maven. Doing
that seemed like less work to maintain rather than a full blown pom.

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.77

[Coty Sutherland]

On Tue, Mar 28, 2017 at 12:45 PM, Violeta Georgieva
 wrote:
> The proposed Apache Tomcat 7.0.77 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.77/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1128/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_77/
>
> The proposed 7.0.77 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.77 Stable

+1

> Regards,
> Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.15

[Coty Sutherland]

On Fri, May 5, 2017 at 7:38 AM, Mark Thomas  wrote:
> The proposed Apache Tomcat 8.5.15 release is now available for voting.
>
> The major changes compared to the 8.5.13 release are:
>
> - Various improvements to the handling of static custom error pages
>
> - Update to Eclipse JDT Compiler 4.6.3
>
> - Review those places where Tomcat re-encodes a URI or URI component
>   and ensure that that correct encoding is consistently applied.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.15/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1134/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_15/
>
> The proposed 8.5.15 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.15

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Proposal to remove AjpApr connector

[Coty Sutherland]

On May 26, 2017 07:46, "Mark Thomas"  wrote:

On 25/05/17 18:04, Christopher Schultz wrote:
> All,
>
> At ApacheCon, a few of us were talking about things that could be
> removed in upcoming versions of Tomcat. The issue of connectors came up,
> and I was thinking that there doesn't seem to be a reason to have an
> AjpApr connector any more.
>
> The APR flavor of the AJP connector was only useful when BIO was the
> only IO strategy available, but now NIO has been available for some
> time. APR really only gives a benefit when used with OpenSSL for TLS,
> and since AJP doesn't use crypto, I think it's no longer necessary.
>
> I think we could even remove it as of Tomcat 9 if we want.
>
> What do others think?

It is only 8 lines of code. It is probably simpler just to keep it than
to take the time to document why that particular combination is no
longer available.

However, if you expand the proposal to removing the HTTP APR/native
connector as well then that gets a lot more interesting.

Now we have NIO/NIO2 + OpenSSL there is much less of a requirement for
APR/native.

On the plus side, it is probably (mariginally?) faster in some scenarios.

On the down side, it is less stable (we still get the odd crash report)
and it is ~1200 lines of code.

Dropping the APR/native connectors also opens up the possibility of a
significantly trimmed down native library - or possibly even going
directly to OpenSSL.

It feels a bit late to do this for 9.0.x although we code if we wanted
to. It is more of an option for 10.0.x.

My current thinking is that we should drop APR/native for 10.0.x. What
do others think?

+1


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.7

[Coty Sutherland]

Just a quick question for clarity regarding APR tests...we're testing
against the openssl-1.0.2-stable branch, correct? That passes fine,
but testing against trunk fails a couple of tests:

org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testAllOpenSSLCiphersMapped

junit.framework.AssertionFailedError: No mapping found in IBM's JSSE
implementation for TLS13-AES-128-GCM-SHA256+TLSv1.3 when one was
expected
No mapping found in Oracle's JSSE implementation for
TLS13-AES-128-GCM-SHA256+TLSv1.3 when one was expected

org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testOpenSSLCipherAvailability

junit.framework.AssertionFailedError: TLS13-AES-128-GCM-SHA256+TLSv1.3
 expected:<0> but was:<1>
at 
org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testOpenSSLCipherAvailability(TestCipher.java:107)

On Thu, Nov 3, 2016 at 10:49 AM, Mark Thomas  wrote:
> On 03/11/2016 14:43, Felix Schumacher wrote:
>> Hi all,
>>
>> change r1767357 broke ajp connector with an executor.
>>
>> Tomcat fails to set the thread priority, since the ajp connector reports a 
>> default priority of -1 and Thread#setPriority will throw an IAE in line 583 
>> of AbstractProtocol#start.
>>
>> To reproduce this enable the commented executor in server.xml and add that 
>> executor to the ajp connector.
>>
>> A second rather minor point is a white space policy violation in 
>> webapps/docs/config/http2.xml:160.
>
> That almost certainly means 9.0.x is broken as well.
>
> I can re-roll once this is fixed.
>
> I'll be able to get to this in a few hours. If someone beats me to the
> fix, that would be great :)
>
> Mark
>
>>
>> Regards,
>>  Felix
>>
>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas :
>>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>>
>>> The major changes compared to the 8.5.6 release are:
>>>
>>>
>>> - Implement header limits for HTTP/2
>>>
>>> - Improve handling of I/O errors with async processing
>>>
>>> - Fail earlier on invalid HTTP requests
>>>
>>> It can be obtained from:
>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>>> The Maven staging repo is:
>>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>>> The svn tag is:
>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>>
>>> The proposed 8.5.7 release is:
>>> [ ] Broken - do not release
>>> [ ] Alpha  - go ahead and release as 8.5.7
>>> [ ] Beta   - go ahead and release as 8.5.7
>>> [ ] Stable - go ahead and release as 8.5.7
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.8

[Coty Sutherland]

On Thu, Nov 3, 2016 at 5:50 PM, Mark Thomas  wrote:

> The proposed 8.5.8 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.8

Unit tests look good and a few basic tests look good.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.39

[Coty Sutherland]

On Wed, Nov 9, 2016 at 4:41 AM, Violeta Georgieva  wrote:
> The proposed Apache Tomcat 8.0.39 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.39/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1107/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_39/
>
> The proposed 8.0.39 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.39

+1

> Regards,
> Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.73

[Coty Sutherland]

On Mon, Nov 7, 2016 at 5:15 PM, Violeta Georgieva  wrote:
> The proposed Apache Tomcat 7.0.73 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.73/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1106/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_73/
>
> The proposed 7.0.73 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.73 Stable

+1

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.9

[Coty Sutherland]

> The proposed 8.5.9 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.9 (there's a typo here in the 
> original email)

+1

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1775523 - /tomcat/site/trunk/docs/whichversion.html

[Coty Sutherland]

> That reference is correct. Tomcat 9 implements specs from Java EE 8.

Ah, I'll fix it. Sorry.

On Wed, Dec 21, 2016 at 2:00 PM, Mark Thomas  wrote:
> On 21/12/2016 18:18, csuth...@apache.org wrote:
>> Author: csutherl
>> Date: Wed Dec 21 18:18:32 2016
>> New Revision: 1775523
>>
>> URL: http://svn.apache.org/viewvc?rev=1775523&view=rev
>> Log:
>> Added missing JASPIC spec implementation note for tomcat 9.0 and updated an 
>> incorrect reference to Java EE 8.
>
> That reference is correct. Tomcat 9 implements specs from Java EE 8.
> There has been little to no movement on a number of specs. Based on past
> experience there may be some last minute maintenance releases just
> before javaEE 8 goes final.
>
> Mark
>
>
>>
>> Modified:
>> tomcat/site/trunk/docs/whichversion.html
>>
>> Modified: tomcat/site/trunk/docs/whichversion.html
>> URL: 
>> http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775523&r1=1775522&r2=1775523&view=diff
>> ==
>> --- tomcat/site/trunk/docs/whichversion.html (original)
>> +++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 18:18:32 2016
>> @@ -449,10 +449,10 @@ run stably for extended periods of time.
>>  Apache Tomcat 9.x is the current focus of development, it
>>  builds on Tomcat 8.0.x and implements the current draft of the 
>> Servlet
>>  4.0 specification and will also implement the
>> -JSP 2.4?, EL 3.1? and
>> -Web Socket 1.2? specifications once work starts on updating
>> -those specifications for Java EE 8. In addition to this, it includes the
>> -following significant improvements:
>> +JSP 2.4?, EL 3.1?, Web Socket 1.2?
>> + and JASPIC 1.1  specifications once work starts 
>> on
>> +updating those specifications for Java EE 9. In addition to this, it 
>> includes
>> +the following significant improvements:
>>  
>>
>>  
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

JASPIC Specification info missing from a few places

[Coty Sutherland]

Hi all,

I've been looking at the specifications listings on the
whichversions.html page and noticed JASPIC was missing, but is
implemented in 8.5+. I've added it on the site, but then I noticed
that it's also missing from the specifications page here:
https://wiki.apache.org/tomcat/Specifications. I don't think I have
access to the wiki, can someone fix that? I was going to file a bug,
and then noticed that JASPIC is also missing from the descriptions on
the page here: https://bz.apache.org/bugzilla/enter_bug.cgi



Thanks,
Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JASPIC Specification info missing from a few places

[Coty Sutherland]

> Yes. We need you MoinMoin ID for the Tomcat wiki.

Ah. OK, I created an account for the wiki (I didn't see the sign up
link before). It's "Coty Sutherland", if you need that.

> BZ account name? I'll add you as an admin

Awesome, thanks. It's `csuth...@redhat.com`.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JASPIC Specification info missing from a few places

[Coty Sutherland]

> Is there a space there? I'm assuming not since none of the others have
> one. If it does, we'll need to figure out how to handle that.

That was my fault; I fixed it and am able to edit.

> You should be able to add components now.

I just updated the description. Should I also add a component for
JASPIC, or just leave it lumped together in the 'Specification APIs'
component? There isn't a component for JSP and Servlet, but there are
ones for WebSocket and EL, so I'm not sure what the convention is.

On Wed, Dec 21, 2016 at 3:59 PM, Mark Thomas  wrote:
> On 21/12/2016 20:15, Coty Sutherland wrote:
>>> Yes. We need you MoinMoin ID for the Tomcat wiki.
>>
>> Ah. OK, I created an account for the wiki (I didn't see the sign up
>> link before). It's "Coty Sutherland", if you need that.
>
> Is there a space there? I'm assuming not since none of the others have
> one. If it does, we'll need to figure out how to handle that.
>
>>> BZ account name? I'll add you as an admin
>>
>> Awesome, thanks. It's `csuth...@redhat.com`.
>
> You should be able to add components now.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1775523 - /tomcat/site/trunk/docs/whichversion.html

[Coty Sutherland]

> 1). *.html are generated files. Do not edit them manually!

Got it, sorry. Fixed! Thanks for catching that.

> 2). Please add yourself to the following page:

Done.



Cheers,
-Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1775649 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

[Coty Sutherland]

> I believe the committer names are sorted by family name...
> So probably you should not place yourself at last.

Yep, fixed.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Question about Windows zip distro

[Coty Sutherland]

Hi all,

Do we intentionally ship the shell scripts along with the
tomcat-native and commons-daemon-native tarballs in bin for the
Windows distribution?

+++
$ ll apache-tomcat-7.0.73-windows-x64.zip/apache-tomcat-7.0.73/bin/ |
egrep '(tar.gz|sh)$'
-rw-r--r--. 1 coty coty   21646 Nov  7 23:29 catalina.sh
-rw-r--r--. 1 coty coty  204944 Nov  7 23:29 commons-daemon-native.tar.gz
-rw-r--r--. 1 coty coty1922 Nov  7 23:29 configtest.sh
-rw-r--r--. 1 coty coty7888 Nov  7 23:29 daemon.sh
-rw-r--r--. 1 coty coty1965 Nov  7 23:29 digest.sh
-rw-r--r--. 1 coty coty3547 Nov  7 23:29 setclasspath.sh
-rw-r--r--. 1 coty coty1902 Nov  7 23:29 shutdown.sh
-rw-r--r--. 1 coty coty1904 Nov  7 23:29 startup.sh
-rw-r--r--. 1 coty coty  391853 Nov  7 23:29 tomcat-native.tar.gz
-rw-r--r--. 1 coty coty5024 Nov  7 23:29 tool-wrapper.sh
-rw-r--r--. 1 coty coty1908 Nov  7 23:29 version.sh
+++

If not, I can amend the build.xml so that it doesn't include them; I
just thought it looks odd (and would save us 631.9K off the zip size).



Thanks,
Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [ANN] New committer: Emmanuel Bourg

[Coty Sutherland]

Congrats and welcome!

On Fri, Jan 20, 2017 at 12:33 PM, Emmanuel Bourg  wrote:
> Le 20/01/2017 à 18:12, Mark Thomas a écrit :
>> On behalf of the Tomcat committers I am pleased to announce that
>> Emmanuel Bourg (ebourg) has been voted in as a new Tomcat committer.
>>
>> Please join me in welcoming him.
>>
>> Regards,
>>
>> Mark
>
> Thanks a lot for the invitation, I'm very pleased to join and help
> further improving Tomcat. I do solemnly swear that I will, to the best
> of my ability, improve, fix and review the Apache Tomcat code ;)
>
> Emmanuel Bourg
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.41

[Coty Sutherland]

2017-01-19 1:07 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 8.0.41 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1118/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>
> The proposed 8.0.41 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.41

+1

On Mon, Jan 23, 2017 at 11:43 AM, Rémy Maucherat  wrote:
> 2017-01-19 0:07 GMT+01:00 Violeta Georgieva :
>
>> The proposed Apache Tomcat 8.0.41 release is now available for voting.
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1118/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>>
>> The proposed 8.0.41 release is:
>> [ ] Broken - do not release
>> [X] Stable - go ahead and release as 8.0.41
>>
>> Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.75

[Coty Sutherland]

2017-01-18 23:45 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.75 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1117/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>
> The proposed 7.0.75 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.75 Stable

+1

On Mon, Jan 23, 2017 at 12:12 PM, Rémy Maucherat  wrote:
> 2017-01-18 22:45 GMT+01:00 Violeta Georgieva :
>
>> The proposed Apache Tomcat 7.0.75 release is now available for voting.
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1117/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>>
>> The proposed 7.0.75 release is:
>> [ ] Broken - do not release
>> [X] Stable - go ahead and release as 7.0.75 Stable
>>
>> Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1782037 - in /tomcat/tc8.5.x/trunk: conf/catalina.properties java/org/apache/tomcat/util/http/parser/HttpParser.java webapps/docs/changelog.xml webapps/docs/config/systemprops.xml

[Coty Sutherland]

Thanks for the suggestions; I implemented them in http://svn.apache.org/r1782240

On Tue, Feb 7, 2017 at 7:13 PM, Mark Thomas  wrote:
> On 07/02/17 18:13, csuth...@apache.org wrote:
>>
>> Author: csutherl
>> Date: Tue Feb  7 18:13:40 2017
>> New Revision: 1782037
>>
>> URL: http://svn.apache.org/viewvc?rev=1782037&view=rev
>> Log:
>> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60594
>> Adding implementation of whitelist patch
>>
>> Modified:
>> tomcat/tc8.5.x/trunk/conf/catalina.properties
>>
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>> tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
>> tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml
>>
>> Modified: tomcat/tc8.5.x/trunk/conf/catalina.properties
>> URL:
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/conf/catalina.properties?rev=1782037&r1=1782036&r2=1782037&view=diff
>>
>> ==
>> --- tomcat/tc8.5.x/trunk/conf/catalina.properties (original)
>> +++ tomcat/tc8.5.x/trunk/conf/catalina.properties Tue Feb  7 18:13:40 2017
>> @@ -146,3 +146,6 @@ tomcat.util.buf.StringCache.byte.enabled
>>  #tomcat.util.buf.StringCache.char.enabled=true
>>  #tomcat.util.buf.StringCache.trainThreshold=50
>>  #tomcat.util.buf.StringCache.cacheSize=5000
>> +
>> +# Allow for changes to HTTP request validation
>
>
> I'd add here:
>
> # WARNING: Using this option will expose the server to CVE-2016-6816
>
>
>> +#tomcat.util.http.parser.HttpParser.requestTargetAllow=|
>>
>> Modified:
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1782037&r1=1782036&r2=1782037&view=diff
>>
>> ==
>> ---
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>> (original)
>> +++
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>> Tue Feb  7 18:13:40 2017
>> @@ -19,6 +19,9 @@ package org.apache.tomcat.util.http.pars
>>  import java.io.IOException;
>>  import java.io.StringReader;
>>
>> +import org.apache.juli.logging.Log;
>> +import org.apache.juli.logging.LogFactory;
>> +
>>  /**
>>   * HTTP header value parser implementation. Parsing HTTP headers as per
>> RFC2616
>>   * is not always as simple as it first appears. For headers that only use
>> tokens
>> @@ -34,6 +37,8 @@ import java.io.StringReader;
>>   */
>>  public class HttpParser {
>>
>> +private static final Log log = LogFactory.getLog(HttpParser.class);
>> +
>>  private static final int ARRAY_SIZE = 128;
>>
>>  private static final boolean[] IS_CONTROL = new boolean[ARRAY_SIZE];
>> @@ -42,8 +47,22 @@ public class HttpParser {
>>  private static final boolean[] IS_HEX = new boolean[ARRAY_SIZE];
>>  private static final boolean[] IS_NOT_REQUEST_TARGET = new
>> boolean[ARRAY_SIZE];
>>  private static final boolean[] IS_HTTP_PROTOCOL = new
>> boolean[ARRAY_SIZE];
>> +private static final boolean[] REQUEST_TARGET_ALLOW = new
>> boolean[ARRAY_SIZE];
>>
>>  static {
>> +String prop =
>> System.getProperty("tomcat.util.http.parser.HttpParser.requestTargetAllow");
>> +if (prop != null) {
>> +for (int i = 0; i < prop.length(); i++) {
>> +char c = prop.charAt(i);
>> +if (c == '{' || c == '}' || c == '|') {
>> +REQUEST_TARGET_ALLOW[c] = true;
>> +} else {
>> +log.warn("HttpParser: Character '" + c + "' is not
>> allowed and will continue "
>> ++ "being rejected.");
>
>
> This should use the StringManager for i18n support.
>
> Also "... will continue to be rejected." sounds better.
>
>
>> +}
>> +}
>> +}
>> +
>>  for (int i = 0; i < ARRAY_SIZE; i++) {
>>  // Control> 0-31, 127
>>  if (i < 32 || i == 127) {
>> @@ -74,7 +93,9 @@ public class HttpParser {
>>  if (IS_CONTROL[i] || i > 127 ||
>>  i == ' ' || i == '\"' || i == '#' || i == '<' || i ==
>> '>' || i == '\\' ||
>>  i == '^' || i == '`'  || i == '{' || i == '|' || i ==
>> '}') {
>> -IS_NOT_REQUEST_TARGET[i] = true;
>> +if (!REQUEST_TARGET_ALLOW[i]) {
>> +IS_NOT_REQUEST_TARGET[i] = true;
>> +}
>>  }
>>
>>  // Not valid for HTTP protocol
>>
>> Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
>> URL:
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1782037&r1=1782036&r2=1782037&view=diff
>>
>> ==
>> --- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
>> +++ tomcat/tc8.5.x/trunk/w

Re: svn commit: r1782037 - in /tomcat/tc8.5.x/trunk: conf/catalina.properties java/org/apache/tomcat/util/http/parser/HttpParser.java webapps/docs/changelog.xml webapps/docs/config/systemprops.xml

[Coty Sutherland]

> LGTM. Thanks for seeing this through.

Awesome, no problem :)

On Wed, Feb 8, 2017 at 2:46 PM, Mark Thomas  wrote:
> On 08/02/17 19:42, Coty Sutherland wrote:
>>
>> Thanks for the suggestions; I implemented them in
>> http://svn.apache.org/r1782240
>
>
> LGTM. Thanks for seeing this through.
>
> Mark
>
>
>
>>
>> On Tue, Feb 7, 2017 at 7:13 PM, Mark Thomas  wrote:
>>>
>>> On 07/02/17 18:13, csuth...@apache.org wrote:
>>>>
>>>>
>>>> Author: csutherl
>>>> Date: Tue Feb  7 18:13:40 2017
>>>> New Revision: 1782037
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1782037&view=rev
>>>> Log:
>>>> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60594
>>>> Adding implementation of whitelist patch
>>>>
>>>> Modified:
>>>> tomcat/tc8.5.x/trunk/conf/catalina.properties
>>>>
>>>>
>>>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>>>> tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
>>>> tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml
>>>>
>>>> Modified: tomcat/tc8.5.x/trunk/conf/catalina.properties
>>>> URL:
>>>>
>>>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/conf/catalina.properties?rev=1782037&r1=1782036&r2=1782037&view=diff
>>>>
>>>>
>>>> ==
>>>> --- tomcat/tc8.5.x/trunk/conf/catalina.properties (original)
>>>> +++ tomcat/tc8.5.x/trunk/conf/catalina.properties Tue Feb  7 18:13:40
>>>> 2017
>>>> @@ -146,3 +146,6 @@ tomcat.util.buf.StringCache.byte.enabled
>>>>  #tomcat.util.buf.StringCache.char.enabled=true
>>>>  #tomcat.util.buf.StringCache.trainThreshold=50
>>>>  #tomcat.util.buf.StringCache.cacheSize=5000
>>>> +
>>>> +# Allow for changes to HTTP request validation
>>>
>>>
>>>
>>> I'd add here:
>>>
>>> # WARNING: Using this option will expose the server to CVE-2016-6816
>>>
>>>
>>>> +#tomcat.util.http.parser.HttpParser.requestTargetAllow=|
>>>>
>>>> Modified:
>>>>
>>>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>>>> URL:
>>>>
>>>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1782037&r1=1782036&r2=1782037&view=diff
>>>>
>>>>
>>>> ==
>>>> ---
>>>>
>>>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>>>> (original)
>>>> +++
>>>>
>>>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>>>> Tue Feb  7 18:13:40 2017
>>>> @@ -19,6 +19,9 @@ package org.apache.tomcat.util.http.pars
>>>>  import java.io.IOException;
>>>>  import java.io.StringReader;
>>>>
>>>> +import org.apache.juli.logging.Log;
>>>> +import org.apache.juli.logging.LogFactory;
>>>> +
>>>>  /**
>>>>   * HTTP header value parser implementation. Parsing HTTP headers as per
>>>> RFC2616
>>>>   * is not always as simple as it first appears. For headers that only
>>>> use
>>>> tokens
>>>> @@ -34,6 +37,8 @@ import java.io.StringReader;
>>>>   */
>>>>  public class HttpParser {
>>>>
>>>> +private static final Log log = LogFactory.getLog(HttpParser.class);
>>>> +
>>>>  private static final int ARRAY_SIZE = 128;
>>>>
>>>>  private static final boolean[] IS_CONTROL = new
>>>> boolean[ARRAY_SIZE];
>>>> @@ -42,8 +47,22 @@ public class HttpParser {
>>>>  private static final boolean[] IS_HEX = new boolean[ARRAY_SIZE];
>>>>  private static final boolean[] IS_NOT_REQUEST_TARGET = new
>>>> boolean[ARRAY_SIZE];
>>>>  private static final boolean[] IS_HTTP_PROTOCOL = new
>>>> boolean[ARRAY_SIZE];
>>>> +private static final boolean[] REQUEST_TARGET_ALLOW = new
>>>> boolean[ARRAY_SIZE];
>>>>
>>>>  static {
>>>> +String prop =
>&

Re: [GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

[Coty Sutherland]

Can anyone get the validate task to show this error? I think I know
what the problem is, but my local `ant validate` shows no problems...

On Thu, Feb 9, 2017 at 2:07 AM, Bill Barker  wrote:
> To whom it may engage...
>
> This is an automated request, but not an unsolicited one. For
> more information please visit http://gump.apache.org/nagged.html,
> and/or contact the folk at gene...@gump.apache.org.
>
> Project tomcat-tc8.0.x-validate has an issue affecting its community 
> integration.
> This issue affects 1 projects.
> The current state of this project is 'Failed', with reason 'Build Failed'.
> For reference only, the following projects are affected by this:
> - tomcat-tc8.0.x-validate :  Tomcat 8.x, a web server implementing the 
> Java Servlet 3.1,
> ...
>
>
> Full details are available at:
> 
> http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/index.html
>
> That said, some information snippets are provided here.
>
> The following annotations (debug/informational/warning/error messages) were 
> provided:
>  -DEBUG- Dependency on checkstyle exists, no need to add for property 
> checkstyle.jar.
>  -INFO- Failed with reason build failed
>
>
>
> The following work was performed:
> http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate.html
> Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate (Type: Build)
> Work ended in a state of : Failed
> Elapsed: 19 secs
> Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
> -Dbuild.sysclasspath=only org.apache.tools.ant.Main 
> -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
> -Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
> -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar
>  -Dexecute.validate=true validate
> [Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
> CLASSPATH: 
> /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170209.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNA!
>  PSHOT.jar
>  
> :/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20170209.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170209.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-22.0-SNAPSHOT.jar
> -
> Buildfile: /srv/gump/public/workspace/tomcat-8.0.x/build.xml
>
> build-prepare:
>[delete] Deleting directory 
> /srv/gump/public/workspace/tomcat-8.0.x/output/build/temp
> [mkdir] Created dir: 
> /srv/gump/public/workspace/tomcat-8.0.x/output/build/temp
>
> compile-prepare:
>
> download-validate:
>
> testexist:
>  [echo] Testing  for 
> /srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar
>
> setproxy:
>
> downloadfile:
>
> validate:
> [mkdir] Created dir: 
> /srv/gump/public/workspace/tomcat-8.0.x/output/res/checkstyle
> [checkstyle] Running Checkstyle 7.6-SNAPSHOT on 3016 files
> [checkstyle] [ERROR] 
> /srv/gump/public/workspace/tomcat-8.0.x/java/org/apache/tomcat/util/http/parser/HttpParser.java:25:
>  Extra separation in import group before 
> 'org.apache.tomcat.util.res.StringManager' [ImportOrder]
>
> BUILD FAILED
> /srv/gump/public/workspace/tomcat-8.0.x/build.xml:552: Got 1 errors and 0 
> warnings.
>
> Total time: 19 seconds
> -
>
> To subscribe to this information via syndicated feeds:
> - RSS: 
> http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/rss.xml
> - Atom: 
> http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/atom.xml
>
> == Gump Tracking Only ===
> Produced by Apache Gump(TM) version 2.3.
> Gump Run 20170209060011, vmgump-vm3.apache.org:vmgump:20170209060011
> Gump E-mail Identifier (unique within run) #3.
>
> --
> Apache Gump
> http://gump.apache.org/ [Instance: vmgump-vm3]
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.18

[Coty Sutherland]

On Wed, Oct 17, 2018 at 6:19 PM Mark Thomas  wrote:

> Version 1.2.18 includes the following changes compared to 1.2.17:
>
> - Windows binaries built with OpenSSL 1.0.2p and APR 1.6.5
> - Windows binaries built with OpenSSL 1.1.1 and APR 1.6.5
> - TLSv1.3 support when built with OpenSSL 1.1.1
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.18 is
>  [x] Stable, go ahead and release
>  [ ] Broken because of ...
>

+1, tested with openssl-1.1.0i-fips and apr-1.6.3 on fc28.


>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.18/
> [2]
> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_18
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: "Embedded" improvements

[Coty Sutherland]

I had a trivial comment that I put on the GitHub commit :) Otherwise that
looks OK to me.

On Wed, Oct 24, 2018 at 5:55 AM Rémy Maucherat  wrote:

> Hi,
>
> I'm starting to review embedded. Maybe I won't make many changes in the end
> and won't need a separate API.
>
> However, I have another post 9.0.13 refactoring with a redoing of
> ConfigFileLoader and various places which try to load the configuration
> from seemingly random locations (the winner is "server-embed.xml", which
> IMO everyone forgot about aeons ago). So this redoes it with a pluggable
> API as ConfigFileLoader was not. Minor additional work is needed to use it
> in more places, since all configuration/resource loading from conf would
> need to go through it (ideally) (and except logging, since it's obviously
> pluggable enough).
>
>
> https://github.com/rmaucher/tomcat/commit/c386eb2fc3b2f42b3a307cbc2d0ab1a72581f56a
>
> Comments ?
>
> Rémy
>

Re: [VOTE] Release Apache Tomcat 9.0.13

[Coty Sutherland]

On Fri, Nov 2, 2018 at 12:11 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.13 release is now available for voting.
>
> The major changes compared to the 9.0.13 release are:
>
> - support for TLSv1.3 when used with a JRE or OPenSSl version that
>   supports it
>
> - added support for encrypting cluster traffic
>
> - added automatic reloading of tomcat-users.xml after a change
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.13/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1196/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_13/
>
> The proposed 9.0.13 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 9.0.13
>

+1


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 7.0.92

[Coty Sutherland]

On Fri, Nov 9, 2018 at 6:34 AM Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.92 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.92/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1198/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_92/
>
> The proposed 7.0.92 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.92 Stable
>

+1, LGTM :)


>
> Regards,
> Violeta
>

Re: [VOTE] Release Apache Tomcat Native 1.2.19

[Coty Sutherland]

On Fri, Nov 30, 2018 at 3:00 PM Mark Thomas  wrote:

> Version 1.2.19 includes the following changes compared to 1.2.18:
>
> - Windows binaries built with OpenSSL 1.0.2q and APR 1.6.5
> - Windows binaries built with OpenSSL 1.1.1a and APR 1.6.5
> - Fixed memory leak associated with OCSP
> - Fix an error that prevented the use of TLS 1.0 and 1.1 if 1.3 was
>   available
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.19 release is
>  [x] Stable, go ahead and release
>  [ ] Broken because of ...
>

+1


>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.19/
> [2]
> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_19
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 9.0.14

[Coty Sutherland]

On Thu, Dec 6, 2018 at 4:37 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.14 release is now available for voting.
>
> The major changes compared to the 9.0.13 release are:
>
> - Significant expansion of localisation support with the addition of
>   Brazilian Portuguese, Korean and Chinese (simplified) as well as
>   the expansion of coverage for existing languages
>
> - Refactor back ground processing and various independent thread pools
>   to use a common executor
>
> - Update the packaged version of the Tomcat Native Library to 1.2.19 to
>   pick up the latest Windows binaries built with APR 1.6.5 and OpenSSL
>   1.1.1a.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.14/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1199/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_14/
>
> The proposed 9.0.14 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 9.0.14
>

+1


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Deploying JK Site Docs

[Coty Sutherland]

Hi,

I made a bunch of changes to the JK site yesterday so that it uses the
updated Tomcat site's stylesheets to unify the UI between the two project
sites. Unfortunately, I can't figure out how to deploy it. The
HOWTO-RELEASE.txt doc says to copy the build/docs output
to people.apache.org:/x1/www/tomcat.apache.org/connectors-doc, but that
doesn't seem to exist anymore? Can anyone help me deploy these changes? Or
should I revert them and leave it be haha



Thanks,
Coty

Re: Deploying JK Site Docs

[Coty Sutherland]

Thanks!

On Fri, Dec 14, 2018 at 12:22 PM Mark Thomas  wrote:

> On 14/12/2018 17:16, Coty Sutherland wrote:
> > Hi,
> >
> > I made a bunch of changes to the JK site yesterday so that it uses the
> > updated Tomcat site's stylesheets to unify the UI between the two project
> > sites.
>
> A very welcome change.
>

I noticed it was older and thought it would be pretty quick/easy to
update...I proved myself wrong on that one :)


>
> > Unfortunately, I can't figure out how to deploy it. The
> > HOWTO-RELEASE.txt doc says to copy the build/docs output
> > to people.apache.org:/x1/www/tomcat.apache.org/connectors-doc, but that
> > doesn't seem to exist anymore? Can anyone help me deploy these changes?
> Or
> > should I revert them and leave it be haha
>
> That is VERY out of date.
>

Should that text file be removed? I haven't tried any of the other stuff,
but the docs in JK are way outdated in a lot of places (i.e. refs to httpd
1.3 and Windows 98).


>
> Try these instructions:
> https://svn.apache.org/viewvc/tomcat/site/trunk/README.txt?view=markup


That worked. After pushing I notice that I broke the links in the navbar,
so fixing that now.


>
>
> Ping the list if you have more questions.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: svn commit: r1849118 [1/9] - in /tomcat/site/trunk/docs/connectors-doc: ./ ajp/ ajp/printer/ common_howto/ common_howto/printer/ miscellaneous/ miscellaneous/printer/ news/ news/printer/ printer/

[Coty Sutherland]

On Mon, Dec 17, 2018, 18:21 Mark Thomas  +1
>
> Very nice.


Thanks! I'm glad I was about to sort out the link problem. Apparently it
was broken before I touched it :) There is a bunch of other little stuff to
fix and some doc updates so I'll be pushing more things as I have time.


> Mark
>
>
> On 17/12/2018 19:15, Rainer Jung wrote:
> > Looks great, thanks!
>

I'm happy to help!

>
> > Regards,
> >
> > Rainer
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat Native 1.2.16

[Coty Sutherland]

On Nov 17, 2017 06:24, "Rainer Jung"  wrote:

Am 15.11.2017 um 12:03 schrieb Mark Thomas:

> Version 1.2.16 includes the following changes compared to 1.2.14:
>
> - Update minimum recommended OpenSSL version to 1.0.2m
> - Update minimum recommended APR version to 1.6.3
> - Windows binaries built with OpenSSL 1.0.2m and APR 1.6.3
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.16 is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

+1 to release, thanks for RMing.

3 minor remarks:

- there's a new empty top-level "bin" folder. It also exists as an empty
folder in svn.

- the functional changes are mostly in OCSP and that is probably not really
being used by our TC unit tests


+1, we don't have any documentation around it either. There should be a PR
to remedy the doc issue soon, I'll see if the contributor also wants to
propose a test.


- it seems to me that on Unix/Linux OCSP support is always active if
OpenSSL supports it, but on Windows one needs to enable it. We should
probably sync that behavior before the next release. I currently don't see
a reason, why the platforms should behave differently.


+1. That's what I was getting at with my OCSP thread on the users list.
Also the download page mentions that OCSP support ok Windows is
experimental, if that isn't true it needs an update.



- Tested with APR 1.6.3, OpenSSL 1.0.2m and 1.1.0g,
  and unit tests of TC 8.5 head
- Platforms Solaris 10 Sparc, SLES 11 and 12 64 Bit, RHEL 6 and 7 64 Bits
- configure flag "--enable-maintainer-mode"
- make with gcc 7.2.0 on Solaris and platform gcc on Linux
- Using Java version 1.8.0_144 64 Bit
  - Using "-XX:-UseCompressedClassPointers" on 64 Bit Linux
- SHA1 and MD5 OK
- signatures OK
- gz and zip for sources consistent
- source dist consistent with svn tag
- config.guess and config.sub from apr 1.6.3 (copied by buildconf)
  from this year (OK).
- VERSIONS says OpenSSL 1.0.2m and APR 1.6.3
- recreated release with jnirelease script, results are
  consistent with source dist, except for minor expected diffs in
  generated docs
- make succeeds and builds lib
  - no C warnings
- unit test results for TC
  - no failures

Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.24

[Coty Sutherland]

On Mon, Nov 27, 2017 at 8:46 AM, Mark Thomas  wrote:
> The proposed Apache Tomcat 8.5.24 release is now available for voting.
>
> The major changes compared to the 8.5.23 release are:
>
> - Java 9 is fully supported
>
> - Fixed a number of HTTP/2 issues
>
> - Fixed numerous JASPIC issues with patches from Lazar
>
> - Update the packaged version of the Tomcat Native Library to
>   1.2.16 to pick up the latest Windows binaries built with
>   APR 1.6.3 and OpenSSL 1.0.2m
>
>
> Along with lots of other bug fixes and improvements.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.24/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1161/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_24/
>
> The proposed 8.5.24 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.24

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.2

[Coty Sutherland]

On Sat, Nov 25, 2017 at 4:36 PM, Mark Thomas  wrote:
> The proposed Apache Tomcat 9.0.2 release is now available for voting.
>
> The major changes compared to the 9.0.1 release are:
>
> - Java 9 is fully supported
>
> - Fixed numerous JASPIC issues with patches from Lazar
>
> - Update the packaged version of the Tomcat Native Library to
>   1.2.16 to pick up the latest Windows binaries built with
>   APR 1.6.3 and OpenSSL 1.0.2m
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.2/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1160/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_2/
>
> The proposed 9.0.2 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 9.0.2
> [x] Beta   - go ahead and release as 9.0.2

+1

> [ ] Stable - go ahead and release as 9.0.2
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Migrating to git

[Coty Sutherland]

On Tue, Dec 5, 2017 at 3:43 PM, Emmanuel Bourg  wrote:
> Le 05/12/2017 à 21:03, Mark Thomas a écrit :
>
>> and then migrate /trunk, /tags and /branches to git, leaving the rest in
>> place. Most will stay there. Some components may move to git in the future.
>
> The goal is to put all Tomcat versions in the same Git repository right?
> Would that make the svn tags available as git tags or git branches? Is
> svn2git able to aggregate several tags directories (tags/tc7.0.x/*,
> tags/tc8.0.x/, etc) ? If not the tags could probably be merged in the
> same directory before the migration.

I'm +1 for this, but had the same questions. I think taking this
opportunity to consolidate the repos into one (especially on github)
if possible would help with new contributors given questions I've seen
on freenode.

> Emmanuel Bourg
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.48

[Coty Sutherland]

On Thu, Nov 30, 2017 at 12:19 PM, Violeta Georgieva
 wrote:
> The proposed Apache Tomcat 8.0.48 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.48/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1162/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_48/
>
> The proposed 8.0.48 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.48

+1

> Regards,
> Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.83

[Coty Sutherland]

On Thu, Nov 30, 2017 at 2:37 PM, Violeta Georgieva  wrote:
> The proposed Apache Tomcat 7.0.83 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.83/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1163/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_83/
>
> The proposed 7.0.83 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.83 Stable

+1

> Regards,
> Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: GC allocation failure

[Coty Sutherland]

This is a question for the users list, not the developers list. From
http://tomcat.apache.org/lists.html#tomcat-dev:

"This development list is only for discussion of changes to the Apache
Tomcat source code and related issues. Other questions will be
ignored."

On Thu, Jan 4, 2018 at 11:05 AM, Sanka, Ambica  wrote:
> I am seeing below highlighted errors in native_err logs in all my tomcat 
> applications. I also increased memory for the VM from 4GB to 8GB. Still 
> seeing those. When do we get that errors?
> I am reading online that when program asks for memory and java cannot give, 
> that's when we see them. Please suggest.
> Java HotSpot(TM) 64-Bit Server VM (25.20-b23) for linux-amd64 JRE 
> (1.8.0_20-b26), built on Jul 30 2014 13:13:52 by "java_re" with gcc 4.3.0 
> 20080428 (Red Hat 4.3.0-8)
> Memory: 4k page, physical 8061572k(2564740k free), swap 4063228k(4063228k 
> free)
> CommandLine flags: -XX:+HeapDumpOnOutOfMemoryError 
> -XX:HeapDumpPath=/opt/apache/ancillariesmonitoring/logs/ 
> -XX:InitialHeapSize=128985152 -XX:MaxHeapSize=268435456 -XX:+PrintGC 
> -XX:+PrintGCTimeStamps -XX:+UseCompressedClassPointers -XX:+UseCompressedOops 
> -XX:+UseParallelGC
> 3.203: [GC (Allocation Failure)  31744K->6311K(121856K), 0.0097261 secs]
> 3.578: [GC (Allocation Failure)  38055K->12368K(121856K), 0.0089875 secs]
> 3.756: [GC (Allocation Failure)  44112K->19589K(121856K), 0.0100339 secs]
> 3.897: [GC (Allocation Failure)  51333K->25872K(153600K), 0.0092326 secs]
> 4.172: [GC (Allocation Failure)  89360K->38878K(153600K), 0.0152940 secs]
> 4.417: [GC (Allocation Failure)  102366K->50311K(148480K), 0.0148816 secs]
> 4.594: [GC (Allocation Failure)  95367K->49903K(151040K), 0.0197327 secs]
> 4.765: [GC (Allocation Failure)  94959K->50213K(148992K), 0.0149008 secs]
> 4.946: [GC (Allocation Failure)  96293K->52257K(150528K), 0.0172634 secs]
> 5.129: [GC (Allocation Failure)  98337K->53118K(151040K), 0.0139426 secs]
> 5.313: [GC (Allocation Failure)  102270K->53234K(152064K), 0.0122307 secs]
> 5.498: [GC (Allocation Failure)  102386K->53579K(153088K), 0.0166336 secs]
> 5.655: [GC (Allocation Failure)  104779K->54486K(153600K), 0.0161735 secs]
> 6.885: [GC (Allocation Failure)  105686K->51523K(153600K), 0.0123126 secs]

In the spirit of helpfulness, see the first result for googling "GC
(Allocation Failure)",
https://stackoverflow.com/questions/28342736/java-gc-allocation-failure
;)

If you have further questions, direct them to the users list please.

>
> Thanks
> Ambica.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Git migration] trunk or master

[Coty Sutherland]

On Jan 8, 2018 09:33, "Mark Thomas"  wrote:

This is the third of the per issue e-mails to discuss the issues
associated with migrating from svn to git.

The standard name for the main branch where development takes place in
svn is 'trunk'. In git the standard name is 'master'.

We can use either of these going forwards. Or something completely
different.

We need to pick a name.

Thoughts?


+1 for following the git standard of master.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.3

[Coty Sutherland]

On Thu, Jan 11, 2018 at 6:29 AM, Mark Thomas  wrote:
> The proposed Apache Tomcat 9.0.3 release is now available for voting.
>
> The major changes compared to the 9.0.2 release are:
>
> - Modify the Default and WebDAV Servlets so that a 405 status code is
>   returned for PUT and DELETE requests when disabled via the readonly
>   initialisation parameter.
>
> - Add support for GZIP compression with HTTP/2
>
> - Expand the TLS functionality exposed via the Manager application
>
> - Return a simple, plain text error message if a client attempts to make
>   a plain text HTTP connection to a TLS enabled NIO or NIO2 Connector.
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.3/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1164/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_3/
>
> The proposed 9.0.3 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 9.0.3
> [ ] Beta   - go ahead and release as 9.0.3
> [x] Stable - go ahead and release as 9.0.3

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Git migration] Existing PRs

[Coty Sutherland]

On Thu, Jan 18, 2018 at 3:40 PM, Mark Thomas  wrote:
> Hi,
>
> This issue might have resolved itself. We currently only have open PRs
> on the apache/tomcat github repo. Assuming that repo would be made
> read/write (I'm checking with infra) then there isn't a problem.
>
> If anyone opnes a PR on one of the other repos between now and migration
> we can simply ask then to redo the PR against apache/tomcat
>
> Thoughts?

Yeah, I think asking them to move it is fine.

> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.4

[Coty Sutherland]

On Thu, Jan 18, 2018 at 3:14 PM, Mark Thomas  wrote:
> The proposed Apache Tomcat 9.0.4 release is now available for voting.
>
> The major changes compared to the 9.0.2 release are:
>
> - Modify the Default and WebDAV Servlets so that a 405 status code is
>   returned for PUT and DELETE requests when disabled via the readonly
>   initialisation parameter.
>
> - Add support for GZIP compression with HTTP/2
>
> - Expand the TLS functionality exposed via the Manager application
>
> - Return a simple, plain text error message if a client attempts to make
>   a plain text HTTP connection to a TLS enabled NIO or NIO2 Connector.
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.4/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1166/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_4/
>
> The proposed 9.0.4 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 9.0.4
> [ ] Beta   - go ahead and release as 9.0.4
> [x] Stable - go ahead and release as 9.0.4

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.27

[Coty Sutherland]

On Thu, Jan 18, 2018 at 3:43 PM, Mark Thomas  wrote:
> The proposed Apache Tomcat 8.5.27 release is now available for voting.
>
> The major changes compared to the 8.5.24 release are:
>
> - Add support for GZIP compression with HTTP/2
>
> - Expand the TLS functionality exposed via the Manager application
>
> - Return a simple, plain text error message if a client attempts to make
>   a plain text HTTP connection to a TLS enabled NIO or NIO2 Connector.
>
> - Add a new system property
>   (org.apache.jasper.runtime.BodyContentImpl.BUFFER_SIZE) to control the
>   size of the buffer used by Jasper when buffering tag bodies.
>
>
> Along with lots of other bug fixes and improvements.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1167/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_27/
>
> The proposed 8.5.27 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.27

+1

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.84

[Coty Sutherland]

On Fri, Jan 19, 2018 at 10:41 AM, Violeta Georgieva
 wrote:
> The proposed Apache Tomcat 7.0.84 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.84/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1168/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_84/
>
> The proposed 7.0.84 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.84 Stable

+1

> Regards,
> Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.49

[Coty Sutherland]

On Fri, Jan 19, 2018 at 4:08 PM, Violeta Georgieva  wrote:
> The proposed Apache Tomcat 8.0.49 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.49/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1169/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_49/
>
> The proposed 8.0.49 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.49

+1

> Regards,
> Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Migrating to git

[Coty Sutherland]

I think this is the right thread to add this :)

Given that we will be able to accept PRs on Github after this
migration, do we want to add a Travis (or other CI) configuration to
our repository so that it will do a test build (and maybe test one
connector) when someone proposes a pull? Doing that will ensure we get
all of the new code accepted by PRs tested without manual intervention
or waiting for the ASF build infrastructure to do it. You can make
passing the tests a condition to accept the PR too I believe.

On Wed, Dec 13, 2017 at 8:52 AM, Rémy Maucherat  wrote:
> On Wed, Dec 13, 2017 at 10:23 AM, Mark Thomas  wrote:
>
>> The plan is to switch to "github as master' which is actually a dual
>> master system where commits can be made directly to either github or the
>> ASF. I don't think it matter which we use. My (not recent) experience is
>> that github is faster.
>>
>> Nice setup.
>
> Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Migrating to git

[Coty Sutherland]

On Wed, Jan 24, 2018 at 4:57 PM, Christopher Schultz
 wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Coty,
>
> On 1/24/18 1:34 PM, Coty Sutherland wrote:
>> I think this is the right thread to add this :)
>>
>> Given that we will be able to accept PRs on Github after this
>> migration, do we want to add a Travis (or other CI) configuration
>> to our repository so that it will do a test build (and maybe test
>> one connector) when someone proposes a pull? Doing that will ensure
>> we get all of the new code accepted by PRs tested without manual
>> intervention or waiting for the ASF build infrastructure to do it.
>> You can make passing the tests a condition to accept the PR too I
>> believe.
>
> Could this "feature" be used to DOS some host(s)? If every PR causes a
> checkout/compile/test cycle, it could get "expensive".

Possibly, but my thoughts were to use travis (https://travis-ci.org/)
which has it's own hosts and such that we won't need to worry about.
Travis also allows you to limit concurrent builds and even limit it to
only building PRs. Were you worried about the potential for DoSing ASF
infra? I just pushed a test .travls.yml in my tomcat fork
(https://github.com/csutherl/tomcat/blob/trunk/.travis.yml) so I could
play with it a bit.

> - -chris
> -BEGIN PGP SIGNATURE-
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQJRBAEBCAA7FiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlppAVQdHGNocmlzQGNo
> cmlzdG9waGVyc2NodWx0ei5uZXQACgkQHPApP6U8pFjBPg/+LywMRfUig0DsOkAt
> StgtY8dvvBJJyf9H9pQM8cqnjWx/nfKhvGhaaHgCd8ftfynM3k8I9X4iImKlRRhN
> xKCRbXyIr7QsCkbUDZqzVoTQeYE3A0OHSgo5kKlauI0+nrFPaoJW0fSAx9Gd4npV
> cV4PPsKokYiBbFl8/7q9taZ/FP0wB5QWf3hN1QEUFVyhlKzKhouB+dxmnzZzgBFS
> NRBFViOygJvYV299Jcg8UlyFC4HCfLy+L7uFsS5pf7MO29TG71xEMVrdNiMihz+j
> TxWG2n6AAK1fu0HS4GTIcan4zQUDtDoQB9VJD1TwOYQATgJQlNQbvaZvMk/+n6Gu
> WieMrGyLbJfix7asgv4qkQ80TyCTdQ1M3Ab4afrP0YGVzqIXRKFoyHQgiTZXgs6k
> de5Y6uFOgDna13up596BFKL94QkRyirAPXasVbB4QSuynmGiGCpAf7S+KHXb/T5W
> Ro2Zs1bHj1vTFB46NqGNJCjXC21ZmvPoujil7evohNc0vEVFNFLqsqcta2A30D6n
> +Yp/tbmDzY0xAl1Rp7BEUKVndzIWofvbQ08A41qWLMWTG1n16FjUQJg3xO3YHcDZ
> Oy0gWDnYvQlQnFKZs4bRCLle36dkAcZ2GzCwBELbxKKwiXk+mLS+Fz05YGG2BMYt
> 7GOhLV/GMhrz2Rs0MEzWgxlKhes=
> =ZVjJ
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [ANN] New committer: Woonsan Ko

[Coty Sutherland]

Congratulations and Welcome Woonsan!

On Wed, Dec 19, 2018 at 9:08 PM Keiichi Fujino  wrote:

> Congratulations!
> Welcome Woonsan!
>
> 2018年12月19日(水) 18:56 Mark Thomas :
>
> > On behalf of the Tomcat committers I am pleased to announce that
> > Woonsan Ko (woonsan) has been voted in as a new Tomcat committer.
> >
> > Please join me in welcoming him.
> >
> > Kind regards,
> >
> > Mark
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>
> --
> Keiichi.Fujino
>

tomcat-native include directory name

[Coty Sutherland]

Hi all,

Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
include directory instead of tomcat-native? I just pushed
http://svn.apache.org/r1849428 so that make now copies the header files
into _includedir, and noticed that the directory is named 'apr' rather than
'tomcat-native'.

$ grep includedir native/config.layout
includedir:${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
includedir:${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
includedir:${prefix}/include
includedir:${prefix}/include+
includedir:
/System/Library/Frameworks/apr.framework/Versions/2.0/Headers
includedir:${prefix}/include+
includedir:${prefix}/include/apr
includedir:${prefix}/include
includedir:${prefix}/include
includedir:${prefix}/include/apr
includedir:${exec_prefix}/include/apr
includedir:${exec_prefix}/include
includedir:${exec_prefix}/lib/apr/include
includedir:${exec_prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}



Thanks,
Coty

Re: tomcat-native include directory name

[Coty Sutherland]

On Sun, Dec 23, 2018 at 4:57 AM Mark Thomas  wrote:

> On 20/12/2018 19:51, Coty Sutherland wrote:
> > Hi all,
> >
> > Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
> > include directory instead of tomcat-native? I just pushed
> > http://svn.apache.org/r1849428 so that make now copies the header files
> > into _includedir, and noticed that the directory is named 'apr' rather
> than
> > 'tomcat-native'.
>
> If I had to guess, I'd say because the original file was copied from APR
> and that part was never changed.
>

Should fixing that be considered a breaking change and therefore trigger a
minor update instead of a revision? Or can I just change it and move on
with life? :)


>
> Mark
>
>
> >
> > $ grep includedir native/config.layout
> > includedir:${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> > includedir:${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> > includedir:${prefix}/include
> > includedir:${prefix}/include+
> > includedir:
> > /System/Library/Frameworks/apr.framework/Versions/2.0/Headers
> > includedir:${prefix}/include+
> > includedir:${prefix}/include/apr
> > includedir:${prefix}/include
> > includedir:${prefix}/include
> > includedir:${prefix}/include/apr
> > includedir:${exec_prefix}/include/apr
> > includedir:${exec_prefix}/include
> > includedir:${exec_prefix}/lib/apr/include
> > includedir:${exec_prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> >
> >
> >
> > Thanks,
> > Coty
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: tomcat-native include directory name

[Coty Sutherland]

On Tue, Jan 8, 2019 at 7:06 PM Mark Thomas  wrote:

> On 08/01/2019 19:53, Coty Sutherland wrote:
> > On Sun, Dec 23, 2018 at 4:57 AM Mark Thomas  wrote:
> >
> >> On 20/12/2018 19:51, Coty Sutherland wrote:
> >>> Hi all,
> >>>
> >>> Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
> >>> include directory instead of tomcat-native? I just pushed
> >>> http://svn.apache.org/r1849428 so that make now copies the header
> files
> >>> into _includedir, and noticed that the directory is named 'apr' rather
> >> than
> >>> 'tomcat-native'.
> >>
> >> If I had to guess, I'd say because the original file was copied from APR
> >> and that part was never changed.
> >>
> >
> > Should fixing that be considered a breaking change and therefore trigger
> a
> > minor update instead of a revision? Or can I just change it and move on
> > with life? :)
>
> What could break if you changed this? Isn't it a build time thing rather
> than a run time thing?
>

You're right. I was thinking of this with my package maintainer hat on,
however after checking the package it doesn't depend on that directory
specifically so I think I'm free to correct it.


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Migrate to git

[Coty Sutherland]

On Thu, Feb 21, 2019 at 11:13 AM Mark Thomas  wrote:

> This is a VOTE to migrate the primary source code repository for Apache
> Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git.
>
> The migration will be performed as per:
> https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration
>
> with the following changes:
> - 8.0.x will not be migrated
> - the tag name format will be changed from "TOMCAT_9_0_5" to "9.0.5"
> - the branches will be named master, 8.5.x and 7.0.x
>
> The proposed date (subject to Infra agreement) for the migration is 26
> Feb 2018.
>
> The migration process will be:
> - Make svn read only for trunk, 8.5.x and 7.0.x
> - Turn off the svn->git replication for trunk, 8.5.x and 7.0.x
> - Make git://git.apache.org/tomcat.git read/write for me only
> - Perform the migration as set out in the wiki with the modifications
>   described above
> - Check the migration
> - Make git://git.apache.org/tomcat.git read/write for all committers
>   (Note: This automatically makes https://github.com/apache/tomcat
>read/write as well)
>
> The critical work is done at this point. The following tasks are more
> clean-up and may end up being spread over several days.
>
> - Confirm there are no open PRs for https://github.com/apache/tomcat85
>   and then delete it and git://git.apache.org/tomcat85.git
> - Confirm there are no open PRs for https://github.com/apache/tomcat70
>   and then delete it and git://git.apache.org/tomcat70.git
> - Update the CI systems to pull the source from git
> - Create /source.html and replace /svn.html with a redirect to
>   /source.html
> - Update migration guide to pull diffs from gitweb
> - Update Tomcat Native to pull in source from git hash
> - Fix anything else we have forgotten about.
>
> If anything goes wrong and we can't fix is easily, the fallback is to
> make svn read-write and go back to using svn while we clean up the git
> side of things, figure out what went wrong and come up with a better
> migration plan.
>
> [x] +1 Go ahead with the migration
>

+1


> [ ] -1 Postpone the migration because...
>
> The vote will be open for at least 72 hours.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: New git based merging workflow?

[Coty Sutherland]

On Thu, Feb 28, 2019 at 6:10 AM Emmanuel Bourg  wrote:

> Le 28/02/2019 à 11:47, Rainer Jung a écrit :
> > Thanks a bunch. Looks like what I was searching for, will try it.
> >
> > Rainer
>
> You could play with a single repository too:
>

+1, that's what I do.


>
>   # Initial setup
>   cd ~/repos
>   git clone g...@github.com:apache/tomcat.git
>
>   # Commit...
>   cd ~/repos/tomcat
>   # edit files
>   git commit -a -m "Some message"
>   git push
>
>   # ...and backport
>   git checkout 8.5.x
>   git cherry-pick 
>   git push origin 8.5.x
>
>   git checkout master
>

Sometimes I also create a local branch to do the work in so that I don't
have to worry about putting everything in one commit from the start. After
I'm done with the bug/feature, then I squash that whole local branch into
one commit and merge it into master (or whatever branch). From there you
can cherry-pick that single commit to wherever it's needed.


>
> Emmanuel Bourg
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Git migration read for testing

[Coty Sutherland]

The email notifications work for when we push commits to the repository,
but it looks like we're missing emails when PRs are opened.

On Wed, Feb 27, 2019 at 9:03 AM Rémy Maucherat  wrote:

> On Wed, Feb 27, 2019 at 11:09 AM Mark Thomas  wrote:
>
> > On 27/02/2019 09:44, Rémy Maucherat wrote:
> > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas  wrote:
> > >
> > >> All,
> > >>
> > >> https://github.com/apache/tomcat
> > >
> > >
> > > Trying my test commit, I can't push to the github repo. I probably
> missed
> > > something obvious.
> >
> > You need to make sure you have three green ticks here:
> > https://gitbox.apache.org/setup/
> >
> > If you haven't linked your ASF and GitHub accounts or setup MFA then it
> > can take an hour or so after you make those changes for write access to
> > be enabled (various systems need to sync in the background).
> >
>
> I had forgotten about this as the Tomcat repo commit info was already
> linked to my account. Thanks for the help !
>
> Rémy
>
>
> >
> > Mark
> >
> >
> > >
> > > Rémy
> > >
> > >
> > >>
> > >>
> > >> is now ready for testing.
> > >>
> > >> It should contain:
> > >> branches
> > >> - master (9.0.x)
> > >> - 8.5.x
> > >> - 7.0.x
> > >>
> > >> Tags:
> > >> - one for each 7.0.x, 8.5.x and 9.0.x release
> > >>
> > >> Tags have all been renamed to follow a a.b.c-MODIFIERn format for
> > >> version number where modifier is RC or M.
> > >>
> > >> The repository is probably read/write for all committers now but
> please
> > >> refrain from making any changes until we confirm that all is well.
> > >>
> > >> If you have some time available now, please test this new repository
> and
> > >> report and questions or concerns to this thread.
> > >>
> > >> Assuming no issues are discovered, I'd like to formally move over to
> git
> > >> later today.
> > >>
> > >> Mark
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> > >>
> > >>
> > >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>

Git Migration: What is the svn:eol-style equilvalent?

[Coty Sutherland]

Hi,

I updated the BUILDING and CONTRIBUTING documents so that GitHub users no
longer see instructions for SVN after our migration, however I had a few
questions. Does anyone know of a git equivalent to svn:eol-style that we
should be using? It is mentioned in the "git-svn quirks" section of
https://wiki.apache.org/general/GitAtApache, but before trying it I wanted
to get some feedback from everyone.

Secondly, the SVN references in MERGE.txt should be cleaned up at this
point, right? Is the git section still up to date (I see it was updated
last on Jan 29, so probably)?



Thanks!
Coty

Re: GitHub Issues / GitHub PRs / Bugzilla

[Coty Sutherland]

On Thu, Mar 14, 2019 at 8:39 AM Mark Thomas  wrote:

> It is early days but my impression is that the move to git has triggered
> an increase in conversations that end up split between a GitHub PR and
> Bugzilla.
>
> Personally, I'm not finding it unmanageable at this point but it does
> feel a little disorganized.
>

+1, I was just thinking about this earlier while trying to follow some
conversations.


>
> I'm wondering if we need clearer guidelines about what to discuss where
> or do we need something else? What about a bigger change such as moving
> issue tracking to GitHub? Would that be beneficial?
>

I agree that we should probably outline the best way to carry on
conversations now that we have the possibility of dev/user list, BZ, and
PRs; I'm not sure what exactly that would look like though. Is there a way
to push links from PR comments into BZ (that's how GitHub does it with PRs
and issues IIRC) to retain the conversation flow? Moving to GitHub's issue
tracker is an interesting solution. I think that the issue tracker is
robust enough that we wouldn't have any issues moving over, but is that OK
in the eyes of the ASF Infra team? How would we be archiving those
conversations (assuming that we need to)?


>
> What do others think?
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: GitHub Issues / GitHub PRs / Bugzilla

[Coty Sutherland]

On Thu, Mar 14, 2019 at 11:14 AM Coty Sutherland 
wrote:

> On Thu, Mar 14, 2019 at 8:39 AM Mark Thomas  wrote:
>
>> It is early days but my impression is that the move to git has triggered
>> an increase in conversations that end up split between a GitHub PR and
>> Bugzilla.
>>
>> Personally, I'm not finding it unmanageable at this point but it does
>> feel a little disorganized.
>>
>
> +1, I was just thinking about this earlier while trying to follow some
> conversations.
>
>
>>
>> I'm wondering if we need clearer guidelines about what to discuss where
>> or do we need something else? What about a bigger change such as moving
>> issue tracking to GitHub? Would that be beneficial?
>>
>
> I agree that we should probably outline the best way to carry on
> conversations now that we have the possibility of dev/user list, BZ, and
> PRs; I'm not sure what exactly that would look like though. Is there a way
> to push links from PR comments into BZ (that's how GitHub does it with PRs
> and issues IIRC) to retain the conversation flow? Moving to GitHub's issue
> tracker is an interesting solution. I think that the issue tracker is
> robust enough that we wouldn't have any issues moving over, but is that OK
> in the eyes of the ASF Infra team? How would we be archiving those
> conversations (assuming that we need to)?
>

Apache CloudStack instructs people to use Jira (which mostly has GSoC
issues), but also has several issues reported on the GitHub issue tracker;
there doesn't seem to be any integration between the two. They use a nice
template for issues on GitHub too.


>
>
>>
>> What do others think?
>>
>> Mark
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>

commons-daemon packaging question

[Coty Sutherland]

Hi,

I'm looking into commons-daemon in Tomcat and it appears that the Windows
executables (prunsrv and prunmgr) don't require the commons-daemon.jar to
run Tomcat like the *nix binary (jsvc) does. Can someone confirm that (I
tested it and it seems to work fine without the jar)? If it's unused I can
remove it to clean up the packaging a bit.



Thanks,
Coty

Re: [VOTE] Release Apache Tomcat 8.5.40

[Coty Sutherland]

On Wed, Apr 10, 2019 at 10:58 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.40 release is now available for voting.
>
> The major changes compared to the 8.5.39 release are:
>
> - Fix for CVE-2019-0232 a RCE vulnerability on Windows
>
> - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also
>   now supported if used with a ECJ version with support for those  Java
>   versions
>
> - Various NIO2 stability improvements
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.40/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1208/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.40
> 5ec070352b283535946327b44228b610a27a76c5
>
>
> The proposed 8.5.40 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.40
>

+1


>
>
> Due to the security fix contained in this release, the voting period may
> be shortened once sufficient votes are cast to enable a faster release.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 9.0.18

[Coty Sutherland]

On Wed, Apr 10, 2019 at 9:44 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.18 release is now available for voting.
>
> The major changes compared to the 9.0.17 release are:
>
> - Fix for CVE-2019-0232 a RCE vulnerability on Windows
>
> - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also
>   now supported if used with a ECJ version with support for those  Java
>   versions
>
> - Various NIO2 stability improvements
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1207/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.18
> 0862607e5da91a7c476a6350288d8d8a9380f556
>
> The proposed 9.0.18 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 9.0.18
>

+1


>
>
> Due to the security fix contained in this release, the voting period may
> be shortened once sufficient votes are cast to enable a faster release.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: svn commit: r33591 - in /dev/tomcat/tomcat-9/v9.0.19: ./ bin/ bin/embed/ src/

[Coty Sutherland]

Are these svn commits intentional? I thought the svn repo was read-only now.

On Fri, Apr 12, 2019 at 10:47 AM  wrote:

> Author: markt
> Date: Fri Apr 12 14:47:16 2019
> New Revision: 33591
>
> Log:
> Upload 9.0.19 for voting
>
> Added:
> dev/tomcat/tomcat-9/v9.0.19/
> dev/tomcat/tomcat-9/v9.0.19/KEYS
> dev/tomcat/tomcat-9/v9.0.19/README.html
> dev/tomcat/tomcat-9/v9.0.19/RELEASE-NOTES
> dev/tomcat/tomcat-9/v9.0.19/bin/
> dev/tomcat/tomcat-9/v9.0.19/bin/README.html
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.tar.gz
>  (with props)
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.tar.gz.asc
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.tar.gz.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.zip
>  (with props)
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.zip.asc
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.zip.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-fulldocs.tar.gz
>  (with props)
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-fulldocs.tar.gz.asc
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-fulldocs.tar.gz.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x64.zip
>  (with props)
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x64.zip.asc
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x64.zip.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x86.zip
>  (with props)
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x86.zip.asc
>
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x86.zip.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.exe   (with props)
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.exe.asc
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.exe.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.tar.gz   (with
> props)
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.tar.gz.asc
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.tar.gz.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.zip   (with props)
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.zip.asc
> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.zip.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/embed/
>
> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.tar.gz
>  (with props)
>
> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.tar.gz.asc
>
> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.tar.gz.sha512
> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.zip
>  (with props)
>
> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.zip.asc
>
> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.zip.sha512
> dev/tomcat/tomcat-9/v9.0.19/src/
> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.tar.gz
>  (with props)
> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.tar.gz.asc
> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.tar.gz.sha512
> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.zip   (with
> props)
> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.zip.asc
> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.zip.sha512
>
> Added: dev/tomcat/tomcat-9/v9.0.19/KEYS
>
> ==
> --- dev/tomcat/tomcat-9/v9.0.19/KEYS (added)
> +++ dev/tomcat/tomcat-9/v9.0.19/KEYS Fri Apr 12 14:47:16 2019
> @@ -0,0 +1,676 @@
> +This file contains the PGP&GPG keys of various Apache developers.
> +Please don't use them for email unless you have to. Their main
> +purpose is code signing.
> +
> +Apache users: pgp < KEYS
> +Apache developers:
> +(pgpk -ll  && pgpk -xa ) >> this file.
> +  or
> +(gpg --fingerprint --list-sigs 
> + && gpg --armor --export ) >> this file.
> +
> +Apache developers: please ensure that your key is also available via the
> +PGP keyservers (such as pgpkeys.mit.edu).
> +
> +
> +Type Bits/KeyIDDate   User ID
> +pub  2048/F22C4FED 2001/07/02 Andy Armstrong 
> +
> +-BEGIN PGP PUBLIC KEY BLOCK-
> +Version: PGPfreeware 7.0.3 for non-commercial use 
> +
> +mQGiBDtAWuURBADZ0KUEyUkSUiTA09e7tvEbX25STsjxrR+DNTainCls+XlkVOij
> +gBv216lqge9tIsS0L6hCP4OQbFf/64qVtJssX4QXdyiZGb5wpmcj0Mz602Ew8r+N
> +I0S5NvmogoYWW7BlP4r61jNxO5zrr03KaijM5r4ipJdLUxyOmM6P2jRPUwCg/5gm
> +bpqiYl7pXX5FgDeB36tmD+UD/06iLqOnoiKO0vMbOk7URclhCObMNrHqxTxozMTS
> +B9soYURbIeArei+plYo2n+1qB12ayybjhVu3uksXRdT9bEkyxMfslvLbIpDAG8Cz
> +gNftTbKx/MVS7cQU0II8BKo2Akr+1FZah+sD4ovK8SfkMXUQUbTeefTntsAQKyyU
> +9M9tA/9on9tBiHFl0qVJht6N4GiJ2G689v7rS2giLgKjetjiCduxBXEgvUSuyQID
> +nF9ATrpXjITwsRlGKFmpZiFm5oCeCXihIVH0u6q066xNW2AXkLVoJ1l1Rs2Z0lsb
> +0cq3xEAcwAmYLKQvCtgDV8CYgWKVmPi+49

Re: svn commit: r33591 - in /dev/tomcat/tomcat-9/v9.0.19: ./ bin/ bin/embed/ src/

[Coty Sutherland]

On Fri, Apr 12, 2019 at 11:29 AM Coty Sutherland 
wrote:

> Are these svn commits intentional? I thought the svn repo was read-only
> now.
>

Disregard that :)


>
> On Fri, Apr 12, 2019 at 10:47 AM  wrote:
>
>> Author: markt
>> Date: Fri Apr 12 14:47:16 2019
>> New Revision: 33591
>>
>> Log:
>> Upload 9.0.19 for voting
>>
>> Added:
>> dev/tomcat/tomcat-9/v9.0.19/
>> dev/tomcat/tomcat-9/v9.0.19/KEYS
>> dev/tomcat/tomcat-9/v9.0.19/README.html
>> dev/tomcat/tomcat-9/v9.0.19/RELEASE-NOTES
>> dev/tomcat/tomcat-9/v9.0.19/bin/
>> dev/tomcat/tomcat-9/v9.0.19/bin/README.html
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.tar.gz
>>  (with props)
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.tar.gz.asc
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.tar.gz.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.zip
>>  (with props)
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.zip.asc
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-deployer.zip.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-fulldocs.tar.gz
>>  (with props)
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-fulldocs.tar.gz.asc
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-fulldocs.tar.gz.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x64.zip
>>  (with props)
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x64.zip.asc
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x64.zip.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x86.zip
>>  (with props)
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x86.zip.asc
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19-windows-x86.zip.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.exe   (with
>> props)
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.exe.asc
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.exe.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.tar.gz   (with
>> props)
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.tar.gz.asc
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.tar.gz.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.zip   (with
>> props)
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.zip.asc
>> dev/tomcat/tomcat-9/v9.0.19/bin/apache-tomcat-9.0.19.zip.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/embed/
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.tar.gz
>>  (with props)
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.tar.gz.asc
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.tar.gz.sha512
>> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.zip
>>  (with props)
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.zip.asc
>>
>> dev/tomcat/tomcat-9/v9.0.19/bin/embed/apache-tomcat-9.0.19-embed.zip.sha512
>> dev/tomcat/tomcat-9/v9.0.19/src/
>> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.tar.gz
>>  (with props)
>> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.tar.gz.asc
>> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.tar.gz.sha512
>> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.zip   (with
>> props)
>> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.zip.asc
>> dev/tomcat/tomcat-9/v9.0.19/src/apache-tomcat-9.0.19-src.zip.sha512
>>
>> Added: dev/tomcat/tomcat-9/v9.0.19/KEYS
>>
>> ==
>> --- dev/tomcat/tomcat-9/v9.0.19/KEYS (added)
>> +++ dev/tomcat/tomcat-9/v9.0.19/KEYS Fri Apr 12 14:47:16 2019
>> @@ -0,0 +1,676 @@
>> +This file contains the PGP&GPG keys of various Apache developers.
>> +Please don't use them for email unless you have to. Their main
>> +purpose is code signing.
>> +
>> +Apache users: pgp < KEYS
>> +Apache developers:
>> +(pgpk -ll  && pgpk -xa ) >> this file.
>> +  or
>> +(gpg --fingerprint --list-sigs 
>> + && gpg --armor --export ) >> this file.
>> +
>> +Apache developers: please ensure that your key is also available via the
>> +

Re: [VOTE] Release Apache Tomcat 9.0.19

[Coty Sutherland]

On Fri, Apr 12, 2019 at 10:48 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.19 release is now available for voting.
> 9.0.19 corrects a regression and a number of packaging errors in 9.0.18.
>
> The major changes compared to the 9.0.17 release are:
>
> - Fix for CVE-2019-0232 a RCE vulnerability on Windows
>
> - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also
>   now supported if used with a ECJ version with support for those  Java
>   versions
>
> - Various NIO2 stability improvements
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.19/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1210/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.19
> 854f4dcf435a6d335576aa22402e2871c66f4fd9
>
> The proposed 9.0.19 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 9.0.19
>

+1


>
>
> Due to the security fix contained in this release, the voting period may
> be shortened once sufficient votes are cast to enable a faster release.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Regarding IDE configuration files

[Coty Sutherland]

On Sat, Feb 4, 2023 at 5:21 AM Mark Thomas  wrote:

>
> 4 Feb 2023 04:17:29 Bailey Brownie :
>
> > Hi all,
> >
> > Recently, when setting up Tomcat for development with the Eclipse IDE,
> > I noticed that the configuration files that come with Tomcat had
> > multiple hard-coded (and outdated) references to some dependencies.
>
> Sorry. That is probably me forgetting to update those files.
>
> > Is it a good idea to handle class path configuration for IDEs by using
> > a filterset when copying the config files in the IDE build targets? Are
> > there any potential downsides to this approach?
>
> Excellent idea. No downside I can think of.
>

+1

Re: tomcat-native v2.0+ breaks unix domain socket support on java16-

[Coty Sutherland]

Hi there,

On Mon, Mar 6, 2023 at 6:01 PM Graham Leggett 
wrote:

> Hi all,
>
> A while back I added unix domain socket support to tomcat-native, and
> patched tomcat to use it until java16 is available.
>
> Unfortunately unix domain socket support was removed from tomcat-native
> 2.0+, and now tomcat-native 2.0+ is appearing in distros, meaning that unix
> domain socket support just broke.
>
> https://tomcat.apache.org/native-doc/miscellaneous/changelog.html
>
> "Remove all API methods (and supporting code) that are not used by Tomcat
> 10.1.x to support the use of OpenSSL as a replacement for JSSE to provide
> TLS functionality. (markt)”
>
> Is there a way to fix this, or has tomcat just broken everything for
> anyone in a RHEL environment?
>

"tomcat" has broken nothing ;)

Assuming that you're using tomcat-native from EPEL 9 (because that's the
only place to get tomcat-native for RHEL at the moment), the only option is
to downgrade to the build from Aug 2022 (tomcat-native-1.2.35-1.el9). I
reopened a similar issue https://bugzilla.redhat.com/show_bug.cgi?id=2124703
to address this; please watch/engage there with any more questions/comments
(unless they are purely tomcat/tomcat-native related). Also, if you feel
that you want to document your unique problem in more detail, you can
comment or open a new bugzilla issue against Fedora EPEL 9 too.

Apologies for the inconvenience.


> Regards,
> Graham
> —
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Java 21 and virtual threads

[Coty Sutherland]

On Thu, May 4, 2023 at 8:37 AM Mark Thomas  wrote:

> Hi all,
>
> The latest Java 21 EA build has moved virtual threads (from project
> Loom) out of preview. How do we want to handle this in Tomcat 11? Recall
> that Jakarta EE 11 has set Java 21 as the minimum version.
>
> I think we have the following options:
>
> 1. Stick with Java 17 as the minimum version and don't provide virtual
> thread functionality.
>
> 2. Stick with Java 17 as the minimum version and provide virtual thread
> functionality via the JreCompat module.
>
> 3. Increase minimum Java version to Java 21 for Tomcat 11 and provide
> virtual thread functionality.
>
> I am currently leaning towards 3 but could live with 2.
>
> Thoughts? Other options?
>

+1 for option 3.

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

[Coty Sutherland]

This commit is problematic :( It's broken some projects that depend on
Tomcat because now the tomcat-coyote.jar doesn't contain the
org.apache.tomcat.util.net.jsse or org.apache.tomcat.util.modeler.modules
packages which results in ClassNotFoundExceptions. I haven't seen any
issues with other jars yet. The removal of those packages from the jar
looks intentional, but we aren't providing the classes anywhere else for
users to use which is causing problems. Thoughts?

On Tue, Jun 23, 2020 at 6:43 AM  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch 9.0.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
> commit 393c022c87e5cbebf1b96c3e1e7aa3b2ab4d5b74
> Author: Raymond Augé 
> AuthorDate: Fri Jun 19 09:32:56 2020 -0400
>
> Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating
> a better manifest and make sure the resulting jar contents are correct.
>
> Signed-off-by: Raymond Augé 
> ---
>  build.xml | 17 ++---
>  res/bnd/annotations-api.jar.tmp.bnd   |  2 +-
>  res/bnd/build-defaults.bnd| 15 +++
>  res/bnd/catalina-tribes.jar.tmp.bnd   |  5 -
>  res/bnd/catalina.jar.tmp.bnd  |  5 -
>  res/bnd/el-api.jar.tmp.bnd|  2 +-
>  res/bnd/jasper-el.jar.tmp.bnd |  8 +++-
>  res/bnd/jasper.jar.tmp.bnd|  7 ++-
>  res/bnd/jaspic-api.jar.tmp.bnd|  2 +-
>  res/bnd/jsp-api.jar.tmp.bnd   |  2 +-
>  res/bnd/servlet-api.jar.tmp.bnd   |  2 +-
>  res/bnd/{el-api.jar.tmp.bnd => spec-defaults.bnd} | 11 ++-
>  res/bnd/tomcat-coyote.jar.tmp.bnd |  9 -
>  res/bnd/tomcat-embed-core.jar.tmp.bnd | 15 ++-
>  res/bnd/tomcat-embed-el.jar.tmp.bnd   |  8 +++-
>  res/bnd/tomcat-embed-jasper.jar.tmp.bnd   |  7 ++-
>  res/bnd/tomcat-embed-websocket.jar.tmp.bnd|  7 ++-
>  res/bnd/tomcat-util.jar.tmp.bnd   |  6 +-
>  res/bnd/tomcat-websocket.jar.tmp.bnd  |  7 ++-
>  res/bnd/websocket-api.jar.tmp.bnd |  2 +-
>  webapps/docs/changelog.xml|  5 +
>  21 files changed, 119 insertions(+), 25 deletions(-)
>
> diff --git a/build.xml b/build.xml
> index 1900b78..7dba702 100644
> --- a/build.xml
> +++ b/build.xml
> @@ -3358,9 +3358,20 @@ Read the Building page on the Apache Tomcat
> documentation site for details on ho
>
>
>  
> -
> -  
> -
> +
> +
> + +  basedir="${basedir}"
> +  output="${jarfile}.tmp"
> +>
> +  
> +
> +
> +  
> +  
> +
> +  
> +
>  
>  
>
> diff --git a/res/bnd/annotations-api.jar.tmp.bnd
> b/res/bnd/annotations-api.jar.tmp.bnd
> index 9399b6c..9b2f84e 100644
> --- a/res/bnd/annotations-api.jar.tmp.bnd
> +++ b/res/bnd/annotations-api.jar.tmp.bnd
> @@ -13,7 +13,7 @@
>  # See the License for the specific language governing permissions and
>  # limitations under the License.
>
> --include: build-defaults.bnd
> +-include: build-defaults.bnd, spec-defaults.bnd
>
>  Bundle-Name: tomcat-annotations-api
>  Bundle-SymbolicName: org.apache.tomcat-annotations-api
> diff --git a/res/bnd/build-defaults.bnd b/res/bnd/build-defaults.bnd
> index 06e64c4..cdefb9c 100644
> --- a/res/bnd/build-defaults.bnd
> +++ b/res/bnd/build-defaults.bnd
> @@ -14,3 +14,18 @@
>  # limitations under the License.
>
>  Bundle-Version: ${version_cleanup;${version}}
> +
> +Specification-Title: Apache Tomcat
> +Specification-Version: ${version.major.minor}
> +Specification-Vendor: Apache Software Foundation
> +Implementation-Title: Apache Tomcat
> +Implementation-Version: ${version}
> +Implementation-Vendor: Apache Software Foundation
> +
> +X-Compile-Source-JDK: ${compile.source}
> +X-Compile-Target-JDK: ${compile.target}
> +
> +-includeresource.notice:
> META-INF/NOTICE;literal="${replace;${cat;../META-INF/default.notice};@YEAR
> @;${year}}\n"
> +-includeresource.license: {META-INF/LICENSE=../META-INF/default.license}
> +
> +-noclassforname: true
> \ No newline at end of file
> diff --git a/res/bnd/catalina-tribes.jar.tmp.bnd
> b/res/bnd/catalina-tribes.jar.tmp.bnd
> index 630169d..d6ae14a 100644
> --- a/res/bnd/catalina-tribes.jar.tmp.bnd
> +++ b/res/bnd/catalina-tribes.jar.tmp.bnd
> @@ -28,4 +28,7 @@ Export-Package: \
>  org.apache.catalina.tribes.transport,\
>  org.apache.catalina.tribes.transport.bio,\
>  org.apache.catalina.tribes.transport.nio,\
> -org.apache.catalina.tribes.util
> \ No newline at end of file
> +org.apache.catalina.tribes.util
> +
> +-includepackage: \
> +org.apache.catalina.tribes.membership.cloud
> \ No newline at end of file
> diff --git a/res/bnd/catalina.jar.tmp.bnd b/res/bnd/catalina

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

[Coty Sutherland]

Hi Mark,

On Tue, Jul 21, 2020 at 4:48 AM Mark Thomas  wrote:

> On 20/07/2020 18:20, Coty Sutherland wrote:
> > This commit is problematic :( It's broken some projects that depend on
> > Tomcat because now the tomcat-coyote.jar doesn't contain the
> > org.apache.tomcat.util.net.jsse or
> > org.apache.tomcat.util.modeler.modules packages which results in
> > ClassNotFoundExceptions. I haven't seen any issues with other jars yet.
> > The removal of those packages from the jar looks intentional, but we
> > aren't providing the classes anywhere else for users to use which is
> > causing problems. Thoughts?
>
> Those packages are still present.
>

It seems that removing the packages from the exported packages list
actually removed them completely from the tomcat-coyote.jar (I decompiled
it to look and they were not present, nor were they included in any other
jars).


> Do you mean those packages are no longer listed as exported in the OSGi
> / JPMS meta-data? The following packages are currently listed as private
> (and I assume the JPMS metadata is the same):


> org.apache.tomcat.util.bcel
> org.apache.tomcat.util.http.fileupload.impl
> org.apache.tomcat.util.http.fileupload.util.mime
> org.apache.tomcat.util.modeler.modules
> org.apache.tomcat.util.net.jsse
>
> It should be fairly easy to get that fixed.
>
> Out of curiosity, what projects are broken? I'm surprised that something
> has dependencies that deep into Tomcat's internals. Is this an OSGi
> dependency or JPMS?
>

Thanks for looking into it, the fix you did was the same patch that I added
yesterday (
https://src.fedoraproject.org/rpms/tomcat/c/a8c5ea85614dca66b492fe030a7e7cfc10cd52de?branch=master)
:) I wish I'd proposed it upstream now, I just wasn't sure what the
criteria was for not exporting the packages.

The packages that were pointed out to me as broken are FreeIPA server (
https://bugzilla.redhat.com/show_bug.cgi?id=1857043) and Debian's
libtomcat9-java package (
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964433), both with
different CNFEs.

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

[Coty Sutherland]

On Tue, Jul 21, 2020 at 7:52 AM Mark Thomas  wrote:

> On 21/07/2020 12:43, Coty Sutherland wrote:
> > Hi Mark,
> >
> > On Tue, Jul 21, 2020 at 4:48 AM Mark Thomas  > <mailto:ma...@apache.org>> wrote:
> >
> > On 20/07/2020 18:20, Coty Sutherland wrote:
> > > This commit is problematic :( It's broken some projects that
> depend on
> > > Tomcat because now the tomcat-coyote.jar doesn't contain the
> > > org.apache.tomcat.util.net <http://org.apache.tomcat.util.net>.jsse
> or
> > > org.apache.tomcat.util.modeler.modules packages which results in
> > > ClassNotFoundExceptions. I haven't seen any issues with other jars
> > yet.
> > > The removal of those packages from the jar looks intentional, but
> we
> > > aren't providing the classes anywhere else for users to use which
> is
> > > causing problems. Thoughts?
> >
> > Those packages are still present.
> >
> >
> > It seems that removing the packages from the exported packages list
> > actually removed them completely from the tomcat-coyote.jar (I
> > decompiled it to look and they were not present, nor were they included
> > in any other jars).
>
> I've just checked the 9.0.37 binaries and those packages (and the
> classes they contain) are present in tomcat-coyote.jar.
>
> I saw the same when I built 10.0.x locally (before my fix).
>
> From where did you obtain a JAR where those classes were missing?
>

Oh yeah, you're right. They were included in the ASF binaries, but Fedora
(and Debian I guess) built their own bits and that's where the classes came
up missing. I wasn't able to identify *why* the classes weren't present,
only that it was the OSGi step that was removing them. I thought initially
that it was because the Fedora version of aqute-bnd in use is 3.5, but I
don't see the classes in my local build from the 9.0.37 tag (using bnd 5.1)
either.


> > Thanks for looking into it, the fix you did was the same patch that I
> > added yesterday
> > (
> https://src.fedoraproject.org/rpms/tomcat/c/a8c5ea85614dca66b492fe030a7e7cfc10cd52de?branch=master
> )
> > :) I wish I'd proposed it upstream now, I just wasn't sure what the
> > criteria was for not exporting the packages.
> >
> > The packages that were pointed out to me as broken are FreeIPA server
> > (https://bugzilla.redhat.com/show_bug.cgi?id=1857043) and Debian's
> > libtomcat9-java package
> > (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964433), both with
> > different CNFEs.
>
> Tx. I'm curious as whether the root cause was missing classes or missing
> exports - but that depends on figuring out why the classes were missing
> first.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [tomcat] 01/02: Fix BZ 64540 - switch from bndwrap task to bnd task, begin generating a better manifest and make sure the resulting jar contents are correct.

[Coty Sutherland]

On Tue, Jul 21, 2020 at 9:15 AM Mark Thomas  wrote:

> On 21/07/2020 14:06, Coty Sutherland wrote:
>
> 
>
> > Oh yeah, you're right. They were included in the ASF binaries, but
> > Fedora (and Debian I guess) built their own bits and that's where the
> > classes came up missing. I wasn't able to identify *why* the classes
> > weren't present, only that it was the OSGi step that was removing them.
> > I thought initially that it was because the Fedora version of aqute-bnd
> > in use is 3.5, but I don't see the classes in my local build from the
> > 9.0.37 tag (using bnd 5.1) either.
>
> OK. That means it isn't quite as bad as it could be.
>
> What about the other packages in the original list? Are:
>
> org.apache.tomcat.util.bcel
> org.apache.tomcat.util.http.fileupload.impl
> org.apache.tomcat.util.http.fileupload.util.mime
>
> still present?
>

Nope.