[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user rmannibucau commented on the issue: https://github.com/apache/tomee/pull/176 Hmm, you close the classloader before it is used so it is no more usable normally - or it will leak. Side question: any issue having an impl os ClassPath using the classloader to keep existing one for java 8 users? ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Ok @rmannibucau, sent the correct patch, let me know what do you think. Thank you! ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Ohh.. sorry I sent the wrong patch. Pushing the correct one. ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user rmannibucau commented on the issue: https://github.com/apache/tomee/pull/176 Hope i didnt misread the diff (starts to be late ;)) but it misses a close and the urlclassloader cast will not work on all java versions right? ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Hi @rmannibucau, patch updated. It seems to look better now. Please, review it and thank you for all the help, I really appreciate it. ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau, Nice.. working on it. Thank you! :) ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user rmannibucau commented on the issue: https://github.com/apache/tomee/pull/176 Yes, this is what i had in mind as well. That said if it is just for our CLI your hack is fine, we should just lock it for other cases like openejb-standalone ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 @rmannibucau, TomEE is not showing any exception when running with j11 (I was able to start and deploy a simple application on it really fine), that is not the issue. It just appears with tomee.sh when I'm using the CLI commands. Maybe applying that change just to cover the org.apache.openejb.cli.Bootstrap should works. WDYT? ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user rmannibucau commented on the issue: https://github.com/apache/tomee/pull/176 well some thoughts: 1. most of the time we dont need this dynamism so maybe we can just rework the distro and delete it 2. we already hack equals/hashcode in cxf container loader but it is not super robust (this is why we have a flag to disable it) so maybe not the best solution but current impl clearly breaks some apps 3. you can open java modules to get the URLClassPath, even of the system classloader in j11 so maybe we just document how to open it and replace the cast by some reflection? ---
[GitHub] tomee issue #176: TOMEE-2253 - tomee.sh -version not working properly with J...
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/176 Hey @rmannibucau, I updated it to call `close` and also now we call the ClassLoader.registerAsParallelCapable(); in a static block. hashcode and equals still using the super, the new class doesn't have any property which we can use to create a custom equals ou hashcode. If you have some idea how can I create ones, please show off. ---
Re: TomEE 8 Release Preview
I think we can add it. Also, I think we wanted to be careful about it, so to not disrupt any of the other profiles and people could test it. We could add MP specs for M2. > On 23 Oct 2018, at 08:26, Jonathan Gallimore > wrote: > > I'd also like to see it part of Plus and Plume. It adds about 3MB to the > distribution size. Any other thoughts? > > Jon > > On Tue, Oct 23, 2018 at 4:44 PM dkwakkel wrote: > >> I was also planning to use Plus and expected micro profile being part of >> it. >> We don't see that our customers maintain their own distro. We just instruct >> them how to download/install tomee. >> Could you reconsider making microprofile part of Plus? >> >> >> >> -- >> Sent from: >> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html >>
Re: Startup time between TomEE 8.0.0-M1 Plus and MP
Exactly. Cheers, Roberto > On 22 Oct 2018, at 10:22, COURTAULT Francois > wrote: > > Hello Roberto, > > So if I have understood you well TomEE MP is TomEE Web Profile + MP > specifications, right ? > > Best Regards. > > -Original Message- > From: Roberto Cortez [mailto:radcor...@yahoo.com.INVALID] > Sent: lundi 22 octobre 2018 18:14 > To: us...@tomee.apache.org > Cc: dev@tomee.apache.org > Subject: Re: Startup time between TomEE 8.0.0-M1 Plus and MP > > Hi Francois, > > Thank you. > > TomEE MP is build from TomEE WebProfile, so it does support Java EE, > including JPA and Concurrency. > > Stuff, available in MP Plus, like JMS or JBatch are currently not available > in TomEE MP. > > Regarding the error, I’ve only notice them after the release. I suspect that > the MP JWT filter has some kind of impact in packaged apps, like the docs or > the console, so they are failing to start. I’m going to have a better look at > it. > > Cheers, > Roberto > >> On 22 Oct 2018, at 07:08, COURTAULT Francois >> wrote: >> >> Hello everyone, >> >> I have performed some comparison between TomEE 8.0.0-M1 Plus and MP. >> The average startup time for TomEE 8.0.0-M1 Plus using java 11, on my >> laptop with Core i5, SSD and 16 GB of RAM is: 1,303 ms The average >> startup time for TomEE 8.0.0-M1 MP using java 11, on my laptop with Core >> i5, SSD and 16 GB of RAM is: 1,824 ms I was expecting the opposite. >> >> Looking at the TomEE 8.0.0-M1 logs, I saw: >> 22-Oct-2018 14:25:46.872 SEVERE [main] >> org.apache.catalina.core.StandardContext.startInternal One or more >> Filters failed to start. Full details will be found in the appropriate >> container log file >> 22-Oct-2018 14:25:46.873 SEVERE [main] >> org.apache.catalina.core.StandardContext.startInternal Context [/docs] >> startup failed due to previous errors ... >> 22-Oct-2018 14:25:47.116 SEVERE [main] >> org.apache.catalina.core.StandardContext.startInternal One or more >> Filters failed to start. Full details will be found in the appropriate >> container log file >> 22-Oct-2018 14:25:47.116 SEVERE [main] >> org.apache.catalina.core.StandardContext.startInternal Context >> [/host-manager] startup failed due to previous errors ... >> 22-Oct-2018 14:25:47.306 SEVERE [main] >> org.apache.catalina.core.StandardContext.startInternal One or more >> Filters failed to start. Full details will be found in the appropriate >> container log file >> 22-Oct-2018 14:25:47.307 SEVERE [main] >> org.apache.catalina.core.StandardContext.startInternal Context [/manager] >> startup failed due to previous errors ... >> 22-Oct-2018 14:25:47.497 SEVERE [main] >> org.apache.catalina.core.StandardContext.startInternal One or more >> Filters failed to start. Full details will be found in the appropriate >> container log file >> 22-Oct-2018 14:25:47.497 SEVERE [main] >> org.apache.catalina.core.StandardContext.startInternal Context [] >> startup failed due to previous errors >> >> I didn't see those entries in TomEE 8.0.0-M1 Plus during startup: maybe this >> can explain the startup time difference ? Is it an issue ? >> >> BTW, could you confirm or not to me that the difference between TomEE 8 Plus >> and TomEE 8 MP are: >> >> * TomEE MP doesn't have Concurrency utilities for EE support >> (available in Web Profile) >> >> * TomEE MP doesn't have JPA support (available in Web Profile) >> >> * TomEE MP doesn't have JAX-WS support (available in Plus) >> >> * TomEE MP doesn't have JCA support (available in Plus) >> >> * TomEE MP doesn't have JMS support (available in Plus) >> >> * TomEE MP doesn't have JBatch support (available in Plus) >> >> Could you also confirm to me or not, that TomEE 8 MP: >> >> * Will have CDI 2.0 support ? >> >> * Will have JSON-P 1.1 support ? >> >> * Will have JAX-RS 2.1 support ? >> >> * Will have JSON-B 1.0 support ? >> >> Best Regards. >> >> This message and any attachments are intended solely for the addressees and >> may contain confidential information. Any unauthorized use or disclosure, >> either whole or partial, is prohibited. >> E-mails are susceptible to alteration. Our company shall not be liable for >> the message if altered, changed or falsified. If you are not the intended >> recipient of this message, please delete it and notify the sender. >> Although all reasonable efforts have been made to keep this transmission >> free from viruses, the sender will not be liable for damages caused by a >> transmitted virus. > > > This message and any attachments are intended solely for the addressees and > may contain confidential information. Any unauthorized use or disclosure, > either whole or partial, is prohibited. > E-mails are susceptible to alteration. Our company shall not be liable for > the message if altered, changed or falsified. If you are not the
Re: TomEE 8 Release Preview
I'd also like to see it part of Plus and Plume. It adds about 3MB to the distribution size. Any other thoughts? Jon On Tue, Oct 23, 2018 at 4:44 PM dkwakkel wrote: > I was also planning to use Plus and expected micro profile being part of > it. > We don't see that our customers maintain their own distro. We just instruct > them how to download/install tomee. > Could you reconsider making microprofile part of Plus? > > > > -- > Sent from: > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html >
Re: TomEE 8 Release Preview
I was also planning to use Plus and expected micro profile being part of it. We don't see that our customers maintain their own distro. We just instruct them how to download/install tomee. Could you reconsider making microprofile part of Plus? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
[GitHub] tomee pull request #178: TOMEE-2261 - Make service.bat compatible with JDK11...
GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/178 TOMEE-2261 - Make service.bat compatible with JDK11+ Detect java version and act on it. After java 11: - Remove jre references because they are invalid when using the JDK. - Remove endorced property def. because is no longer supported. This has been developped with Tomee 7.0.6-SNAPSHOT and tested with: - Windows 2012 R2 - OpenJDK11-jdk_x64_windows_openj9_11.0.1_13 - OpenJDK8U-jdk_x64_windows_hotspot_8u181b13 Signed-off-by: brunobat You can merge this pull request into a Git repository by running: $ git pull https://github.com/brunobat/tomee fix-win-service-j11 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomee/pull/178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #178 commit 4309ec73f2c452fed5ca96dee6d344247dbee27b Author: brunobat Date: 2018-10-23T11:14:22Z Detect java version and act on it. After java 11: - Remove jre references because they are invalid when using the JDK. - Remove endorced property def. because is no longer supported. Signed-off-by: brunobat ---
