[GitHub] tomee pull request #181: Update CXF to latest release

2018-10-30 Thread deki
GitHub user deki opened a pull request:

https://github.com/apache/tomee/pull/181

Update CXF to latest release



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/deki/tomee cxf-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomee/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #181


commit a5513230e8f77a4985916f901c3eda2c5c45c6d2
Author: Dennis Kieselhorst 
Date:   2018-10-30T14:30:06Z

Update CXF to latest release




---


[GitHub] tomee issue #180: Apache BVal - BV certification feedback

2018-10-30 Thread rmannibucau
Github user rmannibucau commented on the issue:

https://github.com/apache/tomee/pull/180
  
@gsmet updated master to pass the tck with bval 2.0.1-SNAPSHOT, do you care 
rebasing your PR and checking it works for you?


---


[GitHub] tomee pull request #180: Apache BVal - BV certification feedback

2018-10-30 Thread gsmet
GitHub user gsmet opened a pull request:

https://github.com/apache/tomee/pull/180

Apache BVal - BV certification feedback

@rmannibucau @mbenson

So it might not be the best place to discuss this but as the TomEE 
infrastructure is used to certify Apache BVal and changes were needed to TomEE, 
I thought we might as well discuss it here.

The PR contains a number of changes to the build (mostly to upgrade BVal 
and the TCK but also to check the BV API signatures at build time).

Unfortunately, while I can run the tests in the bval-embedded directory 
successfully, I have test failures when trying to run the tests in the 
bval-tomee directory, namely:
```
[ERROR] Failures: 
[ERROR]   
BootstrapCustomProviderDefinedInServiceFileTest>Arquillian.run:164->testProviderResolverReturnsListOfAvailableProviders:73
 » Validation
[ERROR]   
DuplicateConfigurationTest>Arquillian.run:164->testXmlConfiguredConstraintExposesCorrespondingAnnotationViaMetadata:72
 » Validation
[ERROR]   
XmlConfigurationTest>Arquillian.run:164->testAnnotationDefinedConstraintApplies:176->AbstractTCKTest.getValidator:61
 » Validation
[ERROR]   
XmlConfigurationTest>Arquillian.run:164->testCascadingConfiguredInXml:203->AbstractTCKTest.getValidator:61
 » Validation
[ERROR]   
XmlConfigurationTest>Arquillian.run:164->testClassConstraintDefinedInXml:79->AbstractTCKTest.getValidator:61
 » Validation
[ERROR]   
XmlConfigurationTest>Arquillian.run:164->testElementConversionInXmlConfiguredConstraint:255->AbstractTCKTest.getValidator:61
 » Validation
[ERROR]   
XmlConfigurationTest>Arquillian.run:164->testFieldConstraintDefinedInXml:151->AbstractTCKTest.getValidator:61
 » Validation
[ERROR]   
XmlConfigurationTest>Arquillian.run:164->testIgnoreValidationXml:109->AbstractTCKTest.getValidator:61
 » Validation
[ERROR]   
XmlConfigurationTest>Arquillian.run:164->testMappingFilesAddedViaConfigurationGetAddedToXmlConfiguredMappings:216->AbstractTCKTest.getValidator:61
 » Validation
[ERROR]   
XmlConfigurationTest>Arquillian.run:164->testPropertyConstraintDefinedInXml:127->AbstractTCKTest.getValidator:61
 » Validation
[ERROR]   
XmlConfiguredConstraintValidatorTest>Arquillian.run:164->testExcludeExistingValidators:57
 » Validation
[ERROR]   
XmlConfiguredConstraintValidatorTest>Arquillian.run:164->testIncludeExistingValidators:84
 » Validation
[INFO] 
[ERROR] Tests run: 1043, Failures: 12, Errors: 0, Skipped: 0
```

Don't know exactly if they are TCK issues or issues in TomEE/Apache BVal 
but they certainly need some attention.

Note that even without my PR, with master, I have test failures when 
running the tests from the bval-tomee directly but not the same tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gsmet/tomee bv-certification

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomee/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #180


commit ceb4ad3aa85d08dc02043bfcba8d31435aae5283
Author: Guillaume Smet 
Date:   2018-10-30T11:23:18Z

TOMEE-2266 Upgrade Apache BVal to 2.0.0

commit 539b8f5563861137817d787c42940440bd9e4182
Author: Guillaume Smet 
Date:   2018-10-30T11:23:52Z

TOMEE-2266 Upgrade the Bean Validation TCK to 2.0.4.Final

commit 143834b636e5397f4e7c33e0f80728eec7b3d146
Author: Guillaume Smet 
Date:   2018-10-30T11:24:40Z

TOMEE-2267 Check the signatures of the Bean Validation API at build time




---