[GitHub] [tomee] willesreis commented on a change in pull request #686: TOMEE-2877 Translate to Portuguese: examples/mp-rest-jwt-public-key

2020-07-16 Thread GitBox


willesreis commented on a change in pull request #686:
URL: https://github.com/apache/tomee/pull/686#discussion_r456208136



##
File path: examples/mp-rest-jwt-public-key/README_pt.adoc
##
@@ -0,0 +1,110 @@
+:index-group: MicroProfile
+:jbake-type: page
+:jbake-status: published
+
+= MP REST JWT com Public key do MP Config
+
+Este é um exemplo de como configurar e usar o MicroProfile JWT 1.1 no TomEE.
+
+== Executando o teste
+
+Este projeto inclui uma aplicação de amostra e um teste do Arquillian para 
mostrar o controle de acesso baseado em função (RBAC) com JWT no MicroProfile.
+Para executar o cenário, você pode executar o seguinte comando:
+
+[source, bash]
+
+mvn clean test
+
+
+A aplicação representa um recurso REST de livraria com alguns endpoints.
+Todos esperam que o cliente forneça um token da web JSON (JWT) válido, 
representando um usuário com determinadas funções.
+O teste Arquillian é responsável por gerar os JWTs e anexá-los os requests.
+
+== Configuração no TomEE
+
+Para ativar o JWT, você precisa anotar sua classe de aplicação REST com a 
anotação `org.eclipse.microprofile.auth.LoginConfig`.
+Neste exemplo, a classe é `ApplicationConfig`.
+
+Outra coisa que precisa ser feita é configurar a `public key` para verificar a 
assinatura do JWT anexada no cabeçalho `Authorization'.
+É assinado na criação com a `private key` do issuer.
+Isso é feito para evitar o uso moderado do token enquanto ele viaja do 
chamador até o endpoint.
+Geralmente, a emissão do JWT ocorre em um módulo ou microsserviço especial 
responsável pela autenticação dos usuários.
+Neste projeto de amostra, isso acontece no `BookstoreTest`.
+
+Cada tempo de execução de suporte ao MicroProfile JWT deve poder verificar se 
a assinatura está correta e se o conteúdo assinado não é alterado ao longo do 
caminho.
+Para fazer isso, ele precisa ter acesso a uma `public key`.
+Essa `public key` pode estar no formato `PKCS#8 PEM, JWK ou JWKS`.
+Desde o MP JWT 1.1 (que é suportado pelo TomEE), a chave pode ser fornecida 
como uma string na propriedade de configuração `mp.jwt.verify.publickey` ou 
como um local ou URL de arquivo especificado em 
`mp.jwt.verify.publickey.location` na propriedade de configuração.
+
+Neste projeto de amostra, você pode ver a primeira opção.
+O arquivo `src/main/resource/META-INF/microprofile-config.properties` contém a 
seguinte entrada:
+
+[source,properties]
+
+mp.jwt.verify.publickey=MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAlivFI8qB4D0y2jy0CfEqFyy46R0o7S8TKpsx5xbHKoU1VWg6QkQm+ntyIv1p4kE1sPEQO73+HY8+Bzs75XwRTYL1BmR1w8J5hmjVWjc6R2BTBGAYRPFRhor3kpM6ni2SPmNNhurEAHw7TaqszP5eUF/F9+KEBWkwVta+PZ37bwqSE4sCb1soZFrVz/UT/LF4tYpuVYt3YbqToZ3pZOZ9AX2o1GCG3xwOjkc4x0W7ezbQZdC9iftPxVHR8irOijJRRjcPDtA6vPKpzLl6CyYnsIYPd99ltwxTHjr3npfv/3Lw50bAkbT4HeLFxTx4flEoZLKO/g0bAoV2uqBhkA9xnQIDAQAB
+
+
+== trabalhando com JWT
+
+A classe `BookResource` neste projeto de amostra mostra dois casos em que você 
pode usar a especificação MP JWT: obter o valor de uma declaração JWT e o 
controle de acesso baseado em função dos endpoints REST.
+
+=== Obtenção de valores de claim
+
+O token da web JSON (JWT) anexado no cabeçalho HTTP `Authorization` é 
essencialmente um objeto JSON que contém vários atributos.

Review comment:
   ```suggestion
   O JSON Web Token (JWT) anexado no cabeçalho HTTP `Authorization` é 
essencialmente um objeto JSON que contém vários atributos.
   ```

##
File path: examples/mp-rest-jwt-public-key/README_pt.adoc
##
@@ -0,0 +1,110 @@
+:index-group: MicroProfile
+:jbake-type: page
+:jbake-status: published
+
+= MP REST JWT com Public key do MP Config
+
+Este é um exemplo de como configurar e usar o MicroProfile JWT 1.1 no TomEE.
+
+== Executando o teste
+
+Este projeto inclui uma aplicação de amostra e um teste do Arquillian para 
mostrar o controle de acesso baseado em função (RBAC) com JWT no MicroProfile.
+Para executar o cenário, você pode executar o seguinte comando:
+
+[source, bash]
+
+mvn clean test
+
+
+A aplicação representa um recurso REST de livraria com alguns endpoints.
+Todos esperam que o cliente forneça um token da web JSON (JWT) válido, 
representando um usuário com determinadas funções.
+O teste Arquillian é responsável por gerar os JWTs e anexá-los os requests.
+
+== Configuração no TomEE
+
+Para ativar o JWT, você precisa anotar sua classe de aplicação REST com a 
anotação `org.eclipse.microprofile.auth.LoginConfig`.
+Neste exemplo, a classe é `ApplicationConfig`.
+
+Outra coisa que precisa ser feita é configurar a `public key` para verificar a 
assinatura do JWT anexada no cabeçalho `Authorization'.
+É assinado na criação com a `private key` do issuer.
+Isso é feito para evitar o uso moderado do token enquanto ele viaja do 
chamador até o endpoint.
+Geralmente, a emissão do JWT ocorre em um módulo ou microsserviço especial 
responsável pela autenticação dos usuários.
+Neste projeto de amostra, isso acontece no `BookstoreTest`.
+

TOMEE-2881 Translate to Portuguese: examples/persistence-fragment

2020-07-16 Thread Daniel Dias Dos Santos
Hello,

I opened a ticket in Jira [1] and a PR [2], can anyone revise the
translation?

thank you

[1] https://issues.apache.org/jira/browse/TOMEE-2881
[2] https://github.com/apache/tomee/pull/690
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


TOMEE-2880 Translate to Portuguese: examples/myfaces-codi-demo

2020-07-16 Thread Daniel Dias Dos Santos
Hello,

I opened a ticket in Jira [1] and a PR [2], can anyone revise the
translation?

thank you

[1] https://issues.apache.org/jira/browse/TOMEE-2880
[2] https://github.com/apache/tomee/pull/689
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


[GitHub] [tomee] Daniel-Dos merged pull request #682: TOMEE-2872 Translate to Portuguese: examples/mp-rest-jwt

2020-07-16 Thread GitBox


Daniel-Dos merged pull request #682:
URL: https://github.com/apache/tomee/pull/682


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] Daniel-Dos commented on pull request #682: TOMEE-2872 Translate to Portuguese: examples/mp-rest-jwt

2020-07-16 Thread GitBox


Daniel-Dos commented on pull request #682:
URL: https://github.com/apache/tomee/pull/682#issuecomment-659676369


   thanks 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: Making Antora actionable

2020-07-16 Thread David Jencks
Hi Willes,

I’ve never seen that particular error from npm!  I changed the relevant url to 
be https://, could you try again?

I also added some todo.adoc files to these two new projects…. take a look, are 
they more or less what you had in mind?

Thanks!
David Jencks

> On Jul 16, 2020, at 1:00 PM, Willes Reis  wrote:
> 
> Hi David, thanks for your effort.
> 
> 
>>> On Jul 15, 2020, at 6:03 PM, David Jencks 
>> wrote:
>>> 
>>> I’ve:
>>> 
>>> - started an Antora UI bundle project for TomEE:  tomee-antora-ui <
>> https://github.com/djencks/tomee-antora-ui>
>>> It’s already built, but if you want to build it yourself, clone it, run
>> npm i, and gulp.
> 
> I did fork/clone this project, but I haven't built it yet..
> 
> 
>>> In order to track what is changed from the default UI, I used my
>> slightly experimental UI builder.  If we want  to proceed on this path I
>> can release it to npm; right now it’s in my space on AWS.
>> 
>> 
>>> I set header/footer colors/images to match the existing site and removed
>> the cruft from the header.  I didn’t try to match header/footer content
>> with the existing site since I think it needs to be rethought for Antora.
>> 
> I could help you with this details in design/UI asap.
> 
>> - started an Antora playbook project for TomEE: tomee-antora <
>> https://github.com/djencks/tomee-antora>
>>> To build this, clone it, and run npm run clean-build.  The site will be
>> at build/site.
>>> I have not yet provided a maven project to run this.
>> 
> 
> I did fork/clone this project and run build, but there was some error at
> authentication in your GitHub repo tomee-antora-ui, as follows:
> Perhaps you can understand and know what to do.
> 
> 
>> willesreis@host tomme-antora % npm run clean-build
>> 
> 
>>> @ clean-build /Users/willesreis/tomee-antora
>> 
>>> npm run clean-install;npm run build
>> 
>> 
>> 
>>> @ clean-install /Users/willesreis/tomee-antora
>> 
>>> rm -rf node_modules/ .cache/ package-lock.json;npm i --cache=.cache/npm
>> 
>> 
>> The authenticity of host 'github.com (18.228.52.138)' can't be
>> established.tf8@0.0.1 fetched in 1083ms
>> 
>> RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
>> 
>> ⸨░░⸩ ⠼ fetchMetadata: sill pacote version manifest for
>> to-utf8@0.0.1 fetched in 1083ms
>> 
>> npm ERR! Error while executing:
>> 
>> npm ERR! /usr/bin/git ls-remote -h -t ssh://
>> g...@github.com/djencks/tomee-antora-ui.git
>> 
>> npm ERR!
>> 
>> npm ERR! Host key verification failed.
>> 
>> npm ERR! fatal: Could not read from remote repository.
>> 
>> npm ERR!
>> 
>> npm ERR! Please make sure you have the correct access rights
>> 
>> npm ERR! and the repository exists.
>> 
>> npm ERR!
>> 
>> npm ERR! exited with error code: 128
>> 
> 
> I suggest that we put a ".adoc" file kind "to do" or "progress" on each
> repo, on which we can write all of things to do, i.e. our path, and we go
> "checking" each item as we progress. What do you think?
> 
> Willes Reis



Re: Making Antora actionable

2020-07-16 Thread Willes Reis
Hi David, thanks for your effort.


> > On Jul 15, 2020, at 6:03 PM, David Jencks 
> wrote:
> >
> > I’ve:
> >
> > - started an Antora UI bundle project for TomEE:  tomee-antora-ui <
> https://github.com/djencks/tomee-antora-ui>
> > It’s already built, but if you want to build it yourself, clone it, run
> npm i, and gulp.

I did fork/clone this project, but I haven't built it yet..


> > In order to track what is changed from the default UI, I used my
> slightly experimental UI builder.  If we want  to proceed on this path I
> can release it to npm; right now it’s in my space on AWS.
>
>
> > I set header/footer colors/images to match the existing site and removed
> the cruft from the header.  I didn’t try to match header/footer content
> with the existing site since I think it needs to be rethought for Antora.
>
I could help you with this details in design/UI asap.

> - started an Antora playbook project for TomEE: tomee-antora <
> https://github.com/djencks/tomee-antora>
> > To build this, clone it, and run npm run clean-build.  The site will be
> at build/site.
> > I have not yet provided a maven project to run this.
>

I did fork/clone this project and run build, but there was some error at
authentication in your GitHub repo tomee-antora-ui, as follows:
Perhaps you can understand and know what to do.


> willesreis@host tomme-antora % npm run clean-build
>

> > @ clean-build /Users/willesreis/tomee-antora
>
> > npm run clean-install;npm run build
>
>
>
> > @ clean-install /Users/willesreis/tomee-antora
>
> > rm -rf node_modules/ .cache/ package-lock.json;npm i --cache=.cache/npm
>
>
> The authenticity of host 'github.com (18.228.52.138)' can't be
> established.tf8@0.0.1 fetched in 1083ms
>
> RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
>
> ⸨░░⸩ ⠼ fetchMetadata: sill pacote version manifest for
> to-utf8@0.0.1 fetched in 1083ms
>
> npm ERR! Error while executing:
>
> npm ERR! /usr/bin/git ls-remote -h -t ssh://
> g...@github.com/djencks/tomee-antora-ui.git
>
> npm ERR!
>
> npm ERR! Host key verification failed.
>
> npm ERR! fatal: Could not read from remote repository.
>
> npm ERR!
>
> npm ERR! Please make sure you have the correct access rights
>
> npm ERR! and the repository exists.
>
> npm ERR!
>
> npm ERR! exited with error code: 128
>

I suggest that we put a ".adoc" file kind "to do" or "progress" on each
repo, on which we can write all of things to do, i.e. our path, and we go
"checking" each item as we progress. What do you think?

Willes Reis


TOMEE-2879 Translate to Portuguese: examples/multiple-tomee-arquillian

2020-07-16 Thread Daniel Dias Dos Santos
Hello,

I opened a ticket in Jira [1] and a PR [2], can anyone revise the
translation?

thank you

[1] https://issues.apache.org/jira/browse/TOMEE-2879
[2] https://github.com/apache/tomee/pull/688
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


TOMEE-2878 - Translate to Portuguese: examples/multi-jpa-provider-testing

2020-07-16 Thread Daniel Dias Dos Santos
Hello,

I opened a ticket in Jira [1] and a PR [2], can anyone revise the
translation?

thank you

[1] https://issues.apache.org/jira/browse/TOMEE-2878
[2] https://github.com/apache/tomee/pull/687
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


TOMEE-2877 Translate to Portuguese: examples/mp-rest-jwt-public-key

2020-07-16 Thread Daniel Dias Dos Santos
Hello,

I opened a ticket in Jira [1] and a PR [2], can anyone revise the
translation?

thank you

[1] https://issues.apache.org/jira/browse/TOMEE-2877
[2] https://github.com/apache/tomee/pull/686/
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


Re: Making Antora actionable

2020-07-16 Thread David Jencks
I’ve updated the UI to more closely match the existing site (especially the 
header :-) and enabled prev/next pagination, and updated the preview.

IMO this is close to usable.  

We still have to decide on what should go in the footer, but that may be more 
evident when the navigation is developed to a workable state.

David Jencks

> On Jul 15, 2020, at 6:03 PM, David Jencks  wrote:
> 
> I’ve:
> 
> - started an Antora UI bundle project for TomEE:  tomee-antora-ui 
> 
> It’s already built, but if you want to build it yourself, clone it, run npm 
> i, and gulp.
> In order to track what is changed from the default UI, I used my slightly 
> experimental UI builder.  If we want  to proceed on this path I can release 
> it to npm; right now it’s in my space on AWS.
> 
> I set header/footer colors/images to match the existing site and removed the 
> cruft from the header.  I didn’t try to match header/footer content with the 
> existing site since I think it needs to be rethought for Antora.
> 
> - started an Antora playbook project for TomEE: tomee-antora 
> 
> To build this, clone it, and run npm run clean-build.  The site will be at 
> build/site.
> I have not yet provided a maven project to run this.
> 
> I removed the examples from what was previously in the Antora site.
> 
> The results are visible at 
> https://tomee-preview.s3-us-west-2.amazonaws.com/common/contribute.html 
>  (a 
> somewhat arbitrary start page).  Since an AWS bucket isn’t a web server or a 
> local file system, there are some strange things happening for some links.
> 
> Comments:
> 
> - In order to combine the playbook project with tomee-site-generator, I think 
> tomee-site-generator needs to become a multi-module reactor maven project.  
> Let’s make sure that is actually the most sensible approach before proceeding.
> 
> - I believe this preview includes all of what I think people have been 
> describing as the non-example non-doc content.  I think this includes all the 
> stuff previously buried in secret in, mostly, markdown and html  in the CMS.  
> IIUC there’s some objection to this being in the Antora part of the site.  I 
> would like a clear explanation of what is better for this to be non-Antora 
> content.
> 
> - IIRC the content for 7.0, 7.1, and 8 is identical (there might be slight 
> differences, of a couple of pages).  I’d suggest that since there is not 
> enough interest to maintain the site at a high level, this be collapsed to 
> one version.  Small differences can be  pointed out with “since 8.0” etc.  If 
> in the future new docs for 9.0 are actually written, that would be a good 
> time to add another version.
> 
> - I haven’t yet considered how this might be combined with non-Antora parts 
> of the site.  I pointed out a few messages ago that at least the Antora part 
> can easily use ASF infrastructure to publish to the appropriate git repo.
> 
> - I haven’t made any attempt to set up reasonable navigation in the site.  I 
> think all pages are present in navigation, but wouldn’t promise anything.  I 
> think this may relate to the “what needs to be generated” discussion.
> 
> I think it would be really great if this could get enough attention so that 
> we can end up with a new site soon.
> 
> Thanks!
> David Jencks
> 
>> On Jul 15, 2020, at 8:22 AM, David Jencks > > wrote:
>> 
>> 
>> 
>>> On Jul 15, 2020, at 3:58 AM, Jonathan Gallimore 
>>> mailto:jonathan.gallim...@gmail.com>> wrote:
>>> 
 I recommend we first eliminate the Apache CMS so we have a hands-free
>>> setup.  Then I recommend we make it so the `tomee-site-generator` maven
>>> project is the thing that kicks off and runs Antora.
>>> 
>>> Sounds good to me.
>>> 
 I seriously don't care what we use for them as the majority of the issues
>>> are content, not tool.  If we need to rollout a tool to motivate people to
>>> pay attention to the content, let's do it.  As long as everything remains
>>> in Asciidoc we are free to switch at any time, so there's no harm in giving
>>> it a try.
>>> 
>>> I agree. I recall there's been some discussion about the navigation
>>> hierarchy and splitting stuff into "admin" and "developer", and I don't
>>> think that went anywhere. If we have good content, then the right
>>> structure will follow. Some way of enumerating what we have so we can
>>> identify gaps, and review content feels like a potential starting point.
>>> Seeing what we have on the "old" site that isn't on the "new" site could be
>>> interesting - if I search for something, I usually get a page from the
>>> "old" site.
>>> 
>> 
>> AFAIK I’ve found all the “old content”, translated it to Asciidoc, and 
>> included it in the preview Antora site.
>> 
>> David Jencks
>>> Jon
>>> 
>>> On Wed, Jul 15, 2020 at 3:35 AM David Blevins >> 

[GitHub] [tomee] Daniel-Dos merged pull request #681: TOMEE-2871 - Translate to Portuguese: examples/mp-rest-client

2020-07-16 Thread GitBox


Daniel-Dos merged pull request #681:
URL: https://github.com/apache/tomee/pull/681


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] Daniel-Dos commented on pull request #681: TOMEE-2871 - Translate to Portuguese: examples/mp-rest-client

2020-07-16 Thread GitBox


Daniel-Dos commented on pull request #681:
URL: https://github.com/apache/tomee/pull/681#issuecomment-659501175


   thanks .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] Daniel-Dos merged pull request #680: TOMEE-2870 Translate to Portuguese: examples/mp-metrics-timed

2020-07-16 Thread GitBox


Daniel-Dos merged pull request #680:
URL: https://github.com/apache/tomee/pull/680


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] Daniel-Dos commented on pull request #680: TOMEE-2870 Translate to Portuguese: examples/mp-metrics-timed

2020-07-16 Thread GitBox


Daniel-Dos commented on pull request #680:
URL: https://github.com/apache/tomee/pull/680#issuecomment-659501460


   thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] Daniel-Dos commented on pull request #682: TOMEE-2872 Translate to Portuguese: examples/mp-rest-jwt

2020-07-16 Thread GitBox


Daniel-Dos commented on pull request #682:
URL: https://github.com/apache/tomee/pull/682#issuecomment-659500808


   thanks @willesreis for review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] Daniel-Dos commented on pull request #685: TOMEE-2875 Translate to Portuguese: examples/mp-rest-jwt-principal

2020-07-16 Thread GitBox


Daniel-Dos commented on pull request #685:
URL: https://github.com/apache/tomee/pull/685#issuecomment-659499289


   thanks @willesreis for review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] Daniel-Dos merged pull request #685: TOMEE-2875 Translate to Portuguese: examples/mp-rest-jwt-principal

2020-07-16 Thread GitBox


Daniel-Dos merged pull request #685:
URL: https://github.com/apache/tomee/pull/685


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] rmannibucau commented on a change in pull request #678: Fix for random JMS2AMQTest failure

2020-07-16 Thread GitBox


rmannibucau commented on a change in pull request #678:
URL: https://github.com/apache/tomee/pull/678#discussion_r455561701



##
File path: 
container/openejb-core/src/test/java/org/apache/openejb/activemq/JMS2AMQTest.java
##
@@ -93,6 +93,8 @@ public Properties config() {
 
 .p("mdbs", "new://Container?type=MESSAGE")
 .p("mdbs.ResourceAdapter", "amq")
+.p("mdbs.InstanceLimit", "30")

Review comment:
   maybe put a comment why it is needed because there is no high 
concurrency in this test (the 50 messages are sequential)
   
   Two things which can go wrong in such a test are the sleep() - but normally 
it is also guarded by latches - and the implicit request scope which would 
stack messages if implicitly used but increasing instances and sessions is 
surprising upfront so a comment is likely worth it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] rzo1 edited a comment on pull request #678: Fix for random JMS2AMQTest failure

2020-07-16 Thread GitBox


rzo1 edited a comment on pull request #678:
URL: https://github.com/apache/tomee/pull/678#issuecomment-659207065


   Hi @cesarhernandezgt 
   
   CI build has failed. I have checked the logs:
   
   ```
   (1) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on 
project mp-config-source-database: There are test failures.
 => Classes are missing (org/apache/commons/dbutils/DbUtils)

   (2) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on 
project moviefun-functional-test: There are test failures.
   => java.lang.RuntimeException: Could not invoke deployment method: public 
static org.jboss.shrinkwrap.api.spec.EnterpriseArchive 
org.superbiz.moviefun.MoviesArquillianHtmlUnitTest.createDeployment()
 
   (3) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on 
project mvc-cxf: There are test failures.
   => java.lang.NoClassDefFoundError: org/eclipse/krazo/engine/Viewable
   
   (4) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on 
project mvc-cxf-hibernate: There are test failures.
   => java.lang.ClassNotFoundException: org.eclipse.krazo.engine.Viewable
   
   (5) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on 
project mvc-resteasy: There are test failures
   => Could not invoke deployment method: public static 
org.jboss.shrinkwrap.api.spec.WebArchive 
org.superbiz.mvc.MVCTest.createDeployment()
   ```
   
   Probably very easy fixes due to classpath issues / version mismatches. Shall 
we go for this in this branch or in a separate one (from this one here) ?
   
   In addition, the Surefire Plugin version seems to differ within the 
project...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] rzo1 commented on pull request #678: Fix for random JMS2AMQTest failure

2020-07-16 Thread GitBox


rzo1 commented on pull request #678:
URL: https://github.com/apache/tomee/pull/678#issuecomment-659207065


   Hi @cesarhernandezgt 
   
   CI build has failed. I have checked the logs:
   
   ```
   (1) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on 
project mp-config-source-database: There are test failures.
 => Classes are missing (org/apache/commons/dbutils/DbUtils)

   (2) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on 
project moviefun-functional-test: There are test failures.
   => java.lang.RuntimeException: Could not invoke deployment method: public 
static org.jboss.shrinkwrap.api.spec.EnterpriseArchive 
org.superbiz.moviefun.MoviesArquillianHtmlUnitTest.createDeployment()
 
   (3) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on 
project mvc-cxf: There are test failures.
   => java.lang.NoClassDefFoundError: org/eclipse/krazo/engine/Viewable
   
   (4) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on 
project mvc-cxf-hibernate: There are test failures.
   => java.lang.ClassNotFoundException: org.eclipse.krazo.engine.Viewable
   
   (5) Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on 
project mvc-resteasy: There are test failures
   => Could not invoke deployment method: public static 
org.jboss.shrinkwrap.api.spec.WebArchive 
org.superbiz.mvc.MVCTest.createDeployment()
   ```
   
   Probably very easy fixes due to classpath issues / version mismatches. Shall 
we go for this in this branch or in a separate one (from this one here) ?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org