[GitHub] [tomee] cesarhernandezgt merged pull request #830: TOMEE-3647

2022-03-29 Thread GitBox


cesarhernandezgt merged pull request #830:
URL: https://github.com/apache/tomee/pull/830


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] cesarhernandezgt edited a comment on pull request #830: TOMEE-3647

2022-03-29 Thread GitBox


cesarhernandezgt edited a comment on pull request #830:
URL: https://github.com/apache/tomee/pull/830#issuecomment-1082198363


   > my comment aims for only one thing: we should
   > not forget it.
   
   Totally agree, I created https://issues.apache.org/jira/browse/TOMEE-3883 
aiming at master (9) so we not forget.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] cesarhernandezgt commented on pull request #830: TOMEE-3647

2022-03-29 Thread GitBox


cesarhernandezgt commented on pull request #830:
URL: https://github.com/apache/tomee/pull/830#issuecomment-1082198363


   > my comment aims for only one thing: we should
   > not forget it.
   Totally agree, I created https://issues.apache.org/jira/browse/TOMEE-3883 
aiming at master (9) so we not forget.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [tomee] cesarhernandezgt closed pull request #831: Fix examples poms to avoid release issues

2022-03-29 Thread GitBox


cesarhernandezgt closed pull request #831:
URL: https://github.com/apache/tomee/pull/831


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: TomEE 9.x - from javax to jakarta namespace

2022-03-29 Thread Zowalla, Richard
Hi,

to follow up on TOMEE-3879 [1]: I add some more context to the Jira.
The permissions do not matter as we are not invoking the scripts in
bin/* in the failover itests (itests/failover). 

We are directly booting the servers via the java command (via Bootstrap
from openejb-core) and a lot of properties to configure it, which fails
(at least for me atm) with a ClassNotFoundException (see issue). Due to
this exception, the servers never become ready and the tests will just
timeout.

Don't have time to dig into it now but hope it helps anyone, who will
work on it in the near future :)

Gruß
Richard

[1] https://issues.apache.org/jira/browse/TOMEE-3879

Am Montag, dem 28.03.2022 um 08:16 + schrieb Zowalla, Richard:
> Heyho,
> 
> the ZIP created for TOMEE-3879 looks good to me. It has +x set.
> Perhaps
> it looses the info during extraction in our code. 
> 
> Can you give a pointer, which tests are suspected to be impacted by
> it?
> 
> Gruß
> Richard
> 
> Am Samstag, dem 26.03.2022 um 10:40 +0100 schrieb Jean-Louis
> Monteiro:
> > Awesome, divide and conquer.
> > 
> > Trying to add a bit more...
> > This one might be small for someone with some spare cycles.
> > 
> > https://issues.apache.org/jira/browse/TOMEE-3879
> > 
> > 
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> > 
> > 
> > On Sat, Mar 26, 2022 at 5:35 AM David Blevins <
> > david.blev...@gmail.com>
> > wrote:
> > 
> > > > On Mar 24, 2022, at 2:28 AM, Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com> wrote:
> > > > We can now divide and conquer. An issue has been created
> > > > https://issues.apache.org/jira/browse/TOMEE-3862
> > > > We are going to add as many small tasks as possible so people
> > > > can
> > > > pick
> > > and
> > > > contribute in parallel.
> > > 
> > > Thanks for that JIRA.  I saw an easy one I could do and went a
> > > head
> > > and
> > > knocked it out :)
> > > 
> > >  -
> > > https://github.com/apache/tomee/commit/6e37ec02ca60fe955a3a909d761e09aa5a506978
> > > 
> > > That yanks 1 minute out of the build on my machine.
> > > 
> > > 
> > > -David
> > > 
> > > 
> > > > On Tue, Mar 22, 2022 at 1:59 PM Jean-Louis Monteiro <
> > > > jlmonte...@tomitribe.com> wrote:
> > > > 
> > > > > Hi,
> > > > > 
> > > > > I've been working for quite a long time on TomEE 9.x, and
> > > > > it's
> > > > > been more
> > > > > challenging and painful than I was expecting. I thought it
> > > > > would be
> > > good to
> > > > > give you some sort of status.
> > > > > 
> > > > > I created a PR for the work. As a reminder, since Java EE
> > > > > moved
> > > > > to
> > > Eclipse
> > > > > to become Jakarta EE, we had a switch from javax.* namespace
> > > > > to
> > > jakarta.*
> > > > > namespace. This is an impacting change, since all
> > > > > applications
> > > > > and
> > > > > applications servers are built on top of it.
> > > > > 
> > > > > In TomEE, we decided to do that change in TomEE. We had
> > > > > previously a
> > > > > bytecode change approach like an application could do. It
> > > > > worked and we
> > > > > were able to get certified. But it had a lot of limitations,
> > > > > so
> > > > > we had
> > > to
> > > > > do the migration in the code and fix all compatibility
> > > > > issues.
> > > > > 
> > > > > Here is the PR https://github.com/apache/tomee/pull/814
> > > > > It has 90+ commits and nearly 5000 files touched (added,
> > > > > removed,
> > > > > updated). I understand it's a lot and it makes it almost
> > > > > impossible to
> > > > > review. But I did not see much approaches in this scenario to
> > > > > create
> > > > > smaller PRs.
> > > > > 
> > > > > I created a Jenkins build though available at
> > > > > https://ci-builds.apache.org/job/Tomee/job/master-build-quick-9.x/
> > > > > 
> > > > > It makes it possible to track the progress. There have been
> > > > > steps
> > > forward
> > > > > and steps backward.
> > > > > 
> > > > > All the code does not sit under TomEE, we use a bunch of
> > > > > third
> > > > > party
> > > > > projects and libraries. I have been able to contribute,
> > > > > publish
> > > > > jakarta
> > > > > compatible versions and get releases for some of them
> > > > > (Jakarta
> > > > > EE APIs
> > > Uber
> > > > > jar, Geronimo Connectors and Transaction Manager, Geronimo
> > > > > Config,
> > > Health,
> > > > > Metrics, OpenTracing, OpenAPI. OpenJPA, BVal, and
> > > > > OpenWebBeans
> > > > > will be
> > > > > released soon.
> > > > > 
> > > > > The big parts is CXF, and ActiveMQ. I had to get them done in
> > > > > TomEE and
> > > > > update all group/artifact ids. It's under deps, alongside
> > > > > with
> > > > > SXC,
> > > DBCP,
> > > > > and others.
> > > > > 
> > > > > In terms of removal, I tried to remove old stuff like SAAJ
> > > > > Axis
> > > > > 1
> > > > > integration, JAX RPC, Management J2EE and a couple of other
> > > > > old
> > > > > things.
> > > > > 
> > > > > A lot of other libraries got updated to their 

[GitHub] [tomee] rmannibucau commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache

2022-03-29 Thread GitBox


rmannibucau commented on pull request #828:
URL: https://github.com/apache/tomee/pull/828#issuecomment-1081455368


   > there could be an external tool to modify a dezipped certified TomEE to 
change its implementation jars.
   
   If you look tomee-maven-plugin it enables to do any distro from plain tomcat 
to advanced customized tomee and you can use it to build a tomee plume from 
tomee webprofile or any distro ;). Installer is legacy since years :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org