[GitHub] [tomee] rzo1 commented on pull request #883: Tomee 3824

[GitBox]

rzo1 commented on PR #883:
URL: https://github.com/apache/tomee/pull/883#issuecomment-1125684017

   Thanks for the PR @tichovz - I left some comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824

[GitBox]

rzo1 commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r872021449


##
container/openejb-jee/src/test/resources/web-fragment-example.xml:
##
@@ -0,0 +1,14 @@
+

Review Comment:
   This file misses a license header - subsequently, the license header checks 
in CI will fail. 
   
   You can ake a look at the other descriptor files and just copy & paste the 
ASF license header into this file. 



##
container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
##
@@ -166,4 +167,12 @@ public JAXBElement createConnector(final 
Webservices value) {
 public JAXBElement createFacesConfig(final FacesConfig value) 
{
 return new JAXBElement(_FacesConfig_QNAME, 
FacesConfig.class, null, value);
 }
+
+ /**
+ * Create an instance of {@link JAXBElement }{@code <}{@link WebFragment 
}{@code >}}
+ */
+@XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee;, name = 
"web-fragment")

Review Comment:
   We might need to add `web-fragment` part to `ObjectFactory$JAXB` in 
`openejb-jee-accessors` to fully support it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824

[GitBox]

rzo1 commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r872020377


##
container/openejb-jee/src/test/java/org/apache/openejb/jee/JeeTest.java:
##
@@ -18,23 +18,22 @@
 
 package org.apache.openejb.jee;
 
+import jakarta.xml.bind.*;

Review Comment:
   Can we restore the original import order? It is basically a style change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: TOMEE-3824 New Jakarta EE 9 XML namespace not recognized in web-fragment.xml (was Re: How can I help?)

[Zoltán Tichov]

Hi!

If I have a pending pull request, can I work on another issue as well?

Thanks: Zoltán

On Tue, May 10, 2022 at 10:48 PM David Blevins 
wrote:

> Hi Zoltán!
>
> Really fantastic you have something working!
>
> If you create a PR that'a the best way to say "here are my changes, can
> you please review?"
>
>  -
> https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
>
> Any JDK 11 is fine since TomEE doesn't require a specific Java vendor --
> any Java 11 version is good.
>
> Once you have that PR ready, feel free to update this thread with the
> link.  Discussion can happen in the PR as well, but definitely more people
> see it here.
>
>
> -David
>
>
> > On May 10, 2022, at 11:06 AM, Zoltán Tichov 
> wrote:
> >
> > Hi David!
> >
> > I made some changes and a testcase, how can I show these changes to
> > somebody?
> > Which JDK should I use? Now I use adoptOpenJDK 11 to run the tests.
> >
> > Thanks: Zoltán
> >
> > On Fri, May 6, 2022 at 1:27 AM David Blevins 
> > wrote:
> >
> >> Hey Zoltán!
> >>
> >> Absolutely, you're welcome to fix the issue.  I can assign the issue to
> >> you if you let me know your JIRA username.  Make a comment on the issue
> and
> >> that'll be the quickest way to send it.
> >>
> >> We intentionally have it setup so new people can't assign issues to
> >> themselves so that they're forced to come to the list where we can get
> them
> >> off to the right start.
> >>
> >> On the issue you want to fix, most the code that would be involved in
> the
> >> fix is here:
> >>
> >> -
> >>
> https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java
> >>
> >> Some important history to help you.  When J2EE got renamed to Java EE,
> the
> >> namespaces changed.  The TCK for full Java EE server tests that all
> >> historic namespaces can be supported.  Our solution was to create an
> >> org.xml.sax.XMLFilter and dynamically rewrite the namespace on any
> document
> >> we were given to the then latest namespace
> >> http://java.sun.com/xml/ns/javaee
> >>
> >> -
> >>
> https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java#L291
> >>
> >> The way JAXB works is all the namespaces are hardcoded and without a
> >> filter like the one we made, there'd be no way to support multiple
> >> namespaces.  Those namespaces are all here:
> >>
> >> -
> >>
> https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java
> >>
> >> I did most that work, but it was 15 years ago and I don't recall all the
> >> details.  Jean-Louis did the work for the Jakarta namespace.  I know
> we're
> >> testing at least some those old namespaces and the new namespace.  We
> have
> >> some test descriptors here:
> >>
> >> -
> >>
> https://github.com/apache/tomee/tree/master/container/openejb-jee/src/test/resources
> >>
> >> I don't recall the name of those tests offhand, but if you search for
> the
> >> names of some of those files that should get you close.
> >>
> >>
> >> Now a couple thoughts as I see potential for some short-term work and
> some
> >> longer-term work.
> >>
> >> - Long-term: We're clearly still referring to "
> >> http://java.sun.com/xml/ns/javaee; as the primary namespace.  That's
> not
> >> going to age well.  If someone has to write an email like this in 15
> years,
> >> they'll likely have to explain what "javaee" is like I had to harken
> back
> >> to "J2EE".  We should probably make the new Jakarta EE namespace be the
> >> primary namespace and rework all the JAXB code and namespace filters
> >> accordingly.
> >>
> >> - Short-term: Do not do any of that and avoid opening that can of worms
> >> at all cost.  Get the file to parse with the minimum change possible.
> Get
> >> some experience with the code and a successful contribution in the can.
> >>
> >> This is what I'd do regardless of (or because of?) years of
> experience.  I
> >> always take the quick win before attempting the big one.
> >>
> >> If you get into the code and decide the big change sounds like fun, we
> can
> >> make a ticket for it and plan it.  Probably we'd want to shore up any
> test
> >> coverage we'd be lacking and also get a full TCK run to see what those
> >> numbers look like so we can spot regressions.
> >>
> >> Hope some of this is helpful!
> >>
> >> Don't hesitate to be super noisy and ask lots and lots of questions.
> >> Silence is death. :)
> >>
> >>
> >> -David
> >>
> >>
> >>> On May 5, 2022, at 3:31 PM, Zoltán Tichov 
> >> wrote:
> >>>
> >>> Hi Richard!
> >>> I found a ticket with a bug that I also encountered.The ticket is open
> >> and
> >>> unassigned.
> >>> Should I try to fix it? If so, how can it be assigned to me?
> >>> https://issues.apache.org/jira/browse/TOMEE-3824
> >>>
> >>> Best: Zoltán
> >>>
> >>> On Wed, Apr 27, 2022 at 8:36 AM 

Re: TomEE 9.x - from javax to jakarta namespace

[Wiesner, Martin]

+1

Best
Martin
—
https://twitter.com/mawiesne


Am 11.05.2022 um 19:00 schrieb Cesar Hernandez 
mailto:cesargu...@gmail.com>>:

+1, Thank you!


El mié, 11 may 2022 a las 9:06, Daniel Dias Dos Santos (<
daniel.dias.analist...@gmail.com>) 
escribió:

+1

On Wed, May 11, 2022, 12:00 Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> wrote:

I am fine with it: +1

Von: Jean-Louis Monteiro 
mailto:jlmonte...@tomitribe.com>>
Gesendet: Mittwoch, 11. Mai 2022 15:57:54
An: dev@tomee.apache.org
Betreff: Re: TomEE 9.x - from javax to jakarta namespace

Alright, with the latest changes pushed yesterday and today, we are now
at
the exact same numbers for TomEE 8.x / Jakarta EE 8 under JDK8 and TomEE
9.x / Jakarta 9.1 under JDK17.

If everyone is ok with it, we can create a new milestone and give users
the
opportunity to provide us with some feedback and to report bugs.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, May 10, 2022 at 7:06 PM David Blevins 
wrote:

Was checking out the TCK numbers this morning can make to suggest a
9.0.0-M8 while things look good and found this amazing email.

The 9.0.x branch is looking absolutely amazing!!!

What do we think about pushing out a 9.0.0-M8 while things are in their
peak-stable state?  I'm sure we'll have to rip up a few more things to
finish off the remaining Jakarta EE and MP TCK issues.  Would be great
to
have something that isn't M7 to fallback on as a reference point to
track
regressions.

Thoughts?


-David



On May 10, 2022, at 3:56 AM, Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

Hi all,

Time for some reporting

On our journey to migrate TomEE over from javax to jakarta namespace,
we
had many issues.
After updating all our code, we had to do a bunch of dependency
upgrades
after upgrading many of them (OpenWebbeans, BVal, Geronimo, etc).

We then faced many issues with non compatible libraries for example
(ActiveMQ, commons-dbcp, CXF, sxc, taglib, etc). So we ended up
repacking
them in our own groupId after using the Maven Shade plugin to
relocate
the
packages.

We worked on BVal TCK and CDI TCK and we are close to passing them.

But we had before to solve all our outdated MicroProfile 1.3 stack to
the
most recent and jakarta compatible version. Geronimo implementations
being
far being, we decided to use some SmallRye implementations until we
can
dedicate some time to update our Apache implementations (config,
metrics,
health, openapi, opentracing, fault tolerance).

Our build is now more stable, but still not green. Some issues are
basically easy to fix and most people could do it (examples for
instance).

https://ci-builds.apache.org/job/Tomee/job/master-build-full/

The integration for openapi, opentracing and fault tolerance is not
done
and we are far from passing the TCK. On config, metrics and health we
are
close. Same for our JWT implementation.

I also wanted to have a view on the platform TCK, so I decided to
stop
TomEE work in order to spend time on the Platform TCK to do all
dependency
upgrades and get the TCK to run properly. I'm pleased to announce
that
after 2 weeks of hard work, we are 99% compatible

https://tck.work/tomee/build?id=1652104572445

Thanks everyone for the help.
Keep going and if you need some guidance or help, let us know.

For coordination purposes, here is the issue
https://issues.apache.org/jira/browse/TOMEE-3862
Many subtasks are there and you can create new tasks when needed and
ask
any committer to assign it to you.



--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, May 5, 2022 at 11:13 AM Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> wrote:

Yes - we already yanked it in 9.x

Gruß
Richard

Am Donnerstag, dem 05.05.2022 um 10:10 +0100 schrieb Jonathan
Gallimore:
Sounds good. I'll drop the transformer from the 8.x branch (looks
like we
don't use it in 9.x), and I'll create a single example to
demonstrate
it in
a sandbox.

Jon

On Wed, May 4, 2022 at 12:32 PM Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> wrote:

You are right - we can remove it imho from 8.x as we do not test
with
it and the transformed samples might not even work, e.g.
dependencies
are not migrated, etc.

+1 for providing a (bigger) example.

Gruß
Richard

Am Mittwoch, dem 04.05.2022 um 11:17 +0100 schrieb Jonathan
Gallimore:
I've picked up a task related to the examples:
https://issues.apache.org/jira/browse/TOMEE-3873. I specifically
went
for
this, as I added the Eclipse Transformer to the build for a
number of
examples in the past, back when we were doing the transformation
process on
TomEE itself. The drawbacks here is that any tests in the
examples
run on
the javax code, and we just "assume" that the transformed
artifact
works. I

TomEE 9.x - jakarta.enterpise.inject.spi.Extension VS javax.enterpise.inject.spi.Extension

[Richard Zowalla]

Hi all,

while working on fixing the Deltaspike examples on EE9 / master
I encountered some 

Currently, TomEE 9.x only scans for "META-
INF/services/jakarta.enterprise.inject.spi.Extension". 

This breaks, if 3rd party artifacts do not correctly relocate their
"META-INF/services" files and still deliver
"javax.enterprise.inject.spi.Extension". While we can fix that via PRs
in OSS projects, it might be a problem in the wild.

I wonder, if we should compensate this for our users, i.e.

- Additionally scan for "javax.enterprise.inject.spi.Extension"
- If we find something, log a warning/info that this is not really
expected (?) and load the extension instead of failing with an
unsatisfied dependency error later.

Note, that we also rewrite javax to jakarta in XML files on the fly, so
it would probably be consistent to also scan for javax.enterprise.injec
t.spi.Extension" but I would like to hear some opinions on it.

Gruß
Richard