Hi Zoltán,
thanks for your PR [1] !
It usually takes some time for peope to review a PR. The best way to
proceed is, that - after you created a PR - you sent a follow up email
on your mail thread in which you asked for issue assignment.
GitHub mails are flodding our mailboxes and some people might have
filters in place and do not see it.
I left some comments. From a quick look at the codebase, I think, that
we need to add the web fragment to the "openejb-jee-accessors" module
as well (but I might be wrong ;) - at least this is done for all other
descriptor types.
A good place for a unit test would probably "openejb-core". Maybe
something like org.apache.openejb.jee.servlet31.DontFailOnUnusedTagTest
Gruß
Richard
[1] https://github.com/apache/tomee/pull/883
Am Donnerstag, dem 12.05.2022 um 18:10 +0200 schrieb Zoltán Tichov:
> Hi!
>
> If I have a pending pull request, can I work on another issue as
> well?
>
> Thanks: Zoltán
>
> On Tue, May 10, 2022 at 10:48 PM David Blevins <
> david.blev...@gmail.com>
> wrote:
>
> > Hi Zoltán!
> >
> > Really fantastic you have something working!
> >
> > If you create a PR that'a the best way to say "here are my changes,
> > can
> > you please review?"
> >
> > -
> > https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request
> >
> > Any JDK 11 is fine since TomEE doesn't require a specific Java
> > vendor --
> > any Java 11 version is good.
> >
> > Once you have that PR ready, feel free to update this thread with
> > the
> > link. Discussion can happen in the PR as well, but definitely more
> > people
> > see it here.
> >
> >
> > -David
> >
> >
> > > On May 10, 2022, at 11:06 AM, Zoltán Tichov <
> > > zoltan.tic...@gmail.com>
> > wrote:
> > > Hi David!
> > >
> > > I made some changes and a testcase, how can I show these changes
> > > to
> > > somebody?
> > > Which JDK should I use? Now I use adoptOpenJDK 11 to run the
> > > tests.
> > >
> > > Thanks: Zoltán
> > >
> > > On Fri, May 6, 2022 at 1:27 AM David Blevins <
> > > david.blev...@gmail.com>
> > > wrote:
> > >
> > > > Hey Zoltán!
> > > >
> > > > Absolutely, you're welcome to fix the issue. I can assign the
> > > > issue to
> > > > you if you let me know your JIRA username. Make a comment on
> > > > the issue
> > and
> > > > that'll be the quickest way to send it.
> > > >
> > > > We intentionally have it setup so new people can't assign
> > > > issues to
> > > > themselves so that they're forced to come to the list where we
> > > > can get
> > them
> > > > off to the right start.
> > > >
> > > > On the issue you want to fix, most the code that would be
> > > > involved in
> > the
> > > > fix is here:
> > > >
> > > > -
> > > >
> > https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java
> > > > Some important history to help you. When J2EE got renamed to
> > > > Java EE,
> > the
> > > > namespaces changed. The TCK for full Java EE server tests that
> > > > all
> > > > historic namespaces can be supported. Our solution was to
> > > > create an
> > > > org.xml.sax.XMLFilter and dynamically rewrite the namespace on
> > > > any
> > document
> > > > we were given to the then latest namespace
> > > > http://java.sun.com/xml/ns/javaee
> > > >
> > > > -
> > > >
> > https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java#L291
> > > > The way JAXB works is all the namespaces are hardcoded and
> > > > without a
> > > > filter like the one we made, there'd be no way to support
> > > > multiple
> > > > namespaces. Those namespaces are all here:
> > > >
> > > > -
> > > >
> > https://github.com/apache/tomee/blob/master/container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java
> > > > I did most that work, but it was 15 years ago and I don't
> > > > recall all the
> > > > details. Jean-Louis did the work for the Jakarta namespace. I
> > > > know
> > we're
> > > > testing at least some those old namespaces and the new
> > > > namespace. We
> > have
> > > > some test descriptors here:
> > > >
> > > > -
> > > >
> > https://github.com/apache/tomee/tree/master/container/openejb-jee/src/test/resources
> > > > I don't recall the name of those tests offhand, but if you
> > > > search for
> > the
> > > > names of some of those files that should get you close.
> > > >
> > > >
> > > > Now a couple thoughts as I see potential for some short-term
> > > > work and
> > some
> > > > longer-term work.
> > > >
> > > > - Long-term: We're clearly still referring to "
> > > > http://java.sun.com/xml/ns/javaee; as the primary
> > > > namespace. That's
> > not
> > > > going to age well. If someone has to write an email like this
> > > > in 15
> > years,
> > > > they'll likely have to explain what "javaee" is like I had to
> > > > harken
> > back
> > > > to "J2EE". We should
