Re: Draft Proposal for overall website direction

2020-02-18 Thread Guillermo García
Hi Hilberto,

I have been following some David's ideas and I agree with him in the
direction of using Antora.  I consider Antora in a mature state to let us
manage the website efficiently. And I am not worried about learning a new
tool, even if it is jbake.

I don't want to open a difficult debate about which technology is the best,
but in the worst case is it possible to call a committee for a votation?
How the TomEE committers team defines which direction to take in these
cases?


Best,

Guillermo

On Tue, Feb 18, 2020, 2:49 PM David Jencks  wrote:

> Antora already supports “edit this page". Some pages in the current site
> have a button for it, but I don’t know if it works.
>
> David Jencks
>
> > On Feb 18, 2020, at 10:43 AM, gilbertoca  wrote:
> >
> > I would stick with jvm tool (jbake) instead of add/learn one
> > more(node-antora). Specially I would to suggest we adopt what our Apache
> > Netbeans friends have done with jbake (jbake.org) in thier site
> > (https://netbeans.apache.org/). There, in each page you have a button
> ("See
> > this page in GitHub") where you/anyone can edit the original asciidoc
> file
> > and make PR for contribution.
> >
> > Regards,
> >
> > Gilberto
> >
> >
> > David Blevins-2 wrote
> >> All,
> >>
> >> I have a draft of something we can kick around for our website overall.
> >>
> >> -
> >>
> https://github.com/apache/tomee-site-generator/blob/master/WEBSITE-2020.adoc
> >>
> >> This took 3 hours to write so apologies for the size.  Much of this is
> >> experience from all the efforts of the past, some imagined improvements
> to
> >> successful parts of the site, while paving the way for the Antora work.
> >>
> >> Food on the table, cranky wife!  Must go!
> >>
> >> Sorry for the short email! :)
> >>
> >>
> >> --
> >> David Blevins
> >> http://twitter.com/dblevins
> >> http://www.tomitribe.com
> >
> >
> >
> >
> >
> > --
> > Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>
>


Re: Documentation site

2020-02-07 Thread Guillermo García
On Thu, Feb 6, 2020 at 11:14 PM David Jencks 
wrote:
>
> After building myself a couple of tiny websites using Antora (
https://antora.org) I’ve become somewhat interested in site generation from
asciidoc
> Does this seem like a direction worth pursuing?  I’m willing to spend a
few days organizing stuff better, fixing the warnings and errors, and
sprucing up the UI (I can change colors and remove the irrelevant stuff
from the header, but advanced css is beyond me at this point).

Hi David,

It's a great approach. Count with me in CSS related changes. Just create
the corresponding JIRA ticket and assign it to my JIRA user: bitcoder.

> There are also a couple of directions of experimentation I might like to
pursue:
>
> — Antora doesn’t have a good strategy for multi-language sites.  Since
there’s at least some translation going on here, this seems like a good
place to try out solutions.  I haven’t found the translations yet :-)
Provisionally my first idea would be to represent languages as versions:
8.0 is english, 8.0-sp, 8.0-pt, 8.0-ru etc are the other languages.   You
could pick your language in the lower left component-version selector (on
the preview only tomee/8.0 is present)


Not sure how i18n is being provided for TomEE documentation.  We could find
a way to track which parts of a translation need to be updated when the
source document changes by using a localization management tool, like the
po4a [1] perl module.

Besides, there's some interesting proposal [2] to use localization in the
AsciiDoc project coming in next releases.

>
> ...
>
> thanks
> David Jencks
>
> ps. My google search for the docs brought up this:
>
> https://tomee.apache.org/latest/docs/documentation.html
>
> which doesn’t look good.
>

It was my first impression too when I was reached the TomEE documentation.
I already fixed some weird characters for the documentation.adoc in
TOMEE-2767 [3], I am just waiting for changes to be deployed.

--
Guillermo Garcia


[1] https://github.com/mquinson/po4a
[2] https://github.com/asciidoctor/asciidoctor/wiki/Design-Doc:-i18n
[3] https://issues.apache.org/jira/browse/TOMEE-2767


Re: Fix Documentation - PR# 628

2020-01-30 Thread Guillermo García
Awesome! My first PR to the project. It's a celebration day. :)

I had to read some documentation and resolve some minor details to get it
done. But now I feel happy. Thanks!


Best,

Guillermo Garcia

On Thu, Jan 30, 2020, 8:58 PM Cesar Hernandez  wrote:

> Hi Guillermo,
>
> PR merged!
> Thanks much for your contribution :)!
>
> El jue., 30 ene. 2020 a las 16:11, Guillermo García ()
> escribió:
>
> > Hello Committers,
> >
> > This is my first PR for the project! I am happy about it.
> >
> > It is just some minimal change in order to try the whole workflow.
> Please,
> > let me know what could I improve and of course take a look at my change.
> > https://github.com/apache/tomee/pull/628
> >
> > Thanks in advance.
> >
> > Best,
> >
> > Guillermo García
> > Software Engineer
> >
>
>
> --
> Atentamente:
> César Hernández.
>


Fix Documentation - PR# 628

2020-01-30 Thread Guillermo García
Hello Committers,

This is my first PR for the project! I am happy about it.

It is just some minimal change in order to try the whole workflow. Please,
let me know what could I improve and of course take a look at my change.
https://github.com/apache/tomee/pull/628

Thanks in advance.

Best,

Guillermo García
Software Engineer


Re: Issue building TomEE

2020-01-30 Thread Guillermo García
On Wed, Jan 29, 2020, 5:06 PM Cesar Hernandez  wrote:

> Hi Guillermo,
> Please use Java 8 and try to build again.
>

Hi Cesar,

Great! Thanks for your kind support. I built TomEE successfully using JDK
oracle64-1.8.0.241.

There's some ambiguity in the installation/build documentation for new
users/developers. In conclusion, we need to improve the Java compatibility
information provided on some pages.

In JIRA, I found two tickets
https://issues.apache.org/jira/browse/TOMEE-2539 and
https://issues.apache.org/jira/browse/TOMEE-2540 to add the
java-compatibility.adoc. We could use this document to link it from any
other installation documentation to make it clear what are the minimum
requirements.

Following a couple of paths:
1. From the homepage to installation pages
2. From the homepage to contribution (how to build) page.
There's no link referencing the "Java Compatibility with TomEE" page.

Also, I read in
https://github.com/apache/tomee/pull/479#issuecomment-500642682 about a
great idea to create a compatibility matrix.

I could work on both documentation improvements. Sounds that good, any
ideas?

As a side note, to have faster results during the verification of your
> environment you can use this "fast build" command [1]:
> mvn -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true
> -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false
> clean install
>
>
Cool beans! I found the same command in the documentation. Thanks.

--
Guillermo Garcia



> [1] http://tomee.apache.org/dev/source-code.html
>
> --
> Atentamente:
> César Hernández.
>


Issue building TomEE

2020-01-29 Thread Guillermo García
Hi Dev Team,

Apologies if I got confused between documentation, and/or mail-list
archives. I cannot find a workaround to resolve this issue.

I am trying to build TomEE from source (tag) v8.0.1 but get the following
error:

Build Command: mvn clean install

> [INFO] --- maven-compiler-plugin:3.6.2:compile (default-compile) @
openejb-client ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 150 source files to
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/target/classes
> [INFO]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/ClientMetaData.java:
Some input files use or override a deprecated API.
> [INFO]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/ClientMetaData.java:
Recompile with -Xlint:deprecation for details.
> [INFO]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/JNDIContext.java:
Some input files use unchecked or unsafe operations.
> [INFO]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/JNDIContext.java:
Recompile with -Xlint:unchecked for details.
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/corba/Corbas.java:[19,21]
package org.omg.CORBA does not exist
> [ERROR]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/corba/Corbas.java:[22,23]
package javax.rmi.CORBA does not exist
> [ERROR]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/corba/Corbas.java:[23,23]
package javax.rmi.CORBA does not exist
> [ERROR]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/corba/Corbas.java:[24,17]
package javax.rmi does not exist
> [ERROR]
/Users/jgarcia/git/tomcat_practices/tomee/server/openejb-client/src/main/java/org/apache/openejb/client/corba/Corbas.java:[43,20]
cannot find symbol
>   symbol:   class ORB
>   location: class org.apache.openejb.client.corba.Corbas

Environment Details:
JDK build 13.0.1+9, 64-bit.
Maven v3.6.3
Hardware:
MacBook Pro
2,5 GHz Quad-Core Intel Core i7
16 GB 1600 MHz DDR3

Is there any known workaround to get a successful build?

Thanks in advance.

Best,

Guillermo García
Software Engineer


Re: How can I help?

2020-01-28 Thread Guillermo García
Hi Cesar.

On Tue, Jan 28, 2020, 10:30 PM Cesar Hernandez  wrote:

> Hola Guillermo,
>
> Welcome to the community and thank you for your interest in fixing the
> issue you found.
> Can you please share your JIRA username so I can assign a contributor role
> and that will allow you to create and move forward the Jira ticket.
>

Thank you for adding the Contributor role. I really appreciate.

Just for the record, my JIRA username is bitcoder

Best,

Guillermo


>
> El mar., 28 ene. 2020 a las 18:38, Guillermo García ()
> escribió:
>
> > Hi Dev Team,
> >
> > [Just following up the formality described in
> > https://tomee.apache.org/community/contributing/contribution-tips.html]
> > I am an independent developer, I am working remotely from Medellín. I am
> > interested in correcting one issue found in the documentation with
> > ASCIIDoc.
> >
> > I think the next step is creating a JIRA Ticket. :)
> >
> > Best,
> >
> > Guillermo García
> > Software Engineer
> >
>
>
> --
> Atentamente:
> César Hernández.
>


Re: Assign TOMEE-2767 to Guillermo Garcia

2020-01-28 Thread Guillermo García
Hi Cesar!

On Tue, Jan 28, 2020, 10:33 PM Cesar Hernandez  wrote:

> Hi Guillermo,
> I just assigned the ticket to you. Thanks!
>

Great!  I appreciate it.

I will open a Pull Request in next minutes.

El mar., 28 ene. 2020 a las 21:31, Guillermo García ()
> escribió:
>
> > Hi Fabio.
> >
> > On Tue, Jan 28, 2020, 9:49 PM Fabio Braga 
> wrote:
> >
> > > terei que baixa o projeto .. me passa o passo a passo para fazer a
> > > correção.
> > >
> > > Fabio braga
> > >
> >
> > I apologize, Portuguese is not my primary language.
> >
> > I cloned the git repo "tomee-master" and have created a local branch with
> > my changes. I need the Jira ticket assigned to me to leave a track of my
> > changes.
> >
> > Is there any missing step required before submitting my fix?
> >
> > Thanks in advance.
> >
> >
> >
> > > Em ter., 28 de jan. de 2020 às 23:36, Fabio Braga <
> > fabiojlbr...@gmail.com>
> > > escreveu:
> > >
> > > > gosteii
> > > >
> > > > Em ter., 28 de jan. de 2020 às 23:25, Guillermo García <
> > > bitco...@gmail.com>
> > > > escreveu:
> > > >
> > > >> Hi Jira Admins,
> > > >>
> > > >> Please, could some Jira Admin assign this ticket to Guillermo Garcia
> > > >> https://issues.apache.org/jira/browse/TOMEE-2767
> > > >> https://powerman.name/doc/asciidoc ?
> > > >>
> > > >> I am following the contributor guidelines to upload this
> documentation
> > > >> fix.
> > > >>
> > > >> Best,
> > > >>
> > > >> Guillermo García
> > > >> Software Engineer
> > > >>
> > > >
> > >
> >
>
>
> --
> Atentamente:
> César Hernández.
>


Re: Assign TOMEE-2767 to Guillermo Garcia

2020-01-28 Thread Guillermo García
Hi Fabio.

On Tue, Jan 28, 2020, 9:49 PM Fabio Braga  wrote:

> terei que baixa o projeto .. me passa o passo a passo para fazer a
> correção.
>
> Fabio braga
>

I apologize, Portuguese is not my primary language.

I cloned the git repo "tomee-master" and have created a local branch with
my changes. I need the Jira ticket assigned to me to leave a track of my
changes.

Is there any missing step required before submitting my fix?

Thanks in advance.



> Em ter., 28 de jan. de 2020 às 23:36, Fabio Braga 
> escreveu:
>
> > gosteii
> >
> > Em ter., 28 de jan. de 2020 às 23:25, Guillermo García <
> bitco...@gmail.com>
> > escreveu:
> >
> >> Hi Jira Admins,
> >>
> >> Please, could some Jira Admin assign this ticket to Guillermo Garcia
> >> https://issues.apache.org/jira/browse/TOMEE-2767
> >> https://powerman.name/doc/asciidoc ?
> >>
> >> I am following the contributor guidelines to upload this documentation
> >> fix.
> >>
> >> Best,
> >>
> >> Guillermo García
> >> Software Engineer
> >>
> >
>


Assign TOMEE-2767 to Guillermo Garcia

2020-01-28 Thread Guillermo García
Hi Jira Admins,

Please, could some Jira Admin assign this ticket to Guillermo Garcia
https://issues.apache.org/jira/browse/TOMEE-2767
https://powerman.name/doc/asciidoc ?

I am following the contributor guidelines to upload this documentation fix.

Best,

Guillermo García
Software Engineer


How can I help?

2020-01-28 Thread Guillermo García
Hi Dev Team,

[Just following up the formality described in
https://tomee.apache.org/community/contributing/contribution-tips.html]
I am an independent developer, I am working remotely from Medellín. I am
interested in correcting one issue found in the documentation with ASCIIDoc.

I think the next step is creating a JIRA Ticket. :)

Best,

Guillermo García
Software Engineer