Re: New Issue and PR

[Jonathan Gallimore]

Done, thank you both!

On Thu, Jun 27, 2019 at 3:54 PM David Salter 
wrote:

> ThanksDaniel :)
>
> > On 27 Jun 2019, at 15:48, Daniel Dias Dos Santos <
> daniel.dias.analist...@gmail.com> wrote:
> >
> > Hi David,
> >
> > Thanks for the contribution,
> >
> > I reviewed your PR .
> >
> > Committers, can you please move forward this contribution.
> > --
> >
> > *Daniel Dias dos Santos*
> > Java Developer
> > SouJava & JCP Member
> > GitHub: https://github.com/Daniel-Dos
> > Linkedin: www.linkedin.com/in/danieldiasjava
> > Twitter: http://twitter.com/danieldiasjava
> >
> >
> > Em qui, 27 de jun de 2019 às 11:43, David Salter <
> wedevelopinj...@gmail.com>
> > escreveu:
> >
> >> Hi,
> >>
> >> I’ve just created a new issue and PR to fix some typos on the MP Config
> >> example readme.
> >>
> >> Could someone take a look and see of these are ok?
> >>
> >> https://issues.apache.org/jira/browse/TOMEE-2552 <
> >> https://issues.apache.org/jira/browse/TOMEE-2552>
> >> https://github.com/apache/tomee/pull/497 <
> >> https://github.com/apache/tomee/pull/497>
> >>
> >> Thanks,
> >>
> >> David.
> >>
> >>
>
>

Re: New Issue and PR

[David Salter]

Thanks Daniel :)

> On 27 Jun 2019, at 15:48, Daniel Dias Dos Santos 
>  wrote:
> 
> Hi David,
> 
> Thanks for the contribution,
> 
> I reviewed your PR .
> 
> Committers, can you please move forward this contribution.
> --
> 
> *Daniel Dias dos Santos*
> Java Developer
> SouJava & JCP Member
> GitHub: https://github.com/Daniel-Dos
> Linkedin: www.linkedin.com/in/danieldiasjava
> Twitter: http://twitter.com/danieldiasjava
> 
> 
> Em qui, 27 de jun de 2019 às 11:43, David Salter 
> escreveu:
> 
>> Hi,
>> 
>> I’ve just created a new issue and PR to fix some typos on the MP Config
>> example readme.
>> 
>> Could someone take a look and see of these are ok?
>> 
>> https://issues.apache.org/jira/browse/TOMEE-2552 <
>> https://issues.apache.org/jira/browse/TOMEE-2552>
>> https://github.com/apache/tomee/pull/497 <
>> https://github.com/apache/tomee/pull/497>
>> 
>> Thanks,
>> 
>> David.
>> 
>> 

Re: New Issue and PR

[Daniel Dias Dos Santos]

Hi David,

Thanks for the contribution,

I reviewed your PR .

Committers, can you please move forward this contribution.
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


Em qui, 27 de jun de 2019 às 11:43, David Salter 
escreveu:

> Hi,
>
> I’ve just created a new issue and PR to fix some typos on the MP Config
> example readme.
>
> Could someone take a look and see of these are ok?
>
> https://issues.apache.org/jira/browse/TOMEE-2552 <
> https://issues.apache.org/jira/browse/TOMEE-2552>
> https://github.com/apache/tomee/pull/497 <
> https://github.com/apache/tomee/pull/497>
>
> Thanks,
>
> David.
>
>

New Issue and PR

[David Salter]

Hi,

I’ve just created a new issue and PR to fix some typos on the MP Config example 
readme.

Could someone take a look and see of these are ok?

https://issues.apache.org/jira/browse/TOMEE-2552 
<https://issues.apache.org/jira/browse/TOMEE-2552>
https://github.com/apache/tomee/pull/497 
<https://github.com/apache/tomee/pull/497>

Thanks,

David.

Re: New Issue and PR

[Richard Monson-Haefel]

Good catch, David!

On Sun, May 26, 2019 at 7:30 PM David Salter 
wrote:

> Hi,
>
> I’ve just created an issue in Jira (
> https://issues.apache.org/jira/browse/TOMEE-252) about the Active MQ
> Resource Adapter config page not rendering correctly.
>
> I’ve created a PR for this on GitHub at:
>
> https://github.com/apache/tomee/pull/472
>
> Can someone assign the issue to me and take a look to see if the PR is ok?
>
> Thanks.
>
> David



-- 
Richard Monson-Haefel
https://twitter.com/rmonson
https://www.linkedin.com/in/monsonhaefel/

Re: New Issue and PR

[David Jencks]

DavidCount++; //Dropping by to say hi…

David Jencks



> On May 26, 2019, at 10:04 PM, David Blevins  wrote:
> 
>> On May 26, 2019, at 3:53 AM, David Salter  
>> wrote:
>> 
>> Thanks. That makes sense. 
>> 
>> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll 
>> create issues and PRs for :)
> 
> That sounds fantastic!  On this example, I regenerated and did a manual tweak 
> of the resulting html -- this seems to be what's required on "stuck" pages 
> for some reason.  Does this look good?
> 
> - http://localhost:8080/tomee-8.0/docs/activemqresourceadapter-config.html
> 
> Side note, it's fun to have another David on the project again :)  People 
> used to mistake me for David Jencks quite regularly.
> 
> I wonder how many Davids we can get on this thread :)
> 
> 
> -David
> 

Re: New Issue and PR

[David Salter]

Davids FTW !

Thanks David.

The page looks all good now :)

I’ve added a comment into Jira stating this, so the issue can now be closed:

https://issues.apache.org/jira/browse/TOMEE-2527 


Thanks.

David.

> On 27 May 2019, at 06:04, David Blevins  wrote:
> 
>> On May 26, 2019, at 3:53 AM, David Salter  
>> wrote:
>> 
>> Thanks. That makes sense. 
>> 
>> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll 
>> create issues and PRs for :)
> 
> That sounds fantastic!  On this example, I regenerated and did a manual tweak 
> of the resulting html -- this seems to be what's required on "stuck" pages 
> for some reason.  Does this look good?
> 
> - http://localhost:8080/tomee-8.0/docs/activemqresourceadapter-config.html
> 
> Side note, it's fun to have another David on the project again :)  People 
> used to mistake me for David Jencks quite regularly.
> 
> I wonder how many Davids we can get on this thread :)
> 
> 
> -David
> 

Re: New Issue and PR

[David Blevins]

> On May 26, 2019, at 3:53 AM, David Salter  
> wrote:
> 
> Thanks. That makes sense. 
> 
> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll 
> create issues and PRs for :)

That sounds fantastic!  On this example, I regenerated and did a manual tweak 
of the resulting html -- this seems to be what's required on "stuck" pages for 
some reason.  Does this look good?

 - http://localhost:8080/tomee-8.0/docs/activemqresourceadapter-config.html

Side note, it's fun to have another David on the project again :)  People used 
to mistake me for David Jencks quite regularly.

I wonder how many Davids we can get on this thread :)


-David

Re: New Issue and PR

[David Blevins]

Just a note that this hit moderation.  Found it and approved it.  If you send 
an email to dev-subscr...@tomee.apache.org you'll be good for future emails :)

I've also assigned the JIRA to you.  As soon as I can get the site to publish 
correctly, we can close it.  Thanks again for the PR!


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On May 24, 2019, at 8:41 AM, David Salter  wrote:
> 
> Hi,
> 
> I’ve just created an issue in Jira 
> (https://issues.apache.org/jira/browse/TOMEE-252) about the Active MQ 
> Resource Adapter config page not rendering correctly.
> 
> I’ve created a PR for this on GitHub at: 
> 
> https://github.com/apache/tomee/pull/472
> 
> Can someone assign the issue to me and take a look to see if the PR is ok?
> 
> Thanks.
> 
> David

New Issue and PR

[David Salter]

Hi,

I’ve just created an issue in Jira 
(https://issues.apache.org/jira/browse/TOMEE-252) about the Active MQ Resource 
Adapter config page not rendering correctly.

I’ve created a PR for this on GitHub at: 

https://github.com/apache/tomee/pull/472

Can someone assign the issue to me and take a look to see if the PR is ok?

Thanks.

David

Re: New Issue and PR

[David Salter]

Thanks. That makes sense. 

As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll 
create issues and PRs for :)

Thanks

David. 


> On 26 May 2019, at 02:32, David Blevins  wrote:
> 
> You didn't do anything wrong.  We had some blockage in the CMS recently do 
> the fact that we have *so* much more doc action going on:
> 
> - https://issues.apache.org/jira/browse/INFRA-18328
> 
> We've been pushing the CMS :)  Yay, us!
> 
> It appears to be functioning, but some docs are "stuck" and it just seems to 
> take some manual work to get them unstuck and synching properly.
> 
> Not sure I'll get to it today, but I'll see if I can push on it again 
> tomorrow.
> 
> 
> -- 
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
> 
>> On May 25, 2019, at 7:25 AM, David Salter  
>> wrote:
>> 
>> Thanks David :)
>> 
>> I don’t see the changes on the site though. They should be available at:
>> 
>> http://tomee.apache.org/tomee-8.0/docs/activemqresourceadapter-config.html
>> 
>> Have I done something wrong?
>> 
>> Thanks
>> 
>> David. 
>> 
>>> On 25 May 2019, at 04:04, David Blevins  wrote:
>>> 
>>> You should be all published now, David!  Check take a peak at the site and 
>>> let me know if you don't see your change.
>>> 
>>> 
>>> -- 
>>> David Blevins
>>> http://twitter.com/dblevins
>>> http://www.tomitribe.com
>>> 
 On May 24, 2019, at 7:20 PM, David Blevins  wrote:
 
 Thank you, David!  Merged and I'm republishing the website now.
 
 
 -- 
 David Blevins
 http://twitter.com/dblevins
 http://www.tomitribe.com
 
> On May 24, 2019, at 8:56 AM, David Salter 
>  wrote:
> 
> Hi,
> 
> I’ve just created an issue in Jira 
> (https://issues.apache.org/jira/browse/TOMEE-252 
> ) about the Active MQ 
> Resource Adapter config page not rendering correctly.
> 
> I’ve created a PR for this on GitHub at: 
> 
> https://github.com/apache/tomee/pull/472 
> 
> 
> Can someone assign the issue to me and take a look to see if the PR is ok?
> 
> Thanks.
> 
> David
 
>>> 
> 

Re: New Issue and PR

[David Blevins]

You didn't do anything wrong.  We had some blockage in the CMS recently do the 
fact that we have *so* much more doc action going on:

 - https://issues.apache.org/jira/browse/INFRA-18328

We've been pushing the CMS :)  Yay, us!

It appears to be functioning, but some docs are "stuck" and it just seems to 
take some manual work to get them unstuck and synching properly.

Not sure I'll get to it today, but I'll see if I can push on it again tomorrow.


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On May 25, 2019, at 7:25 AM, David Salter  
> wrote:
> 
> Thanks David :)
> 
> I don’t see the changes on the site though. They should be available at:
> 
> http://tomee.apache.org/tomee-8.0/docs/activemqresourceadapter-config.html
> 
> Have I done something wrong?
> 
> Thanks
> 
> David. 
> 
>> On 25 May 2019, at 04:04, David Blevins  wrote:
>> 
>> You should be all published now, David!  Check take a peak at the site and 
>> let me know if you don't see your change.
>> 
>> 
>> -- 
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>> 
>>> On May 24, 2019, at 7:20 PM, David Blevins  wrote:
>>> 
>>> Thank you, David!  Merged and I'm republishing the website now.
>>> 
>>> 
>>> -- 
>>> David Blevins
>>> http://twitter.com/dblevins
>>> http://www.tomitribe.com
>>> 
 On May 24, 2019, at 8:56 AM, David Salter 
  wrote:
 
 Hi,
 
 I’ve just created an issue in Jira 
 (https://issues.apache.org/jira/browse/TOMEE-252 
 ) about the Active MQ 
 Resource Adapter config page not rendering correctly.
 
 I’ve created a PR for this on GitHub at: 
 
 https://github.com/apache/tomee/pull/472 
 
 
 Can someone assign the issue to me and take a look to see if the PR is ok?
 
 Thanks.
 
 David
>>> 
>> 

Re: New Issue and PR

[David Salter]

Thanks David :)

I don’t see the changes on the site though. They should be available at:

http://tomee.apache.org/tomee-8.0/docs/activemqresourceadapter-config.html

Have I done something wrong?

Thanks

David. 

> On 25 May 2019, at 04:04, David Blevins  wrote:
> 
> You should be all published now, David!  Check take a peak at the site and 
> let me know if you don't see your change.
> 
> 
> -- 
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
> 
>> On May 24, 2019, at 7:20 PM, David Blevins  wrote:
>> 
>> Thank you, David!  Merged and I'm republishing the website now.
>> 
>> 
>> -- 
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>> 
>>> On May 24, 2019, at 8:56 AM, David Salter  
>>> wrote:
>>> 
>>> Hi,
>>> 
>>> I’ve just created an issue in Jira 
>>> (https://issues.apache.org/jira/browse/TOMEE-252 
>>> ) about the Active MQ 
>>> Resource Adapter config page not rendering correctly.
>>> 
>>> I’ve created a PR for this on GitHub at: 
>>> 
>>> https://github.com/apache/tomee/pull/472 
>>> 
>>> 
>>> Can someone assign the issue to me and take a look to see if the PR is ok?
>>> 
>>> Thanks.
>>> 
>>> David
>> 
> 

Re: New Issue and PR

[David Blevins]

You should be all published now, David!  Check take a peak at the site and let 
me know if you don't see your change.


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On May 24, 2019, at 7:20 PM, David Blevins  wrote:
> 
> Thank you, David!  Merged and I'm republishing the website now.
> 
> 
> -- 
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
> 
>> On May 24, 2019, at 8:56 AM, David Salter  
>> wrote:
>> 
>> Hi,
>> 
>> I’ve just created an issue in Jira 
>> (https://issues.apache.org/jira/browse/TOMEE-252 
>> ) about the Active MQ 
>> Resource Adapter config page not rendering correctly.
>> 
>> I’ve created a PR for this on GitHub at: 
>> 
>> https://github.com/apache/tomee/pull/472 
>> 
>> 
>> Can someone assign the issue to me and take a look to see if the PR is ok?
>> 
>> Thanks.
>> 
>> David
> 

Re: New Issue and PR

[David Blevins]

Thank you, David!  Merged and I'm republishing the website now.


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On May 24, 2019, at 8:56 AM, David Salter  
> wrote:
> 
> Hi,
> 
> I’ve just created an issue in Jira 
> (https://issues.apache.org/jira/browse/TOMEE-252 
> ) about the Active MQ 
> Resource Adapter config page not rendering correctly.
> 
> I’ve created a PR for this on GitHub at: 
> 
> https://github.com/apache/tomee/pull/472 
> 
> 
> Can someone assign the issue to me and take a look to see if the PR is ok?
> 
> Thanks.
> 
> David

New Issue and PR

[David Salter]

Hi,

I’ve just created an issue in Jira 
(https://issues.apache.org/jira/browse/TOMEE-252 
) about the Active MQ Resource 
Adapter config page not rendering correctly.

I’ve created a PR for this on GitHub at: 

https://github.com/apache/tomee/pull/472 


Can someone assign the issue to me and take a look to see if the PR is ok?

Thanks.

David

Re: New Issue and PR

[Jean-Louis Monteiro]

Reviewed and merged and ticket marked as resolved.
Thanks David for the contribution and thanks Cesar for reviewing.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Apr 24, 2019 at 4:26 AM César Hernández Mendoza <
cesargu...@gmail.com> wrote:

> Hi David,
>
> Thank you for the contribution and opening this email thread with fine
> details about the JIRA Ticket and the related Pull Request opened.
>
> I just assigned the ticket to you and also reviewed the PR.
>
> @Committers
> Please move forward the PR: https://github.com/apache/tomee/pull/463
>
> El sáb., 20 abr. 2019 a las 7:45, David Salter
> () escribió:
>
> > Hi,
> >
> > I’ve just created an issue in Jira regarding incorrect formatting on the
> > Spring and Open EJB documentation page.
> >
> > https://issues.apache.org/jira/browse/TOMEE-2512 <
> > https://issues.apache.org/jira/browse/TOMEE-2512>
> >
> > I’ve submitted a PR to resolve this:
> >
> > https://github.com/apache/tomee/pull/463 <
> > https://github.com/apache/tomee/pull/463>
> >
> > Hope this is ok.  Please let me know if this needs any changes.
> >
> > Thanks.
> >
> > David.
> >
> >
>
> --
> Atentamente:
> César Hernández.
>

Re: New Issue and PR

[César Hernández Mendoza]

Hi David,

Thank you for the contribution and opening this email thread with fine
details about the JIRA Ticket and the related Pull Request opened.

I just assigned the ticket to you and also reviewed the PR.

@Committers
Please move forward the PR: https://github.com/apache/tomee/pull/463

El sáb., 20 abr. 2019 a las 7:45, David Salter
() escribió:

> Hi,
>
> I’ve just created an issue in Jira regarding incorrect formatting on the
> Spring and Open EJB documentation page.
>
> https://issues.apache.org/jira/browse/TOMEE-2512 <
> https://issues.apache.org/jira/browse/TOMEE-2512>
>
> I’ve submitted a PR to resolve this:
>
> https://github.com/apache/tomee/pull/463 <
> https://github.com/apache/tomee/pull/463>
>
> Hope this is ok.  Please let me know if this needs any changes.
>
> Thanks.
>
> David.
>
>

-- 
Atentamente:
César Hernández.

New Issue and PR

[David Salter]

Hi,

I’ve just created an issue in Jira regarding incorrect formatting on the Spring 
and Open EJB documentation page.

https://issues.apache.org/jira/browse/TOMEE-2512 


I’ve submitted a PR to resolve this:

https://github.com/apache/tomee/pull/463 


Hope this is ok.  Please let me know if this needs any changes.

Thanks.

David.