Re: Please review PR# 217
ok Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 16:32, Jonathan Gallimore wrote: I already merged it - it looked good to me. Thanks for the PR, and congrats on your first Open Source contribution! Jon On Fri, 23 Nov 2018, 16:12 Frankie Could someone please review this PR? It is my first contribution to an open source project ever, so please be graceful (and give hints) if I missed something ... ;-) This trivial dependency update was the perfect issue for that, so I could focus on the tools and processes. Thank you. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
Re: Please review PR# 217
I already merged it - it looked good to me. Thanks for the PR, and congrats on your first Open Source contribution! Jon On Fri, 23 Nov 2018, 16:12 Frankie Could someone please review this PR? > > It is my first contribution to an open source project ever, so please be > graceful (and give hints) if I missed something ... ;-) > This trivial dependency update was the perfect issue for that, so I could > focus on the tools and processes. > > Thank you. > > > > -- > Sent from: > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html >
Re: Please review PR# 217
Thanks Frankie! I'll have a look. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 16:12, Frankie wrote: Could someone please review this PR? It is my first contribution to an open source project ever, so please be graceful (and give hints) if I missed something ... ;-) This trivial dependency update was the perfect issue for that, so I could focus on the tools and processes. Thank you. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
Re: Please review PR# 217
BTW: why is the automatic generated message from the PR noted "by cesarhernandezgt"? -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
Please review PR# 217
Could someone please review this PR? It is my first contribution to an open source project ever, so please be graceful (and give hints) if I missed something ... ;-) This trivial dependency update was the perfect issue for that, so I could focus on the tools and processes. Thank you. -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
