Re: Another 2.x beta release

2012-02-16 Thread ant elder
On Thu, Feb 9, 2012 at 11:50 PM, Luciano Resende luckbr1...@gmail.com wrote:


 If I don't get them done by sunday night, then i don't want to hold this ...


Turns out the internet where i am is slow and flaky and I'm not making
fast progress on this so no one needs to worry about holding anything
up for now.

   ...ant


[jira] [Created] (TUSCANY-4016) NodeImpl startComposite forgets about a composite if there is a failure on start

2012-02-16 Thread Simon Laws (Created) (JIRA)
NodeImpl startComposite forgets about a composite if there is a failure on start


 Key: TUSCANY-4016
 URL: https://issues.apache.org/jira/browse/TUSCANY-4016
 Project: Tuscany
  Issue Type: Bug
  Components: SCA Java Runtime
Affects Versions: Java-SCA-2.0-Beta3
 Environment: All
Reporter: Simon Laws


org.apache.tuscany.sca.impl.NodeImpl does the following on start

public void startComposite(String contributionURI, String compositeURI) 
throws ActivationException, ValidationException, ContributionReadException {
String key = contributionURI+/+compositeURI;
if (startedComposites.containsKey(key)) {
throw new IllegalStateException(composite already started:  + 
compositeURI);
}
DeployedComposite dc = stoppedComposites.remove(key);
if (dc != null) {
dc.start();
startedComposites.put(key, dc);

and the following on stop

String key = contributionURI+/+compositeURI;
DeployedComposite dc = startedComposites.remove(key);
if (dc != null) {
dc.stop();
stoppedComposites.put(key, dc);
} else {


If an error is thrown on start it won't be in startedComposites but some of the 
providers may have been started. So even in the failure case we should consider 
the composite partially started so that it can be stopped correctly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: Another 2.x beta release

2012-02-16 Thread Luciano Resende
On Thu, Feb 16, 2012 at 7:06 AM, ant elder antel...@apache.org wrote:
 On Thu, Feb 9, 2012 at 11:50 PM, Luciano Resende luckbr1...@gmail.com wrote:


 If I don't get them done by sunday night, then i don't want to hold this ...


 Turns out the internet where i am is slow and flaky and I'm not making
 fast progress on this so no one needs to worry about holding anything
 up for now.

   ...ant

Thanks for the updates, we have brought up the current trunk to our
environment successfully, so I'm done with the bug fixing part.
I'm still working on the policy archetype, but that's not a must.

-- 
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/