[GitHub] twill issue #20: Remove unnecessary methods to get the root log level

[chtyim]

Github user chtyim commented on the issue:

https://github.com/apache/twill/pull/20
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #19: Fix ConcurrentModificationException from removal in ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/twill/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #17: Change initial application submission log message fr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/twill/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #18: Fix reset log level for runnables started up later

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/twill/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill issue #18: Fix reset log level for runnables started up later

[chtyim]

Github user chtyim commented on the issue:

https://github.com/apache/twill/pull/18
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #18: Fix reset log level for runnables started up later

[yaojiefeng]

GitHub user yaojiefeng opened a pull request:

https://github.com/apache/twill/pull/18

Fix reset log level for runnables started up later

There is a bug when we try to reset log levels for some runnables which are 
started up later, e.g, restart or instance changes, after some runtime log 
level changes. For now, when we start up the `TwillContainerService`, we set 
log levels based on the what we try to set in `TwillPreparer` + runtime log 
levels. But we do not memorize the old log level for loggers changed at 
runtime. So we we reset, we will not get back to the state we want.
This PR fixes this by memorizing the log level changes coming from runtime. 
And remove when we call reset.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yaojiefeng/twill 
fix/remember-the-runtime-log-level-change-during-startup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/twill/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18


commit ae01446bfd9c02982428b8b25ec7fe40b33c89f6
Author: yaojiefeng 
Date:   2016-12-13T12:03:55Z

fix reset log level for runnables




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744792#comment-15744792
 ] 

ASF GitHub Bot commented on TWILL-138:
--

Github user yaojiefeng commented on the issue:

https://github.com/apache/twill/pull/14
  
Thanks! @hsaputra 


> Runtime change of Application runnable log level
> 
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
>  Issue Type: New Feature
>  Components: core
>Reporter: Henry Saputra
>Assignee: Yaojie Feng
> Fix For: 0.9.0
>
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] twill issue #14: TWILL-138 Runtime log level change

[yaojiefeng]

Github user yaojiefeng commented on the issue:

https://github.com/apache/twill/pull/14
  
Thanks! @hsaputra 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---