Pull request 597
Hi all, I need to get this PR merged into master. I have fixed all tests and some bugs to ensure that the build compiles and tests correctly. https://github.com/apache/usergrid/pull/597 Thanks, Keyur
Re: [VOTE] Michael Russo as new VP of Usergrid
+1 -shawn On Mon, Sep 24, 2018 at 2:03 PM Todd Nine wrote: > Hi All, > After some discussion on the private list, Michael Russo has volunteered > to take over as the VP of Apache Usergrid. I have too much on my plate to > continue, I'm not giving it the attention it deserves. I think Russo is a > great choice to become the VP of Usergrid. > > This vote will close 72 hours from now. It needs 3 +1 votes from PMC > members to pass. > > +1 > > Thanks, > Todd >
[VOTE] Michael Russo as new VP of Usergrid
Hi All, After some discussion on the private list, Michael Russo has volunteered to take over as the VP of Apache Usergrid. I have too much on my plate to continue, I'm not giving it the attention it deserves. I think Russo is a great choice to become the VP of Usergrid. This vote will close 72 hours from now. It needs 3 +1 votes from PMC members to pass. +1 Thanks, Todd
Re: [VOTE] Michael Russo as new VP of Usergrid
+1 -- Rod Simpson On September 24, 2018 at 2:05:12 PM, Shawn Feldman (shawn.feld...@gmail.com) wrote: +1 -shawn On Mon, Sep 24, 2018 at 2:03 PM Todd Nine wrote: > Hi All, > After some discussion on the private list, Michael Russo has volunteered > to take over as the VP of Apache Usergrid. I have too much on my plate to > continue, I'm not giving it the attention it deserves. I think Russo is a > great choice to become the VP of Usergrid. > > This vote will close 72 hours from now. It needs 3 +1 votes from PMC > members to pass. > > +1 > > Thanks, > Todd >
Re: [VOTE] Michael Russo as new VP of Usergrid
+1 On Mon, Sep 24, 2018 at 1:03 PM Todd Nine wrote: > Hi All, > After some discussion on the private list, Michael Russo has volunteered > to take over as the VP of Apache Usergrid. I have too much on my plate to > continue, I'm not giving it the attention it deserves. I think Russo is a > great choice to become the VP of Usergrid. > > This vote will close 72 hours from now. It needs 3 +1 votes from PMC > members to pass. > > +1 > > Thanks, > Todd >
Re: [VOTE] Michael Russo as new VP of Usergrid
+1 On Mon, Sep 24, 2018, 13:11 Ed Anuff wrote: > +1 > > On Mon, Sep 24, 2018 at 1:03 PM Todd Nine wrote: > > > Hi All, > > After some discussion on the private list, Michael Russo has > volunteered > > to take over as the VP of Apache Usergrid. I have too much on my plate > to > > continue, I'm not giving it the attention it deserves. I think Russo > is a > > great choice to become the VP of Usergrid. > > > > This vote will close 72 hours from now. It needs 3 +1 votes from PMC > > members to pass. > > > > +1 > > > > Thanks, > > Todd > > >
Re: [VOTE] Michael Russo as new VP of Usergrid
+1 On Mon, Sep 24, 2018 at 1:23 PM Keyur Karnik wrote: > +1 > > On Mon, Sep 24, 2018, 13:11 Ed Anuff wrote: > > > +1 > > > > On Mon, Sep 24, 2018 at 1:03 PM Todd Nine wrote: > > > > > Hi All, > > > After some discussion on the private list, Michael Russo has > > volunteered > > > to take over as the VP of Apache Usergrid. I have too much on my plate > > to > > > continue, I'm not giving it the attention it deserves. I think Russo > > is a > > > great choice to become the VP of Usergrid. > > > > > > This vote will close 72 hours from now. It needs 3 +1 votes from PMC > > > members to pass. > > > > > > +1 > > > > > > Thanks, > > > Todd > > > > > >
[jira] [Resolved] (USERGRID-1348) Fix ignored test in CollectionDeleteTest
[ https://issues.apache.org/jira/browse/USERGRID-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keyur Karnik resolved USERGRID-1348. Resolution: Fixed > Fix ignored test in CollectionDeleteTest > > > Key: USERGRID-1348 > URL: https://issues.apache.org/jira/browse/USERGRID-1348 > Project: Usergrid > Issue Type: Bug > Components: Stack >Affects Versions: 2.2.0 >Reporter: Keyur Karnik >Priority: Minor > Fix For: 2.2.0 > > > The CollectionDeleteTest has been ignored with a "fix later" comment. This > test fails sporadically and will require some debugging. > This should not affect actual functionality as Collection Delete has been > tested and found working. > Ref : > https://github.com/apache/usergrid/blob/3c31713fe366d446c0b1bacd2b89dd3c5eed8db8/stack/core/src/test/java/org/apache/usergrid/persistence/CollectionDeleteTest.java#L46 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (USERGRID-1348) Fix ignored test in CollectionDeleteTest
Keyur Karnik created USERGRID-1348: -- Summary: Fix ignored test in CollectionDeleteTest Key: USERGRID-1348 URL: https://issues.apache.org/jira/browse/USERGRID-1348 Project: Usergrid Issue Type: Bug Components: Stack Affects Versions: 2.2.0 Reporter: Keyur Karnik Fix For: 2.2.0 The CollectionDeleteTest has been ignored with a "fix later" comment. This test fails sporadically and will require some debugging. This should not affect actual functionality as Collection Delete has been tested and found working. Ref : https://github.com/apache/usergrid/blob/3c31713fe366d446c0b1bacd2b89dd3c5eed8db8/stack/core/src/test/java/org/apache/usergrid/persistence/CollectionDeleteTest.java#L46 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] usergrid pull request #597: Patchset of changes made by Mike Dunker from ano...
Github user keyurkarnik commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/597#discussion_r220033772
--- Diff:
stack/core/src/test/java/org/apache/usergrid/persistence/CollectionDeleteTest.java
---
@@ -42,6 +43,7 @@
@NotThreadSafe
+@Ignore("fix later")
--- End diff --
Created JIRA ticket https://issues.apache.org/jira/browse/USERGRID-1348
Fixed the issue as well.
---
[jira] [Commented] (USERGRID-1348) Fix ignored test in CollectionDeleteTest
[
https://issues.apache.org/jira/browse/USERGRID-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626639#comment-16626639
]
ASF GitHub Bot commented on USERGRID-1348:
--
Github user keyurkarnik commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/597#discussion_r220033772
--- Diff:
stack/core/src/test/java/org/apache/usergrid/persistence/CollectionDeleteTest.java
---
@@ -42,6 +43,7 @@
@NotThreadSafe
+@Ignore("fix later")
--- End diff --
Created JIRA ticket https://issues.apache.org/jira/browse/USERGRID-1348
Fixed the issue as well.
> Fix ignored test in CollectionDeleteTest
>
>
> Key: USERGRID-1348
> URL: https://issues.apache.org/jira/browse/USERGRID-1348
> Project: Usergrid
> Issue Type: Bug
> Components: Stack
>Affects Versions: 2.2.0
>Reporter: Keyur Karnik
>Priority: Minor
> Fix For: 2.2.0
>
>
> The CollectionDeleteTest has been ignored with a "fix later" comment. This
> test fails sporadically and will require some debugging.
> This should not affect actual functionality as Collection Delete has been
> tested and found working.
> Ref :
> https://github.com/apache/usergrid/blob/3c31713fe366d446c0b1bacd2b89dd3c5eed8db8/stack/core/src/test/java/org/apache/usergrid/persistence/CollectionDeleteTest.java#L46
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (USERGRID-1348) Fix ignored test in CollectionDeleteTest
[ https://issues.apache.org/jira/browse/USERGRID-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626644#comment-16626644 ] Keyur Karnik commented on USERGRID-1348: Fixed here : https://github.com/apache/usergrid/pull/597/commits/5fc3c506a14ac28a702a2c146466b9f3907e4125 > Fix ignored test in CollectionDeleteTest > > > Key: USERGRID-1348 > URL: https://issues.apache.org/jira/browse/USERGRID-1348 > Project: Usergrid > Issue Type: Bug > Components: Stack >Affects Versions: 2.2.0 >Reporter: Keyur Karnik >Priority: Minor > Fix For: 2.2.0 > > > The CollectionDeleteTest has been ignored with a "fix later" comment. This > test fails sporadically and will require some debugging. > This should not affect actual functionality as Collection Delete has been > tested and found working. > Ref : > https://github.com/apache/usergrid/blob/3c31713fe366d446c0b1bacd2b89dd3c5eed8db8/stack/core/src/test/java/org/apache/usergrid/persistence/CollectionDeleteTest.java#L46 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Michael Russo as new VP of Usergrid
+1 > On Sep 24, 2018, at 1:24 PM, Alex Muramoto wrote: > > +1 > > On Mon, Sep 24, 2018 at 1:23 PM Keyur Karnik wrote: > >> +1 >> >> On Mon, Sep 24, 2018, 13:11 Ed Anuff wrote: >> >>> +1 >>> >>> On Mon, Sep 24, 2018 at 1:03 PM Todd Nine wrote: >>> Hi All, After some discussion on the private list, Michael Russo has >>> volunteered to take over as the VP of Apache Usergrid. I have too much on my plate >>> to continue, I'm not giving it the attention it deserves. I think Russo >>> is a great choice to become the VP of Usergrid. This vote will close 72 hours from now. It needs 3 +1 votes from PMC members to pass. +1 Thanks, Todd >>> >>
[GitHub] usergrid pull request #597: Patchset of changes made by Mike Dunker from ano...
Github user michaelarusso commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/597#discussion_r219968111
--- Diff:
stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/CandidateResult.java
---
@@ -54,25 +99,69 @@ public String getDocId() {
return docId;
}
+public String getDirectEntityName() {
+return directEntityName;
+}
+
+public UUID getDirectEntityUUID() {
+return directEntityUUID;
+}
+
+public String getDirectEntityType() {
+return directEntityType;
+}
+
+// use to set id for direct query after resolution
+public void setId(Id entityId) {
+this.entityId = entityId;
+}
+
@Override
public boolean equals( final Object o ) {
if ( this == o ) {
return true;
}
+if ( o == null ) {
+return false;
+}
if ( !( o instanceof CandidateResult ) ) {
return false;
}
final CandidateResult that = ( CandidateResult ) o;
-if ( !entityId.equals( that.entityId ) ) {
+if ( entityId == null && that.entityId != null) {
--- End diff --
Do we have extra tests for all these additional conditions to equals()
---
[GitHub] usergrid pull request #597: Patchset of changes made by Mike Dunker from ano...
Github user michaelarusso commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/597#discussion_r219960051
--- Diff:
stack/core/src/test/java/org/apache/usergrid/persistence/CollectionDeleteTest.java
---
@@ -42,6 +43,7 @@
@NotThreadSafe
+@Ignore("fix later")
--- End diff --
Can we get a JIRA ticket opened with detail only this and link the ignore
comment to the JIRA ticket.
---
[GitHub] usergrid pull request #597: Patchset of changes made by Mike Dunker from ano...
Github user michaelarusso commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/597#discussion_r219963200
--- Diff:
stack/core/src/main/java/org/apache/usergrid/corepersistence/service/ApplicationRestorePasswordServiceImpl.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.usergrid.corepersistence.service;
+
+import com.google.common.base.Preconditions;
+import com.google.inject.Inject;
+import org.apache.commons.lang.StringUtils;
+import org.apache.usergrid.corepersistence.util.CpNamingUtils;
+import org.apache.usergrid.persistence.map.MapManager;
+import org.apache.usergrid.persistence.map.MapManagerFactory;
+import org.apache.usergrid.persistence.map.impl.MapScopeImpl;
+import org.apache.usergrid.persistence.model.entity.Id;
+
+import java.util.UUID;
+
+public class ApplicationRestorePasswordServiceImpl implements
ApplicationRestorePasswordService {
--- End diff --
Also probably good to create JIRA ticket about the new feature and link to
this PR.
---
[GitHub] usergrid pull request #597: Patchset of changes made by Mike Dunker from ano...
Github user michaelarusso commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/597#discussion_r219960347
--- Diff:
stack/core/src/main/java/org/apache/usergrid/corepersistence/service/ApplicationRestorePasswordServiceImpl.java
---
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.usergrid.corepersistence.service;
+
+import com.google.common.base.Preconditions;
+import com.google.inject.Inject;
+import org.apache.commons.lang.StringUtils;
+import org.apache.usergrid.corepersistence.util.CpNamingUtils;
+import org.apache.usergrid.persistence.map.MapManager;
+import org.apache.usergrid.persistence.map.MapManagerFactory;
+import org.apache.usergrid.persistence.map.impl.MapScopeImpl;
+import org.apache.usergrid.persistence.model.entity.Id;
+
+import java.util.UUID;
+
+public class ApplicationRestorePasswordServiceImpl implements
ApplicationRestorePasswordService {
--- End diff --
Can you add a comment that describes what this class is for?
---
[GitHub] usergrid pull request #597: Patchset of changes made by Mike Dunker from ano...
Github user michaelarusso commented on a diff in the pull request:
https://github.com/apache/usergrid/pull/597#discussion_r219960121
--- Diff:
stack/core/src/main/java/org/apache/usergrid/persistence/PathQuery.java ---
@@ -122,10 +126,30 @@ protected Results getHeadResults( EntityManager em )
throws Exception {
EntityRef ref = new SimpleEntityRef(type,uuid);
-// if it's a single name identifier, just directly fetch that
-if ( !query.getQl().isPresent() &&
query.getSingleNameOrEmailIdentifier() != null){
+if ( !query.getQl().isPresent() && query.getSingleUuidIdentifier()
!= null) {
--- End diff --
What is the reasoning behind this change?
---
