[jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation
[ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-861. Resolution: Fixed Applied patch to 1.x trunk. Changed javacc4.2 version to 4.1 in documentation. Improve parser modification and build documentation --- Key: VELOCITY-861 URL: https://issues.apache.org/jira/browse/VELOCITY-861 Project: Velocity Issue Type: Improvement Components: Build, Documentation Affects Versions: 1.x Reporter: Mike Kienenberger Assignee: Mike Kienenberger Fix For: 1.x Attachments: build-parser-documentation-update.patch Removed .../parser/build.sh as this functionality is an out-of-date version of what is found in the main ant build script parser task. Added a license header and updated the portions of the build-and-modify-parser readme found in src/java/org/apache/velocity/runtime/parser/BUILD_README.txt. Moved improved src/java/org/apache/velocity/runtime/parser/BUILD_README.txt to build/BUILD_PARSER_README.txt as it is not obvious to go looking for documentation in src/java/org/apache/velocity/runtime/parser when you are modifying src/parser and running build/build.xml Replaced previous src/java/org/apache/velocity/runtime/parser/BUILD_README.txt with a simplified version that warns about directly modifying files here and points back to build/BUILD_PARSER_README.txt. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation
Should issues be Resolved or Closed? So far I've been closing them. On 06/02/2015 10:25 PM, Mike Kienenberger (JIRA) wrote: [ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-861. Resolution: Fixed -- Sergiu Dumitriu http://purl.org/net/sergiu/ - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation
OK, thanks for the explanation. On 06/02/2015 10:37 PM, Mike Kienenberger wrote: I guess I should be more specific. Using resolve on fix and close on release: -- Allows users to see at a glance to know if the bug is unfixed, fixed but unreleased, or released. -- Allows the release manager to quickly generate a list of changes. (At least, I'm guessing it will) On Tue, Jun 2, 2015 at 10:34 PM, Mike Kienenberger mkien...@gmail.com wrote: I like to resolve when fixed in svn and to close when released. I think it's more meaningful. On Tue, Jun 2, 2015 at 10:30 PM, Sergiu Dumitriu sergiu.dumit...@gmail.com wrote: Should issues be Resolved or Closed? So far I've been closing them. On 06/02/2015 10:25 PM, Mike Kienenberger (JIRA) wrote: [ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-861. Resolution: Fixed -- Sergiu Dumitriu http://purl.org/net/sergiu/ - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org -- Sergiu Dumitriu http://purl.org/net/sergiu/ - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation
I like to resolve when fixed in svn and to close when released. I think it's more meaningful. On Tue, Jun 2, 2015 at 10:30 PM, Sergiu Dumitriu sergiu.dumit...@gmail.com wrote: Should issues be Resolved or Closed? So far I've been closing them. On 06/02/2015 10:25 PM, Mike Kienenberger (JIRA) wrote: [ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-861. Resolution: Fixed -- Sergiu Dumitriu http://purl.org/net/sergiu/ - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [jira] [Resolved] (VELOCITY-861) Improve parser modification and build documentation
I guess I should be more specific. Using resolve on fix and close on release: -- Allows users to see at a glance to know if the bug is unfixed, fixed but unreleased, or released. -- Allows the release manager to quickly generate a list of changes. (At least, I'm guessing it will) On Tue, Jun 2, 2015 at 10:34 PM, Mike Kienenberger mkien...@gmail.com wrote: I like to resolve when fixed in svn and to close when released. I think it's more meaningful. On Tue, Jun 2, 2015 at 10:30 PM, Sergiu Dumitriu sergiu.dumit...@gmail.com wrote: Should issues be Resolved or Closed? So far I've been closing them. On 06/02/2015 10:25 PM, Mike Kienenberger (JIRA) wrote: [ https://issues.apache.org/jira/browse/VELOCITY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger resolved VELOCITY-861. Resolution: Fixed -- Sergiu Dumitriu http://purl.org/net/sergiu/ - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
