Re: Replace Facebook/Yoga with a new implementation.

2017-11-05 Thread 申远
Extremely busy coding for double 11 now.

> 在 2017年11月5日,14:23,Adam Feng  写道:
> 
> How's it going? We need to release a version as soon as Yoga is removed.
> 
> Thanks.
> Adam Feng
> 
> On 12 Oct 2017, 10:37 PM +0800, 申远 , wrote:
>> flex-grow is already supported by flex shorthand, and it’s possible to 
>> support flex-shrink in later version.
>> While, flex-basis is the same as main size which is supported already except 
>> for percent value. I think support percent unit is a huge, duplicate and 
>> unnecessary work for most CSS style, after all I am trying to achieve an 
>> elegant implementation of CSS, excluding dummy, heavy, duplicate part of 
>> CSS. But It makes sense that flex-basis should support and only support 
>> percent value. For baseline, I think if iOS Framework is able to pass 
>> ascent, descent, half-leading, top and bottom to layout engine, layout 
>> engine itself has no problem to manipulate these values.
>> 
>>> 在 2017年10月12日,17:16,xing zhang  写道:
>>> 
>>> Should we consider about layout percent unit, flex-shrink, flex-grow,
>>> flexBasis, and baseline in align-Items ?
>>> 
>>> 2017-10-12 16:54 GMT+08:00 申远 :
>>> 
 Dear all,
 
 I’m considering replacing Facebook/Yoga to a new layout system based on
 Google/Flexbox due to Facebook’s additional patent issue. Besides, this new
 layout system will provide some new css style like order, etc.
 
 Any advise for the new layout system?
 
 PS: I need some advise about the name of the layout system.
>> 



[GitHub] incubator-weex-site issue #2: [WEEX-86] Update documentation for contributio...

2017-11-05 Thread Hanks10100
Github user Hanks10100 commented on the issue:

https://github.com/apache/incubator-weex-site/pull/2
  
This PR is already merged into master.


---


[jira] [Commented] (WEEX-86) Reorganize the structure of documents and website

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239844#comment-16239844
 ] 

ASF GitHub Bot commented on WEEX-86:


Github user Hanks10100 commented on the issue:

https://github.com/apache/incubator-weex-site/pull/2
  
This PR is already merged into master.


> Reorganize the structure of documents and website
> -
>
> Key: WEEX-86
> URL: https://issues.apache.org/jira/browse/WEEX-86
> Project: Weex
>  Issue Type: Improvement
>  Components: Project 
>Reporter: Hanks Zhang
>Assignee: zhengshihan
>
> h1. Weex Document Index
> + contributing.md
> + development-process.md
> + who-is-using-weex.md
> + releasenote.md
> + resources.md
> h2. Guide
> + index.md
> + advanced
>   + app-architecture.md
>   + downgrade.md
>   + page-architecture.md
>   + path.md
>   + use-vuex-and-vue-router.md
> + extend-android.md
> + extend-ios.md
> + extend-js-framework.md
> + extend-web-render.md
> + front-end-frameworks.md
> + integrate-devtool-to-android.md
> + integrate-devtool-to-ios.md
> + integrate-to-your-app.md
> + set-up-env.md
> + using-rax.md
> + using-vue.md
> h2.  References
> + index.md
> + android-apis.md
> + ios-apis.md
> + js-framework-apis.md
> + js-service.md
> + weex-variable.md
> h3. Components
> + a.md
> + cell.md
> + div.md
> + image.md
> + indicator.md
> + input.md
> + list.md
> + loading.md
> + refresh.md
> + scroller.md
> + slider.md
> + switch.md
> + text.md
> + textarea.md
> + video.md
> + waterfall.md
> + web.md
> h3. Modules
> + animation.md
> + clipboard.md
> + dom.md
> + globalevent.md
> + meta.md
> + modal.md
> + navigator.md
> + picker.md
> + storage.md
> + stream.md
> + websocket.md
> + webview.md
> h2. WiKi
> + color-names.md
> + common-events.md
> + common-styles.md
> + css-units.md
> + design-principles.md
> + event-bubble.md
> + faq.md
> + gestures.md
> + index.md
> + platform-difference.md
> + text-styles.md
> h2. Tools
> + helpers.md
> + index.md
> + market.md
> + toolkit.md



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: the max-width for css-style should be taken into consideration when drawing text

2017-11-05 Thread xing zhang
It's related with the algorithm drawing text: consider width first,  if the
css width is not specified, (consider about max-width now ) then we use
`infinite` width as it's width meassuring the height.  But people may don't
know it's text width , the max-width is set.
In a words, calculate text height accords the width input.

As for max-height in mdn:
https://developer.mozilla.org/en-US/docs/Web/CSS/max-height , max-height
overrides height, but min-height overrides max-height.  It behaves more
like `height`. They all clip the content when it's content exceeded,  so
people can now specify height.

We consider max-height/height less when drawing text, people can use
`height` to clip content calculated.

2017-11-05 14:16 GMT+08:00 Adam Feng :

> Thanks for your contribution,  I have seen the pull request and reviewed
> the code,  it looked good to me,   can `max-height` also be supported?
>
> Thanks.
> Adam Feng
>
> On 5 Nov 2017, 12:22 PM +0800, xing zhang ,
> wrote:
> > Hi , I open an issue for support max-width in iOS, as it works well
> both on Android and web.
> >
> > As I test the css for `max-width`, it works well both on Android and Web
> platform except iOS.
> > Here is the test code on DotWe  website:
> >
> > http://dotwe.org/vue/7e556c582a55630518d0bf6336ddde0e
> >
> > When meassuring the width of drawing text , the max-width of css-style
> should take into consideration.It seems that only width for css-style works.
> >
> > The attachment  is the screenshot both on iOS and  web(html5).
> >
> > ..
> >
> >
> >
> > And later, I will open an pull request to resolve this bug.
>


[jira] [Created] (WEEX-92) How to use playground

2017-11-05 Thread wei (JIRA)
wei created WEEX-92:
---

 Summary: How to use playground
 Key: WEEX-92
 URL: https://issues.apache.org/jira/browse/WEEX-92
 Project: Weex
  Issue Type: Task
  Components: iOS
Affects Versions: 0.12
Reporter: wei
Assignee: Adam Feng
Priority: Blocker


Why scanning QR code use playground in phone is show a blank, i found this 
[#http://dotwe.org/vue/6792fe75b4ba4661b0d154aa99618ed9/] only support code on 
line. how to use playground debugger in my local?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Plugin development

2017-11-05 Thread Adam Feng
Hi,

Again,  thanks for your contribution.

Maybe I can answer the first question,   The PR title should be of the form 
[WEEX-][COMPONENT] Title, where  is the relevant JIRA number, COMPONENT 
is one of the PR categories(android, iOS, jsfm, web, component, doc, website, 
example, test, other) , which is described in our develop process [1] (being 
reviewed and will be merged soon).

For the second question,  can any Android developers have a check?

[1] 
https://github.com/cxfeng1/incubator-weex-site/blob/doc-contributing/source/development-process.md

Thanks.
Adam Feng

On 5 Nov 2017, 10:40 PM +0800, Tiago Alves , wrote:
> Hi!
>
> Done! https://github.com/apache/incubator-weex-site/pull/8 :D
>
> I have a couple questions:
>
> - Why do all PR names start with [WEEX-86][doc]? Namely, what does
> [WEEX-86] mean? I think this explanation should be part of the contributing
> guide.
>
> - I couldn't quite get the android test plugin playground app to work on my
> machine. The android dependencies are not correct. Anyone knows how to run
> the android playground app inside the plugin project (playground/android)?
>
> Thanks!
> Tiago
>
>
> On Sun, 5 Nov 2017 at 04:13 Adam Feng  wrote:
>
> > Hi, Tiago,
> >
> > Thanks for your contribution! You can follow the new contribution
> > guide[1](which is being reviewed and will be merged soon) to improve the
> > documentation.
> >
> > [1]
> > https://github.com/cxfeng1/incubator-weex-site/blob/6a04e077e896709c5797ad30d9a31632a8e0a193/source/contributing.md
> >
> > Thanks.
> > Adam Feng
> >
> > On 5 Nov 2017, 3:28 AM +0800, Tiago Alves , wrote:
> > > I figured it out.
> > >
> > > weex plugin create weex-my-plugin
> > >
> > > Then there are more instructions in doc/how-to-develop.md.
> > >
> > > I will translate this document, add more info and PR it to the docs.
> > Seems
> > > important!
> > >
> > > Tiago
> > >
> > > On Sat, 4 Nov 2017 at 16:06 Tiago Alves  wrote:
> > >
> > > > Good day!
> > > >
> > > > I am developing a weex plugin. I feel it will be a great oportunity
> > for me
> > > > to help improving the plugin docs.
> > > >
> > > > I remember reading docs about developing a weex plugin (plugin.xml,
> > etc),
> > > > but thats seems to be gone along with the legacy stuff. Is there any
> > docs
> > > > that would help me getting started?
> > > >
> > > > I am using this plugin as reference
> > > > https://github.com/weex-plugins/weex-amap, but this sort of reverse
> > > > engineering gives the constant feeling that I am missing out on
> > something.
> > > >
> > > > Thanks!
> > > > Tiago
> > > >
> >


Re: Plugin development

2017-11-05 Thread Tiago Alves
Hi!

Done! https://github.com/apache/incubator-weex-site/pull/8 :D

I have a couple questions:

- Why do all PR names start with [WEEX-86][doc]? Namely, what does
[WEEX-86] mean? I think this explanation should be part of the contributing
guide.

- I couldn't quite get the android test plugin playground app to work on my
machine. The android dependencies are not correct. Anyone knows how to run
the android playground app inside the plugin project (playground/android)?

Thanks!
Tiago


On Sun, 5 Nov 2017 at 04:13 Adam Feng  wrote:

> Hi, Tiago,
>
> Thanks for your contribution! You can follow the new contribution
> guide[1](which is being reviewed and will be merged soon) to improve the
> documentation.
>
> [1]
> https://github.com/cxfeng1/incubator-weex-site/blob/6a04e077e896709c5797ad30d9a31632a8e0a193/source/contributing.md
>
> Thanks.
> Adam Feng
>
> On 5 Nov 2017, 3:28 AM +0800, Tiago Alves , wrote:
> > I figured it out.
> >
> > weex plugin create weex-my-plugin
> >
> > Then there are more instructions in doc/how-to-develop.md.
> >
> > I will translate this document, add more info and PR it to the docs.
> Seems
> > important!
> >
> > Tiago
> >
> > On Sat, 4 Nov 2017 at 16:06 Tiago Alves  wrote:
> >
> > > Good day!
> > >
> > > I am developing a weex plugin. I feel it will be a great oportunity
> for me
> > > to help improving the plugin docs.
> > >
> > > I remember reading docs about developing a weex plugin (plugin.xml,
> etc),
> > > but thats seems to be gone along with the legacy stuff. Is there any
> docs
> > > that would help me getting started?
> > >
> > > I am using this plugin as reference
> > > https://github.com/weex-plugins/weex-amap, but this sort of reverse
> > > engineering gives the constant feeling that I am missing out on
> something.
> > >
> > > Thanks!
> > > Tiago
> > >
>


[GitHub] incubator-weex-site issue #8: [WEEX-86][doc] Adds a guide on how to create a...

2017-11-05 Thread cxfeng1
Github user cxfeng1 commented on the issue:

https://github.com/apache/incubator-weex-site/pull/8
  
@Hanks10100 Please have a review.


---


[jira] [Commented] (WEEX-86) Reorganize the structure of documents and website

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239563#comment-16239563
 ] 

ASF GitHub Bot commented on WEEX-86:


Github user cxfeng1 commented on the issue:

https://github.com/apache/incubator-weex-site/pull/8
  
@Hanks10100 Please have a review.


> Reorganize the structure of documents and website
> -
>
> Key: WEEX-86
> URL: https://issues.apache.org/jira/browse/WEEX-86
> Project: Weex
>  Issue Type: Improvement
>  Components: Project 
>Reporter: Hanks Zhang
>Assignee: zhengshihan
>
> h1. Weex Document Index
> + contributing.md
> + development-process.md
> + who-is-using-weex.md
> + releasenote.md
> + resources.md
> h2. Guide
> + index.md
> + advanced
>   + app-architecture.md
>   + downgrade.md
>   + page-architecture.md
>   + path.md
>   + use-vuex-and-vue-router.md
> + extend-android.md
> + extend-ios.md
> + extend-js-framework.md
> + extend-web-render.md
> + front-end-frameworks.md
> + integrate-devtool-to-android.md
> + integrate-devtool-to-ios.md
> + integrate-to-your-app.md
> + set-up-env.md
> + using-rax.md
> + using-vue.md
> h2.  References
> + index.md
> + android-apis.md
> + ios-apis.md
> + js-framework-apis.md
> + js-service.md
> + weex-variable.md
> h3. Components
> + a.md
> + cell.md
> + div.md
> + image.md
> + indicator.md
> + input.md
> + list.md
> + loading.md
> + refresh.md
> + scroller.md
> + slider.md
> + switch.md
> + text.md
> + textarea.md
> + video.md
> + waterfall.md
> + web.md
> h3. Modules
> + animation.md
> + clipboard.md
> + dom.md
> + globalevent.md
> + meta.md
> + modal.md
> + navigator.md
> + picker.md
> + storage.md
> + stream.md
> + websocket.md
> + webview.md
> h2. WiKi
> + color-names.md
> + common-events.md
> + common-styles.md
> + css-units.md
> + design-principles.md
> + event-bubble.md
> + faq.md
> + gestures.md
> + index.md
> + platform-difference.md
> + text-styles.md
> h2. Tools
> + helpers.md
> + index.md
> + market.md
> + toolkit.md



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] incubator-weex-site pull request #8: guide-feature-create-plugin

2017-11-05 Thread tralves
GitHub user tralves opened a pull request:

https://github.com/apache/incubator-weex-site/pull/8

guide-feature-create-plugin

Greetings,

This PR adds the page "Create a plugin" to guide the user on the process of 
starting, developing, testing and deploying a plugin.

I hope it helps. Looking forward for your comments on it.

Thanks,
Tiago

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tralves/incubator-weex-site master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex-site/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit bf9de101b7c82254e1aa6ee9add25a65bf8f98c3
Author: Tiago Alves 
Date:   2017-11-05T14:22:08Z

+ [guide] create a plugin




---