[jira] [Commented] (WEEX-479) Expect to not hide the navigation bar when opening weex debug
[ https://issues.apache.org/jira/browse/WEEX-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530718#comment-16530718 ] ASF GitHub Bot commented on WEEX-479: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex/pull/1291 > Expect to not hide the navigation bar when opening weex debug > - > > Key: WEEX-479 > URL: https://issues.apache.org/jira/browse/WEEX-479 > Project: Weex > Issue Type: Bug >Reporter: erha19 >Assignee: erha19 >Priority: Major > > I found that the [weex > bundle|https://github.com/Hanks10100/weex-vue-examples/blob/master/src/pages/landing/Landing.js#L7] > has used `titlebar` module to hiding the title bar, but while the next page > needs the title bar, it's ok when you are not open the weex debug switch, > when you open it, it will always be hiding because of the `titlebar` module > used on the `landing` page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-479) Expect to not hide the navigation bar when opening weex debug
[ https://issues.apache.org/jira/browse/WEEX-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524600#comment-16524600 ] ASF GitHub Bot commented on WEEX-479: - Github user Hanks10100 commented on the issue: https://github.com/apache/incubator-weex/pull/1291 The new files are not compressed. Every thing else looks fine for me. > Expect to not hide the navigation bar when opening weex debug > - > > Key: WEEX-479 > URL: https://issues.apache.org/jira/browse/WEEX-479 > Project: Weex > Issue Type: Bug >Reporter: erha19 >Assignee: erha19 >Priority: Major > > I found that the [weex > bundle|https://github.com/Hanks10100/weex-vue-examples/blob/master/src/pages/landing/Landing.js#L7] > has used `titlebar` module to hiding the title bar, but while the next page > needs the title bar, it's ok when you are not open the weex debug switch, > when you open it, it will always be hiding because of the `titlebar` module > used on the `landing` page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-479) Expect to not hide the navigation bar when opening weex debug
[ https://issues.apache.org/jira/browse/WEEX-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524484#comment-16524484 ] ASF GitHub Bot commented on WEEX-479: - Github user erha19 commented on the issue: https://github.com/apache/incubator-weex/pull/1291 @Hanks10100 needs you review > Expect to not hide the navigation bar when opening weex debug > - > > Key: WEEX-479 > URL: https://issues.apache.org/jira/browse/WEEX-479 > Project: Weex > Issue Type: Bug >Reporter: erha19 >Assignee: erha19 >Priority: Major > > I found that the [weex > bundle|https://github.com/Hanks10100/weex-vue-examples/blob/master/src/pages/landing/Landing.js#L7] > has used `titlebar` module to hiding the title bar, but while the next page > needs the title bar, it's ok when you are not open the weex debug switch, > when you open it, it will always be hiding because of the `titlebar` module > used on the `landing` page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-479) Expect to not hide the navigation bar when opening weex debug
[ https://issues.apache.org/jira/browse/WEEX-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523330#comment-16523330 ] erha19 commented on WEEX-479: - Fixed it https://github.com/apache/incubator-weex/pull/1291 https://github.com/Hanks10100/weex-vue-examples/pull/18 > Expect to not hide the navigation bar when opening weex debug > - > > Key: WEEX-479 > URL: https://issues.apache.org/jira/browse/WEEX-479 > Project: Weex > Issue Type: Bug >Reporter: erha19 >Assignee: erha19 >Priority: Major > > I found that the [weex > bundle|https://github.com/Hanks10100/weex-vue-examples/blob/master/src/pages/landing/Landing.js#L7] > has used `titlebar` module to hiding the title bar, but while the next page > needs the title bar, it's ok when you are not open the weex debug switch, > when you open it, it will always be hiding because of the `titlebar` module > used on the `landing` page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-479) Expect to not hide the navigation bar when opening weex debug
[ https://issues.apache.org/jira/browse/WEEX-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523329#comment-16523329 ] ASF GitHub Bot commented on WEEX-479: - Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1291 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS > Expect to not hide the navigation bar when opening weex debug > - > > Key: WEEX-479 > URL: https://issues.apache.org/jira/browse/WEEX-479 > Project: Weex > Issue Type: Bug >Reporter: erha19 >Assignee: erha19 >Priority: Major > > I found that the [weex > bundle|https://github.com/Hanks10100/weex-vue-examples/blob/master/src/pages/landing/Landing.js#L7] > has used `titlebar` module to hiding the title bar, but while the next page > needs the title bar, it's ok when you are not open the weex debug switch, > when you open it, it will always be hiding because of the `titlebar` module > used on the `landing` page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-479) Expect to not hide the navigation bar when opening weex debug
[ https://issues.apache.org/jira/browse/WEEX-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523326#comment-16523326 ] ASF GitHub Bot commented on WEEX-479: - GitHub user erha19 opened a pull request: https://github.com/apache/incubator-weex/pull/1291 [WEEX-479] update jsbundle of weex playground app Fixed jira issue: https://issues.apache.org/jira/browse/WEEX-479 You can merge this pull request into a Git repository by running: $ git pull https://github.com/erha19/incubator-weex master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1291.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1291 commit b4de266b7ae82ec3759c937380b9f0e0201488ff Author: erha19 Date: 2018-06-26T07:05:45Z * [js] update jsbundle of weex playground app > Expect to not hide the navigation bar when opening weex debug > - > > Key: WEEX-479 > URL: https://issues.apache.org/jira/browse/WEEX-479 > Project: Weex > Issue Type: Bug >Reporter: erha19 >Assignee: erha19 >Priority: Major > > I found that the [weex > bundle|https://github.com/Hanks10100/weex-vue-examples/blob/master/src/pages/landing/Landing.js#L7] > has used `titlebar` module to hiding the title bar, but while the next page > needs the title bar, it's ok when you are not open the weex debug switch, > when you open it, it will always be hiding because of the `titlebar` module > used on the `landing` page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
