[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753937#comment-17753937 ] Sebb commented on WHIMSY-404: - It only exists as a command-line tool at present; it cannot be plugged into Whimsy without further work. The manual process is: - checkout the relevant agenda - run the tool (requires Ruby) - check the changes - replace the agenda with the fixed version - commit the changes > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753867#comment-17753867 ] Craig L Russell commented on WHIMSY-404: Given that this tool is expected to be low usage, perhaps all that should be done now is to add it to the "Useful Officer/Member tools" in whimsy [https://whimsy.apache.org/officers/] Thank you for creating this tool. > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753366#comment-17753366 ] Sebb commented on WHIMSY-404: - I've created a library routine and CLI tool which is able to repair the broken agenda file from r113354. This leaves the file in a state that can be modified and committed without an error. However, it does not look to be at all easy to include it in the agenda work-flow. For example, currently only individual report bodies can be edited, but the errors may occur in the headers. Given that broken files are very rare, I don't propose to update the agenda tool. The file repair code is in a separate library module, so can easily be invoked from the agenda if it is decided to integrate it into app at a later point. > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752204#comment-17752204 ] Craig L Russell commented on WHIMSY-404: The minimum marketable function from my perspective: Add code to (refresh) to scan the file for illegal characters. If found: edit the file to replace the illegal characters with "unknown"; commit the changes with a message "Invalid UTF-8 characters found in agenda_2023_09_21.txt; manual edit needed"; then proceed to the normal (refresh) processing. I agree that extensive changes to a tool that will be replaced sometime before 2030 is not warranted. > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752194#comment-17752194 ] Sebb commented on WHIMSY-404: - The most recent case was caused by the use of characters encoded in a scheme other than UTF-8. They were correct in their encoding, but not in UTF-8. As such, the characters needed replacement not deletion. Given that this hardly every occurs, I am not sure that it is worth the effort of doing anything other than replacing the bad characters with the relevant marker and flagging up that the agenda needs to be corrected at some point. It is easy enough to search for this character in the source, and usually the correct replacement will be obvious (all of the recent issues were caused by accents in names, apart from one spurious symbol). There is no way of knowing for sure what the original encoding of each character was, so in general it is not possible to automate replacement. Indeed if several edits are made outside Whimsy, multiple encodings may be involved. If this was a frequent occurrence it might be worth trying to develop some heuristics to automate the process, but I suspect that would be quite a lot of effort, and not guaranteed to work. Also note that the Whimsy agenda app is slated to be retired at some point, so non-essential work on it is likely to be wasted effort. I think the minimum that needs to be done is to replace invalid characters with the standard unknown character marker - � - so that edits no longer cause a crash. It would be sensible to provide some sort of notification that this has been necessary so the necessary manual correction(s) can be made at some point. > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752152#comment-17752152 ] Craig L Russell commented on WHIMSY-404: It looks like we are in agreement that the (refresh) button handler would be an appropriate locus for action. Since this affects all users, not just the user that committed the error. At the point where the handler detects an errant character, it should determine where the character is and notify the appropriate group that there was a problem. If it is in a project report, the error was most probably introduced by the project, and the project private mail list would be good to include on a message to:board, cc:private@project that an error was detected. If the error was anywhere else, probably just to:board is sufficient. I'm not sure that any dialog with the user is needed. But if it is, perhaps a dialog with the proposed diff and (cancel) or (confirm) buttons would be suitable. This situation has only happened twice that I can recall, and in both cases simply deleting the erroneous characters was appropriate. Is there a case that would require additional user action? > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751814#comment-17751814 ] Sebb commented on WHIMSY-404: - Seems to me it would be better to replace any errant characters with the standard unknown character marker: https://www.fileformat.info/info/unicode/char/fffd/index.htm Also, it would be helpful to provide feedback that the file contains one or more such characters, so these can be found and fixed. Note that the file may be updated outside Whimsy. > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751767#comment-17751767 ] Craig L Russell commented on WHIMSY-404: We know what the problem is. We know that whimsy agenda has full svn read/write access to the agenda svn file. The only thing left is when to fix it. I propose that whenever any user asks for a (refresh), whimsy will (should) detect an error. If that error is an errant UTF-8 character, then whimsy should open the agenda, find the errant character(s), delete it(them), and update the file. > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (WHIMSY-404) Can't post project report.
[ https://issues.apache.org/jira/browse/WHIMSY-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751342#comment-17751342 ] Sebb commented on WHIMSY-404: - This was caused by a commit that added a character which was not in UTF-8. The agenda has been adjusted to replace the invalid characters, and commits appear to be working again. It's not clear if the erroneous commit was originated by Whimsy or externally, but ideally Whimsy should not fail if the problem recurs. > Can't post project report. > -- > > Key: WHIMSY-404 > URL: https://issues.apache.org/jira/browse/WHIMSY-404 > Project: Whimsy > Issue Type: Bug > Components: BoardAgenda >Reporter: James Bognar >Priority: Major > > Trying to save project report gives this error message: > Exception > # > Here's the report we're trying to submit. > https://whimsy.apache.org/board/agenda/2023-08-16/Juneau -- This message was sent by Atlassian Jira (v8.20.10#820010)
