WebApplication.addIgnoreMountPath(String)
Hi, A have a Wicket 1.5 question: There is a comment in org.apache.wicket.protocol.http.WebApplication.addIgnoreMountPath(String) : public final void addIgnoreMountPath(String path) { // TODO how is this supposed to work :/ throw new UnsupportedOperationException(); } Idea: currently the root mapper is SystemMapper which extends CompoundRequestMapper. We can instanceof and cast here to CompoundRequestMapper and add the list of ignored paths and later on in org.apache.wicket.request.mapper.CompoundRequestMapper.mapRequest(Request) we can check the ignored ones first and then iterate over the added mappers. The only problem I see is that the user can register another root IRequestMapper with org.apache.wicket.Application.setRootRequestMapper(IRequestMapper) and then this feature will stop working. But in this case many other things wont work too - see org.apache.wicket.SystemMapper.SystemMapper(Application). What do you think ?
Re: WebApplication.addIgnoreMountPath(String)
why do we need this? afaik in 1.4 wicket filter can be configured to ignore paths -igor On Mon, Jul 19, 2010 at 8:49 AM, Martin Grigorov mgrigo...@apache.org wrote: Hi, A have a Wicket 1.5 question: There is a comment in org.apache.wicket.protocol.http.WebApplication.addIgnoreMountPath(String) : public final void addIgnoreMountPath(String path) { // TODO how is this supposed to work :/ throw new UnsupportedOperationException(); } Idea: currently the root mapper is SystemMapper which extends CompoundRequestMapper. We can instanceof and cast here to CompoundRequestMapper and add the list of ignored paths and later on in org.apache.wicket.request.mapper.CompoundRequestMapper.mapRequest(Request) we can check the ignored ones first and then iterate over the added mappers. The only problem I see is that the user can register another root IRequestMapper with org.apache.wicket.Application.setRootRequestMapper(IRequestMapper) and then this feature will stop working. But in this case many other things wont work too - see org.apache.wicket.SystemMapper.SystemMapper(Application). What do you think ?
Welcome Martin Grigorov as a core team member
The Wicket team is happy to announce that Martin Grigorov was invited to join the Wicket team as a committer and PMC member, and he accepted! Martin's relentless patience, high quality patches and sustained energy haven't gone unnoticed. He has continually provided valuable insights and put a lot of effort into the project. He helps out many on the mailing lists and IRC channel. In Martin's first two days with access, he's already made 16 commits and closed several JIRA issues. We look forward to his continued contributions. Please join me in welcoming Martin to the team! -- Jeremy Thomerson http://www.wickettraining.com
Re: WebApplication.addIgnoreMountPath(String)
Presumably because you can not configure the wicket filter through code? I agree. The use case is thin. Regards, Erik. Op 19-07-10 18:24, Igor Vaynberg wrote: why do we need this? afaik in 1.4 wicket filter can be configured to ignore paths -igor -- Sent from my SMTP compliant software Erik van Oosten http://day-to-day-stuff.blogspot.com/
Re: WebApplication.addIgnoreMountPath(String)
you can by subclassing it... -igor On Mon, Jul 19, 2010 at 10:50 AM, Erik van Oosten e.vanoos...@grons.nl wrote: Presumably because you can not configure the wicket filter through code? I agree. The use case is thin. Regards, Erik. Op 19-07-10 18:24, Igor Vaynberg wrote: why do we need this? afaik in 1.4 wicket filter can be configured to ignore paths -igor -- Sent from my SMTP compliant software Erik van Oosten http://day-to-day-stuff.blogspot.com/