Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Martin Grigorov 
+1 for vote in users@

I just found a problem while creating new wicket-example for the new request
mappers:

java.lang.StackOverflowError
 at
org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
 at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
 at
org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 at org.apache.wicket.Component.initialize(Component.java:970)
 at
org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
 at org.apache.wicket.Page.componentAdded(Page.java:1130)
 at
org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
 at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
 at
org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 at org.apache.wicket.Component.initialize(Component.java:970)
 at
org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
 at org.apache.wicket.Page.componentAdded(Page.java:1130)
 at
org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
 at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
 at
org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 at org.apache.wicket.Component.initialize(Component.java:970)
 at
org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
 at org.apache.wicket.Page.componentAdded(Page.java:1130)
 at
org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
 at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
 at
org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 at org.apache.wicket.Component.initialize(Component.java:970)
 at
org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
 at org.apache.wicket.Page.componentAdded(Page.java:1130)
 at
org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
 at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
 at
org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 at org.apache.wicket.Component.initialize(Component.java:970)


In 
org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
I have add(header).

My fix looks is:
Index: wicket/src/main/java/org/apache/wicket/Component.java
===
--- wicket/src/main/java/org/apache/wicket/Component.java (revision 978819)
+++ wicket/src/main/java/org/apache/wicket/Component.java (working copy)
@@ -967,8 +967,8 @@
  {
  if (!getFlag(FLAG_INITIALIZED))
  {
+ setFlag(FLAG_INITIALIZED, true);
  onInitialize();
- setFlag(FLAG_INITIALIZED, true);
  }
  }

Is this ok ?

On Fri, Jul 23, 2010 at 5:45 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote:

 since this has turned into more of a vote should we take it to the
 user list so we get a wider range of responses?

 -igor

 On Fri, Jul 23, 2010 at 1:50 AM, Martijn Dashorst
 martijn.dasho...@gmail.com wrote:
  +1 for Johan's changes to make the surface area of the change smaller.
 
  I didn't find onInitialize and onConfigure in our code base as well.
 
  The benefits are evident. So that is +0 from me to keep them in.
  Pushing them to only 1.5 ensures we get enough folks trying 1.5 though
  :)
 
  Martijn
 
  On Fri, Jul 23, 2010 at 10:38 AM, Johan Compagner jcompag...@gmail.com
 wrote:
  we (servoy) dont care much about those changes, they can be left in
  (we dont use it and they also dont give us a problem (after my fix ;)
  )
 
 
  the only problem is by the way onInitialize and onConfigure()
 
  Because initialize and also doInitialize() are package scope so they
  are not a problem as far as i know... for example doinitialize() is
  final but a subclass of component in another package can just create
  such a method just fine...
 
  configure() you made public final.. i think we just should do the
  same, make it package scope final...
  then that method shouldnt also be a big problem.
 
  The it is just the 2 overridable protected methods onInitialize and
 onConfigure
 
  johan
 
 
  On Thu, Jul 22, 2010 at 19:33, Igor Vaynberg igor.vaynb...@gmail.com
 wrote:
  i just thought of something, i added oninitialize and onconfigure
  features to 1.4.x as well as trunk, but they can create an
  incompatibility for 1.4.x users if they have declared a method on
  their components with the same name.
 
  impacted method names are component#configure(), onConfigure(),
  initialize(), onInitialize().
 
  should we remove these features from 1.4.x to remove the chance of an
  incompatibility?
 
  -igor
 
 
 
 
 
  --
  Become a Wicket expert, learn from the best: http://wicketinaction.com
  Apache Wicket 1.4 increases type safety for web applications
  Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.8

Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Johan Compagner 
I think that fix should be fine
The thing i have is why does Page.componentAdded() really call initialize again
Will that not happen anyway?

Also now i do see a but of weird initializing when you see the order..
In MarkupContainer.addedComponent:

if (page != null)
{
component.initialize();
}

if (page != null)
{
page.componentAdded(component);
}


so first we call component initialize. then page.componentAdded that
will call initialize on the page.
But isnt that a bit the wrong way around?

If you are in the constructor of a page and you add a component.
Then i think the component is called initialized on and
page.componentAdded will then call initialize on itself
But then the component is called initialized first before the page is
initialized
AND we are still in the constructor of the page so initialize is
suddenly called on a page that is still constructing?
(i have to test this a bit, just looking at the code quickly)

i think we should have some logic that as long as the page is not
initialized, component shouldnt also be initialized.
And for a page the same thing as for a component should happen, only
after construction the initialize is called.

johan


On Sat, Jul 24, 2010 at 11:05, Martin Grigorov mgrigo...@apache.org wrote:
 +1 for vote in users@

 I just found a problem while creating new wicket-example for the new request
 mappers:

 java.lang.StackOverflowError
  at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
 

 In 
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 I have add(header).

 My fix looks is:
 Index: wicket/src/main/java/org/apache/wicket/Component.java
 ===
 --- wicket/src/main/java/org/apache/wicket/Component.java (revision 978819)
 +++ wicket/src/main/java/org/apache/wicket/Component.java (working copy)
 @@ -967,8 +967,8 @@
  {
  if (!getFlag(FLAG_INITIALIZED))
  {
 + setFlag(FLAG_INITIALIZED, true);
  onInitialize();
 - setFlag(FLAG_INITIALIZED, true);
  }
  }

 Is this ok ?

 On Fri, Jul 23, 2010 at 5:45 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote:

 since this has turned into more of a vote should we take it to the
 user list so we get a wider range of responses?

 -igor

 On Fri, Jul 23, 2010 at 1:50 AM, Martijn Dashorst
 martijn.dasho...@gmail.com wrote:
  +1 for Johan's changes to make the surface area of the change smaller.
 
  I didn't find onInitialize and onConfigure in our code base as well.
 
  The benefits are evident. So that is +0 from me to keep them in.
  Pushing them to only 1.5 ensures we get enough folks trying 1.5 though
  :)
 
  Martijn
 
  On Fri, Jul 23, 2010 at 10:38 AM, Johan Compagner jcompag...@gmail.com
 wrote:
  we (servoy) dont care much

Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Martijn Dashorst 
Given these nuances, and the binary incompatibilty, shouldn't we just
revert for 1.4.x and ensure proper working in 1.5?

It's not that folks are unable to create awesome apps with 1.4 without
these changes. I'd rather not introduce subtle bugs into 1.4.x at this
stage.

Martijn

On Sat, Jul 24, 2010 at 11:19 AM, Johan Compagner jcompag...@gmail.com wrote:
 I think that fix should be fine
 The thing i have is why does Page.componentAdded() really call initialize 
 again
 Will that not happen anyway?

 Also now i do see a but of weird initializing when you see the order..
 In MarkupContainer.addedComponent:

                if (page != null)
                {
                        component.initialize();
                }

                if (page != null)
                {
                        page.componentAdded(component);
                }


 so first we call component initialize. then page.componentAdded that
 will call initialize on the page.
 But isnt that a bit the wrong way around?

 If you are in the constructor of a page and you add a component.
 Then i think the component is called initialized on and
 page.componentAdded will then call initialize on itself
 But then the component is called initialized first before the page is
 initialized
 AND we are still in the constructor of the page so initialize is
 suddenly called on a page that is still constructing?
 (i have to test this a bit, just looking at the code quickly)

 i think we should have some logic that as long as the page is not
 initialized, component shouldnt also be initialized.
 And for a page the same thing as for a component should happen, only
 after construction the initialize is called.

 johan


 On Sat, Jul 24, 2010 at 11:05, Martin Grigorov mgrigo...@apache.org wrote:
 +1 for vote in users@

 I just found a problem while creating new wicket-example for the new request
 mappers:

 java.lang.StackOverflowError
  at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
 

 In 
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 I have add(header).

 My fix looks is:
 Index: wicket/src/main/java/org/apache/wicket/Component.java
 ===
 --- wicket/src/main/java/org/apache/wicket/Component.java (revision 978819)
 +++ wicket/src/main/java/org/apache/wicket/Component.java (working copy)
 @@ -967,8 +967,8 @@
  {
  if (!getFlag(FLAG_INITIALIZED))
  {
 + setFlag(FLAG_INITIALIZED, true);
  onInitialize();
 - setFlag(FLAG_INITIALIZED, true);
  }
  }

 Is this ok ?

 On Fri, Jul 23, 2010 at 5:45 PM, Igor Vaynberg 
 igor.vaynb...@gmail.comwrote:

 since this has turned into more of a vote should we take it to the
 user list so we get a wider range of responses?

 -igor

 On Fri, Jul 23, 2010 at 1:50 AM, Martijn Dashorst
 martijn.dasho...@gmail.com wrote:
  +1 for Johan's changes to make

Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Igor Vaynberg 
On Sat, Jul 24, 2010 at 2:19 AM, Johan Compagner jcompag...@gmail.com wrote:
 I think that fix should be fine
 The thing i have is why does Page.componentAdded() really call initialize 
 again

its called because the page object itself needs to have onInitialize()
called on it.

-igor

 Will that not happen anyway?

 Also now i do see a but of weird initializing when you see the order..
 In MarkupContainer.addedComponent:

                if (page != null)
                {
                        component.initialize();
                }

                if (page != null)
                {
                        page.componentAdded(component);
                }


 so first we call component initialize. then page.componentAdded that
 will call initialize on the page.
 But isnt that a bit the wrong way around?

 If you are in the constructor of a page and you add a component.
 Then i think the component is called initialized on and
 page.componentAdded will then call initialize on itself
 But then the component is called initialized first before the page is
 initialized
 AND we are still in the constructor of the page so initialize is
 suddenly called on a page that is still constructing?
 (i have to test this a bit, just looking at the code quickly)

 i think we should have some logic that as long as the page is not
 initialized, component shouldnt also be initialized.
 And for a page the same thing as for a component should happen, only
 after construction the initialize is called.

 johan


 On Sat, Jul 24, 2010 at 11:05, Martin Grigorov mgrigo...@apache.org wrote:
 +1 for vote in users@

 I just found a problem while creating new wicket-example for the new request
 mappers:

 java.lang.StackOverflowError
  at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
 

 In 
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 I have add(header).

 My fix looks is:
 Index: wicket/src/main/java/org/apache/wicket/Component.java
 ===
 --- wicket/src/main/java/org/apache/wicket/Component.java (revision 978819)
 +++ wicket/src/main/java/org/apache/wicket/Component.java (working copy)
 @@ -967,8 +967,8 @@
  {
  if (!getFlag(FLAG_INITIALIZED))
  {
 + setFlag(FLAG_INITIALIZED, true);
  onInitialize();
 - setFlag(FLAG_INITIALIZED, true);
  }
  }

 Is this ok ?

 On Fri, Jul 23, 2010 at 5:45 PM, Igor Vaynberg 
 igor.vaynb...@gmail.comwrote:

 since this has turned into more of a vote should we take it to the
 user list so we get a wider range of responses?

 -igor

 On Fri, Jul 23, 2010 at 1:50 AM, Martijn Dashorst
 martijn.dasho...@gmail.com wrote:
  +1 for Johan's changes to make the surface area of the change smaller.
 
  I didn't find onInitialize and onConfigure in our code base as well.
 
  The benefits are evident. So that is +0 from me to keep them in.

Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Igor Vaynberg 
recrete it in ComponentInitializationTest and fix it :)

-igor

On Sat, Jul 24, 2010 at 2:05 AM, Martin Grigorov mgrigo...@apache.org wrote:
 +1 for vote in users@

 I just found a problem while creating new wicket-example for the new request
 mappers:

 java.lang.StackOverflowError
  at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
     at
 org.apache.wicket.MarkupContainer.initialize(MarkupContainer.java:992)
     at org.apache.wicket.Page.componentAdded(Page.java:1130)
     at
 org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978)
     at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168)
     at
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
     at org.apache.wicket.Component.initialize(Component.java:970)
 

 In 
 org.apache.wicket.examples.WicketExamplePage.onInitialize(WicketExamplePage.java:67)
 I have add(header).

 My fix looks is:
 Index: wicket/src/main/java/org/apache/wicket/Component.java
 ===
 --- wicket/src/main/java/org/apache/wicket/Component.java (revision 978819)
 +++ wicket/src/main/java/org/apache/wicket/Component.java (working copy)
 @@ -967,8 +967,8 @@
  {
  if (!getFlag(FLAG_INITIALIZED))
  {
 + setFlag(FLAG_INITIALIZED, true);
  onInitialize();
 - setFlag(FLAG_INITIALIZED, true);
  }
  }

 Is this ok ?

 On Fri, Jul 23, 2010 at 5:45 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote:

 since this has turned into more of a vote should we take it to the
 user list so we get a wider range of responses?

 -igor

 On Fri, Jul 23, 2010 at 1:50 AM, Martijn Dashorst
 martijn.dasho...@gmail.com wrote:
  +1 for Johan's changes to make the surface area of the change smaller.
 
  I didn't find onInitialize and onConfigure in our code base as well.
 
  The benefits are evident. So that is +0 from me to keep them in.
  Pushing them to only 1.5 ensures we get enough folks trying 1.5 though
  :)
 
  Martijn
 
  On Fri, Jul 23, 2010 at 10:38 AM, Johan Compagner jcompag...@gmail.com
 wrote:
  we (servoy) dont care much about those changes, they can be left in
  (we dont use it and they also dont give us a problem (after my fix ;)
  )
 
 
  the only problem is by the way onInitialize and onConfigure()
 
  Because initialize and also doInitialize() are package scope so they
  are not a problem as far as i know... for example doinitialize() is
  final but a subclass of component in another package can just create
  such a method just fine...
 
  configure() you made public final.. i think we just should do the
  same, make it package scope final...
  then that method shouldnt also be a big problem.
 
  The it is just the 2 overridable protected methods onInitialize and
 onConfigure
 
  johan
 
 
  On Thu, Jul 22, 2010 at 19:33, Igor Vaynberg igor.vaynb...@gmail.com
 wrote:
  i just thought of something, i added oninitialize and onconfigure
  features to 1.4.x as well as trunk, but they can create an
  incompatibility for 1.4.x users if they have declared a method on
  their components with the same name.
 
  impacted method names are component#configure(), onConfigure(),
  initialize(), onInitialize().
 
  should we remove these features from 1.4.x to remove the chance of an
  incompatibility?
 
  -igor
 
 
 
 
 
  --
  Become a Wicket expert, learn from

Examples for the new request mappers

2010-07-24 Thread Martin Grigorov 
Hi,

I just added a new wicket-examples application (Wicket 1.5 only) showing two
custom request mappers:
* custom home page - e.g. requesting http://example.com will load
Application#getHomePage() at http://example.com/custom/path
* locale first mapper - the session locale is encoded as first segment in
the url. This feature is often asked in the mailing lists and I used the
mapper Igor posted about a year ago in the mailing lists.

The examples will be visible at http://wicketstuff.org/wicket/ after the
next deploy of the snapshot.

If you have ideas for more examples with the new request mappers now is the
moment to share them ;-)

martin-g

Re: Examples for the new request mappers

2010-07-24 Thread Martin Makundi 
Hi M! Is was there a tutorial on this topic?

**
Martin

2010/7/24 Martin Grigorov mgrigo...@apache.org:
 Hi,

 I just added a new wicket-examples application (Wicket 1.5 only) showing two
 custom request mappers:
 * custom home page - e.g. requesting http://example.com will load
 Application#getHomePage() at http://example.com/custom/path
 * locale first mapper - the session locale is encoded as first segment in
 the url. This feature is often asked in the mailing lists and I used the
 mapper Igor posted about a year ago in the mailing lists.

 The examples will be visible at http://wicketstuff.org/wicket/ after the
 next deploy of the snapshot.

 If you have ideas for more examples with the new request mappers now is the
 moment to share them ;-)

 martin-g

Re: Examples for the new request mappers

2010-07-24 Thread Martin Grigorov 
For now the only tutorial is the source code :-/

On Sat, Jul 24, 2010 at 8:47 PM, Martin Makundi 
martin.maku...@koodaripalvelut.com wrote:

 Hi M! Is was there a tutorial on this topic?

 **
 Martin

 2010/7/24 Martin Grigorov mgrigo...@apache.org:
  Hi,
 
  I just added a new wicket-examples application (Wicket 1.5 only) showing
 two
  custom request mappers:
  * custom home page - e.g. requesting http://example.com will load
  Application#getHomePage() at http://example.com/custom/path
  * locale first mapper - the session locale is encoded as first segment in
  the url. This feature is often asked in the mailing lists and I used the
  mapper Igor posted about a year ago in the mailing lists.
 
  The examples will be visible at http://wicketstuff.org/wicket/ after the
  next deploy of the snapshot.
 
  If you have ideas for more examples with the new request mappers now is
 the
  moment to share them ;-)
 
  martin-g

Re: Examples for the new request mappers

2010-07-24 Thread Martin Makundi 
Any brief what this is all about ;) ? Sounds interesting but I don't
have any clue. Any selected links to previous discussion on the topic?

**
Martin

2010/7/24 Martin Grigorov mgrigo...@apache.org:
 For now the only tutorial is the source code :-/

 On Sat, Jul 24, 2010 at 8:47 PM, Martin Makundi 
 martin.maku...@koodaripalvelut.com wrote:

 Hi M! Is was there a tutorial on this topic?

 **
 Martin

 2010/7/24 Martin Grigorov mgrigo...@apache.org:
  Hi,
 
  I just added a new wicket-examples application (Wicket 1.5 only) showing
 two
  custom request mappers:
  * custom home page - e.g. requesting http://example.com will load
  Application#getHomePage() at http://example.com/custom/path
  * locale first mapper - the session locale is encoded as first segment in
  the url. This feature is often asked in the mailing lists and I used the
  mapper Igor posted about a year ago in the mailing lists.
 
  The examples will be visible at http://wicketstuff.org/wicket/ after the
  next deploy of the snapshot.
 
  If you have ideas for more examples with the new request mappers now is
 the
  moment to share them ;-)
 
  martin-g