Re: Again Inline Enclosure does not ... wicket:extend and wicket:child and workaround
Hi! I have tested, it works okay, but now the point of view is different (and not so handy)! T.G. Okay, thanks. Sounds valuable advise to test, so. its kind of wide sense workaround for problem :-) T.G. Hi, I'd recommend you to not use InlineEnclosure if it causes you troubles. Just introduce WebMarkupContainer instead and override its onConfigure() to set its visibility depending on its child visibility. Additionally you'll have to update the WMC in Ajax requests when the child has to be updated but it will be more reliable in long term. On Thu, Feb 9, 2012 at 9:35 AM, The Genuiini genui...@dnainternet.net wrote: Hi again, has anyone tested the functionality of workaround given in https://issues.apache.org/jira/browse/WICKET-3947? It helps with one bug, but is it sure it not create other problems? BR. T.G. -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: Again Inline Enclosure does not ... wicket:extend and wicket:child and workaround
On Fri, Feb 10, 2012 at 10:16 AM, The Genuiini genui...@dnainternet.net wrote: Hi! I have tested, it works okay, but now the point of view is different (and not so handy)! It is handy for me because you wont report weird problems like the one in the mentioned ticket ;-) We are aware about the problem and at some point we will improve it. T.G. Okay, thanks. Sounds valuable advise to test, so. its kind of wide sense workaround for problem :-) T.G. Hi, I'd recommend you to not use InlineEnclosure if it causes you troubles. Just introduce WebMarkupContainer instead and override its onConfigure() to set its visibility depending on its child visibility. Additionally you'll have to update the WMC in Ajax requests when the child has to be updated but it will be more reliable in long term. On Thu, Feb 9, 2012 at 9:35 AM, The Genuiini genui...@dnainternet.net wrote: Hi again, has anyone tested the functionality of workaround given in https://issues.apache.org/jira/browse/WICKET-3947? It helps with one bug, but is it sure it not create other problems? BR. T.G. -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: source/commits in jira
https://issues.apache.org/jira/browse/INFRA-4157 On Fri, Feb 10, 2012 at 5:44 PM, Jeremy Thomerson jer...@wickettraining.com wrote: Feel free to email infrastruct...@apache.org to bring the subject up there. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Fri, Feb 10, 2012 at 9:59 AM, Bertrand Guay-Paquet ber...@step.polymtl.ca wrote: Hi, I asked the same question on dec 22 and Igor replied : infra is working on this afaik. -igor So I guess they haven't finished yet! Bertrand On 10/02/2012 9:34 AM, Johan Compagner wrote: Hi, What broke now that we are over to git is the nice link between jira issues and the source code so this tab: https://issues.apache.org/**jira/browse/WICKET-1654?page=**com.atlassian. **jirafisheyeplugin:fisheye-**issuepanel#issue-tabshttps://issues.apache.org/jira/browse/WICKET-1654?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel#issue-tabs (or that subversion tab which ofcourse will not work anymore) is there a solution for that for GIT? So that we can at least backtrack easy what is changed for a specific issue? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: source/commits in jira
thx so it all depends first on: http://studio.plugins.atlassian.com/browse/JGIT-74 but then if we do the commit, how do we say to git that this is issue XXX ? So that the plugin knows that that commit is for that issue? I guess we we need to fill in certain things on commit we should start with that asap. On Fri, Feb 10, 2012 at 16:57, Martin Grigorov mgrigo...@apache.org wrote: https://issues.apache.org/jira/browse/INFRA-4157 On Fri, Feb 10, 2012 at 5:44 PM, Jeremy Thomerson jer...@wickettraining.com wrote: Feel free to email infrastruct...@apache.org to bring the subject up there. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Fri, Feb 10, 2012 at 9:59 AM, Bertrand Guay-Paquet ber...@step.polymtl.ca wrote: Hi, I asked the same question on dec 22 and Igor replied : infra is working on this afaik. -igor So I guess they haven't finished yet! Bertrand On 10/02/2012 9:34 AM, Johan Compagner wrote: Hi, What broke now that we are over to git is the nice link between jira issues and the source code so this tab: https://issues.apache.org/**jira/browse/WICKET-1654?page=**com.atlassian. **jirafisheyeplugin:fisheye-**issuepanel#issue-tabs https://issues.apache.org/jira/browse/WICKET-1654?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel#issue-tabs (or that subversion tab which ofcourse will not work anymore) is there a solution for that for GIT? So that we can at least backtrack easy what is changed for a specific issue? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: source/commits in jira
On Fri, Feb 10, 2012 at 6:02 PM, Johan Compagner jcompag...@gmail.com wrote: thx so it all depends first on: http://studio.plugins.atlassian.com/browse/JGIT-74 but then if we do the commit, how do we say to git that this is issue XXX ? So that the plugin knows that that commit is for that issue? I guess we we need to fill in certain things on commit we should start with that asap. I think adding WICKET-XXX is enough. Currently I use git log --grep=WICKET-XXX to find all commits for a specific ticket. Since the history is locally it is quite fast. On Fri, Feb 10, 2012 at 16:57, Martin Grigorov mgrigo...@apache.org wrote: https://issues.apache.org/jira/browse/INFRA-4157 On Fri, Feb 10, 2012 at 5:44 PM, Jeremy Thomerson jer...@wickettraining.com wrote: Feel free to email infrastruct...@apache.org to bring the subject up there. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Fri, Feb 10, 2012 at 9:59 AM, Bertrand Guay-Paquet ber...@step.polymtl.ca wrote: Hi, I asked the same question on dec 22 and Igor replied : infra is working on this afaik. -igor So I guess they haven't finished yet! Bertrand On 10/02/2012 9:34 AM, Johan Compagner wrote: Hi, What broke now that we are over to git is the nice link between jira issues and the source code so this tab: https://issues.apache.org/**jira/browse/WICKET-1654?page=**com.atlassian. **jirafisheyeplugin:fisheye-**issuepanel#issue-tabs https://issues.apache.org/jira/browse/WICKET-1654?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel#issue-tabs (or that subversion tab which ofcourse will not work anymore) is there a solution for that for GIT? So that we can at least backtrack easy what is changed for a specific issue? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: source/commits in jira
On Fri, Feb 10, 2012 at 6:08 PM, Martin Grigorov mgrigo...@apache.org wrote: On Fri, Feb 10, 2012 at 6:02 PM, Johan Compagner jcompag...@gmail.com wrote: thx so it all depends first on: http://studio.plugins.atlassian.com/browse/JGIT-74 but then if we do the commit, how do we say to git that this is issue XXX ? So that the plugin knows that that commit is for that issue? I guess we we need to fill in certain things on commit we should start with that asap. I think adding WICKET-XXX is enough. Currently I use git log --grep=WICKET-XXX to find all commits for a specific ticket. Since the history is locally it is quite fast. Also the search interface at http://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=summary does the same. On Fri, Feb 10, 2012 at 16:57, Martin Grigorov mgrigo...@apache.org wrote: https://issues.apache.org/jira/browse/INFRA-4157 On Fri, Feb 10, 2012 at 5:44 PM, Jeremy Thomerson jer...@wickettraining.com wrote: Feel free to email infrastruct...@apache.org to bring the subject up there. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Fri, Feb 10, 2012 at 9:59 AM, Bertrand Guay-Paquet ber...@step.polymtl.ca wrote: Hi, I asked the same question on dec 22 and Igor replied : infra is working on this afaik. -igor So I guess they haven't finished yet! Bertrand On 10/02/2012 9:34 AM, Johan Compagner wrote: Hi, What broke now that we are over to git is the nice link between jira issues and the source code so this tab: https://issues.apache.org/**jira/browse/WICKET-1654?page=**com.atlassian. **jirafisheyeplugin:fisheye-**issuepanel#issue-tabs https://issues.apache.org/jira/browse/WICKET-1654?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel#issue-tabs (or that subversion tab which ofcourse will not work anymore) is there a solution for that for GIT? So that we can at least backtrack easy what is changed for a specific issue? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: source/commits in jira
can we somehow force that? Just like we did with svn that has that build in case:xxx support (in the commit dialog?) But i will place WICKET-XXX then in all my commits from now on On Fri, Feb 10, 2012 at 17:08, Martin Grigorov mgrigo...@apache.org wrote: On Fri, Feb 10, 2012 at 6:02 PM, Johan Compagner jcompag...@gmail.com wrote: thx so it all depends first on: http://studio.plugins.atlassian.com/browse/JGIT-74 but then if we do the commit, how do we say to git that this is issue XXX ? So that the plugin knows that that commit is for that issue? I guess we we need to fill in certain things on commit we should start with that asap. I think adding WICKET-XXX is enough. Currently I use git log --grep=WICKET-XXX to find all commits for a specific ticket. Since the history is locally it is quite fast. On Fri, Feb 10, 2012 at 16:57, Martin Grigorov mgrigo...@apache.org wrote: https://issues.apache.org/jira/browse/INFRA-4157 On Fri, Feb 10, 2012 at 5:44 PM, Jeremy Thomerson jer...@wickettraining.com wrote: Feel free to email infrastruct...@apache.org to bring the subject up there. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Fri, Feb 10, 2012 at 9:59 AM, Bertrand Guay-Paquet ber...@step.polymtl.ca wrote: Hi, I asked the same question on dec 22 and Igor replied : infra is working on this afaik. -igor So I guess they haven't finished yet! Bertrand On 10/02/2012 9:34 AM, Johan Compagner wrote: Hi, What broke now that we are over to git is the nice link between jira issues and the source code so this tab: https://issues.apache.org/**jira/browse/WICKET-1654?page=**com.atlassian. **jirafisheyeplugin:fisheye-**issuepanel#issue-tabs https://issues.apache.org/jira/browse/WICKET-1654?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel#issue-tabs (or that subversion tab which ofcourse will not work anymore) is there a solution for that for GIT? So that we can at least backtrack easy what is changed for a specific issue? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: source/commits in jira
we can write a server hook to make sure the string is present i suppose. i am not sure if infra would like that or not... -igor On Fri, Feb 10, 2012 at 8:10 AM, Johan Compagner jcompag...@gmail.com wrote: can we somehow force that? Just like we did with svn that has that build in case:xxx support (in the commit dialog?) But i will place WICKET-XXX then in all my commits from now on On Fri, Feb 10, 2012 at 17:08, Martin Grigorov mgrigo...@apache.org wrote: On Fri, Feb 10, 2012 at 6:02 PM, Johan Compagner jcompag...@gmail.com wrote: thx so it all depends first on: http://studio.plugins.atlassian.com/browse/JGIT-74 but then if we do the commit, how do we say to git that this is issue XXX ? So that the plugin knows that that commit is for that issue? I guess we we need to fill in certain things on commit we should start with that asap. I think adding WICKET-XXX is enough. Currently I use git log --grep=WICKET-XXX to find all commits for a specific ticket. Since the history is locally it is quite fast. On Fri, Feb 10, 2012 at 16:57, Martin Grigorov mgrigo...@apache.org wrote: https://issues.apache.org/jira/browse/INFRA-4157 On Fri, Feb 10, 2012 at 5:44 PM, Jeremy Thomerson jer...@wickettraining.com wrote: Feel free to email infrastruct...@apache.org to bring the subject up there. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Fri, Feb 10, 2012 at 9:59 AM, Bertrand Guay-Paquet ber...@step.polymtl.ca wrote: Hi, I asked the same question on dec 22 and Igor replied : infra is working on this afaik. -igor So I guess they haven't finished yet! Bertrand On 10/02/2012 9:34 AM, Johan Compagner wrote: Hi, What broke now that we are over to git is the nice link between jira issues and the source code so this tab: https://issues.apache.org/**jira/browse/WICKET-1654?page=**com.atlassian. **jirafisheyeplugin:fisheye-**issuepanel#issue-tabs https://issues.apache.org/jira/browse/WICKET-1654?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel#issue-tabs (or that subversion tab which ofcourse will not work anymore) is there a solution for that for GIT? So that we can at least backtrack easy what is changed for a specific issue? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: source/commits in jira
That could be tricky, because not all commits are always related to an issue i think.. But if the UI gives you the option (in eclipse at least for svn) then it is easer NOT to forget :) On Fri, Feb 10, 2012 at 17:12, Igor Vaynberg igor.vaynb...@gmail.comwrote: we can write a server hook to make sure the string is present i suppose. i am not sure if infra would like that or not... -igor On Fri, Feb 10, 2012 at 8:10 AM, Johan Compagner jcompag...@gmail.com wrote: can we somehow force that? Just like we did with svn that has that build in case:xxx support (in the commit dialog?) But i will place WICKET-XXX then in all my commits from now on On Fri, Feb 10, 2012 at 17:08, Martin Grigorov mgrigo...@apache.org wrote: On Fri, Feb 10, 2012 at 6:02 PM, Johan Compagner jcompag...@gmail.com wrote: thx so it all depends first on: http://studio.plugins.atlassian.com/browse/JGIT-74 but then if we do the commit, how do we say to git that this is issue XXX ? So that the plugin knows that that commit is for that issue? I guess we we need to fill in certain things on commit we should start with that asap. I think adding WICKET-XXX is enough. Currently I use git log --grep=WICKET-XXX to find all commits for a specific ticket. Since the history is locally it is quite fast. On Fri, Feb 10, 2012 at 16:57, Martin Grigorov mgrigo...@apache.org wrote: https://issues.apache.org/jira/browse/INFRA-4157 On Fri, Feb 10, 2012 at 5:44 PM, Jeremy Thomerson jer...@wickettraining.com wrote: Feel free to email infrastruct...@apache.org to bring the subject up there. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Fri, Feb 10, 2012 at 9:59 AM, Bertrand Guay-Paquet ber...@step.polymtl.ca wrote: Hi, I asked the same question on dec 22 and Igor replied : infra is working on this afaik. -igor So I guess they haven't finished yet! Bertrand On 10/02/2012 9:34 AM, Johan Compagner wrote: Hi, What broke now that we are over to git is the nice link between jira issues and the source code so this tab: https://issues.apache.org/**jira/browse/WICKET-1654?page=**com.atlassian. **jirafisheyeplugin:fisheye-**issuepanel#issue-tabs https://issues.apache.org/jira/browse/WICKET-1654?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel#issue-tabs (or that subversion tab which ofcourse will not work anymore) is there a solution for that for GIT? So that we can at least backtrack easy what is changed for a specific issue? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: git commit: change 'void' methods to pass-through checked argument
i dont really like this.
having a set of checks at the top of the method is easier to
read/parse then a bunch of checks mixed with a bunch of assignments...
-igor
On Fri, Feb 10, 2012 at 2:47 PM, p...@apache.org wrote:
Updated Branches:
refs/heads/master b0118c114 - 57a09fbe6
change 'void' methods to pass-through checked argument
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/57a09fbe
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/57a09fbe
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/57a09fbe
Branch: refs/heads/master
Commit: 57a09fbe6321921e805f721766dd1559808fef92
Parents: b0118c1
Author: Peter Ertl p...@apache.org
Authored: Fri Feb 10 23:41:27 2012 +0100
Committer: Peter Ertl p...@apache.org
Committed: Fri Feb 10 23:41:27 2012 +0100
--
.../java/org/apache/wicket/util/lang/Args.java | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/57a09fbe/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
--
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
b/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
index ce9d60b..f64900d 100644
--- a/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
@@ -77,13 +77,14 @@ public class Args
* @throws IllegalArgumentException
* if the passed collection is either null or empty
*/
- public static void notEmpty(final Collection? collection, final
String message,
+ public static T extends Collection? T notEmpty(final T
collection, final String message,
final Object... params)
{
if (collection == null || collection.isEmpty())
{
throw new
IllegalArgumentException(Args.format(message, params));
}
+ return collection;
}
/**
@@ -94,9 +95,9 @@ public class Args
* @throws IllegalArgumentException
* if the passed collection is either null or empty
*/
- public static void notEmpty(final Collection? collection, final
String name)
+ public static T extends Collection? T notEmpty(final T
collection, final String name)
{
- notEmpty(collection, Collection '%s' may not be null or
empty., name);
+ return notEmpty(collection, Collection '%s' may not be null
or empty., name);
}
/**
@@ -109,7 +110,7 @@ public class Args
* @param name
* @throws IllegalArgumentException
*/
- public static T extends ComparableT void withinRange(final T min,
final T max,
+ public static T extends ComparableT T withinRange(final T min,
final T max,
final T value, final String name)
{
notNull(min, name);
@@ -120,6 +121,7 @@ public class Args
String.format(Argument '%s' must have a value
within [%s,%s], but was %s, name,
min, max, value));
}
+ return value;
}
/**
