Re: [VOTE] Release Wicket 1.4.21
+1 On 29 August 2012 15:41, Carl-Eric Menzel cmen...@wicketbuch.de wrote: It's time to mop up the last remaining changes in 1.4.x so we can finally close that branch and concentrate on 1.5 and 6.0. Please check the following source release and then vote: - branch build/wicket-1.4.21 - source tarball https://people.apache.org/~cmenzel/wicket-1.4.21/apache-wicket-1.4.21-git.tgz Signature and hashes available there too. [ ] +1 release Apache Wicket 1.4.21 [ ] -1 don't release Apache Wicket 1.4.21 This vote lasts until Monday, September 3rd, 16:00CET. (longer time because today is almost over and the weekend is coming up soon again). Carl-Eric
Re: [VOTE] Release Wicket 1.4.21
The vote has passed with 3 binding +1s and one non-binding +1. Thank you! On Tue, Sep 4, 2012 at 9:56 AM, Johan Compagner jcompag...@gmail.com wrote: +1 On 29 August 2012 15:41, Carl-Eric Menzel cmen...@wicketbuch.de wrote: It's time to mop up the last remaining changes in 1.4.x so we can finally close that branch and concentrate on 1.5 and 6.0. Please check the following source release and then vote: - branch build/wicket-1.4.21 - source tarball https://people.apache.org/~cmenzel/wicket-1.4.21/apache-wicket-1.4.21-git.tgz Signature and hashes available there too. [ ] +1 release Apache Wicket 1.4.21 [ ] -1 don't release Apache Wicket 1.4.21 This vote lasts until Monday, September 3rd, 16:00CET. (longer time because today is almost over and the weekend is coming up soon again). Carl-Eric -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
Re: git commit: WICKET-4729: support multiple tabs with the same page
On Tue, Sep 4, 2012 at 8:29 PM, papega...@apache.org wrote:
Updated Branches:
refs/heads/master c0c9635d9 - 659ee9b33
WICKET-4729: support multiple tabs with the same page
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/659ee9b3
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/659ee9b3
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/659ee9b3
Branch: refs/heads/master
Commit: 659ee9b337944a461bef400aedbe5f71a5abccf2
Parents: c0c9635
Author: Emond Papegaaij papega...@apache.org
Authored: Tue Sep 4 20:27:45 2012 +0200
Committer: Emond Papegaaij papega...@apache.org
Committed: Tue Sep 4 20:27:56 2012 +0200
--
.../wicket/atmosphere/AtmosphereBehavior.java | 17 +-
.../org/apache/wicket/atmosphere/EventBus.java | 44 +--
2 files changed, 54 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/659ee9b3/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
index 3f574bb..f4641bd 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
@@ -18,9 +18,11 @@ package org.apache.wicket.atmosphere;
import javax.servlet.http.HttpServletRequest;
+import org.apache.wicket.Application;
import org.apache.wicket.Component;
import org.apache.wicket.IResourceListener;
import org.apache.wicket.MetaDataKey;
+import org.apache.wicket.Session;
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.ajax.json.JSONException;
import org.apache.wicket.ajax.json.JSONObject;
@@ -66,13 +68,25 @@ public class AtmosphereBehavior extends Behavior
private static final long serialVersionUID = 1L;
+ private String applicationKey;
+
+ private String sessionId;
+
private Component component;
+
/**
* Construct.
*/
public AtmosphereBehavior()
{
+ applicationKey = Application.get().getApplicationKey();
+ sessionId = Session.get().getId();
+ }
+
+ private EventBus findEventBus()
+ {
+ return EventBus.get(Application.get(applicationKey));
}
@Override
@@ -97,7 +111,7 @@ public class AtmosphereBehavior extends Behavior
Meteor meteor = Meteor.build(request.getContainerRequest());
String uuid = getUUID(meteor.getAtmosphereResource());
component.getPage().setMetaData(ATMOSPHERE_UUID, uuid);
- EventBus.get().registerPage(uuid, component.getPage());
+ findEventBus().registerPage(uuid, component.getPage());
// Add us to the listener list.
meteor.addListener(this);
@@ -169,6 +183,7 @@ public class AtmosphereBehavior extends Behavior
log.info(String.format(%s connection dropped from ip
%s:%s, transport == null
? websocket : transport,
req.getRemoteAddr(), req.getRemotePort()));
}
+
findEventBus().unregisterConnection(getUUID(event.getResource()));
}
@Override
http://git-wip-us.apache.org/repos/asf/wicket/blob/659ee9b3/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
index 2a0dfd4..794cf28 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
@@ -19,6 +19,7 @@ package org.apache.wicket.atmosphere;
import java.util.Collection;
import java.util.Collections;
import java.util.Iterator;
+import java.util.Map;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletRequestWrapper;
@@ -38,11 +39,10 @@ import org.atmosphere.cpr.BroadcasterFactory;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import com.google.common.collect.BiMap;
import
Re: git commit: WICKET-4729: support multiple tabs with the same page
You read all the commits, don't you? :) That line shouldn't have been
there, I often use System.out.println for temporary debug lines,
because it stands out of the rest of the logging due to the missing
timestamp etc. I've removed it.
On Tue, Sep 4, 2012 at 8:41 PM, Martin Grigorov mgrigo...@apache.org wrote:
On Tue, Sep 4, 2012 at 8:29 PM, papega...@apache.org wrote:
Updated Branches:
refs/heads/master c0c9635d9 - 659ee9b33
WICKET-4729: support multiple tabs with the same page
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/659ee9b3
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/659ee9b3
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/659ee9b3
Branch: refs/heads/master
Commit: 659ee9b337944a461bef400aedbe5f71a5abccf2
Parents: c0c9635
Author: Emond Papegaaij papega...@apache.org
Authored: Tue Sep 4 20:27:45 2012 +0200
Committer: Emond Papegaaij papega...@apache.org
Committed: Tue Sep 4 20:27:56 2012 +0200
--
.../wicket/atmosphere/AtmosphereBehavior.java | 17 +-
.../org/apache/wicket/atmosphere/EventBus.java | 44 +--
2 files changed, 54 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/659ee9b3/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
index 3f574bb..f4641bd 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
@@ -18,9 +18,11 @@ package org.apache.wicket.atmosphere;
import javax.servlet.http.HttpServletRequest;
+import org.apache.wicket.Application;
import org.apache.wicket.Component;
import org.apache.wicket.IResourceListener;
import org.apache.wicket.MetaDataKey;
+import org.apache.wicket.Session;
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.ajax.json.JSONException;
import org.apache.wicket.ajax.json.JSONObject;
@@ -66,13 +68,25 @@ public class AtmosphereBehavior extends Behavior
private static final long serialVersionUID = 1L;
+ private String applicationKey;
+
+ private String sessionId;
+
private Component component;
+
/**
* Construct.
*/
public AtmosphereBehavior()
{
+ applicationKey = Application.get().getApplicationKey();
+ sessionId = Session.get().getId();
+ }
+
+ private EventBus findEventBus()
+ {
+ return EventBus.get(Application.get(applicationKey));
}
@Override
@@ -97,7 +111,7 @@ public class AtmosphereBehavior extends Behavior
Meteor meteor = Meteor.build(request.getContainerRequest());
String uuid = getUUID(meteor.getAtmosphereResource());
component.getPage().setMetaData(ATMOSPHERE_UUID, uuid);
- EventBus.get().registerPage(uuid, component.getPage());
+ findEventBus().registerPage(uuid, component.getPage());
// Add us to the listener list.
meteor.addListener(this);
@@ -169,6 +183,7 @@ public class AtmosphereBehavior extends Behavior
log.info(String.format(%s connection dropped from
ip %s:%s, transport == null
? websocket : transport,
req.getRemoteAddr(), req.getRemotePort()));
}
+
findEventBus().unregisterConnection(getUUID(event.getResource()));
}
@Override
http://git-wip-us.apache.org/repos/asf/wicket/blob/659ee9b3/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
index 2a0dfd4..794cf28 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
@@ -19,6 +19,7 @@ package org.apache.wicket.atmosphere;
import java.util.Collection;
import java.util.Collections;
import java.util.Iterator;
+import
Re: git commit: WICKET-4729: support multiple tabs with the same page
On Tue, Sep 4, 2012 at 8:54 PM, Emond Papegaaij
emond.papega...@gmail.com wrote:
You read all the commits, don't you? :) That line shouldn't have been
Yes, this saves me time later when debugging problems :-) And keeps me
up-to-date.
there, I often use System.out.println for temporary debug lines,
because it stands out of the rest of the logging due to the missing
timestamp etc. I've removed it.
I've noticed ;-)
On Tue, Sep 4, 2012 at 8:41 PM, Martin Grigorov mgrigo...@apache.org wrote:
On Tue, Sep 4, 2012 at 8:29 PM, papega...@apache.org wrote:
Updated Branches:
refs/heads/master c0c9635d9 - 659ee9b33
WICKET-4729: support multiple tabs with the same page
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/659ee9b3
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/659ee9b3
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/659ee9b3
Branch: refs/heads/master
Commit: 659ee9b337944a461bef400aedbe5f71a5abccf2
Parents: c0c9635
Author: Emond Papegaaij papega...@apache.org
Authored: Tue Sep 4 20:27:45 2012 +0200
Committer: Emond Papegaaij papega...@apache.org
Committed: Tue Sep 4 20:27:56 2012 +0200
--
.../wicket/atmosphere/AtmosphereBehavior.java | 17 +-
.../org/apache/wicket/atmosphere/EventBus.java | 44 +--
2 files changed, 54 insertions(+), 7 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/659ee9b3/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
index 3f574bb..f4641bd 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
@@ -18,9 +18,11 @@ package org.apache.wicket.atmosphere;
import javax.servlet.http.HttpServletRequest;
+import org.apache.wicket.Application;
import org.apache.wicket.Component;
import org.apache.wicket.IResourceListener;
import org.apache.wicket.MetaDataKey;
+import org.apache.wicket.Session;
import org.apache.wicket.WicketRuntimeException;
import org.apache.wicket.ajax.json.JSONException;
import org.apache.wicket.ajax.json.JSONObject;
@@ -66,13 +68,25 @@ public class AtmosphereBehavior extends Behavior
private static final long serialVersionUID = 1L;
+ private String applicationKey;
+
+ private String sessionId;
+
private Component component;
+
/**
* Construct.
*/
public AtmosphereBehavior()
{
+ applicationKey = Application.get().getApplicationKey();
+ sessionId = Session.get().getId();
+ }
+
+ private EventBus findEventBus()
+ {
+ return EventBus.get(Application.get(applicationKey));
}
@Override
@@ -97,7 +111,7 @@ public class AtmosphereBehavior extends Behavior
Meteor meteor = Meteor.build(request.getContainerRequest());
String uuid = getUUID(meteor.getAtmosphereResource());
component.getPage().setMetaData(ATMOSPHERE_UUID, uuid);
- EventBus.get().registerPage(uuid, component.getPage());
+ findEventBus().registerPage(uuid, component.getPage());
// Add us to the listener list.
meteor.addListener(this);
@@ -169,6 +183,7 @@ public class AtmosphereBehavior extends Behavior
log.info(String.format(%s connection dropped from
ip %s:%s, transport == null
? websocket : transport,
req.getRemoteAddr(), req.getRemotePort()));
}
+
findEventBus().unregisterConnection(getUUID(event.getResource()));
}
@Override
http://git-wip-us.apache.org/repos/asf/wicket/blob/659ee9b3/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
index 2a0dfd4..794cf28 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java
+++
Re: [jira] [Updated] (WICKET-4729) atmosphere example will stop working if opening the same url in a different tab in the same browser
What do we do with wicket-experimental modules on the 6.0.1 release? As far as my understanding of semantic version goes, 6.0.1 should only contain bug fixes, 6.1 will be the next version with new features, but still api-compatible. Experimental modules, however, are all versioned below 1.0, allowing any change, because semver starts at 1.0. I did not break the API, but you could see this as a new feature (multi-tab support). IMHO, 6.1.0 should be the next release, where 6.0.1 will only contain some bugfixes. For example, selenium releases a new 2.x.0 every few weeks, and only release a 2.x.1 when a critical bug is found. This also makes it easier to cope with the experimental modules, because we can simply release them with 6.1 and skip 6.0.1. Best regards, Emond On Tue, Sep 4, 2012 at 8:41 PM, Martin Grigorov (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/WICKET-4729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov updated WICKET-4729: Fix Version/s: (was: 6.1.0) 6.0.1 atmosphere example will stop working if opening the same url in a different tab in the same browser --- Key: WICKET-4729 URL: https://issues.apache.org/jira/browse/WICKET-4729 Project: Wicket Issue Type: Bug Components: wicket-atmosphere Affects Versions: 6.0.0-beta3 Reporter: Sean Lin Assignee: Emond Papegaaij Fix For: 6.0.1 If the url of a running atmosphere example is copied and then opened in a different tab while the old one left open in the same browser, i.e. there are two atmosphere examples of the same url opened at the same time in a browser, one of them will stop working. I found the cause of this problem is that trackingPages in EventBus is using a BiMap. If there are different tracking-ids mapping to the same PageKey, one of the map entry will be removed. The simple solution would be replacing the BiMap with HashMap, but I think there might be reasons why BiMap is used here. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
