[GitHub] wicket issue #229: WICKET-6438 - 8.x reference guide needs a few minor impro...
Github user ozeray commented on the issue: https://github.com/apache/wicket/pull/229 Closed by fault. Sorry. Reopened the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #229: WICKET-6438 - 8.x reference guide needs a few mino...
GitHub user ozeray reopened a pull request: https://github.com/apache/wicket/pull/229 WICKET-6438 - 8.x reference guide needs a few minor improvements Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during maven packaging phase: WARNING: image to embed not found or not readable: F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg Minor fix in contributing.adoc: Revised the generated document target directory for the user guide documentation. Cropped top and bottom blank parts in comsysto-logo.png to have the Introduction page fit in one page in PDF. Made minor changes in helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ozeray/wicket master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit 9e323be5eecba1052414e22f4d3505bbc5863238 Author: ozeray Date: 2017-08-06T00:12:03Z A few minor improvements Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during maven packaging phase: WARNING: image to embed not found or not readable: F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg Minor fix in contributing.adoc: Revised the generated document target directory for the user guide documentation. Cropped top and bottom blank parts in comsysto-logo.png to have the Introduction page fit in one page in PDF. Made minor changes in helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. commit 149134dbea8bb99253853338f471a2dab207733c Author: ozeray Date: 2017-08-06T00:42:04Z Added github forking step into Contribution section. Made a few minor changes to adapt with this new step. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #229: WICKET-6438 - 8.x reference guide needs a few minor impro...
Github user ozeray commented on the issue: https://github.com/apache/wicket/pull/229 Added github forking step into Contribution section. Made a few minor changes to adapt with this new step. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #229: WICKET-6438 - 8.x reference guide needs a few mino...
Github user ozeray closed the pull request at: https://github.com/apache/wicket/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #229: WICKET-6438 - 8.x reference guide needs a few mino...
GitHub user ozeray opened a pull request: https://github.com/apache/wicket/pull/229 WICKET-6438 - 8.x reference guide needs a few minor improvements Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during maven packaging phase: WARNING: image to embed not found or not readable: F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg Minor fix in contributing.adoc: Revised the generated document target directory for the user guide documentation. Cropped top and bottom blank parts in comsysto-logo.png to have the Introduction page fit in one page in PDF. Made minor changes in helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ozeray/wicket master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit 9e323be5eecba1052414e22f4d3505bbc5863238 Author: ozeray Date: 2017-08-06T00:12:03Z A few minor improvements Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during maven packaging phase: WARNING: image to embed not found or not readable: F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg Minor fix in contributing.adoc: Revised the generated document target directory for the user guide documentation. Cropped top and bottom blank parts in comsysto-logo.png to have the Introduction page fit in one page in PDF. Made minor changes in helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Wicket 8 (M7) release
https://github.com/apache/wicket/pull/228 On Sat, Aug 5, 2017 at 12:04 PM, Maxim Solodovnik wrote: > OK, thanks > will prepare PR > > On Sat, Aug 5, 2017 at 11:59 AM, Martin Grigorov > wrote: >> Hi Maxim, >> >> On Aug 5, 2017 3:28 AM, "Maxim Solodovnik" wrote: >> >> Hello All, >> >> I would like to update version on libraries being used by wicket to the >> most recent versions is it OK? >> >> >> Sure! >> >> >> report can be get as follows (with some exceptions of course): >> >> mvn versions:display-dependency-updates >> >> >> >> On Sat, Aug 5, 2017 at 3:26 AM, Tobias Soloschenko < >> tobiassolosche...@googlemail.com> wrote: >> >>> +1 for M7 >>> >>> kind regards >>> >>> Tobias >>> >>> > Am 04.08.2017 um 18:56 schrieb Korbinian Bachl < >>> korbinian.ba...@whiskyworld.de>: >>> > >>> > Please a thousand +1 (non-binding) >>> > >>> > :) >>> > >>> > - Ursprüngliche Mail - >>> >> Von: "Andrea Del Bene" >>> >> An: dev@wicket.apache.org >>> >> Gesendet: Freitag, 4. August 2017 17:12:43 >>> >> Betreff: Re: Wicket 8 (M7) release >>> > >>> >> Hi, >>> >> >>> >> I think we are ready to promote Wicket 8 to GA but I would wait for >>> >> September as August is usually a very quite month (at least in Europe) >>> so >>> >> it risks to be overlooked. But I have no objection to prepare a M7 in >>> the >>> >> meantime. >>> >> >>> >> What do you think? >>> >> >> >> >> -- >> WBR >> Maxim aka solomax > > > > -- > WBR > Maxim aka solomax -- WBR Maxim aka solomax
[GitHub] wicket pull request #228: WICKET-6437: Library versions are updated
GitHub user solomax opened a pull request: https://github.com/apache/wicket/pull/228 WICKET-6437: Library versions are updated I was unable to update org.jglue.cdi-unit:cdi-unit and wildfly It seems code/build modifications are required for this :( You can merge this pull request into a Git repository by running: $ git pull https://github.com/solomax/wicket WICKET-6437 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228 commit dad47df0bde5cb1ab312d719ac9283c52abb7301 Author: Maxim Solodovnik Date: 2017-08-05T15:08:45Z Library versions are updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Question on wicketstuff release
Good news :) The release is available at Maven Central :) On Sat, Aug 5, 2017 at 12:20 PM, Maxim Solodovnik wrote: > Thanks a lot > I will check during the day > > On Sat, Aug 5, 2017 at 12:10 PM, Martin Grigorov > wrote: >> >> Hi Maxim, >> >> I'm on my mobile, without my laptop at the moment. >> If it has closed successfully then it is a matter of time to accept the >> release command. >> I'll check when I get home! >> >> >> On Aug 5, 2017 8:03 AM, "Maxim Solodovnik" wrote: >> >> Hello Martin, >> >> I did close wicketstuff staging repo, but it seems not to be released >> Could you please help? >> >> -- >> WBR >> Maxim aka solomax > > > > > -- > WBR > Maxim aka solomax -- WBR Maxim aka solomax
