[GitHub] wicket pull request #283: Wicket-6563 page store implementation
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/283#discussion_r240041611
--- Diff:
wicket-core/src/main/java/org/apache/wicket/pageStore/DelegatingPageStore.java
---
@@ -1,100 +1,76 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.wicket.page;
-
-import org.apache.wicket.util.lang.Args;
-
-/**
- * Decorator for {@link IPageManager}
- *
- * @author igor
- */
-public class PageManagerDecorator implements IPageManager
-{
- private final IPageManager delegate;
-
- /**
-* Constructor
-*
-* @param delegate
-*/
- public PageManagerDecorator(IPageManager delegate)
- {
- Args.notNull(delegate, "delegate");
- this.delegate = delegate;
- }
-
- @Override
- public IPageManagerContext getContext()
- {
- return delegate.getContext();
- }
-
- @Override
- public IManageablePage getPage(int id)
- {
- return delegate.getPage(id);
- }
-
- @Override
- public void removePage(final IManageablePage page) {
- delegate.removePage(page);
- }
-
- @Override
- public void touchPage(IManageablePage page)
- {
- delegate.touchPage(page);
- }
-
- @Override
- public void untouchPage(IManageablePage page)
- {
- delegate.untouchPage(page);
- }
-
- @Override
- public boolean supportsVersioning()
- {
- return delegate.supportsVersioning();
- }
-
- @Override
- public void commitRequest()
- {
- delegate.commitRequest();
- }
-
- @Override
- public void newSessionCreated()
- {
- delegate.newSessionCreated();
- }
-
- @Override
- public void clear()
- {
- delegate.clear();
- }
-
- @Override
- public void destroy()
- {
- delegate.destroy();
- }
-
-}
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.pageStore;
+
+import org.apache.wicket.page.IManageablePage;
+import org.apache.wicket.util.lang.Args;
+
+/**
+ * An {@link IPageStore} that delegates to another storage.
+ */
+public abstract class DelegatingPageStore implements IPageStore
+{
+ private final IPageStore delegate;
+
+ protected DelegatingPageStore(IPageStore delegate) {
+ this.delegate = Args.notNull(delegate, "delegate");
+ }
+
+ public IPageStore getDelegate()
+ {
+ return delegate;
+ }
+
+ /**
+* Versioning is supported depending on the delegate.
+*/
+ @Override
+ public boolean supportsVersioning()
+ {
+ return delegate.supportsVersioning();
+ }
+
+ @Override
+ public void addPage(IPageContext context, IManageablePage page) {
--- End diff --
Just a minor issue with curly brackets indentation which should be on a new
line.
---
[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 Sounds good to me ---
[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 @svenmeier sorry, what I said wasn't correct. By calling onDetach we don't discard the current page instance but we force configuration phase to be performed again before the actual rendering phase, so no information is lost. I still think this can be an improvement because users expect onConfigure to be called before the actual rendering and after event/submission handling. ---
[GitHub] wicket issue #342: Wicket 6616 always render new pages
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/342 @svenmeier i agree with the overall goal of accessing to render components only. There is however a huge drawback with this solution as now onConfigure is executed before form validation or event handling. Components like FeddbackPanel can not work properly anymore. To overcome this limit with stateless pages we can consider to use a brand new page instance for rendering phase. To achieve this result we can for example detach PageComponentProvider after we have invoked the required listener. I will commit this improvement as soon as possible. ---
[GitHub] wicket issue #340: Improve formatting of example snippet
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/340 thank you @jmewes ! ---
[GitHub] wicket issue #296: Simplify BufferedWebResponse's implementation
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/296 @Jezza Code rules can be found in wicket-core which contains file EclipseCodeFormat.xml. Unfortunately this file is not documented anywhere yet. ---
[GitHub] wicket issue #301: Format inline source code italic
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/301 thank you! ---
[GitHub] wicket issue #291: Fix org.junit as resolution:=optional
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/291 Hi, I've merged this commit with 8.x and master branch. Can you close di PR? Thank you. ---
[GitHub] wicket pull request #259: WICKET-6522 session cleaning code moved to HttpSes...
Github user bitstorm closed the pull request at: https://github.com/apache/wicket/pull/259 ---
[GitHub] wicket pull request #259: WICKET-6522 session cleaning code moved to HttpSes...
GitHub user bitstorm opened a pull request: https://github.com/apache/wicket/pull/259 WICKET-6522 session cleaning code moved to HttpSessionStore You can merge this pull request into a Git repository by running: $ git pull https://github.com/bitstorm/wicket WICKET-6522 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/259.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #259 commit 0315c37d447a1040609cb5fa0b137def66a254c3 Author: Andrea Del Bene <adelbene@...> Date: 2018-01-23T08:45:27Z WICKET-6522 session cleaning code moved to HttpSessionStore ---
[GitHub] wicket issue #242: WICKET-6490
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/242 That's the DebugBar. Honestly even to me It's not very clear who is using it and what its purpose is,but it was already there in the old examples version. We might consider to remove it if it is not used at all. ---
[GitHub] wicket issue #242: WICKET-6490
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/242 Your are welcome! ---
[GitHub] wicket issue #242: WICKET-6490
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/242 Filter path can be obtained from Request#getFilterPath(), which under the woods is used buy the current solution where the correct link to homepage (index.html) is resolved by markup filter RelativePathPrefixHandler. ---
[GitHub] wicket issue #242: WICKET-6490
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/242 Hi @klopfdreh , with your solution I wasn't able to move back to the main page from a single example (clicking on 'weicket examples ' logo). I guess because most of the examples have their own WebApplication class mounted at a given path, so `WebApplication.get().getServletContext().getContextPath()` doesn't return the expected root path. ---
[GitHub] wicket issue #242: WICKET-6490
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/242 Hi @klopfdreh, I think we should simply use the code we has so far for examples :stuck_out_tongue:, which is using a simple link like this: `
[GitHub] wicket issue #242: WICKET-6490
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/242 @klopfdreh could you please close the pr? I've merged your changes. ---
[GitHub] wicket issue #242: WICKET-6490
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/242 For some reason running the examples with Eclipse plug-in (http://eclipse-jetty.github.io/) doesn't throw this exception. From now on I will also use StartExamples. ---
[GitHub] wicket issue #237: ListItemModel: allow modification
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/237 Hi @selckin , could you please close this PR? I've merged your changes into master but I don't have the rights to close the PR. ---
[GitHub] wicket issue #235: Wicket 6105 java.time
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/235 I would also glad to help solving the remaining tasks/issuse for this branch :) ---
[GitHub] wicket issue #235: Wicket 6105 java.time
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/235 yes please :-) ---
[GitHub] wicket issue #233: WICKET-6465 prevent unbound during storeTouchedPages only
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/233 Got it. That's way I hope for a future improvement of this boolean-based solution :-). ---
[GitHub] wicket issue #233: WICKET-6465 prevent unbound during storeTouchedPages only
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/233 I'm fine with this quick fix, but I warmly suggest to improve it after it has been applied, at least in master branch. About concurrent access afaik we do have to take care of concurrency. At the moment we don't have any guarantee that setSessionAttribute saves the entry for the last request submitted (for the same session). ---
[GitHub] wicket issue #233: WICKET-6465 prevent unbound during storeTouchedPages only
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/233 I see. thank you for the clarification. Still, I'd like to evaluate more structural solutions, at least for Wicket 8. A good start point might be HttpSessionStore.SessionBindingListener#valueUnbound. It's already used to call Session#onInvalidate and we can add Session#clear() after it. ---
[GitHub] wicket issue #233: WICKET-6465 prevent unbound during storeTouchedPages only
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/233 We should consider method Session.destroy() to remove pages when session expires. See my comment at https://issues.apache.org/jira/browse/WICKET-6465 ---
[GitHub] wicket issue #229: WICKET-6438 - 8.x reference guide needs a few minor impro...
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/229 @ozeray , could you please close this PR? Thank you! ---
[GitHub] wicket issue #229: WICKET-6438 - 8.x reference guide needs a few minor impro...
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/229 hi @ozeray , please close this issue as i don't have the rights to do it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #224: Fixed WicketTester to detect components in enclosu...
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/224#discussion_r129855170
--- Diff:
wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
---
@@ -2325,21 +2325,27 @@ public Result isComponentOnAjaxResponse(final
Component component)
failMessage = "Component wasn't found in the AJAX response. " +
componentInfo;
result = isTrue(failMessage, isComponentInAjaxResponse);
- // Check if the component has been included as part of an
enclosure render
- Enclosure enclosure =
getLastRenderedPage().visitChildren(Enclosure.class, (Enclosure enc,
IVisit visit) -> {
- if
(AjaxEnclosureListener.isControllerOfEnclosure(component, enc)){
- visit.stop(enc);
+ if (result.wasFailed()){
--- End diff --
To avoid if-else nesting I usually prefer to return immediately:
```
if (!result.wasFailed())
{
return result;
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #212: WICKET-6177 Blocking page serialization
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/212 Hi @manuelbarzi thank you for you PR. I see you added Guava as dependency but I don't see any point where you use it. Am I missing something? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/195 thank you all! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #195: WICKET-6287 Switch from json.org to open-json - 7.x
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/195 @klopfdreh Hi, One minor issue I've seen with this PR is that now ' new JSONObject' throws checked exceptions, so the code must be adapted some how. This happened with WicketStuff [here](https://travis-ci.org/wicketstuff/core/builds/188994145). It's not a big issue, but maybe this could be a problem with other libraries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #193: WICKET-6287 Switch from json.org to open-json - 8.x
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/193 +1 to merge. I've tested with WicketStuff and with @sebfz1 wicket-jquery-ui. Two PR have been created for this two project but everything seems to work fine with them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #193: WICKET-6287 Switch from json.org to open-json - 8.x
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/193 Sorry I wasn't clear. I asked if this PR is complete and if we should proceed merging it and wicketstuff/core#566. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #193: WICKET-6287 Switch from json.org to open-json - 8.x
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/193 @klopfdreh @martin-g Shall we go ahead merging or do you prefer to port the pr to the other two branches first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/193#discussion_r89835461 --- Diff: pom.xml --- @@ -447,6 +447,12 @@ jar + com.tdunning + json + 1.2-SNAPSHOT --- End diff -- I've already opened an issue. Just in case... https://github.com/tdunning/open-json/issues/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/193#discussion_r89825120
--- Diff: pom.xml ---
@@ -447,6 +447,12 @@
jar
+ com.tdunning
+ json
+ 1.2-SNAPSHOT
--- End diff --
I think the problem is that the new library escapes special characters also
for JSONFunction, so 'alert("")' becomes 'alert(\"\")' and can not be evaluated
by javascript.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/193#discussion_r89820402 --- Diff: pom.xml --- @@ -447,6 +447,12 @@ jar + com.tdunning + json + 1.2-SNAPSHOT --- End diff -- @klopfdreh JSONFunction are rendered as regular strings, surrounded by double quotes. But I think the culprit is here: https://github.com/tdunning/open-json/blob/master/src/main/java/org/json/JSONStringer.java#L261 We should rename JsonFunction back to JSONFunction --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/193#discussion_r89802532 --- Diff: pom.xml --- @@ -447,6 +447,12 @@ jar + com.tdunning + json + 1.2-SNAPSHOT --- End diff -- @klopfdreh Please don't go ahead with the integration! I think we have a problem with the new JSON library and AJAX. The Modal Window doesn't work... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/193#discussion_r89743045 --- Diff: pom.xml --- @@ -447,6 +447,12 @@ jar + com.tdunning + json + 1.2-SNAPSHOT --- End diff -- @klopfdreh I'm done with wicketstuff. I think 4-5 modules (select2, whiteboard, etc...) should be manually tested but don't expect problems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/193#discussion_r89698452 --- Diff: pom.xml --- @@ -447,6 +447,12 @@ jar + com.tdunning + json + 1.2-SNAPSHOT --- End diff -- @klopfdreh ok, i'm working on few minor problems with wicketstuff. The main one is to substitute JSONWriter with JSONStringer which don't have exactly the same methods. When I'm done I will proceed with the merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/193#discussion_r89690436 --- Diff: pom.xml --- @@ -447,6 +447,12 @@ jar + com.tdunning + json + 1.2-SNAPSHOT --- End diff -- @klopfdreh mvn clean test works just fine for me, I just changed 1.2-SNAPSHOT to 1.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/193#discussion_r89680957 --- Diff: pom.xml --- @@ -447,6 +447,12 @@ jar + com.tdunning + json + 1.2-SNAPSHOT --- End diff -- @klopfdreh Great! Good job Tobias! I think we can go ahead with this PR and merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #193: WICKET-6287 Switch from json.org to open-json - 8....
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/193#discussion_r89675392 --- Diff: pom.xml --- @@ -447,6 +447,12 @@ jar + com.tdunning + json + 1.2-SNAPSHOT --- End diff -- Hi @klopfdreh , why we can't use the current version 1.1 and wait for 1.2? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #180: Alternative solution
Github user bitstorm closed the pull request at: https://github.com/apache/wicket/pull/180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #180: Alternative solution
GitHub user bitstorm opened a pull request: https://github.com/apache/wicket/pull/180 Alternative solution Why not just this code? You can merge this pull request into a Git repository by running: $ git pull https://github.com/bitstorm/wicket WICKET-6242 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/180.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #180 commit 8a168147799387d5bd457f1ce2d22df07a657a65 Author: Andrea Del Bene <adelb...@apache.org> Date: 2016-09-12T16:04:05Z Alternative solution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #172: WICKET-6053 Allow to reuse the same application instance ...
Github user bitstorm commented on the issue: https://github.com/apache/wicket/pull/172 +1 nice! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: Port of AJAX stateless artifacts from wickets...
Github user bitstorm closed the pull request at: https://github.com/apache/wicket/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: Port of AJAX stateless artifacts from wickets...
Github user bitstorm commented on the pull request: https://github.com/apache/wicket/pull/170#issuecomment-220080928 @svenmeier I also agree that the best way to proceed now would be to commit just the code to make stateless AJAX possible, i.e. to commit just the code involving the existing AJAX components/behaviors. If everybody agrees I will close this PR without merging anything and I will open an issue on JIRA to commit just the code we need. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: Port of AJAX stateless artifacts from wickets...
Github user bitstorm commented on the pull request: https://github.com/apache/wicket/pull/170#issuecomment-219976785 BTW I'm starting to wonder if we really need a custom AbstractDefaultAjaxBehavior#getCallbackUrl() to add page parameters to the callback url. When we generate an URL for stateless pages we end up using AbstractBookmarkableMapper or MountedMapper and both uses page.getPageParameters() to build the URL (line 182 for MountedMapper and 476 for AbstractBookmarkableMapper ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: Port of AJAX stateless artifacts from wickets...
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/170#discussion_r63567121
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -81,7 +82,27 @@
@Override
protected void onBind()
{
- getComponent().setOutputMarkupId(true);
+ final Component component = getComponent();
+
+ component.setOutputMarkupId(true);
+
+ if (getStatelessHint(component))
+ {
+ //generate behavior id
+ component.getBehaviorId(this);
+ }
+ }
+
+ @Override
+ public CharSequence getCallbackUrl()
+ {
+ if (getStatelessHint(getComponent()))
+ {
+ final Url url =
Url.parse(super.getCallbackUrl().toString());
+ return UrlUtils.mergeParameters(url).toString();
--- End diff --
@svenmeier yes you are just right. We should pass page parameters here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Port of AJAX stateless artifacts from wickets...
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/170#discussion_r63556050
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -81,7 +82,27 @@
@Override
protected void onBind()
{
- getComponent().setOutputMarkupId(true);
+ final Component component = getComponent();
+
+ component.setOutputMarkupId(true);
+
+ if (getStatelessHint(component))
+ {
+ //generate behavior id
+ component.getBehaviorId(this);
+ }
+ }
+
+ @Override
+ public CharSequence getCallbackUrl()
+ {
+ if (getStatelessHint(getComponent()))
+ {
+ final Url url =
Url.parse(super.getCallbackUrl().toString());
+ return UrlUtils.mergeParameters(url).toString();
--- End diff --
yes you are right, I haven't finished yet the refactoring. We can simplify
even more moving away getCallbackUrl from AbstractDefaultAjaxBehavior and using
it with page parameters only in StatelessAjaxEventBehavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Port of AJAX stateless artifacts from wickets...
Github user bitstorm commented on the pull request: https://github.com/apache/wicket/pull/170#issuecomment-219660664 @martin-g using inheritance instead of a separate stateless hierarchy reduced the code a lot :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: Port of AJAX stateless artifacts from wickets...
Github user bitstorm commented on the pull request: https://github.com/apache/wicket/pull/170#issuecomment-218976648 Hi @martin-g and thank you for your reviw, as you noted the code contains some classes where code is repeated. I've tried to reduce code duplication but without using Java 8 is nearly impossible. As you mentioned above default methods might help a lot. I'm considering to post-pone this integration to Wicket 8 where I'm free to use Java 8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: Port of AJAX stateless artifacts from wickets...
GitHub user bitstorm opened a pull request: https://github.com/apache/wicket/pull/170 Port of AJAX stateless artifacts from wicketstuff stateless module Port of AJAX stateless artifacts from wicketstuff stateless module You can merge this pull request into a Git repository by running: $ git pull https://github.com/bitstorm/wicket ajax-stateless Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/170.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #170 commit 0ca1c0cce91501e7626e4e37d7ae408c856348dc Author: Andrea Del Bene <andrea.delb...@innoteam.it> Date: 2016-04-05T16:43:38Z Porting of stateless AJAX components to the official project commit 587440b51d71c71ee6021bfe8c34249dbcc5 Author: Andrea Del Bene <andrea.delb...@innoteam.it> Date: 2016-04-07T09:47:27Z Integrated examples and unit tests commit 35f11550c96ebd03c2c7eb7b000b76c68b7be968 Author: Andrea Del Bene <andrea.delb...@innoteam.it> Date: 2016-04-07T15:12:28Z Added javadoc commit 7364d9effdba03da129629c89e1a0b76067b06d6 Author: Andrea Del Bene <andrea.delb...@innoteam.it> Date: 2016-04-08T12:27:28Z added chapter for stateless AJAX commit 8950580644d6fb932cea926d2c498cea1daff211 Author: Andrea Del Bene <andrea.delb...@innoteam.it> Date: 2016-04-08T16:31:48Z Minor fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: examples7x.wicket.apache.org/resourceaggregat...
Github user bitstorm commented on the pull request: https://github.com/apache/wicket/pull/154#issuecomment-169041812 @francois92 could you please close this PR? The problem has been fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Github user bitstorm commented on the pull request: https://github.com/apache/wicket/pull/90#issuecomment-74585821 actually I have already applied your commit to 6.x (hash 1a6f1bde1a6b576f39bf6fd6d5129d577319c2a7 ). So now its ok. I forgot to notify you about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Github user bitstorm commented on a diff in the pull request: https://github.com/apache/wicket/pull/90#discussion_r24722572 --- Diff: wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java --- @@ -233,12 +246,6 @@ protected final CharSequence renderAjaxAttributes(final Component component, attributesJson.put(AjaxAttributeName.MARKUP_ID.jsonName(), componentId); } --- End diff -- I'm just curious...why have you moved the 5 lines below at the beginning of the method (line 223)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/90#discussion_r24726057
--- Diff:
wicket-core/src/test/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadFieldTest.java
---
@@ -63,13 +64,16 @@ protected void onSubmit()
for (int i = 1; i 2; i++)
{
FileUpload fileUpload = uploads.get(i);
-
assertEquals(MultiFileUploadFieldTest.class.getSimpleName()+i+.txt,
fileUpload.getClientFileName());
+
assertEquals(MultiFileUploadFieldTest.class.getSimpleName() + (i - 1) + .txt,
--- End diff --
There's a problem with '(i - 1)'. I've reverted it to simply 'i' and test
passes with success. Can you confirm that this change is not necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Build/wicket 7.0.0 m4
Github user bitstorm commented on the pull request: https://github.com/apache/wicket/pull/82#issuecomment-73699972 Changes integrated in other PRs or branches --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: Build/wicket 7.0.0 m4
Github user bitstorm closed the pull request at: https://github.com/apache/wicket/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: WICKET-5827 Allow to apply multiple Javascrip...
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/87#discussion_r24089981
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CompositeCssCompressor.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.resource;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.wicket.css.ICssCompressor;
+
+/**
+ * Used to apply several {@link ICssCompressor} to the css compression.br
+ * br
+ * Usage:
+ *
+ * pre
+ * CompositeCssCompressor compositeCssCompressor = new
CompositeCssCompressor();
+ *
+ * compositeCssCompressor.getCompressors().add(new MyCssCompressor());
+ * compositeCssCompressor.getCompressors().add(new AnotherCssCompressor());
+ *
+ * this.getResourceSettings().setCssCompressor(compositeCssCompressor);
+ * /pre
+ * @since 6.20.0
+ * @author Tobias Soloschenko
+ *
+ */
+public class CompositeCssCompressor implements ICssCompressor
+{
+
+ /* Compressors to compress the CSS content */
+ private ListICssCompressor compressors;
+
--- End diff --
Personally I would initialize compressors in-line so we can skip 'if
(compressors != null)' checks. In addition I would also add a constructor with
multiple args for compressors : 'CompositeCssCompressor(ICssCompressor...)' .
Same for CompositeJavaScriptCompressor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Build/wicket 7.0.0 m4
GitHub user bitstorm opened a pull request: https://github.com/apache/wicket/pull/82 Build/wicket 7.0.0 m4 pull request to discuss WICKET-5802 and WICKET-5801 You can merge this pull request into a Git repository by running: $ git pull https://github.com/klopfdreh/wicket build/wicket-7.0.0-M4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 commit 8b53ff4a43e6e329ed4eb76cc7769d0c3cd73684 Author: Martijn Dashorst dasho...@apache.org Date: 2014-10-31T13:13:15Z Changes to notice files and quickstart archetype commit 9562c66e671ad9440b743950597733a25f7397bc Author: Martijn Dashorst dasho...@apache.org Date: 2014-10-31T13:13:25Z [maven-release-plugin] prepare release wicket-7.0.0-M4 commit 5ea3b5625c72ad4c8c52fa30a0a2d11d0254c5b0 Author: Martijn Dashorst dasho...@apache.org Date: 2014-10-31T13:13:25Z [maven-release-plugin] prepare for next development iteration commit 15283cb93238995c3fc3ed6bf4095fd0901318b0 Author: klopfdreh klopfdreh@tobiass-mbp Date: 2014-12-25T09:22:24Z Responsive Images http://responsiveimages.org commit 339e9cc3799816808d5233d6a45dc06037725b8d Author: klopfdreh klopfdreh@tobiass-mbp Date: 2014-12-25T09:28:28Z Applied diamond syntax back to the image model commit f89731b267ee5c0f181bd1369988dc00088c Author: klopfdreh klopfdreh@tobiass-mbp Date: 2014-12-28T10:35:03Z HTML5 Import http://www.html5rocks.com/en/tutorials/webcomponents/imports/ http://w3c.github.io/webcomponents/spec/imports/ commit 564acb74c619400635ab3d2de8946ebbb460a540 Author: klopfdreh klopfdreh@tobiass-mbp Date: 2015-01-07T13:17:04Z HTML5 Import with MetaDataHeaderItem commit 0434e1d64520612afb00c6b1fb893e1d7b1b1a04 Author: klopfdreh klopfdreh@tobiass-mbp Date: 2015-01-07T13:26:14Z HTML5 Import with MetaDataHeaderItem rename methods commit 4add7fdea14b6605f06ae1240aaf4239b4b1787b Author: Tobias Soloschenko noctur...@googlemail.com Date: 2015-01-07T13:38:09Z Update MetaDataHeaderItem.java author commit 66c203a0abb47e895bd1696acf43804e9788c27a Author: klopfdreh klopfdreh@tobiass-mbp Date: 2015-01-10T23:27:13Z WICKET-5808 Generic Autowiring Spring 4.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: Update DateTimeField.java new factory method ...
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/80#discussion_r21788676
--- Diff:
wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
---
@@ -209,6 +206,25 @@ public boolean isVisible()
}
/**
+* create a new {@link TextField} instance for hours to be added to
this panel.
+*
+* @param id
+*the component id
+* @param model
+*model that should be used by the {@link TextField}
+* @param type
+*the type of the text field
+* @return a new text field instance
+*/
+ protected TextFieldInteger newHoursTextField(final String id,
IModelInteger model, ClassInteger type) {
+ TextFieldInteger hoursTextField = new TextFieldInteger(id,
model, type);
--- End diff --
Hi. Could you please use diamond operator? We try to use it wherever is
possible. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
wicket pull request: Removed deprecated Url.isAbsolute
Github user bitstorm closed the pull request at: https://github.com/apache/wicket/pull/40
wicket pull request: Removed deprecated Url.isAbsolute
GitHub user bitstorm opened a pull request: https://github.com/apache/wicket/pull/40 Removed deprecated Url.isAbsolute You can merge this pull request into a Git repository by running: $ git pull https://github.com/bitstorm/wicket master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/40.patch commit 80d8f91e7716d78d82effe6f751e5bc7ab15b9fa Author: bitstorm an.delb...@gmail.com Date: 2013-05-28T14:27:46Z Removed deprecated Url.isAbsolute
