[GitHub] wicket pull request #229: WICKET-6438 - 8.x reference guide needs a few mino...
Github user ozeray closed the pull request at: https://github.com/apache/wicket/pull/229 ---
[GitHub] wicket issue #229: WICKET-6438 - 8.x reference guide needs a few minor impro...
Github user ozeray commented on the issue: https://github.com/apache/wicket/pull/229 Implemented Martin's diff request. Made some more improvements on 8.x reference documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #229: WICKET-6438 - 8.x reference guide needs a few minor impro...
Github user ozeray commented on the issue: https://github.com/apache/wicket/pull/229 Closed by fault. Sorry. Reopened the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #229: WICKET-6438 - 8.x reference guide needs a few mino...
GitHub user ozeray reopened a pull request: https://github.com/apache/wicket/pull/229 WICKET-6438 - 8.x reference guide needs a few minor improvements Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during maven packaging phase: WARNING: image to embed not found or not readable: F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg Minor fix in contributing.adoc: Revised the generated document target directory for the user guide documentation. Cropped top and bottom blank parts in comsysto-logo.png to have the Introduction page fit in one page in PDF. Made minor changes in helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ozeray/wicket master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit 9e323be5eecba1052414e22f4d3505bbc5863238 Author: ozeray Date: 2017-08-06T00:12:03Z A few minor improvements Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during maven packaging phase: WARNING: image to embed not found or not readable: F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg Minor fix in contributing.adoc: Revised the generated document target directory for the user guide documentation. Cropped top and bottom blank parts in comsysto-logo.png to have the Introduction page fit in one page in PDF. Made minor changes in helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. commit 149134dbea8bb99253853338f471a2dab207733c Author: ozeray Date: 2017-08-06T00:42:04Z Added github forking step into Contribution section. Made a few minor changes to adapt with this new step. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #229: WICKET-6438 - 8.x reference guide needs a few minor impro...
Github user ozeray commented on the issue: https://github.com/apache/wicket/pull/229 Added github forking step into Contribution section. Made a few minor changes to adapt with this new step. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #229: WICKET-6438 - 8.x reference guide needs a few mino...
Github user ozeray closed the pull request at: https://github.com/apache/wicket/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request #229: WICKET-6438 - 8.x reference guide needs a few mino...
GitHub user ozeray opened a pull request: https://github.com/apache/wicket/pull/229 WICKET-6438 - 8.x reference guide needs a few minor improvements Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during maven packaging phase: WARNING: image to embed not found or not readable: F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg Minor fix in contributing.adoc: Revised the generated document target directory for the user guide documentation. Cropped top and bottom blank parts in comsysto-logo.png to have the Introduction page fit in one page in PDF. Made minor changes in helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ozeray/wicket master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #229 commit 9e323be5eecba1052414e22f4d3505bbc5863238 Author: ozeray Date: 2017-08-06T00:12:03Z A few minor improvements Minor fix in helloWorld.adoc: Removed irrelevant line to avoid warning during maven packaging phase: WARNING: image to embed not found or not readable: F:/wicket/wicket-user-guide/src/main/asciidoc/images/uml-component.svg Minor fix in contributing.adoc: Revised the generated document target directory for the user guide documentation. Cropped top and bottom blank parts in comsysto-logo.png to have the Introduction page fit in one page in PDF. Made minor changes in helloWorld_2.adoc, helloWorld_3.adoc and introduction.adoc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
