[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/224 The PR has been merged to Wicket 8 (master). @disblader Please close it because we do not own this repo. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/224 Thanks a lot for your effort. @martin-g I saw you did the review already. I created a JIRA ticket: https://issues.apache.org/jira/browse/WICKET-6434. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user disblader commented on the issue: https://github.com/apache/wicket/pull/224 I think I managed to revert the changes, the pull request should not contain only useful changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/224 Just do a revert commit and apply the changes you originally wanted to do in a separate one ð I think your IDE is also supporting this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user disblader commented on the issue: https://github.com/apache/wicket/pull/224 Oh no, accidently moved everything around with my IDE ð¢ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user disblader commented on the issue: https://github.com/apache/wicket/pull/224 Awesome! Thanks ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/224 Thanks for the pull request! We will create a ticket in JIRA for the changelog and merge it soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/224 `Enclosure` handles ``. `InlineEnclosure` handles `` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket issue #224: Fixed WicketTester to detect components in enclosure when...
Github user disblader commented on the issue: https://github.com/apache/wicket/pull/224 Also, I used `Enclosure` as opposed to `InlineEnclosure` even thought `AjaxEnclosureListener` uses `InlineEnclosure` because I wasn't sure exactly what the difference was and just wanted to be safe. Should it be changed to `InlineEnclosure`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
