Re: svn commit: r1031432 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
This commits breaks all header contributions when the ajaxrequesttarget has more then 1 component that it must render and the component after the first one also wants to render something in the head.. i committed a fix: commit -m fix form previous commit: 1031432... C:/workspace_wicket14/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Sending C:/workspace_wicket14/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Transmitting file data ... Committed revision 1040980. so that the header is now only closed after all components are rendered. Don't we have any test that would cover this? That should have failed? So a test that renders 2 components in an ajax request and both contribute some css or js. johan On Fri, Nov 5, 2010 at 06:07, jrthomer...@apache.org wrote: Author: jrthomerson Date: Fri Nov 5 05:07:52 2010 New Revision: 1031432 URL: http://svn.apache.org/viewvc?rev=1031432view=rev Log: AjaxRequestTarget was not calling IHeaderResponse.close() after traversing hierarchy to renderhead on all appropriate iheadercontributors Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?rev=1031432r1=1031431r2=1031432view=diff == --- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java (original) +++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Fri Nov 5 05:07:52 2010 @@ -1143,6 +1143,7 @@ public class AjaxRequestTarget implement } }); } + header.getHeaderResponse().close(); // revert to old response
Re: svn commit: r1031432 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Johan, See the discussion from Nov 11 with subject mentioning ...svn commit: r1033843... There we tried to figure out the meaning of the single failing test. I still wonder where that 'B' comes from in the expected result :...javascriptUrl[B]... On Wed, Dec 1, 2010 at 1:34 PM, Johan Compagner jcompag...@gmail.comwrote: This commits breaks all header contributions when the ajaxrequesttarget has more then 1 component that it must render and the component after the first one also wants to render something in the head.. i committed a fix: commit -m fix form previous commit: 1031432... C:/workspace_wicket14/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Sending C:/workspace_wicket14/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Transmitting file data ... Committed revision 1040980. so that the header is now only closed after all components are rendered. Don't we have any test that would cover this? That should have failed? So a test that renders 2 components in an ajax request and both contribute some css or js. johan On Fri, Nov 5, 2010 at 06:07, jrthomer...@apache.org wrote: Author: jrthomerson Date: Fri Nov 5 05:07:52 2010 New Revision: 1031432 URL: http://svn.apache.org/viewvc?rev=1031432view=rev Log: AjaxRequestTarget was not calling IHeaderResponse.close() after traversing hierarchy to renderhead on all appropriate iheadercontributors Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?rev=1031432r1=1031431r2=1031432view=diff == --- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java (original) +++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Fri Nov 5 05:07:52 2010 @@ -1143,6 +1143,7 @@ public class AjaxRequestTarget implement } }); } + header.getHeaderResponse().close(); // revert to old response
Re: svn commit: r1031432 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
I think it does. I haven't had the opportunity to look through the entire thread, but it looks like Johan has a fix. As long as the fix still includes calling close somewhere near the end of the request, it works for me. In that case, if there are VP objections, I'll plan on building a release to vote on in the next 48 hours. Thoughts? Jeremy Thomerson http://wickettraining.com -- sent from my smart phone, so please excuse spelling, formatting, or compiler errors On Dec 1, 2010 8:42 AM, Ernesto Reinaldo Barreiro reier...@gmail.com wrote: Thanks for the explanation. So, this makes 1.4.14 a really dangerous version to use:-( Does this merits rolling out a 1.4.15? Regards, Ernesto On Wed, Dec 1, 2010 at 2:26 PM, Johan Compagner jcompag...@gmail.com wrote: that really sounds ...
Re: svn commit: r1031432 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
i just moved your all a bit up the call chain so no when it handles 1 component but when it handles all components, see my commit. On Wed, Dec 1, 2010 at 15:15, Jeremy Thomerson jer...@wickettraining.com wrote: I think it does. I haven't had the opportunity to look through the entire thread, but it looks like Johan has a fix. As long as the fix still includes calling close somewhere near the end of the request, it works for me. In that case, if there are VP objections, I'll plan on building a release to vote on in the next 48 hours. Thoughts? Jeremy Thomerson http://wickettraining.com -- sent from my smart phone, so please excuse spelling, formatting, or compiler errors On Dec 1, 2010 8:42 AM, Ernesto Reinaldo Barreiro reier...@gmail.com wrote: Thanks for the explanation. So, this makes 1.4.14 a really dangerous version to use:-( Does this merits rolling out a 1.4.15? Regards, Ernesto On Wed, Dec 1, 2010 at 2:26 PM, Johan Compagner jcompag...@gmail.com wrote: that really sounds ...
