[GitHub] wicket pull request #227: Fixes issue of pushing resources

[klopfdreh]

Github user klopfdreh commented on a diff in the pull request:

https://github.com/apache/wicket/pull/227#discussion_r130974278
  
--- Diff: 
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
 ---
@@ -361,7 +366,32 @@ else if (url.toString().startsWith("."))
url = url.toString().substring(1);
}
 
-   urls.add(url.toString());
+   // The context path and the filter have to be 
applied to the URL, because otherwise
--- End diff --

Is someone able to review this and the following lines of code? I dislike 
the handling about the slashes in the url and to build up the path part that 
way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Apache Distributed Release Audit Tool (DRAT)

[Tobias Soloschenko]

Thanks for sharing! :-)

Great to here that Wicket is used that way.

> Am 02.08.2017 um 19:41 schrieb Martijn Dashorst :
> 
> I interpreted Chris's mention of Wicket gurus to be an invite for wider
> sharing
> 
> Martijn
> 
> -- Forwarded message -
> Van: Chris Mattmann
> Datum: wo 2 aug. 2017 om 19:35
> Onderwerp: [DISCUSS] Apache Distributed Release Audit Tool (DRAT)
> 
> Hi Board-Chat@,
> 
> CC/Incubator@
> 
> We are proposing to bring DRAT (Distributed Release Audit Tool) to the ASF.
> DRAT is a parallelized version of Apache RAT that uses OODT, Solr and Tika
> to
> compute, visualize and interact with interesting statistics on code
> auditing as
> output by RAT and Tika. With DRAT you can:
> 
> • Audit large code repositories (has been tested in 100s of M of lines of
> code, and 1000s of projects)  where RAT fails to complete – an example of
> running it across all of Apache
> SVN is here: http://drat.dyndns.org:8080/dratviz/ You can also see its
> output
> for a very large set of NSF funded geosciences code repositories here:
> http://drat.dyndns.org:8080/dratontoviz/
> • Visualize and interact with the output from RAT and Tika in a dynamic
> fashion
> • Get incremental status from code auditing
> • Audit individual code repos and integrate the results into your project
> 
> DRAT was funded by DARPA, NASA, the NSF and other government entities.
> 
> We have prepared a preliminary proposal here:
> https://wiki.apache.org/incubator/DRATProposal
> 
> We are working on flushing it out more, should be done by this weekend. We
> propose
> DRAT to be a straight to TLP (pTLP). I will add a resolution into the Board
> agenda for August 2017
> for its consideration. I am CC’ing the Incubator so that we can potentially
> attract new contributors
> both seasoned and junior to the project. We also welcome any contributors
> from Creadur interested
> in learning more about OODT, Solr, Tika, etc. Also any Wicket gurus – we
> are using Wicket for one of
> DRAT’s key user interfaces, Proteus.
> 
> 
> -- 
> Become a Wicket expert, learn from the best: http://wicketinaction.com

Fwd: [DISCUSS] Apache Distributed Release Audit Tool (DRAT)

[Martijn Dashorst]

I interpreted Chris's mention of Wicket gurus to be an invite for wider
sharing

Martijn

-- Forwarded message -
Van: Chris Mattmann
Datum: wo 2 aug. 2017 om 19:35
Onderwerp: [DISCUSS] Apache Distributed Release Audit Tool (DRAT)

Hi Board-Chat@,

CC/Incubator@

We are proposing to bring DRAT (Distributed Release Audit Tool) to the ASF.
DRAT is a parallelized version of Apache RAT that uses OODT, Solr and Tika
to
compute, visualize and interact with interesting statistics on code
auditing as
output by RAT and Tika. With DRAT you can:

• Audit large code repositories (has been tested in 100s of M of lines of
code, and 1000s of projects)  where RAT fails to complete – an example of
running it across all of Apache
SVN is here: http://drat.dyndns.org:8080/dratviz/ You can also see its
output
for a very large set of NSF funded geosciences code repositories here:
http://drat.dyndns.org:8080/dratontoviz/
• Visualize and interact with the output from RAT and Tika in a dynamic
fashion
• Get incremental status from code auditing
• Audit individual code repos and integrate the results into your project

DRAT was funded by DARPA, NASA, the NSF and other government entities.

We have prepared a preliminary proposal here:
https://wiki.apache.org/incubator/DRATProposal

We are working on flushing it out more, should be done by this weekend. We
propose
DRAT to be a straight to TLP (pTLP). I will add a resolution into the Board
agenda for August 2017
for its consideration. I am CC’ing the Incubator so that we can potentially
attract new contributors
both seasoned and junior to the project. We also welcome any contributors
from Creadur interested
in learning more about OODT, Solr, Tika, etc. Also any Wicket gurus – we
are using Wicket for one of
DRAT’s key user interfaces, Proteus.


-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com