[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1725541943 It's `WSSecurityException.ErrorCode.FAILURE`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1725139230 There now exists: ``` Error: Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.049 s <<< FAILURE! -- in org.apache.wss4j.dom.saml.SamlNegativeTest Error: org.apache.wss4j.dom.saml.SamlNegativeTest.testSAML2AuthnAssertionModified -- Time elapsed: 0.010 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: but was: at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31) at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179) at org.apache.wss4j.dom.saml.SamlNegativeTest.testSAML2AuthnAssertionModified(SamlNegativeTest.java:149) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) ``` Is this something you'd like me to look into? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1720686499 This is now done, and I suppose GH workflows should also update to support JDK 17 which is the minimum requirement for OS v5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1720483723 V5 is now released. Shall I update this pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1373111986 No news yet. It generally should happen along with the release of the shibboleth idp v5, and I suspect that might happen in approx a month. Certainly in Q1. Fingers crossed. How do you feel about merging this and letting folks test changes? At the moment I have a custom fork of the project here built against opensaml v5 and released via GitHub so we can run integration tests. There should hopefully not be any major compatibility issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1370794269 Ok thank you. I am guessing that is likely because wss4j is not using any of the opensaml encoders/decoders that wants to deal with http request and or response(?) since they mainly belong to the javax/jakarta namespace. Otherwise I am not sure how this could ever work :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1369421257 @coheigea Small question if I may: I see that v3 release supports jakarta APIs, and yet the release is still based on OpenSAML v4 which has no support for such APIs. Would't this mean that SAML functionality is effectively broken in the v3 release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1275780728 I appreciate your update. I am keeping an eye out for the OS release, and will post back here. (Anticipating late December) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
[GitHub] [ws-wss4j] mmoayyed commented on pull request #62: Upgrade to OpenSAML v5
mmoayyed commented on PR #62: URL: https://github.com/apache/ws-wss4j/pull/62#issuecomment-1275245180 Hello @coheigea is this something that can be included in v4 here? Given OpenSAML v5 does provide support for Jakarta APIs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ws.apache.org For additional commands, e-mail: dev-h...@ws.apache.org
