Re: [Dev] [APIM] [C5] package-lock.json files are untracked

[Chanaka Jayasena]

Package-lock is to generate the exact node modules tree when there are
chain dependency version mismatches. Configuring the .npmrc to ignore the
lock file is fixing the build breaks (We have config this in the publisher
app ). But recommended approach is to commit the package-lock.json file so
that the one committing the lock file can exactly project the node-modules
tree on the one who's taking the checkout.

thanks,
Chanaka

On Fri, Nov 3, 2017 at 7:35 PM, Harsha Kumara  wrote:

> Adding Chanka.
>
> @Chanka what would be the best here. To ignore or commit it? @Menuka it
> seems we can ignore it from the .gitignire as per you reference issues.
> Let's add a pull request and fix it.
>
> On Thu, Nov 2, 2017 at 1:41 PM, Menuka Warushavithana 
> wrote:
>
>> Hi all,
>> I have created a GitHub issue for $subject. [1]
>> AFAIK package-lock.json files should either be committed or ignored
>> (added to .gitignore) to avoid unexpected results. [2]
>> Or the generation of package-lock.json could be disabled altogether by
>> adding the line 'package-lock=false' to the .npmrc file. [3]
>>
>>
>> [1] https://github.com/wso2/carbon-apimgt/issues/4676
>> [2] https://github.com/nodejs/citgm/issues/451
>> [3] https://github.com/hapijs/contrib/issues/114
>>
>> Regards
>>
>> *Menuka Warushavithana*
>> *Software Engineering Intern*
>> *WSO2*
>>
>> *Moblie:  + <%2B%2094%2011%202145345%20%C2%A0Ext.%205737> 94 77
>> 6979690*
>> *LinkedIn:   **https://www.linkedin.com/in/menukawarushavithana/
>> *
>> *GitHub:  **https://github.com/menuka94/
>> *
>>
>>
>>
>
>
> --
> Harsha Kumara
> Software Engineer, WSO2 Inc.
> Mobile: +94775505618 <+94%2077%20550%205618>
> Blog:harshcreationz.blogspot.com
>



-- 
Chanaka Jayasena
Associate Tech Lead,
email: chan...@wso2.com; cell: +94 77 4464006
blog: http://chanaka3d.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [APIM] [C5] package-lock.json files are untracked

[Harsha Kumara]

Adding Chanka.

@Chanka what would be the best here. To ignore or commit it? @Menuka it
seems we can ignore it from the .gitignire as per you reference issues.
Let's add a pull request and fix it.

On Thu, Nov 2, 2017 at 1:41 PM, Menuka Warushavithana 
wrote:

> Hi all,
> I have created a GitHub issue for $subject. [1]
> AFAIK package-lock.json files should either be committed or ignored (added
> to .gitignore) to avoid unexpected results. [2]
> Or the generation of package-lock.json could be disabled altogether by
> adding the line 'package-lock=false' to the .npmrc file. [3]
>
>
> [1] https://github.com/wso2/carbon-apimgt/issues/4676
> [2] https://github.com/nodejs/citgm/issues/451
> [3] https://github.com/hapijs/contrib/issues/114
>
> Regards
>
> *Menuka Warushavithana*
> *Software Engineering Intern*
> *WSO2*
>
> *Moblie:  + <%2B%2094%2011%202145345%20%C2%A0Ext.%205737> 94 77
> 6979690*
> *LinkedIn:   **https://www.linkedin.com/in/menukawarushavithana/
> *
> *GitHub:  **https://github.com/menuka94/
> *
>
>
>


-- 
Harsha Kumara
Software Engineer, WSO2 Inc.
Mobile: +94775505618
Blog:harshcreationz.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] [APIM] [C5] package-lock.json files are untracked

[Menuka Warushavithana]

Hi all,
I have created a GitHub issue for $subject. [1]
AFAIK package-lock.json files should either be committed or ignored (added
to .gitignore) to avoid unexpected results. [2]
Or the generation of package-lock.json could be disabled altogether by
adding the line 'package-lock=false' to the .npmrc file. [3]


[1] https://github.com/wso2/carbon-apimgt/issues/4676
[2] https://github.com/nodejs/citgm/issues/451
[3] https://github.com/hapijs/contrib/issues/114

Regards

*Menuka Warushavithana*
*Software Engineering Intern*
*WSO2*

*Moblie:  + <%2B%2094%2011%202145345%20%C2%A0Ext.%205737> 94 77 6979690*
*LinkedIn:   **https://www.linkedin.com/in/menukawarushavithana/
*
*GitHub:  **https://github.com/menuka94/ *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev