[Dev] [IS] Changing AuthenticationContext API

2014-11-19 Thread Malithi Edirisinghe
Hi All,

As per the discussion I had with the IS team I will be changing the
reference type of the instance variable subject, of
org.wso2.carbon.identity.application.authentication.framework.context.AuthenticationContext
from String to org.wso2.carbon.identity.application.common.model.User.
Further, the getter and setter of this variable will be changed accordingly.
The intention of this change is to separately identify the user attributes,
such as username, user store domain and tenant domain.

I found below classes with the usages of the methods that would change.
These will be fixed accordingly.

*Usages of the setter*

org.wso2.carbon.identity.application.authentication.framework.handler.sequence.impl.DefaultStepBasedSequenceHandler
org.wso2.carbon.identity.application.authenticator.basicauth.BasicAuthenticator
org.wso2.carbon.identity.application.authenticator.facebook.FacebookAuthenticator
org.wso2.carbon.identity.application.authenticator.facebook.v2.FacebookAuthenticator
org.wso2.carbon.identity.application.authenticator.iwa.IWAAuthenticator
org.wso2.carbon.identity.application.authenticator.oidc.OpenIDConnectAuthenticator
org.wso2.carbon.identity.application.authenticator.openid.manager.DefaultOpenIDManager
org.wso2.carbon.identity.application.authenticator.passive.sts.manager.PassiveSTSManager
org.wso2.carbon.identity.application.authenticator.requestpath.basicauth.BasicAuthRequestPathAuthenticator
org.wso2.carbon.identity.application.authenticator.requestpath.oauth.OAuthRequestPathAuthenticator
org.wso2.carbon.identity.application.authenticator.samlsso.SAMLSSOAuthenticator

*Usages of the getter*

org.wso2.carbon.identity.application.authentication.framework.handler.sequence.impl.DefaultRequestPathBasedSequenceHandler
org.wso2.carbon.identity.application.authentication.framework.handler.step.impl.DefaultStepHandler

This change will be merged to the public svn.

Welcome any thoughts on this.

Thanks,
Malithi.

-- 

*Malithi Edirisinghe*
Senior Software Engineer
WSO2 Inc.

Mobile : +94 (0) 718176807
malit...@wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] [IS] Changing AuthenticationContext API

2014-11-19 Thread Malithi Edirisinghe
Hi All,

Please note that we will be moving this change to the git repo only.

Thanks,
Malithi.

On Wed, Nov 19, 2014 at 9:37 PM, Malithi Edirisinghe malit...@wso2.com
wrote:

 Hi All,

 As per the discussion I had with the IS team I will be changing the
 reference type of the instance variable subject, of
 org.wso2.carbon.identity.application.authentication.framework.context.AuthenticationContext
 from String to org.wso2.carbon.identity.application.common.model.User.
 Further, the getter and setter of this variable will be changed accordingly.
 The intention of this change is to separately identify the user
 attributes, such as username, user store domain and tenant domain.

 I found below classes with the usages of the methods that would change.
 These will be fixed accordingly.

 *Usages of the setter*


 org.wso2.carbon.identity.application.authentication.framework.handler.sequence.impl.DefaultStepBasedSequenceHandler

 org.wso2.carbon.identity.application.authenticator.basicauth.BasicAuthenticator

 org.wso2.carbon.identity.application.authenticator.facebook.FacebookAuthenticator

 org.wso2.carbon.identity.application.authenticator.facebook.v2.FacebookAuthenticator
 org.wso2.carbon.identity.application.authenticator.iwa.IWAAuthenticator

 org.wso2.carbon.identity.application.authenticator.oidc.OpenIDConnectAuthenticator

 org.wso2.carbon.identity.application.authenticator.openid.manager.DefaultOpenIDManager

 org.wso2.carbon.identity.application.authenticator.passive.sts.manager.PassiveSTSManager

 org.wso2.carbon.identity.application.authenticator.requestpath.basicauth.BasicAuthRequestPathAuthenticator

 org.wso2.carbon.identity.application.authenticator.requestpath.oauth.OAuthRequestPathAuthenticator

 org.wso2.carbon.identity.application.authenticator.samlsso.SAMLSSOAuthenticator

 *Usages of the getter*


 org.wso2.carbon.identity.application.authentication.framework.handler.sequence.impl.DefaultRequestPathBasedSequenceHandler

 org.wso2.carbon.identity.application.authentication.framework.handler.step.impl.DefaultStepHandler

 This change will be merged to the public svn.

 Welcome any thoughts on this.

 Thanks,
 Malithi.

 --

 *Malithi Edirisinghe*
 Senior Software Engineer
 WSO2 Inc.

 Mobile : +94 (0) 718176807
 malit...@wso2.com




-- 

*Malithi Edirisinghe*
Senior Software Engineer
WSO2 Inc.

Mobile : +94 (0) 718176807
malit...@wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev