Re: [Dev] [IS] Why append tenant domain to user name when I already know my domain?
Hi, [Edited subject] I am adding this in case anyone else has this same question, and is seeking an answer at any point. With the offline chat I had with Prabath, apparently this is something we could take off from the code, and has been added with no apparent reason, but to only denote the user's presence in a tenant domain. On Fri, Apr 11, 2014 at 4:32 PM, Shani Ranasinghe sh...@wso2.com wrote: Hi, This was probably a discussion that had taken place even before I joined. If so please point me to it so that I could learn the intention of it. When we set the user name to be an email, when a tenant registers and a tenant user is created, the tenant user's user name has the format user -email @tenant domain. for an e.g. it looks like a...@gmail.com@test.comwhere abc@gmailis the user's email and test.com is the tenant domain. I understand that this is as designed. But it looks a bit awkward to have that two @ signs representation two domains in a single user name. To my little experience I have in this industry, I have not seen any place that handles user's in this fashion. Usually in windows, when you have different domains, it let's you choose which domain you need to log into based on the domain you enter before the user name e.g. domain/user name It let's you choose this at the log in page. So I have two questions, 1) I understand that when the user name is supposed to be a name, then we could append the tenant domain to the user name, but then it looks like an email, why are we doing this? rather than having a domain/user name format? When I log is using my domain, why would i need to see which domain I belong to, I already know? 2) When the user name is set to email, why are we not checking if the user name is of the type an email (if the property is enabled), and avoid appending the domain, but keeping the domain in the context where the rest of the login details are kept? We can basically not show this at the UI level correct? we can either let the user enter his domain in a separate field rather than appending it to the user name? This is just a wild thought I had, and please do correct me at any point. -- Thanks and Regards *, Shani Ranasinghe* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 77 2273555 linked in: lk.linkedin.com/pub/shani-ranasinghe/34/111/ab -- Thanks and Regards *,Shani Ranasinghe* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 77 2273555 linked in: lk.linkedin.com/pub/shani-ranasinghe/34/111/ab ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [IS] Why append tenant domain to user name when I already know my domain?
Hi, The pattern domain/user name is already taken for the multiple userstores scenario. Actually we have no reason to stick into the user -email @tenant domain pattern. In any code in the platform, we must use the MultitenantUtils to get the tenant domain from the user name, get the tenant aware username etc. Therefore we can let the pattern configurable (regex) in the Carbon XML, read that config from MultitenantUtils and return the values appropriately. Probably this is something we can do for the next Kernel release. Thanks, -Suresh On Thu, Apr 17, 2014 at 12:59 AM, Shani Ranasinghe sh...@wso2.com wrote: Hi, [Edited subject] I am adding this in case anyone else has this same question, and is seeking an answer at any point. With the offline chat I had with Prabath, apparently this is something we could take off from the code, and has been added with no apparent reason, but to only denote the user's presence in a tenant domain. On Fri, Apr 11, 2014 at 4:32 PM, Shani Ranasinghe sh...@wso2.com wrote: Hi, This was probably a discussion that had taken place even before I joined. If so please point me to it so that I could learn the intention of it. When we set the user name to be an email, when a tenant registers and a tenant user is created, the tenant user's user name has the format user -email @tenant domain. for an e.g. it looks like a...@gmail.com@ test.com where abc@gmail is the user's email and test.com is the tenant domain. I understand that this is as designed. But it looks a bit awkward to have that two @ signs representation two domains in a single user name. To my little experience I have in this industry, I have not seen any place that handles user's in this fashion. Usually in windows, when you have different domains, it let's you choose which domain you need to log into based on the domain you enter before the user name e.g. domain/user name It let's you choose this at the log in page. So I have two questions, 1) I understand that when the user name is supposed to be a name, then we could append the tenant domain to the user name, but then it looks like an email, why are we doing this? rather than having a domain/user name format? When I log is using my domain, why would i need to see which domain I belong to, I already know? 2) When the user name is set to email, why are we not checking if the user name is of the type an email (if the property is enabled), and avoid appending the domain, but keeping the domain in the context where the rest of the login details are kept? We can basically not show this at the UI level correct? we can either let the user enter his domain in a separate field rather than appending it to the user name? This is just a wild thought I had, and please do correct me at any point. -- Thanks and Regards *, Shani Ranasinghe* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 77 2273555 linked in: lk.linkedin.com/pub/shani-ranasinghe/34/111/ab -- Thanks and Regards *, Shani Ranasinghe* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 77 2273555 linked in: lk.linkedin.com/pub/shani-ranasinghe/34/111/ab ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Suresh Attanayake Senior Software Engineer; WSO2 Inc. http://wso2.com/ Blog : http://sureshatt.blogspot.com/ Web : http://www.ssoarcade.com/ Facebook : https://www.facebook.com/IdentityWorld Twitter : https://twitter.com/sureshatt LinkedIn : http://lk.linkedin.com/in/sureshatt Mobile : +94755012060 Mobile : +016166171172 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [IS] Why append tenant domain to user name when I already know my domain?
Hi, On Wed, Apr 16, 2014 at 6:28 PM, Suresh Attanayaka sur...@wso2.com wrote: Hi, The pattern domain/user name is already taken for the multiple userstores scenario. Oh yes. Another option is that in the log screen we can let the user enter the domain as a separate field but it will increase the number of fields in the log in screen which would not be the best option. By appending with an @ it looks like an email, but is not an email. Shouldn't we go with some other instead of this possibly \ ,that is being used by MSFT. (MSFT uses \ and not /, my bad on the previous mail) Actually we have no reason to stick into the user -email @tenant domain pattern. In any code in the platform, we must use the MultitenantUtils to get the tenant domain from the user name, get the tenant aware username etc. Yes my point exactly. Also even if we do have the user name to be a normal user name(not an email) I don't see why we would need to have the tenant domain appended to the user name. Because you already know your domain, that's how you logged in, I don't think it's necessary to show the domain after you log in. Therefore we can let the pattern configurable (regex) in the Carbon XML, read that config from MultitenantUtils and return the values appropriately. Probably this is something we can do for the next Kernel release. would be nice and less confusing on the UI. Thanks, -Suresh On Thu, Apr 17, 2014 at 12:59 AM, Shani Ranasinghe sh...@wso2.com wrote: Hi, [Edited subject] I am adding this in case anyone else has this same question, and is seeking an answer at any point. With the offline chat I had with Prabath, apparently this is something we could take off from the code, and has been added with no apparent reason, but to only denote the user's presence in a tenant domain. On Fri, Apr 11, 2014 at 4:32 PM, Shani Ranasinghe sh...@wso2.com wrote: Hi, This was probably a discussion that had taken place even before I joined. If so please point me to it so that I could learn the intention of it. When we set the user name to be an email, when a tenant registers and a tenant user is created, the tenant user's user name has the format user -email @tenant domain. for an e.g. it looks like a...@gmail.com@ test.com where abc@gmail is the user's email and test.com is the tenant domain. I understand that this is as designed. But it looks a bit awkward to have that two @ signs representation two domains in a single user name. To my little experience I have in this industry, I have not seen any place that handles user's in this fashion. Usually in windows, when you have different domains, it let's you choose which domain you need to log into based on the domain you enter before the user name e.g. domain/user name It let's you choose this at the log in page. So I have two questions, 1) I understand that when the user name is supposed to be a name, then we could append the tenant domain to the user name, but then it looks like an email, why are we doing this? rather than having a domain/user name format? When I log is using my domain, why would i need to see which domain I belong to, I already know? 2) When the user name is set to email, why are we not checking if the user name is of the type an email (if the property is enabled), and avoid appending the domain, but keeping the domain in the context where the rest of the login details are kept? We can basically not show this at the UI level correct? we can either let the user enter his domain in a separate field rather than appending it to the user name? This is just a wild thought I had, and please do correct me at any point. -- Thanks and Regards *, Shani Ranasinghe* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 77 2273555 linked in: lk.linkedin.com/pub/shani-ranasinghe/34/111/ab -- Thanks and Regards *, Shani Ranasinghe* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 77 2273555 linked in: lk.linkedin.com/pub/shani-ranasinghe/34/111/ab ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Suresh Attanayake Senior Software Engineer; WSO2 Inc. http://wso2.com/ Blog : http://sureshatt.blogspot.com/ Web : http://www.ssoarcade.com/ Facebook : https://www.facebook.com/IdentityWorld Twitter : https://twitter.com/sureshatt LinkedIn : http://lk.linkedin.com/in/sureshatt Mobile : +94755012060 Mobile : +016166171172 -- Thanks and Regards *,Shani Ranasinghe* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware mobile: +94 77 2273555 linked in: lk.linkedin.com/pub/shani-ranasinghe/34/111/ab ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
