Re: [Dev] [PPaaS] Defining Template Parameters in Configurator
Hi Imesh, I have now removed the dependency with parameter names from the configurator. Also changed ESB port mapping settings in the template. Can you please review and merge PR [1]. [1]https://github.com/wso2/product-private-paas/pull/85 On Mon, Jun 1, 2015 at 12:44 PM, Imesh Gunaratne im...@wso2.com wrote: Yes option 2 would be more appropriate. In addition I do not think we need dictionaries for HTTP_PORT_MAPPING, HTTPS_PORT_MAPPING. Moreover those variables need to say which HTTP and HTTPS transports they are referring. On Mon, Jun 1, 2015 at 5:27 AM, Anuruddha Liyanarachchi anurudd...@wso2.com wrote: Hi Imesh, There are two ways we can do this, 1. Introduce new section in module.ini for multivalued attributes. 2. Identify multivalued attributes using a delimiter like a comma. 127.0.0.1:4000 , IMO later will be more appropriate. WDYT ? On Fri, May 29, 2015 at 3:36 PM, Imesh Gunaratne im...@wso2.com wrote: Hi Anuruddha, IMO $subject is not appropriate, Configurator needs to be independent from the template module parameters: # Converting Members to dictionary if STRATOS_WKA_MEMBERS in context: context[STRATOS_WKA_MEMBERS] = ConfigParserUtil.convert_properties_to_dictionary( context['STRATOS_WKA_MEMBERS']) if STRATOS_HTTP_PORT_MAPPING in context: context[STRATOS_HTTP_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTP_PORT_MAPPING]) if STRATOS_HTTPS_PORT_MAPPING in context: context[STRATOS_HTTPS_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTPS_PORT_MAPPING]) Is there anyway we can avoid this? Thanks -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a thili...@wso2.comnurudd...@wso2.com -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a thili...@wso2.comnurudd...@wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [PPaaS] Defining Template Parameters in Configurator
Great! I have now merged the pull request. On Tue, Jun 9, 2015 at 4:41 PM, Anuruddha Liyanarachchi anurudd...@wso2.com wrote: Hi Imesh, I have now removed the dependency with parameter names from the configurator. Also changed ESB port mapping settings in the template. Can you please review and merge PR [1]. [1]https://github.com/wso2/product-private-paas/pull/85 On Mon, Jun 1, 2015 at 12:44 PM, Imesh Gunaratne im...@wso2.com wrote: Yes option 2 would be more appropriate. In addition I do not think we need dictionaries for HTTP_PORT_MAPPING, HTTPS_PORT_MAPPING. Moreover those variables need to say which HTTP and HTTPS transports they are referring. On Mon, Jun 1, 2015 at 5:27 AM, Anuruddha Liyanarachchi anurudd...@wso2.com wrote: Hi Imesh, There are two ways we can do this, 1. Introduce new section in module.ini for multivalued attributes. 2. Identify multivalued attributes using a delimiter like a comma. 127.0.0.1:4000 , IMO later will be more appropriate. WDYT ? On Fri, May 29, 2015 at 3:36 PM, Imesh Gunaratne im...@wso2.com wrote: Hi Anuruddha, IMO $subject is not appropriate, Configurator needs to be independent from the template module parameters: # Converting Members to dictionary if STRATOS_WKA_MEMBERS in context: context[STRATOS_WKA_MEMBERS] = ConfigParserUtil.convert_properties_to_dictionary( context['STRATOS_WKA_MEMBERS']) if STRATOS_HTTP_PORT_MAPPING in context: context[STRATOS_HTTP_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTP_PORT_MAPPING]) if STRATOS_HTTPS_PORT_MAPPING in context: context[STRATOS_HTTPS_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTPS_PORT_MAPPING]) Is there anyway we can avoid this? Thanks -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a thili...@wso2.comnurudd...@wso2.com -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a thili...@wso2.comnurudd...@wso2.com -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [PPaaS] Defining Template Parameters in Configurator
Yes option 2 would be more appropriate. In addition I do not think we need dictionaries for HTTP_PORT_MAPPING, HTTPS_PORT_MAPPING. Moreover those variables need to say which HTTP and HTTPS transports they are referring. On Mon, Jun 1, 2015 at 5:27 AM, Anuruddha Liyanarachchi anurudd...@wso2.com wrote: Hi Imesh, There are two ways we can do this, 1. Introduce new section in module.ini for multivalued attributes. 2. Identify multivalued attributes using a delimiter like a comma. 127.0.0.1:4000 , IMO later will be more appropriate. WDYT ? On Fri, May 29, 2015 at 3:36 PM, Imesh Gunaratne im...@wso2.com wrote: Hi Anuruddha, IMO $subject is not appropriate, Configurator needs to be independent from the template module parameters: # Converting Members to dictionary if STRATOS_WKA_MEMBERS in context: context[STRATOS_WKA_MEMBERS] = ConfigParserUtil.convert_properties_to_dictionary( context['STRATOS_WKA_MEMBERS']) if STRATOS_HTTP_PORT_MAPPING in context: context[STRATOS_HTTP_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTP_PORT_MAPPING]) if STRATOS_HTTPS_PORT_MAPPING in context: context[STRATOS_HTTPS_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTPS_PORT_MAPPING]) Is there anyway we can avoid this? Thanks -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a thili...@wso2.comnurudd...@wso2.com -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [PPaaS] Defining Template Parameters in Configurator
Hi Imesh, There are two ways we can do this, 1. Introduce new section in module.ini for multivalued attributes. 2. Identify multivalued attributes using a delimiter like a comma. 127.0.0.1:4000 , IMO later will be more appropriate. WDYT ? On Fri, May 29, 2015 at 3:36 PM, Imesh Gunaratne im...@wso2.com wrote: Hi Anuruddha, IMO $subject is not appropriate, Configurator needs to be independent from the template module parameters: # Converting Members to dictionary if STRATOS_WKA_MEMBERS in context: context[STRATOS_WKA_MEMBERS] = ConfigParserUtil.convert_properties_to_dictionary( context['STRATOS_WKA_MEMBERS']) if STRATOS_HTTP_PORT_MAPPING in context: context[STRATOS_HTTP_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTP_PORT_MAPPING]) if STRATOS_HTTPS_PORT_MAPPING in context: context[STRATOS_HTTPS_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTPS_PORT_MAPPING]) Is there anyway we can avoid this? Thanks -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a thili...@wso2.comnurudd...@wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [PPaaS] Defining Template Parameters in Configurator
Hi Anuruddha, IMO $subject is not appropriate, Configurator needs to be independent from the template module parameters: # Converting Members to dictionary if STRATOS_WKA_MEMBERS in context: context[STRATOS_WKA_MEMBERS] = ConfigParserUtil.convert_properties_to_dictionary( context['STRATOS_WKA_MEMBERS']) if STRATOS_HTTP_PORT_MAPPING in context: context[STRATOS_HTTP_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTP_PORT_MAPPING]) if STRATOS_HTTPS_PORT_MAPPING in context: context[STRATOS_HTTPS_PORT_MAPPING] = ConfigParserUtil.convert_properties_to_dictionary( context[STRATOS_HTTPS_PORT_MAPPING]) Is there anyway we can avoid this? Thanks -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
