Re: [Dev] [ML] Making the server port configurable in the ML samples

2016-07-26 Thread Nirmal Fernando
Thanks, Niranda ! Merged it.

On Tue, Jul 26, 2016 at 2:33 PM, Niranda Perera  wrote:

> Hi Nirmal,
>
> When I run the ML samples, I found out that SERVER_PORT is not
> configurable as of the current impl [1]. Is there any way where we could
> adjust the port offset in the samples?
>
> If not, I created a PR to make it configurable, following the same
> approach for SERVER_PORT. Please review it and merge it. :-)
>
> Best
>
> [1]
> https://github.com/wso2/product-ml/blob/master/modules/samples/server.conf
> [2] https://github.com/wso2/product-ml/pull/307
> --
> *Niranda Perera*
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44 
> https://pythagoreanscript.wordpress.com/
>



-- 

Thanks & regards,
Nirmal

Team Lead - WSO2 Machine Learner
Associate Technical Lead - Data Technologies Team, WSO2 Inc.
Mobile: +94715779733
Blog: http://nirmalfdo.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


[Dev] [ML] Making the server port configurable in the ML samples

2016-07-26 Thread Niranda Perera
Hi Nirmal,

When I run the ML samples, I found out that SERVER_PORT is not configurable
as of the current impl [1]. Is there any way where we could adjust the port
offset in the samples?

If not, I created a PR to make it configurable, following the same approach
for SERVER_PORT. Please review it and merge it. :-)

Best

[1]
https://github.com/wso2/product-ml/blob/master/modules/samples/server.conf
[2] https://github.com/wso2/product-ml/pull/307
-- 
*Niranda Perera*
Software Engineer, WSO2 Inc.
Mobile: +94-71-554-8430
Twitter: @n1r44 
https://pythagoreanscript.wordpress.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev