Re: [Dev] [Puppet Modules] Kubernetes Naming Convention

[Chamila De Alwis]

+1

This should be a consistent naming.


Regards,
Chamila de Alwis
Committer and PMC Member - Apache Stratos
Software Engineer | WSO2 | +94772207163
Blog: code.chamiladealwis.com



On Mon, Apr 11, 2016 at 2:09 PM, Imesh Gunaratne  wrote:

> Hi Devs,
>
> As I see we have used 'k8' for naming Kubernetes variables. IMO this
> should be either 'k8s' or 'kubernetes':
>
> wso2::clustering :
> enabled : true
> #local_member_host : local.esb.wso2.com
> domain : wso2.esb.domain
> local_member_port : 4000
> #membership_scheme : wka
> membership_scheme : kubernetes
> sub_domain : mgt
> k8 :
>k8_master : http://172.17.8.101:8080
>k8_namespace : default
>k8_services : wso2esb-manager,wso2esb-worker
>k8_master_username :
>k8_master_password :
>
> In the above example I prefer to use kubernetes instead of k8s because we
> have used that for the membership scheme name. WDYT?
>
> [1]
> https://github.com/wso2/puppet-modules/blob/master/modules/wso2esb/templates/4.9.0/repository/conf/axis2/axis2.xml.erb#L506
>
> Thanks
>
> --
> *Imesh Gunaratne*
> Senior Technical Lead
> WSO2 Inc: http://wso2.com
> T: +94 11 214 5345 M: +94 77 374 2057
> W: http://imesh.io
> Lean . Enterprise . Middleware
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] [Puppet Modules] Kubernetes Naming Convention

[Imesh Gunaratne]

Hi Devs,

As I see we have used 'k8' for naming Kubernetes variables. IMO this should
be either 'k8s' or 'kubernetes':

wso2::clustering :
enabled : true
#local_member_host : local.esb.wso2.com
domain : wso2.esb.domain
local_member_port : 4000
#membership_scheme : wka
membership_scheme : kubernetes
sub_domain : mgt
k8 :
   k8_master : http://172.17.8.101:8080
   k8_namespace : default
   k8_services : wso2esb-manager,wso2esb-worker
   k8_master_username :
   k8_master_password :

In the above example I prefer to use kubernetes instead of k8s because we
have used that for the membership scheme name. WDYT?

[1]
https://github.com/wso2/puppet-modules/blob/master/modules/wso2esb/templates/4.9.0/repository/conf/axis2/axis2.xml.erb#L506

Thanks

-- 
*Imesh Gunaratne*
Senior Technical Lead
WSO2 Inc: http://wso2.com
T: +94 11 214 5345 M: +94 77 374 2057
W: http://imesh.io
Lean . Enterprise . Middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev