Re: [Dev] Able to install Features without licenses
Hi Niranjan, We need to properly fix these. When a user selects some features to be installed, the installation should only proceed when all features have Licence information and user has accepted all of them (if there are multiple licences). Also on the licence info page, we need show which features have licences and which does not. When a particular licence is shared among multiple features, we can group them together and show. Thanks, Kishanthan. On Mon, Nov 3, 2014 at 10:49 AM, Niranjan Karunanandham niran...@wso2.com wrote: Hi All, When a feature is being installed via the the feature management UI, the licenses for the feature is obtained from provisioning plan stored in the ServletSession. Currently we cannot install a feature which does not have license, but we are able to install it by selecting it with a feature which has a license (public jira - [1]). Why do we get the licenses from the provisioning plan (line number 260 in [2]) instead of the getting it from the Reviewed Installable Units which contains only the features that need to be installed? [1] - https://wso2.org/jira/browse/CARBON-15049 [2] - https://github.com/wso2/carbon4-kernel/blob/master/core/feature-manager/org.wso2.carbon.feature.mgt.services/src/main/java/org/wso2/carbon/feature/mgt/services/prov/ProvisioningAdminService.java Regards, Nira -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com -- *Kishanthan Thangarajah* Senior Software Engineer, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com http://kishanthan.wordpress.com* Twitter - *http://twitter.com/kishanthan http://twitter.com/kishanthan* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Able to install Features without licenses
Thanks Kishanthan. I have updated the JIRA with the improvement to show the features that belong each license. Regards, Nira On Wed, Nov 5, 2014 at 4:46 PM, Kishanthan Thangarajah kishant...@wso2.com wrote: Hi Niranjan, We need to properly fix these. When a user selects some features to be installed, the installation should only proceed when all features have Licence information and user has accepted all of them (if there are multiple licences). Also on the licence info page, we need show which features have licences and which does not. When a particular licence is shared among multiple features, we can group them together and show. Thanks, Kishanthan. On Mon, Nov 3, 2014 at 10:49 AM, Niranjan Karunanandham niran...@wso2.com wrote: Hi All, When a feature is being installed via the the feature management UI, the licenses for the feature is obtained from provisioning plan stored in the ServletSession. Currently we cannot install a feature which does not have license, but we are able to install it by selecting it with a feature which has a license (public jira - [1]). Why do we get the licenses from the provisioning plan (line number 260 in [2]) instead of the getting it from the Reviewed Installable Units which contains only the features that need to be installed? [1] - https://wso2.org/jira/browse/CARBON-15049 [2] - https://github.com/wso2/carbon4-kernel/blob/master/core/feature-manager/org.wso2.carbon.feature.mgt.services/src/main/java/org/wso2/carbon/feature/mgt/services/prov/ProvisioningAdminService.java Regards, Nira -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com -- *Kishanthan Thangarajah* Senior Software Engineer, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com http://kishanthan.wordpress.com* Twitter - *http://twitter.com/kishanthan http://twitter.com/kishanthan* -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Able to install Features without licenses
Also please arrange a code review for this. On Wed, Nov 5, 2014 at 5:32 PM, Niranjan Karunanandham niran...@wso2.com wrote: Thanks Kishanthan. I have updated the JIRA with the improvement to show the features that belong each license. Regards, Nira On Wed, Nov 5, 2014 at 4:46 PM, Kishanthan Thangarajah kishant...@wso2.com wrote: Hi Niranjan, We need to properly fix these. When a user selects some features to be installed, the installation should only proceed when all features have Licence information and user has accepted all of them (if there are multiple licences). Also on the licence info page, we need show which features have licences and which does not. When a particular licence is shared among multiple features, we can group them together and show. Thanks, Kishanthan. On Mon, Nov 3, 2014 at 10:49 AM, Niranjan Karunanandham niran...@wso2.com wrote: Hi All, When a feature is being installed via the the feature management UI, the licenses for the feature is obtained from provisioning plan stored in the ServletSession. Currently we cannot install a feature which does not have license, but we are able to install it by selecting it with a feature which has a license (public jira - [1]). Why do we get the licenses from the provisioning plan (line number 260 in [2]) instead of the getting it from the Reviewed Installable Units which contains only the features that need to be installed? [1] - https://wso2.org/jira/browse/CARBON-15049 [2] - https://github.com/wso2/carbon4-kernel/blob/master/core/feature-manager/org.wso2.carbon.feature.mgt.services/src/main/java/org/wso2/carbon/feature/mgt/services/prov/ProvisioningAdminService.java Regards, Nira -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com -- *Kishanthan Thangarajah* Senior Software Engineer, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com http://kishanthan.wordpress.com* Twitter - *http://twitter.com/kishanthan http://twitter.com/kishanthan* -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com -- *Kishanthan Thangarajah* Senior Software Engineer, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com http://kishanthan.wordpress.com* Twitter - *http://twitter.com/kishanthan http://twitter.com/kishanthan* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Able to install Features without licenses
Hi All, When a feature is being installed via the the feature management UI, the licenses for the feature is obtained from provisioning plan stored in the ServletSession. Currently we cannot install a feature which does not have license, but we are able to install it by selecting it with a feature which has a license (public jira - [1]). Why do we get the licenses from the provisioning plan (line number 260 in [2]) instead of the getting it from the Reviewed Installable Units which contains only the features that need to be installed? [1] - https://wso2.org/jira/browse/CARBON-15049 [2] - https://github.com/wso2/carbon4-kernel/blob/master/core/feature-manager/org.wso2.carbon.feature.mgt.services/src/main/java/org/wso2/carbon/feature/mgt/services/prov/ProvisioningAdminService.java Regards, Nira -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
