Re: [Dev] Cassandra-thrift dependency on carbon-utils

[Gayashan Amarasinghe]

Hi all,

Lets merge these changes today.

On Wed, Sep 3, 2014 at 2:54 PM, Gayashan Amarasinghe 
wrote:

> Hi Sagara,
>
> I have fixed the mentioned issues in the previous PRs and resent the
> following PR to carbon-utils. We can close the previous PRs (#14, #15, #16)
> without merging them.
>  https://github.com/wso2-dev/carbon-utils/pull/17
>

​This has been closed and following PR has been sent instead.
https://github.com/wso2-dev/carbon-utils/pull/20​



>
> Please note that this change requires following changes done to the carbon
> kernel as well.
>
> JIRA: https://wso2.org/jira/browse/CARBON-14934
> PR: https://github.com/wso2-dev/carbon4-kernel/pull/85
>

​This has been closed and following PR has been sent instead.
https://github.com/wso2-dev/carbon4-kernel/pull/106



>
>  I have also raised following JIRAs to track the changes made to the
> platform from these changes, and updated them with the pull requests which
> were already sent by Shameera, and couple of changes done by me as well.
>

>
>1. https://wso2.org/jira/browse/BPS-559
>https://github.com/wso2-dev/product-bps/pull/2
>https://github.com/wso2-dev/carbon-business-process/pull/2
>
>
>2. https://wso2.org/jira/browse/BRS-114
>https://github.com/wso2-dev/product-brs/pull/2
>
>
>3. https://wso2.org/jira/browse/CEP-935
>https://github.com/wso2-dev/product-cep/pull/16
>
>
>4. https://wso2.org/jira/browse/REGISTRY-2293
>https://github.com/wso2-dev/carbon-registry/pull/18
>https://github.com/wso2-dev/carbon-governance/pull/15
>https://github.com/wso2-dev/product-greg/pull/28
>
>
>5. https://wso2.org/jira/browse/ESBJAVA-3281
>https://github.com/wso2-dev/product-esb/pull/54 [This has already been
>merged]
>
> 
>6. https://wso2.org/jira/browse/IDENTITY-2696
>https://github.com/wso2-dev/product-is/pull/3 [This has already been
>merged]
>
>
>7. https://wso2.org/jira/browse/SS-401
>https://github.com/wso2-dev/product-ss/pull/23
>
>
>8. https://wso2.org/jira/browse/STORE-507
>https://github.com/wso2-dev/product-es/pull/13
>
>
>9. https://wso2.org/jira/browse/TS-9
>https://github.com/wso2-dev/product-ts/pull/3
>
>
>10. https://wso2.org/jira/browse/UES-564
>https://github.com/wso2-dev/product-ues/pull/3
>
>
>11. https://wso2.org/jira/browse/WSAS-1776
>https://github.com/wso2-dev/carbon-deployment/pull/23
>
>
>12. https://wso2.org/jira/browse/CARBON-14935
>https://github.com/wso2-dev/carbon4-kernel/pull/90 [On a side note,
>this is a fix on the log4j.properties file in the kernel. Isn't it wrong to
>have to do this change on kernel due to a fix on carbon-utils?]
>
> Similar to last time, we need to make sure that merging these pull
> requests happen in sync.
>

​
We need to make sure the above pull requests are merged in sync with the
above two merges so the platform builds do not break.

Thanks.
/Gayashan​



>
> Thanks.
> /Gayashan
>
>
> On Tue, Sep 2, 2014 at 6:28 PM, Gayashan Amarasinghe 
> wrote:
>
>> Hi Sagara,
>>
>> I was able to remove the CassandraLogProvider and get the commits
>> reapplied to carbon-utils after resolving merge conflicts, etc. However in
>> addition to the changes made to the platform by Shameera, there are couple
>> of more places which needs changes as well. Without those changes the
>> platform build will fail. I will send the pull request to carbon-utils
>> after fixing those places (and sending relevant pull requests) as well.
>>
>> Thanks.
>> /Gayashan
>>
>>
>> On Tue, Sep 2, 2014 at 11:59 AM, Gayashan Amarasinghe 
>> wrote:
>>
>>> Hi Sagara,
>>>
>>> I went through the changes and had a chat with Sameera as well.
>>>
>>> +1 for removing the cassandra-thrift and hector-core dependencies from
>>> the carbon-utils repo since carbon-utils is depended upon by many products.
>>> If we are to remove these dependencies then we have to remove the
>>> CassandraLogProvider from the package as well. Since this is a useful class
>>> for some of the products however we have to move this class to a different
>>> repo, which ensures that this can be used by products as and when needed. I
>>> will send a separate mail regarding this.
>>>
>>> ​I'll also resend the pull request with the changes.
>>>
>>> Thanks.​
>>> /Gayashan
>>>
>>>
>>> On Tue, Sep 2, 2014 at 11:16 AM, Gayashan Amarasinghe >> > wrote:
>>>
 Hi Sagara,

 These changes were done by Shameera as a result of simplifying the
 carbon logging story [1]. Since he is not avail

Re: [Dev] Cassandra-thrift dependency on carbon-utils

[Gayashan Amarasinghe]

Hi Sagara,

I have fixed the mentioned issues in the previous PRs and resent the
following PR to carbon-utils. We can close the previous PRs (#14, #15, #16)
without merging them.
 https://github.com/wso2-dev/carbon-utils/pull/17

Please note that this change requires following changes done to the carbon
kernel as well.

JIRA: https://wso2.org/jira/browse/CARBON-14934
PR: https://github.com/wso2-dev/carbon4-kernel/pull/85

 I have also raised following JIRAs to track the changes made to the
platform from these changes, and updated them with the pull requests which
were already sent by Shameera, and couple of changes done by me as well.


   1. https://wso2.org/jira/browse/BPS-559
   https://github.com/wso2-dev/product-bps/pull/2
   https://github.com/wso2-dev/carbon-business-process/pull/2

   
   2. https://wso2.org/jira/browse/BRS-114
   https://github.com/wso2-dev/product-brs/pull/2

   
   3. https://wso2.org/jira/browse/CEP-935
   https://github.com/wso2-dev/product-cep/pull/16

   
   4. https://wso2.org/jira/browse/REGISTRY-2293
   https://github.com/wso2-dev/carbon-registry/pull/18
   https://github.com/wso2-dev/carbon-governance/pull/15
   https://github.com/wso2-dev/product-greg/pull/28

   
   5. https://wso2.org/jira/browse/ESBJAVA-3281
   https://github.com/wso2-dev/product-esb/pull/54 [This has already been
   merged]


   6. https://wso2.org/jira/browse/IDENTITY-2696
   https://github.com/wso2-dev/product-is/pull/3 [This has already been
   merged]

   
   7. https://wso2.org/jira/browse/SS-401
   https://github.com/wso2-dev/product-ss/pull/23

   
   8. https://wso2.org/jira/browse/STORE-507
   https://github.com/wso2-dev/product-es/pull/13

   
   9. https://wso2.org/jira/browse/TS-9
   https://github.com/wso2-dev/product-ts/pull/3

   
   10. https://wso2.org/jira/browse/UES-564
   https://github.com/wso2-dev/product-ues/pull/3

   
   11. https://wso2.org/jira/browse/WSAS-1776
   https://github.com/wso2-dev/carbon-deployment/pull/23

   
   12. https://wso2.org/jira/browse/CARBON-14935
   https://github.com/wso2-dev/carbon4-kernel/pull/90 [On a side note, this
   is a fix on the log4j.properties file in the kernel. Isn't it wrong to have
   to do this change on kernel due to a fix on carbon-utils?]

Similar to last time, we need to make sure that merging these pull requests
happen in sync.

Thanks.
/Gayashan


On Tue, Sep 2, 2014 at 6:28 PM, Gayashan Amarasinghe 
wrote:

> Hi Sagara,
>
> I was able to remove the CassandraLogProvider and get the commits
> reapplied to carbon-utils after resolving merge conflicts, etc. However in
> addition to the changes made to the platform by Shameera, there are couple
> of more places which needs changes as well. Without those changes the
> platform build will fail. I will send the pull request to carbon-utils
> after fixing those places (and sending relevant pull requests) as well.
>
> Thanks.
> /Gayashan
>
>
> On Tue, Sep 2, 2014 at 11:59 AM, Gayashan Amarasinghe 
> wrote:
>
>> Hi Sagara,
>>
>> I went through the changes and had a chat with Sameera as well.
>>
>> +1 for removing the cassandra-thrift and hector-core dependencies from
>> the carbon-utils repo since carbon-utils is depended upon by many products.
>> If we are to remove these dependencies then we have to remove the
>> CassandraLogProvider from the package as well. Since this is a useful class
>> for some of the products however we have to move this class to a different
>> repo, which ensures that this can be used by products as and when needed. I
>> will send a separate mail regarding this.
>>
>> ​I'll also resend the pull request with the changes.
>>
>> Thanks.​
>> /Gayashan
>>
>>
>> On Tue, Sep 2, 2014 at 11:16 AM, Gayashan Amarasinghe 
>> wrote:
>>
>>> Hi Sagara,
>>>
>>> These changes were done by Shameera as a result of simplifying the
>>> carbon logging story [1]. Since he is not available I will look in to these
>>> changes and provide an update asap.
>>>
>>> [1] https://wso2.org/jira/browse/COMMONS-110
>>>
>>> Thanks.
>>> /Gayashan
>>>
>>>
>>>
>>> On Tue, Sep 2, 2014 at 11:10 AM, Sagara Gunathunga 
>>> wrote:
>>>

 Hi Gayashan,

 It seems like new logging service introduces cassandra-thrift,
 hector-core as dependencies into carbon-util (carbon-common) project bit
 IMHO neither Carbon logging service nor  carbon-util should have these
 dependencies, shall we get rid of them ?

 Anyway I'm getting following build fail with PR-16 [1] .

 [ERROR] Failed to execute goal on project
 org.wso2.carbon.logging.se

Re: [Dev] Cassandra-thrift dependency on carbon-utils

[Gayashan Amarasinghe]

Hi Sagara,

I was able to remove the CassandraLogProvider and get the commits reapplied
to carbon-utils after resolving merge conflicts, etc. However in addition
to the changes made to the platform by Shameera, there are couple of more
places which needs changes as well. Without those changes the platform
build will fail. I will send the pull request to carbon-utils after fixing
those places (and sending relevant pull requests) as well.

Thanks.
/Gayashan


On Tue, Sep 2, 2014 at 11:59 AM, Gayashan Amarasinghe 
wrote:

> Hi Sagara,
>
> I went through the changes and had a chat with Sameera as well.
>
> +1 for removing the cassandra-thrift and hector-core dependencies from the
> carbon-utils repo since carbon-utils is depended upon by many products. If
> we are to remove these dependencies then we have to remove the
> CassandraLogProvider from the package as well. Since this is a useful class
> for some of the products however we have to move this class to a different
> repo, which ensures that this can be used by products as and when needed. I
> will send a separate mail regarding this.
>
> ​I'll also resend the pull request with the changes.
>
> Thanks.​
> /Gayashan
>
>
> On Tue, Sep 2, 2014 at 11:16 AM, Gayashan Amarasinghe 
> wrote:
>
>> Hi Sagara,
>>
>> These changes were done by Shameera as a result of simplifying the carbon
>> logging story [1]. Since he is not available I will look in to these
>> changes and provide an update asap.
>>
>> [1] https://wso2.org/jira/browse/COMMONS-110
>>
>> Thanks.
>> /Gayashan
>>
>>
>>
>> On Tue, Sep 2, 2014 at 11:10 AM, Sagara Gunathunga 
>> wrote:
>>
>>>
>>> Hi Gayashan,
>>>
>>> It seems like new logging service introduces cassandra-thrift,
>>> hector-core as dependencies into carbon-util (carbon-common) project bit
>>> IMHO neither Carbon logging service nor  carbon-util should have these
>>> dependencies, shall we get rid of them ?
>>>
>>> Anyway I'm getting following build fail with PR-16 [1] .
>>>
>>> [ERROR] Failed to execute goal on project
>>> org.wso2.carbon.logging.service: Could not resolve dependencies for project
>>> org.wso2.carbon:org.wso2.carbon.logging.service:bundle:4.3.0-SNAPSHOT:
>>> Failure to find org.apache.cassandra.wso2:cassandra-thrift:jar:1.1.0.wso2v1
>>> in http://maven.wso2.org/nexus/content/groups/wso2-public/ was cached
>>> in the local repository, resolution will not be reattempted until the
>>> update interval of wso2-nexus has elapsed or updates are forced -> [Help 1]
>>>
>>> [1] - https://github.com/wso2-dev/carbon-utils/pull/16/files
>>>
>>> Thanks !
>>> --
>>> Sagara Gunathunga
>>>
>>> Senior Technical Lead; WSO2, Inc.;  http://wso2.com
>>> V.P Apache Web Services;http://ws.apache.org/
>>> Linkedin; http://www.linkedin.com/in/ssagara
>>> Blog ;  http://ssagara.blogspot.com
>>>
>>>
>>
>>
>> --
>> *Gayashan Amarasinghe*
>> Software Engineer | Platform TG
>> WSO2, Inc. | http://wso2.com
>> lean. enterprise. middleware
>>
>> Mobile : +94718314517
>> Blog : gayashan-a.blogspot.com
>>
>
>
>
> --
> *Gayashan Amarasinghe*
> Software Engineer | Platform TG
> WSO2, Inc. | http://wso2.com
> lean. enterprise. middleware
>
> Mobile : +94718314517
> Blog : gayashan-a.blogspot.com
>



-- 
*Gayashan Amarasinghe*
Software Engineer | Platform TG
WSO2, Inc. | http://wso2.com
lean. enterprise. middleware

Mobile : +94718314517
Blog : gayashan-a.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Cassandra-thrift dependency on carbon-utils

[Gayashan Amarasinghe]

Hi Sagara,

I went through the changes and had a chat with Sameera as well.

+1 for removing the cassandra-thrift and hector-core dependencies from the
carbon-utils repo since carbon-utils is depended upon by many products. If
we are to remove these dependencies then we have to remove the
CassandraLogProvider from the package as well. Since this is a useful class
for some of the products however we have to move this class to a different
repo, which ensures that this can be used by products as and when needed. I
will send a separate mail regarding this.

​I'll also resend the pull request with the changes.

Thanks.​
/Gayashan


On Tue, Sep 2, 2014 at 11:16 AM, Gayashan Amarasinghe 
wrote:

> Hi Sagara,
>
> These changes were done by Shameera as a result of simplifying the carbon
> logging story [1]. Since he is not available I will look in to these
> changes and provide an update asap.
>
> [1] https://wso2.org/jira/browse/COMMONS-110
>
> Thanks.
> /Gayashan
>
>
>
> On Tue, Sep 2, 2014 at 11:10 AM, Sagara Gunathunga 
> wrote:
>
>>
>> Hi Gayashan,
>>
>> It seems like new logging service introduces cassandra-thrift,
>> hector-core as dependencies into carbon-util (carbon-common) project bit
>> IMHO neither Carbon logging service nor  carbon-util should have these
>> dependencies, shall we get rid of them ?
>>
>> Anyway I'm getting following build fail with PR-16 [1] .
>>
>> [ERROR] Failed to execute goal on project
>> org.wso2.carbon.logging.service: Could not resolve dependencies for project
>> org.wso2.carbon:org.wso2.carbon.logging.service:bundle:4.3.0-SNAPSHOT:
>> Failure to find org.apache.cassandra.wso2:cassandra-thrift:jar:1.1.0.wso2v1
>> in http://maven.wso2.org/nexus/content/groups/wso2-public/ was cached in
>> the local repository, resolution will not be reattempted until the update
>> interval of wso2-nexus has elapsed or updates are forced -> [Help 1]
>>
>> [1] - https://github.com/wso2-dev/carbon-utils/pull/16/files
>>
>> Thanks !
>> --
>> Sagara Gunathunga
>>
>> Senior Technical Lead; WSO2, Inc.;  http://wso2.com
>> V.P Apache Web Services;http://ws.apache.org/
>> Linkedin; http://www.linkedin.com/in/ssagara
>> Blog ;  http://ssagara.blogspot.com
>>
>>
>
>
> --
> *Gayashan Amarasinghe*
> Software Engineer | Platform TG
> WSO2, Inc. | http://wso2.com
> lean. enterprise. middleware
>
> Mobile : +94718314517
> Blog : gayashan-a.blogspot.com
>



-- 
*Gayashan Amarasinghe*
Software Engineer | Platform TG
WSO2, Inc. | http://wso2.com
lean. enterprise. middleware

Mobile : +94718314517
Blog : gayashan-a.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Cassandra-thrift dependency on carbon-utils

[Gayashan Amarasinghe]

Hi Sagara,

These changes were done by Shameera as a result of simplifying the carbon
logging story [1]. Since he is not available I will look in to these
changes and provide an update asap.

[1] https://wso2.org/jira/browse/COMMONS-110

Thanks.
/Gayashan



On Tue, Sep 2, 2014 at 11:10 AM, Sagara Gunathunga  wrote:

>
> Hi Gayashan,
>
> It seems like new logging service introduces cassandra-thrift, hector-core
> as dependencies into carbon-util (carbon-common) project bit IMHO neither
> Carbon logging service nor  carbon-util should have these dependencies,
> shall we get rid of them ?
>
> Anyway I'm getting following build fail with PR-16 [1] .
>
> [ERROR] Failed to execute goal on project org.wso2.carbon.logging.service:
> Could not resolve dependencies for project
> org.wso2.carbon:org.wso2.carbon.logging.service:bundle:4.3.0-SNAPSHOT:
> Failure to find org.apache.cassandra.wso2:cassandra-thrift:jar:1.1.0.wso2v1
> in http://maven.wso2.org/nexus/content/groups/wso2-public/ was cached in
> the local repository, resolution will not be reattempted until the update
> interval of wso2-nexus has elapsed or updates are forced -> [Help 1]
>
> [1] - https://github.com/wso2-dev/carbon-utils/pull/16/files
>
> Thanks !
> --
> Sagara Gunathunga
>
> Senior Technical Lead; WSO2, Inc.;  http://wso2.com
> V.P Apache Web Services;http://ws.apache.org/
> Linkedin; http://www.linkedin.com/in/ssagara
> Blog ;  http://ssagara.blogspot.com
>
>


-- 
*Gayashan Amarasinghe*
Software Engineer | Platform TG
WSO2, Inc. | http://wso2.com
lean. enterprise. middleware

Mobile : +94718314517
Blog : gayashan-a.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Cassandra-thrift dependency on carbon-utils

[Sagara Gunathunga]

Hi Gayashan,

It seems like new logging service introduces cassandra-thrift, hector-core
as dependencies into carbon-util (carbon-common) project bit IMHO neither
Carbon logging service nor  carbon-util should have these dependencies,
shall we get rid of them ?

Anyway I'm getting following build fail with PR-16 [1] .

[ERROR] Failed to execute goal on project org.wso2.carbon.logging.service:
Could not resolve dependencies for project
org.wso2.carbon:org.wso2.carbon.logging.service:bundle:4.3.0-SNAPSHOT:
Failure to find org.apache.cassandra.wso2:cassandra-thrift:jar:1.1.0.wso2v1
in http://maven.wso2.org/nexus/content/groups/wso2-public/ was cached in
the local repository, resolution will not be reattempted until the update
interval of wso2-nexus has elapsed or updates are forced -> [Help 1]

[1] - https://github.com/wso2-dev/carbon-utils/pull/16/files

Thanks !
-- 
Sagara Gunathunga

Senior Technical Lead; WSO2, Inc.;  http://wso2.com
V.P Apache Web Services;http://ws.apache.org/
Linkedin; http://www.linkedin.com/in/ssagara
Blog ;  http://ssagara.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev