Re: [Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

[Omindu Rathnaweera]

Changing this will break the builds on parent v5 right? Don't we need to
have versioning for code-quality-tools ?

On Sat, Mar 11, 2017 at 10:00 PM, KasunG Gajasinghe  wrote:

>
> Nice. Let's send a PR to https://github.com/wso2/code-quality-tools
>
> On Sat, Mar 11, 2017 at 2:45 PM, Omindu Rathnaweera 
> wrote:
>
>> Hi guys,
>>
>> Finally found some time to have a look at this. We can use the below
>> module [1] to enforce the check on the first sentence. I tested this on OSX
>> and it's working.
>>
>> 
>>
>>  [1]  - http://checkstyle.sourceforge.net/config_javadoc.html#
>> SummaryJavadoc
>>
>> Regards,
>> Omindu.
>>
>> On Mon, Mar 6, 2017 at 3:29 PM, KasunG Gajasinghe 
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 6, 2017 at 3:22 PM, Omindu Rathnaweera 
>>> wrote:
>>>
 Hi Devs,

 Noticed that the builds (with wso2 parent v5) done on windows fails
 with the error "First sentence should end with a period.". Seems like
 this check can be configured with *checkFirstSentence* rule [1]. Is it
 possible to enforce this rule for all environments ?

>>>
>>> +1 Omindu. This has been an issue for a long time. Can you add this rule
>>> to [2] and see whether we can enforce this rule in Linux/Unix environments
>>> as well?
>>>
>>> [2] https://raw.githubusercontent.com/wso2/code-quality-tool
>>> s/master/checkstyle/checkstyle.xml
>>>
>>>

 [1] - http://checkstyle.sourceforge.net/config_javadoc.html#Java
 docStyle

 Regards,
 Omindu.

 --
 Omindu Rathnaweera
 Software Engineer, WSO2 Inc.
 Mobile: +94 771 197 211 <077%20119%207211>

>>>
>>>
>>>
>>> --
>>>
>>> *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc.
>>> email: kasung AT spamfree wso2.com
>>> linked-in: http://lk.linkedin.com/in/gajasinghe
>>> blog: http://kasunbg.org
>>> phone: +1 650-745-4499 <+1%20650-745-4499>, 77 678 0813
>>>
>>>
>>
>>
>>
>> --
>> Omindu Rathnaweera
>> Software Engineer, WSO2 Inc.
>> Mobile: +94 771 197 211 <077%20119%207211>
>>
>
>
>
> --
>
> *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc.
> email: kasung AT spamfree wso2.com
> linked-in: http://lk.linkedin.com/in/gajasinghe
> blog: http://kasunbg.org
> phone: +1 650-745-4499 <(650)%20745-4499>, 77 678 0813
>
>



-- 
Omindu Rathnaweera
Software Engineer, WSO2 Inc.
Mobile: +94 771 197 211
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

[KasunG Gajasinghe]

Nice. Let's send a PR to https://github.com/wso2/code-quality-tools

On Sat, Mar 11, 2017 at 2:45 PM, Omindu Rathnaweera  wrote:

> Hi guys,
>
> Finally found some time to have a look at this. We can use the below
> module [1] to enforce the check on the first sentence. I tested this on OSX
> and it's working.
>
> 
>
>  [1]  - http://checkstyle.sourceforge.net/config_
> javadoc.html#SummaryJavadoc
>
> Regards,
> Omindu.
>
> On Mon, Mar 6, 2017 at 3:29 PM, KasunG Gajasinghe  wrote:
>
>>
>>
>> On Mon, Mar 6, 2017 at 3:22 PM, Omindu Rathnaweera 
>> wrote:
>>
>>> Hi Devs,
>>>
>>> Noticed that the builds (with wso2 parent v5) done on windows fails with
>>> the error "First sentence should end with a period.". Seems like this
>>> check can be configured with *checkFirstSentence* rule [1]. Is it
>>> possible to enforce this rule for all environments ?
>>>
>>
>> +1 Omindu. This has been an issue for a long time. Can you add this rule
>> to [2] and see whether we can enforce this rule in Linux/Unix environments
>> as well?
>>
>> [2] https://raw.githubusercontent.com/wso2/code-quality-tool
>> s/master/checkstyle/checkstyle.xml
>>
>>
>>>
>>> [1] - http://checkstyle.sourceforge.net/config_javadoc.html#JavadocStyle
>>>
>>> Regards,
>>> Omindu.
>>>
>>> --
>>> Omindu Rathnaweera
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94 771 197 211 <077%20119%207211>
>>>
>>
>>
>>
>> --
>>
>> *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc.
>> email: kasung AT spamfree wso2.com
>> linked-in: http://lk.linkedin.com/in/gajasinghe
>> blog: http://kasunbg.org
>> phone: +1 650-745-4499 <+1%20650-745-4499>, 77 678 0813
>>
>>
>
>
>
> --
> Omindu Rathnaweera
> Software Engineer, WSO2 Inc.
> Mobile: +94 771 197 211 <077%20119%207211>
>



-- 

*Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc.
email: kasung AT spamfree wso2.com
linked-in: http://lk.linkedin.com/in/gajasinghe
blog: http://kasunbg.org
phone: +1 650-745-4499, 77 678 0813
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

[Omindu Rathnaweera]

Hi guys,

Finally found some time to have a look at this. We can use the below module
[1] to enforce the check on the first sentence. I tested this on OSX and
it's working.



 [1]  - http://checkstyle.sourceforge.net/config_javadoc.html#SummaryJavadoc

Regards,
Omindu.

On Mon, Mar 6, 2017 at 3:29 PM, KasunG Gajasinghe  wrote:

>
>
> On Mon, Mar 6, 2017 at 3:22 PM, Omindu Rathnaweera 
> wrote:
>
>> Hi Devs,
>>
>> Noticed that the builds (with wso2 parent v5) done on windows fails with
>> the error "First sentence should end with a period.". Seems like this
>> check can be configured with *checkFirstSentence* rule [1]. Is it
>> possible to enforce this rule for all environments ?
>>
>
> +1 Omindu. This has been an issue for a long time. Can you add this rule
> to [2] and see whether we can enforce this rule in Linux/Unix environments
> as well?
>
> [2] https://raw.githubusercontent.com/wso2/code-quality-
> tools/master/checkstyle/checkstyle.xml
>
>
>>
>> [1] - http://checkstyle.sourceforge.net/config_javadoc.html#JavadocStyle
>>
>> Regards,
>> Omindu.
>>
>> --
>> Omindu Rathnaweera
>> Software Engineer, WSO2 Inc.
>> Mobile: +94 771 197 211 <077%20119%207211>
>>
>
>
>
> --
>
> *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc.
> email: kasung AT spamfree wso2.com
> linked-in: http://lk.linkedin.com/in/gajasinghe
> blog: http://kasunbg.org
> phone: +1 650-745-4499 <+1%20650-745-4499>, 77 678 0813
>
>



-- 
Omindu Rathnaweera
Software Engineer, WSO2 Inc.
Mobile: +94 771 197 211
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

[Omindu Rathnaweera]

Hi Devs,

Noticed that the builds (with wso2 parent v5) done on windows fails with
the error "First sentence should end with a period.". Seems like this check
can be configured with *checkFirstSentence* rule [1]. Is it possible to
enforce this rule for all environments ?

[1] - http://checkstyle.sourceforge.net/config_javadoc.html#JavadocStyle

Regards,
Omindu.

-- 
Omindu Rathnaweera
Software Engineer, WSO2 Inc.
Mobile: +94 771 197 211
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Checkstyle rule "checkFirstSentence" check only happens on windows build

[KasunG Gajasinghe]

On Mon, Mar 6, 2017 at 3:22 PM, Omindu Rathnaweera  wrote:

> Hi Devs,
>
> Noticed that the builds (with wso2 parent v5) done on windows fails with
> the error "First sentence should end with a period.". Seems like this
> check can be configured with *checkFirstSentence* rule [1]. Is it
> possible to enforce this rule for all environments ?
>

+1 Omindu. This has been an issue for a long time. Can you add this rule to
[2] and see whether we can enforce this rule in Linux/Unix environments as
well?

[2] https://raw.githubusercontent.com/wso2/code-quality-tools/master/
checkstyle/checkstyle.xml


>
> [1] - http://checkstyle.sourceforge.net/config_javadoc.html#JavadocStyle
>
> Regards,
> Omindu.
>
> --
> Omindu Rathnaweera
> Software Engineer, WSO2 Inc.
> Mobile: +94 771 197 211 <077%20119%207211>
>



-- 

*Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc.
email: kasung AT spamfree wso2.com
linked-in: http://lk.linkedin.com/in/gajasinghe
blog: http://kasunbg.org
phone: +1 650-745-4499 <+1%20650-745-4499>, 77 678 0813
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev