Re: [Dev] Configurator does not give priority to env variables
Correct, configurator is giving priority to the environment variables. I misunderstood it earlier. Sorry for the confusion. Thanks On Mon, Oct 26, 2015 at 9:10 AM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi, > > By any chance if the values are commented out from the module.ini, only >> env values will get populated. > > > This is not the correct approach, the configurator should pick up the > variables from template itself and then search for environment variables > and module.ini. > > Users don't have to comment variables in module.ini. > > Please refer mail with subject *"PPaaS configurator doesn't pick all the > payload parameters"* for more info. > > On Sat, Oct 24, 2015 at 11:43 PM, Pubudu Gunatilaka > wrote: > >> Hi Imesh, >> >> I just checked the configurator. It gives the priority to env variables >> before reading from module.ini. This should be the default approach. >> >> It would be more safe to define values within the template. By any chance >> if the values are commented out from the module.ini, only env values will >> get populated. >> >> Thank you! >> >> On Sat, Oct 24, 2015 at 10:33 PM, Gayan Gunarathne >> wrote: >> >>> So what is the usage of the "module.ini"? We can live with only the >>> environment parameters. >>> >>> If the module.ini is for the default values, why are we having default >>> values in the template it self.We are checking whether that value is >>> defined. If that is not define we are setting the default value. >>> >>> [1] >>> https://github.com/wso2/private-paas-cartridges/blob/master/wso2esb/4.8.1/template-module/templates/repository/conf/datasources/master-datasources.xml.template#L8 >>> >>> Thanks, >>> Gayan >>> >>> On Sat, Oct 24, 2015 at 10:00 PM, Imesh Gunaratne >>> wrote: >>> Hi Devs, I noticed $subject if the same variable has been defined in module.ini. IMO this is not correct. We need to be able to configure any parameter using environment variables without touching the module.ini. Thanks -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >>> -- >>> >>> Gayan Gunarathne >>> Technical Lead, WSO2 Inc. (http://wso2.com) >>> Committer & PMC Member, Apache Stratos >>> email : gay...@wso2.com | mobile : +94 775030545 <%2B94%20766819985> >>> >>> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Pubudu Gunatilaka* >> Committer and PMC Member - Apache Stratos >> Software Engineer >> WSO2, Inc.: http://wso2.com >> mobile : +94774079049 <%2B94772207163> >> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Thanks and Regards,* > Anuruddha Lanka Liyanarachchi > Software Engineer - WSO2 > Mobile : +94 (0) 712762611 > Tel : +94 112 145 345 > a nurudd...@wso2.com > -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Configurator does not give priority to env variables
Hi, By any chance if the values are commented out from the module.ini, only env > values will get populated. This is not the correct approach, the configurator should pick up the variables from template itself and then search for environment variables and module.ini. Users don't have to comment variables in module.ini. Please refer mail with subject *"PPaaS configurator doesn't pick all the payload parameters"* for more info. On Sat, Oct 24, 2015 at 11:43 PM, Pubudu Gunatilaka wrote: > Hi Imesh, > > I just checked the configurator. It gives the priority to env variables > before reading from module.ini. This should be the default approach. > > It would be more safe to define values within the template. By any chance > if the values are commented out from the module.ini, only env values will > get populated. > > Thank you! > > On Sat, Oct 24, 2015 at 10:33 PM, Gayan Gunarathne > wrote: > >> So what is the usage of the "module.ini"? We can live with only the >> environment parameters. >> >> If the module.ini is for the default values, why are we having default >> values in the template it self.We are checking whether that value is >> defined. If that is not define we are setting the default value. >> >> [1] >> https://github.com/wso2/private-paas-cartridges/blob/master/wso2esb/4.8.1/template-module/templates/repository/conf/datasources/master-datasources.xml.template#L8 >> >> Thanks, >> Gayan >> >> On Sat, Oct 24, 2015 at 10:00 PM, Imesh Gunaratne wrote: >> >>> Hi Devs, >>> >>> I noticed $subject if the same variable has been defined in module.ini. >>> >>> IMO this is not correct. We need to be able to configure any parameter >>> using environment variables without touching the module.ini. >>> >>> Thanks >>> >>> -- >>> *Imesh Gunaratne* >>> Senior Technical Lead >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: http://imesh.gunaratne.org >>> Lean . Enterprise . Middleware >>> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> >> Gayan Gunarathne >> Technical Lead, WSO2 Inc. (http://wso2.com) >> Committer & PMC Member, Apache Stratos >> email : gay...@wso2.com | mobile : +94 775030545 <%2B94%20766819985> >> >> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Pubudu Gunatilaka* > Committer and PMC Member - Apache Stratos > Software Engineer > WSO2, Inc.: http://wso2.com > mobile : +94774079049 <%2B94772207163> > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobile : +94 (0) 712762611 Tel : +94 112 145 345 a nurudd...@wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Configurator does not give priority to env variables
Hi Imesh, I just checked the configurator. It gives the priority to env variables before reading from module.ini. This should be the default approach. It would be more safe to define values within the template. By any chance if the values are commented out from the module.ini, only env values will get populated. Thank you! On Sat, Oct 24, 2015 at 10:33 PM, Gayan Gunarathne wrote: > So what is the usage of the "module.ini"? We can live with only the > environment parameters. > > If the module.ini is for the default values, why are we having default > values in the template it self.We are checking whether that value is > defined. If that is not define we are setting the default value. > > [1] > https://github.com/wso2/private-paas-cartridges/blob/master/wso2esb/4.8.1/template-module/templates/repository/conf/datasources/master-datasources.xml.template#L8 > > Thanks, > Gayan > > On Sat, Oct 24, 2015 at 10:00 PM, Imesh Gunaratne wrote: > >> Hi Devs, >> >> I noticed $subject if the same variable has been defined in module.ini. >> >> IMO this is not correct. We need to be able to configure any parameter >> using environment variables without touching the module.ini. >> >> Thanks >> >> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.gunaratne.org >> Lean . Enterprise . Middleware >> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > Gayan Gunarathne > Technical Lead, WSO2 Inc. (http://wso2.com) > Committer & PMC Member, Apache Stratos > email : gay...@wso2.com | mobile : +94 775030545 <%2B94%20766819985> > > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Pubudu Gunatilaka* Committer and PMC Member - Apache Stratos Software Engineer WSO2, Inc.: http://wso2.com mobile : +94774079049 <%2B94772207163> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Configurator does not give priority to env variables
So what is the usage of the "module.ini"? We can live with only the environment parameters. If the module.ini is for the default values, why are we having default values in the template it self.We are checking whether that value is defined. If that is not define we are setting the default value. [1] https://github.com/wso2/private-paas-cartridges/blob/master/wso2esb/4.8.1/template-module/templates/repository/conf/datasources/master-datasources.xml.template#L8 Thanks, Gayan On Sat, Oct 24, 2015 at 10:00 PM, Imesh Gunaratne wrote: > Hi Devs, > > I noticed $subject if the same variable has been defined in module.ini. > > IMO this is not correct. We need to be able to configure any parameter > using environment variables without touching the module.ini. > > Thanks > > -- > *Imesh Gunaratne* > Senior Technical Lead > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 > W: http://imesh.gunaratne.org > Lean . Enterprise . Middleware > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Gayan Gunarathne Technical Lead, WSO2 Inc. (http://wso2.com) Committer & PMC Member, Apache Stratos email : gay...@wso2.com | mobile : +94 775030545 <%2B94%20766819985> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Configurator does not give priority to env variables
Hi Devs, I noticed $subject if the same variable has been defined in module.ini. IMO this is not correct. We need to be able to configure any parameter using environment variables without touching the module.ini. Thanks -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
